[Bug 1836968] Review Request: sipvicious - Set of tools to audit SIP based VoIP systems
https://bugzilla.redhat.com/show_bug.cgi?id=1836968 --- Comment #5 from Fedora Update System --- FEDORA-EPEL-2020-095d013272 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-095d013272 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836689] Review Request: python-typedecorator - Decorator-based type checking library
https://bugzilla.redhat.com/show_bug.cgi?id=1836689 --- Comment #4 from Fedora Update System --- FEDORA-2020-de0a29d210 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-de0a29d210 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825139] Review Request: python-pymata-express - Python Protocol Abstraction Library For Arduino Firmata
https://bugzilla.redhat.com/show_bug.cgi?id=1825139 --- Comment #5 from Fedora Update System --- FEDORA-2020-b007a45cf4 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-b007a45cf4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825139] Review Request: python-pymata-express - Python Protocol Abstraction Library For Arduino Firmata
https://bugzilla.redhat.com/show_bug.cgi?id=1825139 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #4 from Fedora Update System --- FEDORA-2020-9c274ce008 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-9c274ce008 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836689] Review Request: python-typedecorator - Decorator-based type checking library
https://bugzilla.redhat.com/show_bug.cgi?id=1836689 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #3 from Fedora Update System --- FEDORA-2020-32e22e2c99 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-32e22e2c99 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836968] Review Request: sipvicious - Set of tools to audit SIP based VoIP systems
https://bugzilla.redhat.com/show_bug.cgi?id=1836968 --- Comment #4 from Fedora Update System --- FEDORA-2020-f154fad5dd has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f154fad5dd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836968] Review Request: sipvicious - Set of tools to audit SIP based VoIP systems
https://bugzilla.redhat.com/show_bug.cgi?id=1836968 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #3 from Fedora Update System --- FEDORA-2020-11925d273a has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-11925d273a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836568] Review Request: python-graphql-relay - Relay library for graphql-core-next
https://bugzilla.redhat.com/show_bug.cgi?id=1836568 --- Comment #11 from Fedora Update System --- FEDORA-2020-e9658e0782 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-e9658e0782 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836568] Review Request: python-graphql-relay - Relay library for graphql-core-next
https://bugzilla.redhat.com/show_bug.cgi?id=1836568 Fabian Affolter changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-06-26 06:35:32 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836568] Review Request: python-graphql-relay - Relay library for graphql-core-next
https://bugzilla.redhat.com/show_bug.cgi?id=1836568 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #10 from Fedora Update System --- FEDORA-2020-c675c7cbca has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-c675c7cbca -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1849255] Review Request: ghc-network-bsd - Network.BSD
https://bugzilla.redhat.com/show_bug.cgi?id=1849255 Jens Petersen changed: What|Removed |Added Assignee|nob...@fedoraproject.org|tdeca...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1834961] Review Request: python-ansiwrap - Text wrapper with ANSI colors and styles support
https://bugzilla.redhat.com/show_bug.cgi?id=1834961 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-06-26 06:27:46 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1834959] Review Request: python-textwrap3 - Text wrap backport
https://bugzilla.redhat.com/show_bug.cgi?id=1834959 Fabian Affolter changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-06-26 06:25:53 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803348] Review Request: ghc-parsers - Parsing combinators
https://bugzilla.redhat.com/show_bug.cgi?id=1803348 Jens Petersen changed: What|Removed |Added Status|POST|MODIFIED Fixed In Version||ghc-parsers-0.12.10-2.fc33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1834961] Review Request: python-ansiwrap - Text wrapper with ANSI colors and styles support
https://bugzilla.redhat.com/show_bug.cgi?id=1834961 Bug 1834961 depends on bug 1834959, which changed state. Bug 1834959 Summary: Review Request: python-textwrap3 - Text wrap backport https://bugzilla.redhat.com/show_bug.cgi?id=1834959 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1834959] Review Request: python-textwrap3 - Text wrap backport
https://bugzilla.redhat.com/show_bug.cgi?id=1834959 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #3 from Fedora Update System --- FEDORA-2020-e5c6a2370f has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-e5c6a2370f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1795526] Review Request: ghc-cborg - Concise Binary Object Representation
https://bugzilla.redhat.com/show_bug.cgi?id=1795526 Jens Petersen changed: What|Removed |Added Status|POST|MODIFIED Fixed In Version||ghc-cborg-0.2.2.1-2.fc33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1849384] Review Request: swappy - Wayland native snapshot editing tool, inspired by Snappy on macOS
https://bugzilla.redhat.com/show_bug.cgi?id=1849384 --- Comment #2 from Bob Hepple --- Thanks again Aleksei! SPEC URL: https://download.copr.fedorainfracloud.org/results/wef/swappy/fedora-31-x86_64/01504551-swappy/swappy.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/wef/swappy/fedora-31-x86_64/01504551-swappy/swappy-1.1.0-1.fc31.src.rpm It seems to work fine with fontawesome-fonts-4.7.0-7.fc31.noarch but I'll try and chase this down with the author and verify. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830458] Review Request: mdns-repeater - Multicast DNS repeater
https://bugzilla.redhat.com/show_bug.cgi?id=1830458 --- Comment #14 from Fedora Update System --- FEDORA-EPEL-2020-5950e9ac20 has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830539] Review Request: mdns-scan - Scan for mDNS/DNS-SD services published on the local network
https://bugzilla.redhat.com/show_bug.cgi?id=1830539 --- Comment #17 from Fedora Update System --- FEDORA-EPEL-2020-aad4e879dc has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1850262] Review Request: kissat - Keep It Simple SAT solver
https://bugzilla.redhat.com/show_bug.cgi?id=1850262 --- Comment #6 from Jerry James --- (In reply to Jerry James from comment #5) > I don't yet know what's going on with the 32-bit architectures, but will > look into that next. One of the tests attempts to allocate 2 GB, which fails on the 32-bit architectures. I'll see what can be done about this, too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1831578] Review Request: luv-icon-theme - Flat, but complex, icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1831578 --- Comment #9 from Fedora Update System --- FEDORA-2020-34281d4c2f has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-34281d4c2f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-34281d4c2f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815729] Re-Review Request: mkdocs-bootswatch - Bootswatch themes for MkDocs
https://bugzilla.redhat.com/show_bug.cgi?id=1815729 --- Comment #7 from Fedora Update System --- FEDORA-2020-02ca215e71 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-02ca215e71 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-02ca215e71 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1831578] Review Request: luv-icon-theme - Flat, but complex, icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1831578 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- FEDORA-2020-3ab9d76046 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-3ab9d76046 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-3ab9d76046 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #31 from Fedora Update System --- FEDORA-EPEL-2020-9ee16640e9 has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-9ee16640e9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815729] Re-Review Request: mkdocs-bootswatch - Bootswatch themes for MkDocs
https://bugzilla.redhat.com/show_bug.cgi?id=1815729 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- FEDORA-2020-81d383eaa2 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-81d383eaa2 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-81d383eaa2 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839479] Review Request: python-opencensus - A stats collection and distributed tracing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1839479 --- Comment #8 from Fedora Update System --- FEDORA-2020-c5ebbc6add has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844643] Review Request: qwt5-qt5 - Qt Widgets for Technical Applications adapted to Qt5
https://bugzilla.redhat.com/show_bug.cgi?id=1844643 --- Comment #15 from Fedora Update System --- FEDORA-2020-eec8591e24 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836567] Review Request: python-graphql-core - GraphQL implementation for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1836567 --- Comment #13 from Fedora Update System --- FEDORA-2020-607418a363 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821797] Review Request: golang-github-cayleygraph-quad - Quad/Triple formats support
https://bugzilla.redhat.com/show_bug.cgi?id=1821797 Bug 1821797 depends on bug 1821794, which changed state. Bug 1821794 Summary: Review Request: golang-github-piprate-json-gold - JSON-LD processor https://bugzilla.redhat.com/show_bug.cgi?id=1821794 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822145] Review Request: golang-github-geziyor - Web crawling & scraping framework
https://bugzilla.redhat.com/show_bug.cgi?id=1822145 Bug 1822145 depends on bug 1821703, which changed state. Bug 1821703 Summary: Review Request: golang-github-temoto-robotstxt - Robots.txt exclusion protocol implementation https://bugzilla.redhat.com/show_bug.cgi?id=1821703 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839479] Review Request: python-opencensus - A stats collection and distributed tracing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1839479 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-06-26 00:46:21 --- Comment #7 from Fedora Update System --- FEDORA-2020-8a0be5567f has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839480] Review Request: python-opentelemetry - The OpenTelemetry Python client
https://bugzilla.redhat.com/show_bug.cgi?id=1839480 Bug 1839480 depends on bug 1839479, which changed state. Bug 1839479 Summary: Review Request: python-opencensus - A stats collection and distributed tracing framework https://bugzilla.redhat.com/show_bug.cgi?id=1839479 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839773] Review Request: bst-external - Additional BuildStream plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1839773 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-06-26 00:46:30 --- Comment #12 from Fedora Update System --- FEDORA-2020-c514323d72 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821794] Review Request: golang-github-piprate-json-gold - JSON-LD processor
https://bugzilla.redhat.com/show_bug.cgi?id=1821794 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-06-26 00:45:44 --- Comment #6 from Fedora Update System --- FEDORA-2020-4aabb59615 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847117] Review Request: python-sphinxcontrib-zopeext - Sphinx extension for documenting Zope interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=1847117 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-06-26 00:45:28 --- Comment #10 from Fedora Update System --- FEDORA-2020-11ae6c9262 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836568] Review Request: python-graphql-relay - Relay library for graphql-core-next
https://bugzilla.redhat.com/show_bug.cgi?id=1836568 Bug 1836568 depends on bug 1836567, which changed state. Bug 1836567 Summary: Review Request: python-graphql-core - GraphQL implementation for Python https://bugzilla.redhat.com/show_bug.cgi?id=1836567 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821703] Review Request: golang-github-temoto-robotstxt - Robots.txt exclusion protocol implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1821703 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-06-26 00:45:42 --- Comment #6 from Fedora Update System --- FEDORA-2020-0307b9f614 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836567] Review Request: python-graphql-core - GraphQL implementation for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1836567 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-06-26 00:45:18 --- Comment #12 from Fedora Update System --- FEDORA-2020-6f04d899ba has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844643] Review Request: qwt5-qt5 - Qt Widgets for Technical Applications adapted to Qt5
https://bugzilla.redhat.com/show_bug.cgi?id=1844643 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-06-26 00:44:59 --- Comment #14 from Fedora Update System --- FEDORA-2020-44477df31a has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840377] Review Request: socialscan - CLI and library for usage checking of user names and email addresses
https://bugzilla.redhat.com/show_bug.cgi?id=1840377 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-06-26 00:45:37 --- Comment #8 from Fedora Update System --- FEDORA-2020-ae126cbb0b has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830458] Review Request: mdns-repeater - Multicast DNS repeater
https://bugzilla.redhat.com/show_bug.cgi?id=1830458 --- Comment #13 from Fedora Update System --- FEDORA-EPEL-2020-bdfa7d3d3f has been pushed to the Fedora EPEL 7 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1851205] Review Request: AusweisApp2 - Online identification with German ID card (Personalausweis)
https://bugzilla.redhat.com/show_bug.cgi?id=1851205 --- Comment #6 from Björn 'besser82' Esser --- === Updated package === Changelog: * Thu Jun 25 2020 Björn Esser - 1.20.1-0.6 - Use '--help-all' option when generating man-page - Split build of Doxygen API docs from building user docs Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/AusweisApp2.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/AusweisApp2-1.20.1-0.6.fc33.src.rpm Scratch build: Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=46162604 EPEL8:https://koji.fedoraproject.org/koji/taskinfo?taskID=46162606 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1850262] Review Request: kissat - Keep It Simple SAT solver
https://bugzilla.redhat.com/show_bug.cgi?id=1850262 --- Comment #5 from Jerry James --- (In reply to dan.cermak from comment #3) > - The package's tests fails on i686, armv7hl and s390x: > https://koji.fedoraproject.org/koji/taskinfo?taskID=46161272 Upstream has deliberately caused a test failure on big endian architectures. I will see if the code is easy to port and submit a patch upstream if it is. Otherwise, I'll have to add ExcludeArch: s390x and do likewise for the kissat dependency in cvc4. I don't yet know what's going on with the 32-bit architectures, but will look into that next. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1851205] Review Request: AusweisApp2 - Online identification with German ID card (Personalausweis)
https://bugzilla.redhat.com/show_bug.cgi?id=1851205 --- Comment #5 from Björn 'besser82' Esser --- === Updated package === Changelog: * Thu Jun 25 2020 Björn Esser - 1.20.1-0.5 - Add generated man-page Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/AusweisApp2.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/AusweisApp2-1.20.1-0.5.fc33.src.rpm Scratch build: Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=46161533 EPEL8:https://koji.fedoraproject.org/koji/taskinfo?taskID=46161535 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1849384] Review Request: swappy - Wayland native snapshot editing tool, inspired by Snappy on macOS
https://bugzilla.redhat.com/show_bug.cgi?id=1849384 Aleksei Bavshin changed: What|Removed |Added CC||alebast...@gmail.com Doc Type|--- |If docs needed, set a value --- Comment #1 from Aleksei Bavshin --- That's fast! Wasn't swappy released just a few days ago? I can do a formal review on the weekend. Meanwhile some notes I gathered from spec file and upstream build scripts. > Version: 1.0.0 Latest upstream version is 1.1.0. > BuildRequires: cairo-devel > BuildRequires: pango-devel BR: pkgconfig(cairo) BR: pkgconfig(pango) Maybe also BR: pkgconfig(gio-2.0) See corresponding section of the guidelines[1] and PR that changes gio to a proper pkgconfig dependency[2]. Also, there's an optional support for notifications which you could enable by adding BR: pkgconfig(libnotify) > Requires: fontawesome-fonts Requires might be too strong here. Fontawesome could be replaced with other symbol fonts (like Nerd Fonts) and lack of the font does not prevent application from starting. How about `Recommends: fontawesome-fonts`? Also: does this work correctly with fontawesome-fonts = 4.7.0 we have in Fedora? Upstream mentions version 5.x of the font. > %description I believe there's a rpmlint check somewhere for line width in description. Please, format this to 80 chars per line. rpmlint may show empty result on the .spec file while also displaying a full screen of errors on the .src.rpm. I recommend to run it on all source and binary packages before sending the review. Also, feel free to ignore most of spelling-error messages (except maybe British spellings, as specs supposed to be in American English). The dictionary rpmlint uses is woefully lacking. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/ [2] https://github.com/jtheoof/swappy/pull/42/files#diff-969b60ad3d206fd45c208e266ccfed38 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1850262] Review Request: kissat - Keep It Simple SAT solver
https://bugzilla.redhat.com/show_bug.cgi?id=1850262
--- Comment #4 from Jerry James ---
(In reply to dan.cermak from comment #3)
> - Have you tried talking to upstream to get the shared library option added
> upstream so that we don't have this downstream patch?
No, I haven't. This package has the same upstream as cadical. I need to
submit patches for both packages to upstream. I will do that before the next
update to this bug.
> - The package's tests fails on i686, armv7hl and s390x:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=46161272
I'll investigate. Thanks for noticing.
> - consider using `install -p` instead of cp to preserve the timestamps of
> the files
Hmm? I'm using "cp -p", which does preserve timestamps.
> - %{optflags} and $RPM_LD_FLAGS are being phased out, the "new" ones are
> %build_cflags and %build_ldflags, respectively. Also, your patch does not
> appear to forward the LD_FLAGS to the $(LD) invocation at all.
I was unaware of this phasing out. Did I miss an announcement somewhere? (I
like the idea of having the names of the two resemble each other. I'll start
converting my spec files over as I work on them.)
As for the RPM_LD_FLAGS, it looks to me like it is working. I see this in the
build log:
gcc -Wl,-z,relro -Wl,--as-needed -Wl,-z,now
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld -shared -Wl,-h,libkissat.so.0 -o
libkissat.so.0.0.0 allocate.o analyze.o ands.o arena.o assign.o autarky.o
averages.o backtrack.o backward.o build.o bump.o check.o clause.o clueue.o
collect.o colors.o compact.o config.o decide.o deduce.o dense.o dominate.o
dump.o eliminate.o equivalences.o error.o extend.o failed.o file.o flags.o
format.o forward.o frames.o gates.o handle.o heap.o ifthenelse.o import.o
internal.o learn.o limits.o logging.o minimize.o mode.o options.o phases.o
print.o probe.o profile.o promote.o proof.o propdense.o prophyper.o proprobe.o
propsearch.o queue.o reduce.o reluctant.o rephase.o report.o resize.o resolve.o
resources.o restart.o search.o smooth.o sort.o stack.o statistics.o
strengthen.o substitute.o terminate.o ternary.o trail.o transitive.o
utilities.o vector.o vivify.o walk.o watch.o weaken.o xors.o -lm
and this:
gcc -Wl,-z,relro -Wl,--as-needed -Wl,-z,now
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld -o tissat test.o application.o
parse.o witness.o testadd.o testallocate.o testapplication.o testarena.o
testbump.o testcollect.o testcoverage.o testdivert.o testdump.o testendianess.o
testerror.o testfile.o testformat.o testheap.o testinit.o testmain.o
testmessages.o testoptions.o testparse.o testprove.o testqueue.o testrandom.o
testrank.o testreferences.o testreluctant.o testscheduler.o testsizes.o
testsolve.o testsort.o teststack.o testterminate.o testusage.o testvector.o -L.
-lkissat -lm
So for both the library and the binary, $RPM_LD_FLAGS comprise the first
options after "gcc".
> - I would suggest to add a fake version to the .so and bump it with each
> update as upstream has probably no guarantees about ABI compatibility at all.
Yes, that is likely. Okay, let me try to come up with some scheme that won't
cause problems if upstream decides to support shared libraries and sonames.
Thanks again for the review, Dan! I appreciate you taking the time.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839451] Review Request: R-servr - Simple HTTP Server to Serve Static Files or Dynamic Documents
https://bugzilla.redhat.com/show_bug.cgi?id=1839451 --- Comment #5 from Elliott Sales de Andrade --- Latest version: Spec URL: https://qulogic.fedorapeople.org/R-servr.spec SRPM URL: https://qulogic.fedorapeople.org/R-servr-0.17-1.fc31.src.rpm scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=46161418 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1843300] Review Request: cgreen - C unit-test library with mocks
https://bugzilla.redhat.com/show_bug.cgi?id=1843300 dan.cer...@cgc-instruments.com changed: What|Removed |Added CC||dan.cermak@cgc-instruments. ||com Doc Type|--- |If docs needed, set a value --- Comment #1 from dan.cer...@cgc-instruments.com --- Please use the links to the raw files when using github (e.g. https://raw.githubusercontent.com/souryogurt/cgreen-rpm/master/cgreen.spec) as otherwise fedora-review cannot pick them up. I can review your package, but unfortunately I am not able to sponsor you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1845297] Review Request: jgmenu - A simple X11 menu
https://bugzilla.redhat.com/show_bug.cgi?id=1845297
dan.cer...@cgc-instruments.com changed:
What|Removed |Added
CC||dan.cermak@cgc-instruments.
||com
Doc Type|--- |If docs needed, set a value
--- Comment #1 from dan.cer...@cgc-instruments.com ---
Just glanced over the spec:
- AUTHORS.md CONTRIBUTING.md INSTALL.md NEWS.md are imho not worth being added
to the final rpm as %doc, skip them
- use %make_build instead of %{__make} %{?_smp_mflags} (double underscore
macros are considered rpm internal and should be avoided)
- why is there a hash before `--with-lx --with-pmenu --with-gtktheme
--with-xfce4-panel-applet`?
- upstream has tests, can you add them to %check?
I'll try to take a closer look in the next few days. If I forget, please ping
me. Also, as this is a package intended for i3, would you be interested in
joining forces in the i3 SIG (https://fedoraproject.org/wiki/SIGs/i3)?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839451] Review Request: R-servr - Simple HTTP Server to Serve Static Files or Dynamic Documents
https://bugzilla.redhat.com/show_bug.cgi?id=1839451 --- Comment #4 from Iñaki Ucar --- Done in #993. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1850262] Review Request: kissat - Keep It Simple SAT solver
https://bugzilla.redhat.com/show_bug.cgi?id=1850262
dan.cer...@cgc-instruments.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #3 from dan.cer...@cgc-instruments.com ---
I have used Rawhide as the default build root, which currently contains a
broken annobin (again…). F32 works flawlessly so I've used that instead.
A few comments:
- Have you tried talking to upstream to get the shared library option added
upstream so that we don't have this downstream patch?
- The package's tests fails on i686, armv7hl and s390x:
https://koji.fedoraproject.org/koji/taskinfo?taskID=46161272
- consider using `install -p` instead of cp to preserve the timestamps of the
files
- %{optflags} and $RPM_LD_FLAGS are being phased out, the "new" ones are
%build_cflags and %build_ldflags, respectively. Also, your patch does not
appear to forward the LD_FLAGS to the $(LD) invocation at all.
- I would suggest to add a fake version to the .so and bump it with each update
as upstream has probably no guarantees about ABI compatibility at all.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License". 435 files have unknown
license. Detailed output of licensecheck in /home/dan/fedora-
scm/1850262-kissat/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[Bug 1844308] Review Request: python-uvicorn - The lightning-fast ASGI server
https://bugzilla.redhat.com/show_bug.cgi?id=1844308 Carl George 🤠 changed: What|Removed |Added Flags|needinfo?(c...@redhat.com) | --- Comment #5 from Carl George 🤠 --- Thanks Itamar, I'll take a look. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1850262] Review Request: kissat - Keep It Simple SAT solver
https://bugzilla.redhat.com/show_bug.cgi?id=1850262 dan.cer...@cgc-instruments.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|dan.cermak@cgc-instruments. ||com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1851205] Review Request: AusweisApp2 - Online identification with German ID card (Personalausweis)
https://bugzilla.redhat.com/show_bug.cgi?id=1851205 --- Comment #4 from Björn 'besser82' Esser --- === Updated package === Changelog: * Thu Jun 25 2020 Björn Esser - 1.20.1-0.4 - Use a macro for lowercase package name Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/AusweisApp2.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/AusweisApp2-1.20.1-0.4.fc33.src.rpm Scratch build: Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=46161110 EPEL8:https://koji.fedoraproject.org/koji/taskinfo?taskID=46161112 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1831578] Review Request: luv-icon-theme - Flat, but complex, icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1831578 --- Comment #7 from Fedora Update System --- FEDORA-2020-34281d4c2f has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-34281d4c2f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1831578] Review Request: luv-icon-theme - Flat, but complex, icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1831578 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #6 from Fedora Update System --- FEDORA-2020-3ab9d76046 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-3ab9d76046 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839451] Review Request: R-servr - Simple HTTP Server to Serve Static Files or Dynamic Documents
https://bugzilla.redhat.com/show_bug.cgi?id=1839451
--- Comment #3 from Elliott Sales de Andrade ---
(In reply to Iñaki Ucar from comment #2)
> - The Source0 URL works only for current versions, but not when the package
> is
> archived (so it doesn't work now for 0.16). The scheme that is guaranteed
> to
> work both for releases and archived packages is the following:
>
> URL: https://cran.r-project.org/package=%{packname}
> Source0: %{url}&version=%{version}#/%{packname}_%{version}.tar.gz
Please open an PR to the guidelines for this.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1850265] Review Request: ocaml-mew-vi - Modal Editing Witch, VI interpreter
https://bugzilla.redhat.com/show_bug.cgi?id=1850265 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-mew-vi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1850264] Review Request: ocaml-mew - Modal Editing Witch
https://bugzilla.redhat.com/show_bug.cgi?id=1850264 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-mew -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1850265] Review Request: ocaml-mew-vi - Modal Editing Witch, VI interpreter
https://bugzilla.redhat.com/show_bug.cgi?id=1850265
--- Comment #2 from Jerry James ---
(In reply to dan.cermak from comment #1)
> I have the following minor nitpicks (feel free to address or ignore them as
> you feel):
> - the opam file pins the version of mew to {>= "0.1.0" & < "0.2"} but the
> spec just contains the former
> - the documentation is quite large and it might be worthwhile to split it
> into a subpackage
Both good points. I have updated the package. The URLs are the same as
before. Thank you for the review! Let me know if I can do something for you.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1850263] Review Request: ocaml-trie - Strict impure trie tree
https://bugzilla.redhat.com/show_bug.cgi?id=1850263 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-trie -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839474] Review Request: R-DBItest - Testing DBI Backends
https://bugzilla.redhat.com/show_bug.cgi?id=1839474
Iñaki Ucar changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #2 from Iñaki Ucar ---
Noarch-specific bits correct, license correct, files correct, rpmlint correct,
requires sane. Please consider using the more general scheme for the source URL
that works both for current releases and archived packages:
URL: https://cran.r-project.org/package=%{packname}
Source0: %{url}&version=%{version}#/%{packname}_%{version}.tar.gz
Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839456] Review Request: R-filelock - Portable File Locking
https://bugzilla.redhat.com/show_bug.cgi?id=1839456
Iñaki Ucar changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #2 from Iñaki Ucar ---
Arch-specific bits correct, license correct, files correct, rpmlint correct,
requires sane. Please consider using the more general scheme for the source URL
that works both for current releases and archived packages:
URL: https://cran.r-project.org/package=%{packname}
Source0: %{url}&version=%{version}#/%{packname}_%{version}.tar.gz
Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1850264] Review Request: ocaml-mew - Modal Editing Witch
https://bugzilla.redhat.com/show_bug.cgi?id=1850264 --- Comment #2 from Jerry James --- Thanks for the review, Dan! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1850262] Review Request: kissat - Keep It Simple SAT solver
https://bugzilla.redhat.com/show_bug.cgi?id=1850262 --- Comment #2 from Jerry James --- Hi Dan. Thanks for looking at this package. I can't reproduce the problem, but it looks like annobin is/was broken. I just did a mock build with "mock -r fedora-rawhide-x86_64 --rebuild kissat-0-1.sc2020.fc32.src.rpm" and it built successfully. Can you try again and see if the issue was transient? If not, can you give me the mock invocation you are using? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1851205] Review Request: AusweisApp2 - Online identification with German ID card (Personalausweis)
https://bugzilla.redhat.com/show_bug.cgi?id=1851205 --- Comment #3 from Björn 'besser82' Esser --- === Fixed urls === Spec URL: https://pagure.io/besser82/package-review/raw/master/f/AusweisApp2.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/AusweisApp2-1.20.1-0.3.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1850263] Review Request: ocaml-trie - Strict impure trie tree
https://bugzilla.redhat.com/show_bug.cgi?id=1850263 --- Comment #2 from Jerry James --- Thank you for the review, Jared! Let me know if I can do something for you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839451] Review Request: R-servr - Simple HTTP Server to Serve Static Files or Dynamic Documents
https://bugzilla.redhat.com/show_bug.cgi?id=1839451
--- Comment #2 from Iñaki Ucar ---
- Please, package the latest version (0.17).
- The license is GPL+, because they don't specify any version.
- The Source0 URL works only for current versions, but not when the package is
archived (so it doesn't work now for 0.16). The scheme that is guaranteed to
work both for releases and archived packages is the following:
URL: https://cran.r-project.org/package=%{packname}
Source0: %{url}&version=%{version}#/%{packname}_%{version}.tar.gz
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1851205] Review Request: AusweisApp2 - Online identification with German ID card (Personalausweis)
https://bugzilla.redhat.com/show_bug.cgi?id=1851205 Björn 'besser82' Esser changed: What|Removed |Added Blocks||182235 (FE-Legal) Depends On|182235 (FE-Legal) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1851205] Review Request: AusweisApp2 - Online identification with German ID card (Personalausweis)
https://bugzilla.redhat.com/show_bug.cgi?id=1851205 --- Comment #2 from Björn 'besser82' Esser --- === Updated package === Changelog: * Thu Jun 25 2020 Björn Esser - 1.20.1-0.3 - Use ninja-build instead of GNU Make to speed up the build a bit Urls: Spec URL: https://pagure.io/besser82/package-review/blob/master/f/AusweisApp2.spec SRPM URL: https://pagure.io/besser82/package-review/blob/master/f/AusweisApp2-1.20.1-0.3.fc33.src.rpm Scratch build: Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=46158165 EPEL8:https://koji.fedoraproject.org/koji/taskinfo?taskID=46158009 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839429] Review Request: rust-bzip2-sys - Bindings to libbzip2 for bzip2 compression and decompression exposed as Reader/Writer streams
https://bugzilla.redhat.com/show_bug.cgi?id=1839429 Breno changed: What|Removed |Added Flags|needinfo?(brand...@gmail.co |needinfo+ |m) | --- Comment #5 from Breno --- LGTM -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1811774] Review Request: rubygem-puppetserver-ca - A simple CLI tool for interacting with Puppet Server's Certificate Authority
https://bugzilla.redhat.com/show_bug.cgi?id=1811774 Breno changed: What|Removed |Added Flags|needinfo?(brand...@gmail.co | |m) | --- Comment #11 from Breno --- Spec URL: https://download.copr.fedorainfracloud.org/results/brandfbb/el8-playground/epel-8-x86_64/01504103-rubygem-puppetserver-ca/rubygem-puppetserver-ca.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/brandfbb/el8-playground/epel-8-x86_64/01504103-rubygem-puppetserver-ca/rubygem-puppetserver-ca-1.8.0-1.el8.src.rpm Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1811777] Review Request: rubygem-puppet-resource_api - This library provides a simple way to write new native resources for puppet
https://bugzilla.redhat.com/show_bug.cgi?id=1811777 Breno changed: What|Removed |Added Flags|needinfo?(brand...@gmail.co | |m) | --- Comment #7 from Breno --- Spec URL: https://download.copr.fedorainfracloud.org/results/brandfbb/el8-playground/epel-8-x86_64/01504101-rubygem-puppet-resource_api/rubygem-puppet-resource_api.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/brandfbb/el8-playground/epel-8-x86_64/01504101-rubygem-puppet-resource_api/rubygem-puppet-resource_api-1.8.13-1.el8.src.rpm There you go, thanks Michel. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1851205] Review Request: AusweisApp2 - Online identification with German ID card (Personalausweis)
https://bugzilla.redhat.com/show_bug.cgi?id=1851205 --- Comment #1 from Björn 'besser82' Esser --- === Updated package === Changelog: * Thu Jun 25 2020 Björn Esser - 1.20.1-0.2 - Adaptions for building on EPEL Urls: Spec URL: https://pagure.io/besser82/package-review/blob/master/f/AusweisApp2.spec SRPM URL: https://pagure.io/besser82/package-review/blob/master/f/AusweisApp2-1.20.1-0.2.fc33.src.rpm Scratch build: Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=46155735 EPEL8:https://koji.fedoraproject.org/koji/taskinfo?taskID=46155737 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839376] Review Request: rust-log-panics - Panic hook which logs panic messages rather than printing them
https://bugzilla.redhat.com/show_bug.cgi?id=1839376
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #2 from Robert-André Mauchin ---
Try to backport:
https://github.com/sfackler/rust-log-panics/commit/4dcf408a6ff2e458abbb62702ecab088c38596c6
===
diff -up log-panics-2.0.0/examples/panic.rs.orig
log-panics-2.0.0/examples/panic.rs
--- log-panics-2.0.0/examples/panic.rs.orig 2017-08-05 07:32:20.0
+0200
+++ log-panics-2.0.0/examples/panic.rs 2020-06-25 21:09:26.785895461 +0200
@@ -2,7 +2,7 @@ extern crate log_panics;
extern crate env_logger;
fn main() {
-env_logger::init().unwrap();
+env_logger::init();
log_panics::init();
foo();
===
And bump env_logger to 0.7
- License ok
- Latest version packaged
- Builds in mock
- No rpmlint errors
- Conforms to Packaging Guidelines
Please add this patch and address Igor's comments.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1849568] Review Request: sourcetrail - a free and open-source interactive source explorer
https://bugzilla.redhat.com/show_bug.cgi?id=1849568 serge_sans_paille changed: What|Removed |Added Assignee|nob...@fedoraproject.org|tstel...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1851205] Review Request: AusweisApp2 - Online identification with German ID card (Personalausweis)
https://bugzilla.redhat.com/show_bug.cgi?id=1851205 Björn 'besser82' Esser changed: What|Removed |Added Alias||AusweisApp2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1851205] Review Request: AusweisApp2 - Online identification with German ID card (Personalausweis)
https://bugzilla.redhat.com/show_bug.cgi?id=1851205 Björn 'besser82' Esser changed: What|Removed |Added Depends On||182235 (FE-Legal) Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1851205] New: Review Request: AusweisApp2 - Online identification with German ID card (Personalausweis)
https://bugzilla.redhat.com/show_bug.cgi?id=1851205 Bug ID: 1851205 Summary: Review Request: AusweisApp2 - Online identification with German ID card (Personalausweis) Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: besse...@fedoraproject.org QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Description: The AusweisApp2 is a software to identify yourself online with your ID card (Personalausweis) or your electronic residence permit (Aufenthalts- / Niederlassungserlaubis). The AusweisApp2 also offers you an integrated self-assessment in which you are able to view your data that is stored on the online ID. Issues: fedora-review shows no obvious issues. rpmlint emits some non-critical warnings. FAS-User: besser82 Urls: Spec URL: https://pagure.io/besser82/package-review/blob/master/f/AusweisApp2.spec SRPM URL: https://pagure.io/besser82/package-review/blob/master/f/AusweisApp2-1.20.1-0.1.fc33.src.rpm Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=46152262 Additional Information: The EUPL 1.2 license is currently under review by fedora-legal. [1] Build may take up to 20 minutes, depending on your CPU and RAM. Thanks for review in advance! [1] https://lists.fedoraproject.org/archives/list/le...@lists.fedoraproject.org/thread/LZQ4SRN6L5JWEDKL23K4CXDG7TJWFTLF/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839384] Review Request: rust-widestring - A wide string FFI Rust library for converting to and from wide Unicode strings
https://bugzilla.redhat.com/show_bug.cgi?id=1839384 --- Comment #3 from Robert-André Mauchin --- - Add a comment explaining what you've patched out # Initial patched metadata -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839384] Review Request: rust-widestring - A wide string FFI Rust library for converting to and from wide Unicode strings
https://bugzilla.redhat.com/show_bug.cgi?id=1839384
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #2 from Robert-André Mauchin ---
- Bump to 0.4.2
Seems a bug in upstream:
//! ```rust
//! # #[cfg(not(windows))]
//! # fn main() {}
//! # extern crate winapi;
//! # extern crate widestring;
//! # #[cfg(windows)]
//! # fn main() {
Try to send a patch upstream.
- License ok
- Builds in mock
- No rpmlint errors
- Conforms to Packaging Guidelines
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839389] Review Request: naabu - Fast port scanner
https://bugzilla.redhat.com/show_bug.cgi?id=1839389 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- - Bump to 1.1.3 - License ok - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839143] Review Request: mingw-python-requests - MinGW Windows Python requests library
https://bugzilla.redhat.com/show_bug.cgi?id=1839143 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-python-requests -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839144] Review Request: mingw-python-werkzeug - MinGW Windows Python werkzeug library
https://bugzilla.redhat.com/show_bug.cgi?id=1839144 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-python-werkzeug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839380] Review Request: golang-github-phayes-freeport - Detect free and open TCP port
https://bugzilla.redhat.com/show_bug.cgi?id=1839380 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839375] Review Request: rust-dialoguer - Command line prompting library
https://bugzilla.redhat.com/show_bug.cgi?id=1839375 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1850265] Review Request: ocaml-mew-vi - Modal Editing Witch, VI interpreter
https://bugzilla.redhat.com/show_bug.cgi?id=1850265
dan.cer...@cgc-instruments.com changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #1 from dan.cer...@cgc-instruments.com ---
I have the following minor nitpicks (feel free to address or ignore them as you
feel):
- the opam file pins the version of mew to {>= "0.1.0" & < "0.2"} but the spec
just contains the former
- the documentation is quite large and it might be worthwhile to split it into
a subpackage
As this is just a minor issue: package approved, thanks for bringing them to
Fedora!
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License". 19 files have unknown
license. Detailed output of licensecheck in /home/dan/fedora-
scm/1850265-ocaml-mew-vi/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[!]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 962560 bytes in 128 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Ocaml:
[x]: This should never happen
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-Engli
[Bug 1850265] Review Request: ocaml-mew-vi - Modal Editing Witch, VI interpreter
https://bugzilla.redhat.com/show_bug.cgi?id=1850265 dan.cer...@cgc-instruments.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||dan.cermak@cgc-instruments. ||com Assignee|nob...@fedoraproject.org|dan.cermak@cgc-instruments. ||com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839340] Review Request: mingw-python-pillow - MinGW Windows Python pillow library
https://bugzilla.redhat.com/show_bug.cgi?id=1839340
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #1 from Robert-André Mauchin ---
Please be more specific in %files:
%files -n mingw32-python3-%{pkgname}
%license docs/COPYING
%{mingw32_python3_sitearch}/PIL/
%{mingw32_python3_sitearch}/Pillow-%{version}-py*.egg-info
%{mingw32_py3_incdir}/Imaging/
%files -n mingw64-python3-%{pkgname}
%license docs/COPYING
%{mingw64_python3_sitearch}/PIL/
%{mingw64_python3_sitearch}/Pillow-%{version}-py*.egg-info
%{mingw64_py3_incdir}/Imaging/
Package approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU Lesser General Public License",
"*No copyright* SIL Open Font License (v1.1)", "SIL Open Font License
1.1", "NTP License (legal disclaimer)", "Expat License". 1217 files
have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/mingw-python-pillow/review-mingw-python-
pillow/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
mingw32-python3-pillow , mingw64-python3-pillow
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separa
[Bug 1839374] Review Request: terrier - Image and Container analysis tool
https://bugzilla.redhat.com/show_bug.cgi?id=1839374 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1850264] Review Request: ocaml-mew - Modal Editing Witch
https://bugzilla.redhat.com/show_bug.cgi?id=1850264
dan.cer...@cgc-instruments.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||dan.cermak@cgc-instruments.
||com
Assignee|nob...@fedoraproject.org|dan.cermak@cgc-instruments.
||com
Flags||fedora-review+
--- Comment #1 from dan.cer...@cgc-instruments.com ---
Package is approved, thanks for packaging it!
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License". 16 files have unknown
license. Detailed output of licensecheck in /home/dan/fedora-
scm/1850264-ocaml-mew/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 460800 bytes in 86 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Ocaml:
[x]: This should never happen
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]:
[Bug 1839147] Review Request: mingw-python-flask - MinGW Windows Python flask library
https://bugzilla.redhat.com/show_bug.cgi?id=1839147 Bug 1839147 depends on bug 1839142, which changed state. Bug 1839142 Summary: Review Request: mingw-python-jinja2 - MinGW Windows Python jinja2 library https://bugzilla.redhat.com/show_bug.cgi?id=1839142 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839142] Review Request: mingw-python-jinja2 - MinGW Windows Python jinja2 library
https://bugzilla.redhat.com/show_bug.cgi?id=1839142 Sandro Mani changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-06-25 17:25:48 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839338] Review Request: mingw-libimagequant - MinGW Windows libimagequant library
https://bugzilla.redhat.com/show_bug.cgi?id=1839338
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #1 from Robert-André Mauchin ---
Package approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* BSD 2-clause
"Simplified" License", "GNU General Public License", "*No copyright*
GPL (v3 or later)", "NTP License". 38 files have unknown license.
Detailed output of licensecheck in /home/bob/packaging/review/mingw-
libimagequant/review-mingw-libimagequant/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
mingw32-libimagequant , mingw64-libimagequant
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[--]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into
[Bug 1850780] Review Request: qca-qt4 - Qt4 Cryptographic Architecture
https://bugzilla.redhat.com/show_bug.cgi?id=1850780 Rex Dieter changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG Assignee|rdie...@gmail.com |nob...@fedoraproject.org Flags|fedora-review+ | Last Closed||2020-06-25 17:16:05 --- Comment #5 from Rex Dieter --- I'm told fedpkg request-repo qca-qt4 --exception is the way to go, and that no bug is required, I'll close this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839271] Review Request: rust-copypasta - Cross-platform library for getting and setting the contents of the OS-level clipboard
https://bugzilla.redhat.com/show_bug.cgi?id=1839271 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- rust-copypasta+smithay-clipboard-devel.noarch: E: summary-too-long C Cross-platform library for getting and setting the contents of the OS-level clipboard - Shorten the Summary to 80 characters - License ok - Latest version packaged - Builds in mock - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839145] Review Request: mingw-python-itsdangerous - MinGW Windows Python itsdangerous library
https://bugzilla.redhat.com/show_bug.cgi?id=1839145 Sandro Mani changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-06-25 17:08:38 --- Comment #3 from Sandro Mani --- Thanks so much as always, let me know if you have things up for review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839147] Review Request: mingw-python-flask - MinGW Windows Python flask library
https://bugzilla.redhat.com/show_bug.cgi?id=1839147 Bug 1839147 depends on bug 1839145, which changed state. Bug 1839145 Summary: Review Request: mingw-python-itsdangerous - MinGW Windows Python itsdangerous library https://bugzilla.redhat.com/show_bug.cgi?id=1839145 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839144] Review Request: mingw-python-werkzeug - MinGW Windows Python werkzeug library
https://bugzilla.redhat.com/show_bug.cgi?id=1839144 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
