[Bug 1856313] Review Request: python-ipywidgets - IPython HTML widgets for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856313



--- Comment #2 from Lumír Balhar  ---
(In reply to Miro Hrončok from comment #1)
> Spec sanity:
> 
> Why is this needed? IS the dependency generator not working here?
> 
>   Requires:   python3dist(ipython)
>   Requires:   python3dist(ipykernel)
>   Requires:   python3dist(notebook)
>   Requires:   python3dist(traitlets)
>   Requires:   python3dist(widgetsnbextension)

I don't know why, but the automatic runtime dependency generator does not work
here and without explicit specification the result is:

rpm -q --requires RPMS/python3-ipywidgets-7.5.1-1.fc33.noarch.rpm
python(abi) = 3.9
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsZstd) <= 5.4.18-1

> + comments from bz1856310.

%python_provide removed


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856310] Review Request: python-widgetsnbextension - Interactive HTML widgets for Jupyter notebooks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856310



--- Comment #5 from Lumír Balhar  ---
(In reply to Miro Hrončok from comment #1)
> Spec sanity:
> 
> This is useless on rawhide:
> 
>   %{?python_provide:%python_provide python3-%{pypi_name}}
> 
> This is probably useless as well:
> 
>   # Remove bundled egg-info
>   rm -rf %{pypi_name}.egg-info
> 
> Th rest looks reasonable from the fist glance.

Both removed.

> Generic:
> [!]: Spec file according to URL is the same as in SRPM.
>  Note: Spec file as given by url is not the same as in SRPM (see
>  attached diff).
>  See: (this test has no URL)

Fixed.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1180017] Review Request: rubygem-bugzilla - Bugzilla interface library for Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1180017

Akira TAGOH  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DEFERRED
  Flags|needinfo?(ta...@redhat.com) |
Last Closed||2020-07-14 04:08:33



--- Comment #2 from Akira TAGOH  ---
Not that interested in it now. closing.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

needinfo canceled: [Bug 1180017] Review Request: rubygem-bugzilla - Bugzilla interface library for Ruby

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Akira TAGOH  has canceled Package Review
's request for Akira TAGOH
's needinfo:
Bug 1180017: Review Request: rubygem-bugzilla - Bugzilla interface library for
Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1180017



--- Comment #2 from Akira TAGOH  ---
Not that interested in it now. closing.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1374070] Review Request: mediawiki123-HTTP302Found - Forces an external HTTP 302 redirect instead of internal redirects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374070

Kevin Fenzi  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG
  Flags|needinfo?(ke...@scrye.com)  |
Last Closed||2020-07-14 03:14:14



--- Comment #2 from Kevin Fenzi  ---
This is no longer needed. :)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

needinfo canceled: [Bug 1374070] Review Request: mediawiki123-HTTP302Found - Forces an external HTTP 302 redirect instead of internal redirects

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Kevin Fenzi  has canceled Package Review
's request for Kevin Fenzi
's needinfo:
Bug 1374070: Review Request: mediawiki123-HTTP302Found - Forces an external
HTTP 302 redirect instead of internal redirects
https://bugzilla.redhat.com/show_bug.cgi?id=1374070



--- Comment #2 from Kevin Fenzi  ---
This is no longer needed. :)
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1282012] Review Request: palo-client-cpp - Palo Database C++ Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282012

Michael John Arnold  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
Last Closed||2020-07-14 03:06:39




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1282438] Review Request: palo-client-c - Palo Database C Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282438

Michael John Arnold  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
Last Closed|2016-12-20 15:58:33 |2020-07-14 03:07:11




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1282438] Review Request: palo-client-c - Palo Database C Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282438
Bug 1282438 depends on bug 1282012, which changed state.

Bug 1282012 Summary: Review Request: palo-client-cpp - Palo Database C++ Client
https://bugzilla.redhat.com/show_bug.cgi?id=1282012

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856589] Review Request: openshadinglanguage - Advanced shading language for production GI renderers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856589

Luya Tshimbalanga  changed:

   What|Removed |Added

   Doc Type|--- |If docs needed, set a value



--- Comment #1 from Luya Tshimbalanga  ---
COPR repository with successful built: 
https://download.copr.fedorainfracloud.org/results/luya/openshadinglanguage/fedora-rawhide-x86_64/01553288-openshadinglanguage/


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856589] New: Review Request: openshadinglanguage - Advanced shading language for production GI renderers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856589

Bug ID: 1856589
   Summary: Review Request: openshadinglanguage - Advanced shading
language for production GI renderers
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: luya_...@thefinalzone.net
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://download.copr.fedorainfracloud.org/results/luya/openshadinglanguage/fedora-rawhide-x86_64/01553288-openshadinglanguage/openshadinglanguage.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/luya/openshadinglanguage/fedora-rawhide-x86_64/01553288-openshadinglanguage/openshadinglanguage-1.11.6.0-1.fc33.src.rpm
Description: Open Shading Language (OSL) is a small but rich language for
programmable shading in advanced renderers and other applications, ideal for
describing materials, lights, displacement, and pattern generation.

Fedora Account System Username:luya


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1537677] Review Request: nomad-firewall - UFW control module for KDE Plasma 5 and Nomad Desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537677

Kevin Kofler  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG
  Flags|needinfo?(kevin@tigcc.tical |
   |c.org)  |
Last Closed||2020-07-14 02:21:52



--- Comment #6 from Kevin Kofler  ---
I think we can close this at this point. The review got stalled because the
reviewer demanded changes that were not actually required by the packaging
guidelines (at least at the time of the review). In the meantime, the package
got renamed upstream to nx-firewall. I also found that the user interface is
highly impractical to use (see
https://github.com/nx-desktop/nx-firewall/issues/15 and
https://github.com/nx-desktop/nx-firewall/issues/16 ) and the issues have not
been addressed. (In fact, not much has happened upstream other than the
rename.) And the plan upstream is still to rewrite everything to use another
backend ( https://github.com/nx-desktop/nx-firewall/issues/21 ). So I decided
against shipping this package in Kannolo, and hence lost interest in it.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

needinfo canceled: [Bug 1537677] Review Request: nomad-firewall - UFW control module for KDE Plasma 5 and Nomad Desktop

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Kevin Kofler  has canceled Package Review
's request for Kevin Kofler
's needinfo:
Bug 1537677: Review Request: nomad-firewall - UFW control module for KDE Plasma
5 and Nomad Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1537677



--- Comment #6 from Kevin Kofler  ---
I think we can close this at this point. The review got stalled because the
reviewer demanded changes that were not actually required by the packaging
guidelines (at least at the time of the review). In the meantime, the package
got renamed upstream to nx-firewall. I also found that the user interface is
highly impractical to use (see
https://github.com/nx-desktop/nx-firewall/issues/15 and
https://github.com/nx-desktop/nx-firewall/issues/16 ) and the issues have not
been addressed. (In fact, not much has happened upstream other than the
rename.) And the plan upstream is still to rewrite everything to use another
backend ( https://github.com/nx-desktop/nx-firewall/issues/21 ). So I decided
against shipping this package in Kannolo, and hence lost interest in it.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1837107] Review Request: 7kaa - Seven Kingdoms: Ancient Adversaries (claiming ownership of package)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1837107

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #21 from Fedora Update System  ---
FEDORA-2020-cd5132634d has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing
--advisory=FEDORA-2020-cd5132634d \*`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-cd5132634d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1854202] Review Request: golang-github-instrumenta-kubeval - Validate your Kubernetes configuration files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1854202



--- Comment #7 from Fedora Update System  ---
FEDORA-2020-8755e3db8b has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing
--advisory=FEDORA-2020-8755e3db8b \*`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-8755e3db8b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1854202] Review Request: golang-github-instrumenta-kubeval - Validate your Kubernetes configuration files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1854202



--- Comment #6 from Fedora Update System  ---
FEDORA-2020-49e3e8d996 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing
--advisory=FEDORA-2020-49e3e8d996 \*`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-49e3e8d996

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1831602] Review Request: spectrographic - Turn an image into sound

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1831602



--- Comment #4 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/spectrographic


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856557] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856557

Mat Booth  changed:

   What|Removed |Added

Link ID||Fedora Pagure
   ||releng/issue/9600



--- Comment #1 from Mat Booth  ---
This is a re-review for unretirement: https://pagure.io/releng/issue/9600


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856556] Review Request: svnkit - Pure Java library to manage Subversion working copies and repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856556

Mat Booth  changed:

   What|Removed |Added

Link ID||Fedora Pagure
   ||releng/issue/9599



--- Comment #1 from Mat Booth  ---
This is a re-review for unretirement: https://pagure.io/releng/issue/9599


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856554] Review Request: maven-archetype - Maven project templating toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856554

Mat Booth  changed:

   What|Removed |Added

Link ID||Fedora Pagure
   ||releng/issue/9597



--- Comment #1 from Mat Booth  ---
This is a re-review for unretirement: https://pagure.io/releng/issue/9597


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856555] Review Request: maven-indexer - Standard for producing indexes of Maven repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856555

Mat Booth  changed:

   What|Removed |Added

Link ID||Fedora Pagure
   ||releng/issue/9598



--- Comment #1 from Mat Booth  ---
This is a re-review for unretirement: https://pagure.io/releng/issue/9598


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856553] Review Request: jsch-agent-proxy - Proxy to ssh-agent and Pageant in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856553

Mat Booth  changed:

   What|Removed |Added

Link ID||Fedora Pagure
   ||releng/issue/9596



--- Comment #1 from Mat Booth  ---
This is a re-review for unretirement: https://pagure.io/releng/issue/9596


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856552] Review Request: jchardet - Java port of Mozilla's automatic character set detection algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856552

Mat Booth  changed:

   What|Removed |Added

Link ID||Fedora Pagure
   ||releng/issue/9595



--- Comment #1 from Mat Booth  ---
This is a re-review for unretirement: https://pagure.io/releng/issue/9595


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1821724] Review Request: golang-github-gobwas-pool - Go Pooling Helpers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1821724

Hirotaka Wakabayashi  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Hirotaka Wakabayashi  ---
Hello Fabian, Thank you for your updates. Package Approved.

Please update the version before you import. The newer version, which includes
the LICENSE file, has released 13 days ago. :)

Best,
Hirotaka Wakabayashi



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package does not own files or directories owned by other packages.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
 publishes signatures.
 Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on 

[Bug 1856553] Review Request: jsch-agent-proxy - Proxy to ssh-agent and Pageant in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856553

Mat Booth  changed:

   What|Removed |Added

 Blocks||1856556





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1856556
[Bug 1856556] Review Request: svnkit - Pure Java library to manage Subversion
working copies and repositories
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856557] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856557

Mat Booth  changed:

   What|Removed |Added

 Blocks||1856556





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1856556
[Bug 1856556] Review Request: svnkit - Pure Java library to manage Subversion
working copies and repositories
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856556] Review Request: svnkit - Pure Java library to manage Subversion working copies and repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856556

Mat Booth  changed:

   What|Removed |Added

 Depends On||1856553, 1856557





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1856553
[Bug 1856553] Review Request: jsch-agent-proxy - Proxy to ssh-agent and Pageant
in Java
https://bugzilla.redhat.com/show_bug.cgi?id=1856557
[Bug 1856557] Review Request: trilead-ssh2 - SSH-2 protocol implementation in
pure Java
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856553] Review Request: jsch-agent-proxy - Proxy to ssh-agent and Pageant in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856553

Mat Booth  changed:

   What|Removed |Added

 Depends On||1856557





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1856557
[Bug 1856557] Review Request: trilead-ssh2 - SSH-2 protocol implementation in
pure Java
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856557] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856557

Mat Booth  changed:

   What|Removed |Added

 Blocks||1856553





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1856553
[Bug 1856553] Review Request: jsch-agent-proxy - Proxy to ssh-agent and Pageant
in Java
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856552] Review Request: jchardet - Java port of Mozilla's automatic character set detection algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856552

Mat Booth  changed:

   What|Removed |Added

 Blocks||1856554





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1856554
[Bug 1856554] Review Request: maven-archetype - Maven project templating
toolkit
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856554] Review Request: maven-archetype - Maven project templating toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856554

Mat Booth  changed:

   What|Removed |Added

 Blocks||1856555





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1856555
[Bug 1856555] Review Request: maven-indexer - Standard for producing indexes of
Maven repositories
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856555] Review Request: maven-indexer - Standard for producing indexes of Maven repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856555

Mat Booth  changed:

   What|Removed |Added

 Depends On||1856554





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1856554
[Bug 1856554] Review Request: maven-archetype - Maven project templating
toolkit
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856554] Review Request: maven-archetype - Maven project templating toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856554

Mat Booth  changed:

   What|Removed |Added

 Depends On||1856552





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1856552
[Bug 1856552] Review Request: jchardet - Java port of Mozilla's automatic
character set detection algorithm
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856557] New: Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856557

Bug ID: 1856557
   Summary: Review Request: trilead-ssh2 - SSH-2 protocol
implementation in pure Java
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mat.bo...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://fedorapeople.org/~mbooth/reviews/trilead-ssh2.spec
SRPM URL:
https://fedorapeople.org/~mbooth/reviews/trilead-ssh2-217-13.jenkins8.fc33.src.rpm
Fedora Account System Username: mbooth
Description:
Trilead SSH-2 for Java is a library which implements the SSH-2 protocol in pure
Java (tested on J2SE 1.4.2 and 5.0). It allows one to connect to SSH servers
from within Java programs. It supports SSH sessions (remote command execution
and shell access), local and remote port forwarding, local stream forwarding,
X11 forwarding and SCP. There are no dependencies on any JCE provider, as all
crypto functionality is included.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856556] New: Review Request: svnkit - Pure Java library to manage Subversion working copies and repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856556

Bug ID: 1856556
   Summary: Review Request: svnkit - Pure Java library to manage
Subversion working copies and repositories
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mat.bo...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://fedorapeople.org/~mbooth/reviews/svnkit.spec
SRPM URL: https://fedorapeople.org/~mbooth/reviews/svnkit-1.8.12-7.fc33.src.rpm
Fedora Account System Username: mbooth
Description:
SVNKit is a pure java Subversion client library. You would like to use SVNKit
when you need to access or modify Subversion repository from your Java
application, as a standalone program and plugin or web application. Being a
pure java program, SVNKit doesn't need any additional configuration or native
binaries to work on any OS that runs java.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856553] New: Review Request: jsch-agent-proxy - Proxy to ssh-agent and Pageant in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856553

Bug ID: 1856553
   Summary: Review Request: jsch-agent-proxy - Proxy to ssh-agent
and Pageant in Java
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mat.bo...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://fedorapeople.org/~mbooth/reviews/jsch-agent-proxy.spec
SRPM URL:
https://fedorapeople.org/~mbooth/reviews/jsch-agent-proxy-0.0.8-11.fc33.src.rpm
Fedora Account System Username: mbooth
Description:
jsch-agent-proxy is a proxy program to OpenSSH ssh-agent and Pageant
included Putty.  It will be easily integrated into JSch, and users
will be allowed to use those programs in authentications.  This
software has been developed for JSch, but it will be easily applicable
to other ssh2 implementations in Java.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856555] New: Review Request: maven-indexer - Standard for producing indexes of Maven repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856555

Bug ID: 1856555
   Summary: Review Request: maven-indexer - Standard for producing
indexes of Maven repositories
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mat.bo...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://fedorapeople.org/~mbooth/reviews/maven-indexer.spec
SRPM URL:
https://fedorapeople.org/~mbooth/reviews/maven-indexer-6.0.0-4.fc33.src.rpm
Fedora Account System Username: mbooth
Description:
Apache Maven Indexer (former Sonatype Nexus Indexer) is the defacto
standard for producing indexes of Maven repositories. The Indexes
are produced and consumed by all major tools in the ecosystem.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856554] New: Review Request: maven-archetype - Maven project templating toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856554

Bug ID: 1856554
   Summary: Review Request: maven-archetype - Maven project
templating toolkit
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mat.bo...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://fedorapeople.org/~mbooth/reviews/maven-archetype.spec
SRPM URL:
https://fedorapeople.org/~mbooth/reviews/maven-archetype-3.1.2-2.fc33.src.rpm
Fedora Account System Username: mbooth
Description:
Archetype is a Maven project templating toolkit. An archetype is
defined as an original pattern or model from which all other things of
the same kind are made. The names fits as we are trying to provide a
system that provides a consistent means of generating Maven
projects. Archetype will help authors create Maven project templates
for users, and provides users with the means to generate parameterized
versions of those project templates.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1173656] Review Request: jags - Just Another Gibbs Sampler

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1173656



--- Comment #5 from Tom "spot" Callaway  ---
Well, that's weird. Not sure why mock would fail when koji succeeds.

I can reproduce it though, but only in mock with --isolation=nspawn:

pdflatex: fatal: Could not undump 233630 8-byte item(s) from
/builddir/.texlive2020/texmf-var/web2c/pdftex/pdflatex.fmt.
mktexfmt [INFO]: /builddir/.texlive2020/texmf-var/web2c/pdftex/pdflatex.fmt
installed.
make[2]: *** [Makefile:674: jags_developer_manual.pdf] Error 1

When I run mock with --isolation=simple, it works as expected. Perhaps that's
what koji uses?

License tag fixed in -2.

New Spec URL: https://spot.fedorapeople.org/jags.spec
New SRPM URL: https://spot.fedorapeople.org/jags-4.3.0-2.fc33.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856552] New: Review Request: jchardet - Java port of Mozilla's automatic character set detection algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856552

Bug ID: 1856552
   Summary: Review Request: jchardet - Java port of Mozilla's
automatic character set detection algorithm
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mat.bo...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://fedorapeople.org/~mbooth/reviews/jchardet.spec
SRPM URL: https://fedorapeople.org/~mbooth/reviews/jchardet-1.1-20.fc33.src.rpm
Fedora Account System Username: mbooth
Description:
jchardet is a java port of the source from Mozilla's automatic charset
detection algorithm. The original author is Frank Tang. What is available
here is the java port of that code. The original source in C++ can be found
from http://lxr.mozilla.org/mozilla/source/intl/chardet/. More information can
be found at http://www.mozilla.org/projects/intl/chardet.html.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 533763] Review Request: tex-cjw - LaTeX class for writing resumes and cover letters

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=533763



--- Comment #16 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/tex-cjw


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 533763] Review Request: tex-cjw - LaTeX class for writing resumes and cover letters

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=533763



--- Comment #15 from W. Michael Petullo  ---
Spec URL: http://www.flyn.org/SRPMS/tex-cjw.spec
SRPM URL: https://www.flyn.org/SRPMS/tex-cjw-20090907-5.fc32.src.rpm

- Simplify package name to cjw
- Remove texmf definition from first line of specification


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856421] Review Request: python-iniconfig - Brain-dead simple parsing of ini files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856421



--- Comment #3 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-iniconfig


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856421] Review Request: python-iniconfig - Brain-dead simple parsing of ini files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856421



--- Comment #2 from Miro Hrončok  ---
Thank You, Robert-André, I'm well, you?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1837107] Review Request: 7kaa - Seven Kingdoms: Ancient Adversaries (claiming ownership of package)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1837107

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #20 from Fedora Update System  ---
FEDORA-2020-cd5132634d has been submitted as an update to Fedora 31.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-cd5132634d


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1831602] Review Request: spectrographic - Turn an image into sound

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1831602

Robert-André Mauchin   changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Robert-André Mauchin   ---
Package approved.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1854202] Review Request: golang-github-instrumenta-kubeval - Validate your Kubernetes configuration files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1854202

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



--- Comment #4 from Fedora Update System  ---
FEDORA-2020-49e3e8d996 has been submitted as an update to Fedora 32.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-49e3e8d996


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1831602] Review Request: spectrographic - Turn an image into sound

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1831602



--- Comment #2 from Artur Iwicki  ---
simpleaudio and wavio are now packaged, so here's a new build:

spec: https://svgames.pl/fedora/spectrographic-0.9.3-2/spectrographic.spec
srpm:
https://svgames.pl/fedora/spectrographic-0.9.3-2/spectrographic-0.9.3-2.fc32.src.rpm
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=47142852


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856464] Review Request: ufdbGuard - A URL filter for squid

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856464



--- Comment #2 from Robert-André Mauchin   ---
 - ufdbGuard.x86_64: E: incorrect-fsf-address /usr/share/licenses/ufdbGuard/GPL

Notify upstream about their use of an obsolete FSF address (do not patch it).

 -

ufdbGuard.x86_64: E: missing-call-to-setgroups-before-setuid
/usr/sbin/ufdbAnalyse
ufdbGuard.x86_64: E: missing-call-to-setgroups-before-setuid
/usr/sbin/ufdbGenTable
ufdbGuard.x86_64: E: missing-call-to-setgroups-before-setuid
/usr/sbin/ufdbgclient
ufdbGuard.x86_64: E: missing-call-to-setgroups-before-setuid
/usr/sbin/ufdbguardd
ufdbGuard.x86_64: E: missing-call-to-setgroups-before-setuid
/usr/sbin/ufdbhttpd


Not sure what to do about this, I couldn't find any call to setuid/setgid in
the source.



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
  Note: Using both %{buildroot} and $RPM_BUILD_ROOT
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
 BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "GNU General Public License (v2)", "GNU
 Lesser General Public License", "Expat License", "GPL (v3 or later)",
 "Public domain". 225 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/ufdbGuard/review-
 ufdbGuard/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 51200 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: systemd_post is invoked in %post, systemd_preun in %preun, and
 systemd_postun 

[Bug 1856421] Review Request: python-iniconfig - Brain-dead simple parsing of ini files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856421

Robert-André Mauchin   changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin   ---
Hello Miro, I hope you are good.


Package is approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "*No copyright* Expat License". 18
 files have unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/python-iniconfig/review-python-
 iniconfig/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
 packages named with the unversioned python- prefix unless no properly
 versioned package exists. Dependencies on Python packages instead MUST
 use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream 

[Bug 1350884] Review Request: mspgcc - Rebase of GCC for the MSP430 to TI / Red Hat upstream

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350884



--- Comment #20 from Brandon Nielsen  ---
New spec URL:
https://copr-dist-git.fedorainfracloud.org/cgit/nielsenb/msp430-development-tools/msp430-elf-toolchain.git/plain/msp430-elf-toolchain.spec?id=a1b5d4b24db937c84945ddbeda43545e2ea6cc83

New SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/nielsenb/msp430-development-tools/srpm-builds/01550916/msp430-elf-toolchain-9.2.0.0-1.fc32.src.rpm

This is the latest upstream source. The messages from comment 17 still appear.
Also note that the strip workaround[0] for msp430 compiled files has changed
somewhat, it is now dependent on bash, and now assumes the file passed to the
__strip macro is the last argument, not the second. This works around issues
caused by the introduction of brp-strip-lto in F33+[1].

I also removed the obsoletes because msp430-gcc has been retired for more
Fedora releases than are officially supported so it felt unnecessary, and
rpmlint complained about it being unversioned.

0 - https://bugzilla.redhat.com/show_bug.cgi?id=1175942#c6
1 - https://bugzilla.redhat.com/show_bug.cgi?id=1789099


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1854202] Review Request: golang-github-instrumenta-kubeval - Validate your Kubernetes configuration files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1854202



--- Comment #5 from Fedora Update System  ---
FEDORA-2020-8755e3db8b has been submitted as an update to Fedora 31.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-8755e3db8b


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1854202] Review Request: golang-github-instrumenta-kubeval - Validate your Kubernetes configuration files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1854202

Robert-André Mauchin   changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2020-07-13 19:01:04




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856464] Review Request: ufdbGuard - A URL filter for squid

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856464

Robert-André Mauchin   changed:

   What|Removed |Added

 CC||zebo...@gmail.com
   Doc Type|--- |If docs needed, set a value



--- Comment #1 from Robert-André Mauchin   ---
 - It is not needed:

%{?systemd_requires}
BuildRequires: systemd

Instead depend on:

BuildRequires: systemd-rpm-macros

 - Patch0:  ufdbGuard-common.patch

Add a comment explaining why the patch is needed.

 - Not needed:

%install
rm -rf %{buildroot} ←

 - Please use macros for directories:

%configure \
--with-ufdb-user=ufdb \
--prefix=%{_prefix} \
--with-ufdb-bindir=%{_sbindir} \
--with-ufdb-piddir=%{_localstatedir}/run/ufdbguard \
--with-ufdb-mandir=%{_mandir} \
--with-ufdb-images_dir=%{_sharedstatedir}/ufdbguard/images \
--with-ufdb-logdir=%{_localstatedir}/log/ufdbguard \
--with-ufdb-samplesdir=%{_sharedstatedir}/ufdbguard/samples \
--with-ufdb-config=%{_sysconfdir}/ufdbguard \
--with-ufdb-dbhome=%{_sharedstatedir}/ufdbguard/blacklists \
--with-ufdb-imagesdir=%{_sharedstatedir}/ufdbguard/images

 - %{__make} %{?_smp_mflags} → %make_build

 - %{__make} DESTDIR=%{buildroot} mkdirsredhatcentos install → %make_install
mkdirsredhatcentos

 - Don't use macros starting with __, they are for RPM private use, use the
normal binaries:

for i in $(find doc/ -type f -name '*.1'); do
install -p -D -m 0644 $i %{buildroot}%{_mandir}/man1/
done
for i in $(find doc/ -type f -name '*.8'); do
install -p -D -m 0644 $i %{buildroot}%{_mandir}/man8/
done

install -p -D -m 0644 %{SOURCE1} $RPM_BUILD_ROOT%{_unitdir}/ufdbGuard.service
install -p -D -m 0644 %{SOURCE2}
$RPM_BUILD_ROOT%{_sysconfdir}/logrotate.d/ufdbGuard

 - Don't mix both $RPM_BUILD_ROOT and %{buildroot}, standardize on one

 - Macros again:

%dir %{_sharedstatedir}/ufdbguard/
%attr(-, ufdb, ufdb) %dir %{_localstatedir}/log/ufdbguard/
%{_sharedstatedir}/ufdbguard/*


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856310] Review Request: python-widgetsnbextension - Interactive HTML widgets for Jupyter notebooks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856310



--- Comment #4 from Lumír Balhar  ---
(In reply to Miro Hrončok from comment #3)
> [!]: Package does not own files or directories owned by other packages.
>  Note: Dirs in package are owned also by:
>  /usr/share/jupyter/nbextensions/jupyter-js-widgets(sagemath-jupyter)
> …
> [!]: Package does not generate any conflict.

I am waiting for a reply in https://bugzilla.redhat.com/show_bug.cgi?id=1856311

> [!]: %check is present and all tests pass.

There are no tests upstream.

> Generic:
> [!]: Spec file according to URL is the same as in SRPM.
>  Note: Spec file as given by url is not the same as in SRPM (see
>  attached diff).
>  See: (this test has no URL)

I'll fix that during the initial import.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1854202] Review Request: golang-github-instrumenta-kubeval - Validate your Kubernetes configuration files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1854202



--- Comment #3 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-instrumenta-kubeval


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856464] New: Review Request: ufdbGuard - A URL filter for squid

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856464

Bug ID: 1856464
   Summary: Review Request: ufdbGuard - A URL filter for squid
   Product: Fedora
   Version: rawhide
Status: NEW
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: gw...@protonmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Description: ufdbGuard is a free URL filter for Squid with additional features
like SafeSearch enforcement for a large number of search engines, safer HTTPS 
visits and dynamic detection of proxies (URL filter circumventors).

ufdbGuard supports free and commercial URL databases that can be
downloaded from various sites and vendors.
You can also make your own URL database for ufdbGuard.

SPEC: https://fedorapeople.org/~limb/review/ufdbGuard/ufdbGuard.spec
SRPM:
https://fedorapeople.org/~limb/review/ufdbGuard/ufdbGuard-1.34.5-1.fc32.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1855986] Review Request: python-wavio - Read and write WAV files as numpy arrays

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1855986



--- Comment #4 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-wavio


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

needinfo canceled: [Bug 1142508] Review Request: rubygem-true - Testing framework for Sass libraries

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Vít Ondruch  has canceled Package Review
's request for Vít Ondruch
's needinfo:
Bug 1142508: Review Request: rubygem-true - Testing framework for Sass
libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1142508



--- Comment #6 from Vít Ondruch  ---
Closing as stalled review.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1142508] Review Request: rubygem-true - Testing framework for Sass libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1142508

Vít Ondruch  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Blocks||201449 (FE-DEADREVIEW)
 Resolution|--- |NOTABUG
  Flags|fedora-review?  |
   |needinfo?(vondruch@redhat.c |
   |om) |
Last Closed||2020-07-13 15:33:36



--- Comment #6 from Vít Ondruch  ---
Closing as stalled review.



Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response
should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1132670] Review Request: rubygem-compass-core - The Compass core stylesheet library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1132670
Bug 1132670 depends on bug 1142508, which changed state.

Bug 1142508 Summary: Review Request: rubygem-true - Testing framework for Sass 
libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1142508

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NOTABUG




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856163] Review Request: python-vcversioner - Use version control tags to discover version numbers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856163



--- Comment #3 from Fabian Affolter  ---
The PR for adding the COPYING (https://github.com/habnabit/vcversioner/pull/11)
file to the PyPI release tarball is open for almost three and a half years. 

The GitHub tarball includes the tests and the license file. From my point of
view, would be easier to use the actual upstream source than downloading and
handling two files manually.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856421] Review Request: python-iniconfig - Brain-dead simple parsing of ini files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856421

Miro Hrončok  changed:

   What|Removed |Added

 Blocks||1855480





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1855480
[Bug 1855480] pytest-6.0.0rc1 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856421] New: Review Request: python-iniconfig - Brain-dead simple parsing of ini files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856421

Bug ID: 1856421
   Summary: Review Request: python-iniconfig - Brain-dead simple
parsing of ini files
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mhron...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-iniconfig.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/python-iniconfig-1.0.0-1.fc32.src.rpm

Description:
iniconfig is a small and simple INI-file parser module
having a unique set of features:

* tested against Python2.4 across to Python3.2, Jython, PyPy
* maintains order of sections and entries
* supports multi-line values with or without line-continuations
* supports "#" comments everywhere
* raises errors with proper line-numbers
* no bells and whistles like automatic substitutions
* iniconfig raises an Error if two sections have the same name.

Fedora Account System Username: churchyard


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856163] Review Request: python-vcversioner - Use version control tags to discover version numbers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856163



--- Comment #2 from Itamar Reis Peixoto  ---
description updated, but the tarball I think upstream expect people to use from
PyPi

https://github.com/habnabit/vcversioner/blob/master/vcversioner.py#L199


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856310] Review Request: python-widgetsnbextension - Interactive HTML widgets for Jupyter notebooks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856310



--- Comment #3 from Miro Hrončok  ---
Preliminary review:

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD 3-clause "New" or "Revised" License", "Unknown or
 generated", "Expat License". 16 files have unknown license.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /etc/jupyter/nbconfig,
 /usr/share/jupyter/nbextensions, /usr/share/jupyter,
 /etc/jupyter/nbconfig/notebook.d, /etc/jupyter
[!]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/jupyter/nbextensions/jupyter-js-widgets(sagemath-jupyter)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[!]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
 publishes signatures.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
 architectures.
[!]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original 

[Bug 1844308] Review Request: python-uvicorn - The lightning-fast ASGI server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1844308



--- Comment #7 from Carl George 鸞  ---
In a rawhide container, I can install python3-uvicorn and run the example
application from the GitHub readme.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856312] Review Request: golang-github-hsiafan-vlog - Log library for go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856312

Robert-André Mauchin   changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
   Doc Type|--- |If docs needed, set a value
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin   ---
 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856253] Review Request: python-natlas-libnmap - Python library for nmap tasks, parse and compare/diff scan results

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856253

Robert-André Mauchin   changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin   ---
 - Include docs/ as %doc?

Package approved.

Thanks a lot for all your help with my own packages!


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 32 files have unknown license. Detailed
 output of licensecheck in /home/bob/packaging/review/python-natlas-
 libnmap/review-python-natlas-libnmap/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
 packages named with the unversioned python- prefix unless no properly
 versioned package exists. Dependencies on Python packages instead MUST
 use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with 

[Bug 1855986] Review Request: python-wavio - Read and write WAV files as numpy arrays

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1855986

Robert-André Mauchin   changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #3 from Robert-André Mauchin   ---
Package approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD 2-clause "Simplified" License", "Unknown or generated". 9
 files have unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/python-wavio/review-python-
 wavio/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
 packages named with the unversioned python- prefix unless no properly
 versioned package exists. Dependencies on Python packages instead MUST
 use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
 publishes signatures.
 Note: gpgverify is not used.
[-]: Description and summary 

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659



--- Comment #39 from Dominik 'Rathann' Mierzejewski  ---
(In reply to Petr Pisar from comment #38)
> (In reply to Petr Pisar from comment #37)
> > Because you removed fedora-review? flag on 2016-09-08

I actually removed fedora-review+ and set fedora-review?, because the package
should not have passed review and was removed.

> I misread the history. Nevertheless your last action on this review as on
> 2016-10-03.

Correct. There were no updates from the submitter since then. I guess we can
close this and let it be resubmitted with a new package.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1855984] Review Request: python-simpleaudio - Simple, asynchronous, cross-platform audio playback module for Python3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1855984



--- Comment #2 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-simpleaudio


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659



--- Comment #38 from Petr Pisar  ---
(In reply to Petr Pisar from comment #37)
> Because you removed fedora-review? flag on 2016-09-08

I misread the history. Nevertheless your last action on this review as on
2016-10-03.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Petr Pisar  changed:

   What|Removed |Added

  Flags|needinfo?(ppi...@redhat.com |
   |)   |



--- Comment #37 from Petr Pisar  ---
Because you removed fedora-review? flag on 2016-09-08, and a status of this bug
was changed to NEW on 2020-05-26. A package under review has to have all these
three properties synchronized. Otherwise the review bug falls into an
inconsistent state and that break automation tools that operators over the
reviews. After reading a history of hit bug, I got an impression that nobody
works on this review. If this is not true, you can assign it to yourself, set
fedora-review flag to ?, and move the state into ASSIGNED.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856139] Review Request: python-flask-pymongo - PyMongo support for Flask applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856139

Rafael Fontenelle  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||needinfo?(itamar@ispbrasil.
   ||com.br)



--- Comment #1 from Rafael Fontenelle  ---
The given SRPM file is actually the SPEC file. Please provide the actual SRPM
for review.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856313] Review Request: python-ipywidgets - IPython HTML widgets for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856313

Miro Hrončok  changed:

   What|Removed |Added

 CC||mhron...@redhat.com



--- Comment #1 from Miro Hrončok  ---
Spec sanity:

Why is this needed? IS the dependency generator not working here?

  Requires:   python3dist(ipython)
  Requires:   python3dist(ipykernel)
  Requires:   python3dist(notebook)
  Requires:   python3dist(traitlets)
  Requires:   python3dist(widgetsnbextension)


+ comments from bz1856310.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856310] Review Request: python-widgetsnbextension - Interactive HTML widgets for Jupyter notebooks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856310

Miro Hrončok  changed:

   What|Removed |Added

 CC||mhron...@redhat.com



--- Comment #1 from Miro Hrončok  ---
Spec sanity:

This is useless on rawhide:

  %{?python_provide:%python_provide python3-%{pypi_name}}

This is probably useless as well:

  # Remove bundled egg-info
  rm -rf %{pypi_name}.egg-info

Th rest looks reasonable from the fist glance.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856313] Review Request: python-ipywidgets - IPython HTML widgets for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856313

Lumír Balhar  changed:

   What|Removed |Added

 Blocks||1856188





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1856188
[Bug 1856188] F33FailsToInstall: python3-ipython+notebook
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856310] Review Request: python-widgetsnbextension - Interactive HTML widgets for Jupyter notebooks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856310

Lumír Balhar  changed:

   What|Removed |Added

 Blocks||1856313





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1856313
[Bug 1856313] Review Request: python-ipywidgets - IPython HTML widgets for
Jupyter
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856313] Review Request: python-ipywidgets - IPython HTML widgets for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856313

Lumír Balhar  changed:

   What|Removed |Added

 Depends On||1856310





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1856310
[Bug 1856310] Review Request: python-widgetsnbextension - Interactive HTML
widgets for Jupyter notebooks
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856313] New: Review Request: python-ipywidgets - IPython HTML widgets for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856313

Bug ID: 1856313
   Summary: Review Request: python-ipywidgets - IPython HTML
widgets for Jupyter
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: lbal...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://lbalhar.fedorapeople.org/python-ipywidgets.spec
SRPM URL:
https://lbalhar.fedorapeople.org/python-ipywidgets-7.5.1-1.fc32.src.rpm
Description: Interactive HTML widgets for Jupyter notebooks and the IPython
kernel.
Fedora Account System Username: lbalhar

Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=47113684

Depends on: https://bugzilla.redhat.com/show_bug.cgi?id=1856310


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856312] New: Review Request: golang-github-hsiafan-vlog - Log library for go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856312

Bug ID: 1856312
   Summary: Review Request: golang-github-hsiafan-vlog - Log
library for go
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: m...@fabian-affolter.ch
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://fab.fedorapeople.org/packages/SRPMS/golang-github-hsiafan-vlog.spec
SRPM URL:
https://fab.fedorapeople.org/packages/SRPMS/golang-github-hsiafan-vlog-0.6.0-1.fc31.src.rpm

Project URL: https://github.com/hsiafan/vlog

Description:
Simple log library for go.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=47113554

rpmlint output:
$ rpmlint golang-github-hsiafan-vlog-0.6.0-1.fc31.src.rpm 
golang-github-hsiafan-vlog.src: W: no-%build-section
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint golang-github-hsiafan-vlog-devel-0.6.0-1.fc31.noarch.rpm
golang-github-hsiafan-vlog-devel.noarch: W: hidden-file-or-dir
/usr/share/gocode/src/github.com/hsiafan/vlog/.goipath
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Fedora Account System Username: fab


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856310] Review Request: python-widgetsnbextension - Interactive HTML widgets for Jupyter notebooks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856310

Lumír Balhar  changed:

   What|Removed |Added

 Blocks||1856311





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1856311
[Bug 1856311] Move widgetsnbextension into separated package
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856310] New: Review Request: python-widgetsnbextension - Interactive HTML widgets for Jupyter notebooks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856310

Bug ID: 1856310
   Summary: Review Request: python-widgetsnbextension -
Interactive HTML widgets for Jupyter notebooks
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: lbal...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://lbalhar.fedorapeople.org/python-widgetsnbextension.spec
SRPM URL:
https://lbalhar.fedorapeople.org/python-widgetsnbextension-3.5.1-1.fc32.src.rpm
Description: Interactive HTML widgets for Jupyter notebooks.
Fedora Account System Username: lbalhar

Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=47113028

There is a conflict between this package and sagemath-jupyter (sagemath) which
provides this inside its subpackage so I'll open a bug to remove it from there.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1293630] Review Request: wallch - A wallpaper changer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293630

Jakub Jelen  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
  Flags|needinfo?(jje...@redhat.com |
   |)   |
Last Closed||2020-07-13 11:12:46



--- Comment #10 from Jakub Jelen  ---
I no longer care for this package and as it looks like the upstream is dead
too, lets drop it.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

needinfo canceled: [Bug 1293630] Review Request: wallch - A wallpaper changer

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Jakub Jelen  has canceled Package Review
's request for Jakub Jelen
's needinfo:
Bug 1293630: Review Request: wallch - A wallpaper changer
https://bugzilla.redhat.com/show_bug.cgi?id=1293630



--- Comment #10 from Jakub Jelen  ---
I no longer care for this package and as it looks like the upstream is dead
too, lets drop it.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1297011] Review Request: rubygem-mimemagic - Fast mime detection by extension or content

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297011

Jun Aruga  changed:

   What|Removed |Added

 CC||jar...@redhat.com



--- Comment #4 from Jun Aruga  ---
As a note, rubygem-mimemagic already exists in Fedora.
https://src.fedoraproject.org/rpms/rubygem-mimemagic


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

needinfo canceled: [Bug 481272] Review Request: python-webunit - it test your websites with code that acts like a web browser

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Tadej Janež  has canceled Package Review
's request for Ondrej Hudlicky
's needinfo:
Bug 481272: Review Request: python-webunit -  it test your websites with code
that acts like a web browser
https://bugzilla.redhat.com/show_bug.cgi?id=481272



--- Comment #15 from Tadej Janež  ---
The latest release of webunit is 1.3.10 from May 5, 2010:
https://pypi.org/project/webunit/#history

I'm closing this as development of this software has clearly ended a long time
ago.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 481272] Review Request: python-webunit - it test your websites with code that acts like a web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=481272

Tadej Janež  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |CANTFIX
  Flags|needinfo?(ohudlick@redhat.c |
   |om) |
Last Closed||2020-07-13 08:53:44



--- Comment #15 from Tadej Janež  ---
The latest release of webunit is 1.3.10 from May 5, 2010:
https://pypi.org/project/webunit/#history

I'm closing this as development of this software has clearly ended a long time
ago.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856253] Review Request: python-natlas-libnmap - Python library for nmap tasks, parse and compare/diff scan results

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856253

Fabian Affolter  changed:

   What|Removed |Added

 Blocks||563471 (FE-SECLAB)
   Doc Type|--- |If docs needed, set a value





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=563471
[Bug 563471] Tracker: Review Requests for Fedora Security Lab related packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856253] New: Review Request: python-natlas-libnmap - Python library for nmap tasks, parse and compare/diff scan results

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856253

Bug ID: 1856253
   Summary: Review Request: python-natlas-libnmap - Python library
for nmap tasks, parse and compare/diff scan results
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: m...@fabian-affolter.ch
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://fab.fedorapeople.org/packages/SRPMS/python-natlas-libnmap.spec
SRPM URL:
https://fab.fedorapeople.org/packages/SRPMS/python-natlas-libnmap-0.7.1-1.fc31.src.rpm

Project URL: http://pypi.python.org/pypi/natlas-libnmap/

Description:
libnmap is a Python toolkit for manipulating nmap. It allows you to process
namp scans and process the output in various ways.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=47102109

rpmlint output:
$ rpmlint python-natlas-libnmap-0.7.1-1.fc31.src.rpm
python-natlas-libnmap.src: W: spelling-error Summary(en_US) nmap -> nap, map,
neap
python-natlas-libnmap.src: W: spelling-error %description -l en_US nmap -> nap,
map, neap
python-natlas-libnmap.src: W: spelling-error %description -l en_US namp -> nap,
amp, name
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

$ rpmlint python3-natlas-libnmap-0.7.1-1.fc31.noarch.rpm 
python3-natlas-libnmap.noarch: W: spelling-error Summary(en_US) nmap -> nap,
map, neap
python3-natlas-libnmap.noarch: W: spelling-error %description -l en_US nmap ->
nap, map, neap
python3-natlas-libnmap.noarch: W: spelling-error %description -l en_US namp ->
nap, amp, name
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

Fedora Account System Username: fab


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1856139] Review Request: python-flask-pymongo - PyMongo support for Flask applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1856139

Rafael Fontenelle  changed:

   What|Removed |Added

 CC||rafae...@gnome.org
   Assignee|nob...@fedoraproject.org|rafae...@gnome.org
   Doc Type|--- |If docs needed, set a value
  Flags||fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 810049] Review Request: netbeans-ide - Netbeans Integrated Development Environment (IDE)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=810049

streetgirl  changed:

   What|Removed |Added

 CC||khatridarpa...@gmail.com



--- Comment #143 from streetgirl  ---
Streetgirl69 Escort is the most trusted World escort directory and one of the
biggest escort directories in India. Our catalog features luxury companions,
Call Girls, Independent call girl, college call girls, Call boy, Gigolo, and
trans (shemale) sex escorts, independent escort services, elite escort agencies
directory, brothels, cabarets, and strip clubs – they all are checked on
regular basis and updated with real photos.

https://www.streetgirl69.com
https://www.streetgirl69.com/escorts/bhopal
https://www.streetgirl69.com/escorts/jodhpur
https://www.streetgirl69.com/escorts/delhi
https://www.streetgirl69.com/escorts/jaipur
https://www.streetgirl69.com/escorts/thane
https://www.streetgirl69.com/escorts/mumbai
https://www.streetgirl69.com/escorts/navi-mumbai
https://www.streetgirl69.com/escorts/kolkata
https://www.streetgirl69.com/escorts/hyderabad
https://www.streetgirl69.com/escorts/dehradun
https://www.streetgirl69.com/escorts/rourkela
https://www.streetgirl69.com/escorts/haridwar
https://www.streetgirl69.com/escorts/mussoorie
https://www.streetgirl69.com/escorts/bhiwadi
https://www.streetgirl69.com/escorts/alwar
https://www.streetgirl69.com/escorts/allahabad
https://www.streetgirl69.com/escorts/panipat
https://www.streetgirl69.com/escorts/neemrana


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org