[Bug 1856005] Review Request: DMTCP - (Distributed MultiThreaded Checkpointing)
https://bugzilla.redhat.com/show_bug.cgi?id=1856005 --- Comment #7 from Paul Grosu --- Spec URL: http://www.ccs.neu.edu/~pgrosu/fedora/dmtcp.spec SRPM URL: http://www.ccs.neu.edu/~pgrosu/fedora/dmtcp-2.6.1~rc1-0.1.fc30.src.rpm Hi Orion, New the SRPM has 3 new changes from what you saw before: 1) We now include the Apache License 2.0 in dmtcp.h. Thank you for catching this. 2) The Koji testing seems to have problems with our %ix86 architecture during 'make check'. We believe it works, but since this architecture is seldom used for our DMTCP, we removed that architecture from the dmtcp.spec 3) We changed the %check field in dmtcp.spec. Instead of explicitly invoking /usr/bin/python3, it seems simpler to invoke 'make check' with some added options from DMTCP. Thank you, - Gene and Paul -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861187] Review Request: golang-github-chi-cors - CORS net/http middleware for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1861187 --- Comment #8 from Fedora Update System --- FEDORA-2020-35d38650bd has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861188] Review Request: golang-github-dreamacro-shadowsocks2 - Experimental Shadowsocks in Go.
https://bugzilla.redhat.com/show_bug.cgi?id=1861188 --- Comment #8 from Fedora Update System --- FEDORA-2020-5b246fe05e has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1860729] Review Request: wshowkeys - Displays keypresses on screen on supported Wayland compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1860729 --- Comment #16 from Fedora Update System --- FEDORA-2020-ec0c72eb82 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861190] Review Request: golang-gopkg-eapache-channels-1 - Golang channel helpers and special types
https://bugzilla.redhat.com/show_bug.cgi?id=1861190 --- Comment #8 from Fedora Update System --- FEDORA-2020-cc05c82b36 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861185] Review Request: golang-github-chi-render - Easily manage HTTP request / response payloads of Go HTTP services
https://bugzilla.redhat.com/show_bug.cgi?id=1861185 --- Comment #8 from Fedora Update System --- FEDORA-2020-38068a4ffe has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1860729] Review Request: wshowkeys - Displays keypresses on screen on supported Wayland compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1860729 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-08-07 01:08:42 --- Comment #15 from Fedora Update System --- FEDORA-2020-4a56c76e02 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861187] Review Request: golang-github-chi-cors - CORS net/http middleware for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1861187 Fedora Update System changed: What|Removed |Added Resolution|RAWHIDE |ERRATA --- Comment #7 from Fedora Update System --- FEDORA-2020-e78defd173 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861190] Review Request: golang-gopkg-eapache-channels-1 - Golang channel helpers and special types
https://bugzilla.redhat.com/show_bug.cgi?id=1861190 Fedora Update System changed: What|Removed |Added Resolution|RAWHIDE |ERRATA --- Comment #7 from Fedora Update System --- FEDORA-2020-739c65ed9b has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861185] Review Request: golang-github-chi-render - Easily manage HTTP request / response payloads of Go HTTP services
https://bugzilla.redhat.com/show_bug.cgi?id=1861185 Fedora Update System changed: What|Removed |Added Resolution|RAWHIDE |ERRATA --- Comment #7 from Fedora Update System --- FEDORA-2020-0a3280e34b has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861188] Review Request: golang-github-dreamacro-shadowsocks2 - Experimental Shadowsocks in Go.
https://bugzilla.redhat.com/show_bug.cgi?id=1861188 Fedora Update System changed: What|Removed |Added Resolution|RAWHIDE |ERRATA --- Comment #7 from Fedora Update System --- FEDORA-2020-8dce596de1 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859207] Review Request: sane-airscan - SANE backend for eSCL and WSD protocols
https://bugzilla.redhat.com/show_bug.cgi?id=1859207 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #16 from Fedora Update System --- FEDORA-2020-841f4ce8df has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-841f4ce8df` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-841f4ce8df See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861440] Review Request: rig - system event monitoring and data collection utility
https://bugzilla.redhat.com/show_bug.cgi?id=1861440 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System --- FEDORA-2020-8d178614d5 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-8d178614d5 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-8d178614d5 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1866166] Review Request: R-keyring - Access the System Credential Store from R
https://bugzilla.redhat.com/show_bug.cgi?id=1866166 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-keyring -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862902] Review Request: R-tesseract - Open Source OCR Engine
https://bugzilla.redhat.com/show_bug.cgi?id=1862902 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-tesseract -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1866165] Review Request: R-bookdown - Authoring Books and Technical Documents with R Markdown
https://bugzilla.redhat.com/show_bug.cgi?id=1866165 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-bookdown -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785069] Review request: lector - ebook reader and collection manager
https://bugzilla.redhat.com/show_bug.cgi?id=1785069 Andrew Toskin changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2020-08-06 19:55:48 --- Comment #16 from Andrew Toskin --- Finally got the (optional) dependency python-djvulibre pending in Bodhi, so now Lector has built and is pending in Bodhi too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862306] Review Request: easyrpg-player - Game interpreter for RPG Maker 2000/2003 and EasyRPG games
https://bugzilla.redhat.com/show_bug.cgi?id=1862306
--- Comment #2 from Andy Mender ---
Since it would be a real shame if this didn't go into the repos, I'll review it
:).
> # EasyRPG Player itself is GPLv3+.
> [...]
> # PicoJSON is used only for Emscripten builds (and unbundled before build).
> # Dirent is used only for MS Windows builds (and unbundled before build).
> License: GPLv3+ and BSD
Really good job with the license split!
> BuildRequires: fmt-devel
> BuildRequires: freetype-devel
> BuildRequires: liblcf-devel
> BuildRequires: libpng-devel
> BuildRequires: libsndfile-devel
> BuildRequires: libvorbis-devel
> BuildRequires: libxmp-devel
> BuildRequires: mpg123-devel
> BuildRequires: opusfile-devel
> BuildRequires: pixman-devel
> BuildRequires: SDL2-devel
> BuildRequires: SDL2_mixer-devel
> BuildRequires: speexdsp-devel
> BuildRequires: wildmidi-devel
> BuildRequires: zlib-devel
I would check whether it's not possible to rely on pkgconfig for some of these,
replacing "foo-devel" with "pkgconfig(foo)". For packages which do not provide
pkgconfig files one can still use "foo-devel".
> # The upstream CMakeLists.txt forgets to install this file.
> install -m 755 -d %{buildroot}%{_libdir}/
> install -m 755 -p "%{__cmake_builddir}/libEasyRPG_Player.so"
> %{buildroot}%{_libdir}/
The shared lib should probably be versioned since this is not a -devel package.
Other than that, everything's nice and clean. Complete review matrix below:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files directly in %_libdir.
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_devel_packages
Review: mentioned in an earlier comment
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
Review: Koji build provided by the submitter
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License", "*No copyright* Expat
License", "*No copyright* GPL (v3 or later)", "BSD 3-clause "New" or
"Revised" License", "BSD 2-clause "Simplified" License", "GPL (v3 or
later)", "FSF All Permissive License", "Boost Software License 1.0",
"GNU Lesser General Public License", "GNU Free Documentation License
(v1.2 or later)". 387 files have unknown license. Detailed output of
licensecheck in /home/amender/rpmbuild/SPECS/easyrpg-player/easyrpg-
player/licensecheck.txt
Review: ran licensecheck manually. The Boost-licensed file is a
development
file not included in the package:
builds/cmake/Modules/FindSDL2.cmake: Boost Software License 1.0
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[?]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[?]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s)
[Bug 1861440] Review Request: rig - system event monitoring and data collection utility
https://bugzilla.redhat.com/show_bug.cgi?id=1861440 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #16 from Fedora Update System --- FEDORA-2020-8d178614d5 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-8d178614d5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862306] Review Request: easyrpg-player - Game interpreter for RPG Maker 2000/2003 and EasyRPG games
https://bugzilla.redhat.com/show_bug.cgi?id=1862306 Andy Mender changed: What|Removed |Added CC||andymenderu...@gmail.com Assignee|nob...@fedoraproject.org|andymenderu...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862306] Review Request: easyrpg-player - Game interpreter for RPG Maker 2000/2003 and EasyRPG games
https://bugzilla.redhat.com/show_bug.cgi?id=1862306 Andy Mender changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862306] Review Request: easyrpg-player - Game interpreter for RPG Maker 2000/2003 and EasyRPG games
https://bugzilla.redhat.com/show_bug.cgi?id=1862306 Andy Mender changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1860012] Review Request: binaryen - Compiler and toolchain infrastructure library for WebAssembly
https://bugzilla.redhat.com/show_bug.cgi?id=1860012 Andy Mender changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1860012] Review Request: binaryen - Compiler and toolchain infrastructure library for WebAssembly
https://bugzilla.redhat.com/show_bug.cgi?id=1860012 --- Comment #10 from Andy Mender --- No, sorry, forgot to approve! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861440] Review Request: rig - system event monitoring and data collection utility
https://bugzilla.redhat.com/show_bug.cgi?id=1861440 --- Comment #15 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1786210] Review request: python-djvulibre -- Python bindings for the free DjVuLibre implementation of the DjVu file format
https://bugzilla.redhat.com/show_bug.cgi?id=1786210 Andrew Toskin changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2020-08-06 17:23:18 --- Comment #7 from Andrew Toskin --- Okay, finally, all branches build successfully. Packages for f31 through Rawhide are pending in Bodhi. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804288] Review Request: golang-gvisor - A container sandbox runtime focused on security, efficiency, and ease of use.
https://bugzilla.redhat.com/show_bug.cgi?id=1804288 Robert-André Mauchin changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-08-06 15:30:16 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804353] Review Request: golang-github-majek-slirpnetstack - Slirp4netns implementation using gvisor/netstack
https://bugzilla.redhat.com/show_bug.cgi?id=1804353 Bug 1804353 depends on bug 1804288, which changed state. Bug 1804288 Summary: Review Request: golang-gvisor - A container sandbox runtime focused on security, efficiency, and ease of use. https://bugzilla.redhat.com/show_bug.cgi?id=1804288 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
needinfo canceled: [Bug 1248178] Review Request: lttnganalyses - LTTng trace analysis tools
Product: Fedora Version: rawhide Component: Package Review Michael Jeanson has canceled Package Review 's request for Michael Jeanson 's needinfo: Bug 1248178: Review Request: lttnganalyses - LTTng trace analysis tools https://bugzilla.redhat.com/show_bug.cgi?id=1248178 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1248178] Review Request: lttnganalyses - LTTng trace analysis tools
https://bugzilla.redhat.com/show_bug.cgi?id=1248178 Michael Jeanson changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |WONTFIX Flags|needinfo?(mjean...@gmail.co | |m) | Last Closed||2020-08-06 14:47:46 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861440] Review Request: rig - system event monitoring and data collection utility
https://bugzilla.redhat.com/show_bug.cgi?id=1861440 Miro Hrončok changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #14 from Miro Hrončok --- APPROVED again. Consider removing: BuildRequires: python3dist(systemd-python) BuildRequires: python3dist(psutil) It is not needed without any tests. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861440] Review Request: rig - system event monitoring and data collection utility
https://bugzilla.redhat.com/show_bug.cgi?id=1861440
--- Comment #13 from Jake Hunsaker ---
(In reply to Miro Hrončok from comment #10)
> In the future, I strongly suggest
> tagging in git and fetching tarballs from GitHub directly, for integrity:
>
> Url:https://github.com/TurboTurtle/rig
> Source0:%{url}/archive/%{version}/%{name}-%{version}.tar.gz
>
> (Assuming the tag is identical to version.)
Done. I was keeping the specfile changes in a separate branch through this
review to avoid multiple revision pushes to master, those are now pushed and
the release has been re-tagged.
> If not, please don't put an no-op setup.py test call.
Removed
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862660] Review Request: clash - A rule-based tunnel in Go.
https://bugzilla.redhat.com/show_bug.cgi?id=1862660 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/clash -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1866798] New: Review Request: golang-github-xanzy-gitlab - A GitLab API client enabling Go programs to interact with GitLab
https://bugzilla.redhat.com/show_bug.cgi?id=1866798 Bug ID: 1866798 Summary: Review Request: golang-github-xanzy-gitlab - A GitLab API client enabling Go programs to interact with GitLab Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: jsmith.fed...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://jsmith.fedorapeople.org/Packaging/golang-github-xanzy-gitlab/golang-github-xanzy-gitlab.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/golang-github-xanzy-gitlab/golang-github-xanzy-gitlab-0.34.0-1.fc32.src.rpm Description: A GitLab API client enabling Go programs to interact with GitLab Fedora Account System Username: jsmith -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1866800] New: Review Request: golang-github-tcnksm-gitconfig - Use gitconfig values in Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1866800 Bug ID: 1866800 Summary: Review Request: golang-github-tcnksm-gitconfig - Use gitconfig values in Golang Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: jsmith.fed...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://jsmith.fedorapeople.org/Packaging/golang-github-tcnksm-gitconfig/golang-github-tcnksm-gitconfig.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/golang-github-tcnksm-gitconfig/golang-github-tcnksm-gitconfig-0.1.2-1.fc32.src.rpm Description: Use gitconfig values in Golang Fedora Account System Username: jsmith -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862881] Review Request: R-covr - Test Coverage for Packages
https://bugzilla.redhat.com/show_bug.cgi?id=1862881 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-covr -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1866799] New: Review Request: golang-github-tcnksm-gitconfig - Use gitconfig values in Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1866799 Bug ID: 1866799 Summary: Review Request: golang-github-tcnksm-gitconfig - Use gitconfig values in Golang Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: jsmith.fed...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://jsmith.fedorapeople.org/Packaging/golang-github-tcnksm-gitconfig/golang-github-tcnksm-gitconfig.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/golang-github-tcnksm-gitconfig/golang-github-tcnksm-gitconfig-0.1.2-1.fc32.src.rpm Description: Use gitconfig values in Golang Fedora Account System Username: jsmith -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862862] Review Request: R-formattable - Create 'Formattable' Data Structures
https://bugzilla.redhat.com/show_bug.cgi?id=1862862 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-formattable -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862919] Review Request: R-isoband - Generate Isolines and Isobands from Regularly Spaced Elevation Grids
https://bugzilla.redhat.com/show_bug.cgi?id=1862919 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-isoband -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862859] Review Request: R-DT - R Wrapper of the JavaScript Library 'DataTables'
https://bugzilla.redhat.com/show_bug.cgi?id=1862859 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-DT -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862855] Review Request: R-crosstalk - Inter-Widget Interactivity for HTML Widgets
https://bugzilla.redhat.com/show_bug.cgi?id=1862855 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-crosstalk -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858193] Review Request: golang-github-tomnomnom-linkheader - Golang HTTP Link header parser
https://bugzilla.redhat.com/show_bug.cgi?id=1858193 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-tomnomnom-linkheader -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1857747] Review Request: golang-uber-goleak - Goroutine leak detector
https://bugzilla.redhat.com/show_bug.cgi?id=1857747 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-uber-goleak -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1866143] Review Request: R-RPostgres - Rcpp Interface to PostgreSQL
https://bugzilla.redhat.com/show_bug.cgi?id=1866143 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-RPostgres -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1865739] Review Request: R-profmem - Simple Memory Profiling for R
https://bugzilla.redhat.com/show_bug.cgi?id=1865739 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-profmem -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862895] Review Request: R-magick - Advanced Graphics and Image-Processing in R
https://bugzilla.redhat.com/show_bug.cgi?id=1862895 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-magick -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861435] Review Request: python-pytest-venv - py.test fixture for creating a virtual environment
https://bugzilla.redhat.com/show_bug.cgi?id=1861435
Petr Viktorin changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #4 from Petr Viktorin ---
Nitpick for the Summary: "py.test" is the old name; nowadays it's called
"pytest"
Package APPROVED
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[X]: License field in the package spec file matches the actual license.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[X]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[X]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[X]: Python eggs must not download any dependencies during the build
process.
[X]: A package which is used by another package via an egg interface should
provide egg info.
[X]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[X]: Final provides and requires are sane (see attachments).
[X]: Package functions as described.
[X]: Latest version is packaged.
[X]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[X]: Package should compile and build into binary rpms on all supported
architectures.
[X]: %check is present and all tests pass.
[X]: Packages should try to preserve timestamps of original installed
files.
[Bug 1866166] Review Request: R-keyring - Access the System Credential Store from R
https://bugzilla.redhat.com/show_bug.cgi?id=1866166 José Matos changed: What|Removed |Added CC||jama...@fc.up.pt Assignee|nob...@fedoraproject.org|jama...@fc.up.pt Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from José Matos --- fedora-review (non) issues: === - Package have the default element marked as %%doc :DESCRIPTION - Package requires R-core. - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ The license is correct and the package builds and install in rawhide so the package is approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861435] Review Request: python-pytest-venv - py.test fixture for creating a virtual environment
https://bugzilla.redhat.com/show_bug.cgi?id=1861435 Petr Viktorin changed: What|Removed |Added CC||pvikt...@redhat.com Assignee|nob...@fedoraproject.org|pvikt...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1692560] Review Request: postgresqltuner - Script to analyze PostgreSQL database configuration and tuning
https://bugzilla.redhat.com/show_bug.cgi?id=1692560 Ankur Sinha (FranciscoD) changed: What|Removed |Added Status|ASSIGNED|POST CC||sanjay.an...@gmail.com --- Comment #5 from Ankur Sinha (FranciscoD) --- I've sponsored Mikel now. Welcome to the packager team, Mikel. Please ensure that you are subscribed to the following mailing lists: - https://lists.fedoraproject.org/archives/list/devel-announce%40lists.fedoraproject.org/ - https://lists.fedoraproject.org/archives/list/devel-%40lists.fedoraproject.org/ and, please help other packagers with their reviews too. You can find the list of current reviews here: https://fedoraproject.org/PackageReviewStatus/ Please e-mail me, or the devel list, if anything at all comes up! For this package, you can continue from here: https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner Cheers, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862902] Review Request: R-tesseract - Open Source OCR Engine
https://bugzilla.redhat.com/show_bug.cgi?id=1862902 José Matos changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from José Matos --- Thanks. fedora-review throws: - Package have the default element marked as %%doc :doc, DESCRIPTION, NEWS - Package requires R-core. - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ So nothing to see here. The license is correct and the package builds and install in rawhide so the package is approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1866165] Review Request: R-bookdown - Authoring Books and Technical Documents with R Markdown
https://bugzilla.redhat.com/show_bug.cgi?id=1866165 José Matos changed: What|Removed |Added CC||jama...@fc.up.pt Assignee|nob...@fedoraproject.org|jama...@fc.up.pt Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from José Matos --- The issues raised by fedora-review are: - Package have the default element marked as %%doc :DESCRIPTION, CITATION - Package requires R-core. The novelty here is the CITATION. :-) Some day I need to take some time to submit a fix to fedora-review. There is another bug above that is related with the duplication of the % sign. I suspect that a string was transformed to a raw string and the double sign was left behind. :-) The license is correct and the package builds and install in rawhide so the package is approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862902] Review Request: R-tesseract - Open Source OCR Engine
https://bugzilla.redhat.com/show_bug.cgi?id=1862902 --- Comment #2 from Elliott Sales de Andrade --- Spec URL: https://qulogic.fedorapeople.org/reviews/R-tesseract/R-tesseract.spec SRPM URL: https://qulogic.fedorapeople.org/reviews/R-tesseract/R-tesseract-4.1-2.fc31.src.rpm Use correct R-Rcpp-devel BuildRequires -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859207] Review Request: sane-airscan - SANE backend for eSCL and WSD protocols
https://bugzilla.redhat.com/show_bug.cgi?id=1859207 --- Comment #15 from Fedora Update System --- FEDORA-2020-841f4ce8df has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-841f4ce8df -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859207] Review Request: sane-airscan - SANE backend for eSCL and WSD protocols
https://bugzilla.redhat.com/show_bug.cgi?id=1859207 Zdenek Dohnal changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862855] Review Request: R-crosstalk - Inter-Widget Interactivity for HTML Widgets
https://bugzilla.redhat.com/show_bug.cgi?id=1862855 --- Comment #2 from Elliott Sales de Andrade --- Thank you for the review https://pagure.io/releng/fedora-scm-requests/issue/27383 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
