[Bug 1873772] New: Review Request: R-waldo - Find Differences Between R Objects
https://bugzilla.redhat.com/show_bug.cgi?id=1873772 Bug ID: 1873772 Summary: Review Request: R-waldo - Find Differences Between R Objects Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: quantum.anal...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://qulogic.fedorapeople.org/reviews/R-waldo/R-waldo.spec SRPM URL: https://qulogic.fedorapeople.org/reviews/R-waldo/R-waldo-0.2.0-1.fc32.src.rpm Description: Compare complex R objects and reveal the key differences. Designed particularly for use in testing packages where being able to quickly isolate key differences makes understanding test failures much easier. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=50411263 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1873676] Review Request: lua-rpm-macros - The common Lua RPM macros
https://bugzilla.redhat.com/show_bug.cgi?id=1873676 Michel Alexandre Salim changed: What|Removed |Added CC||s...@linuxpower.org --- Comment #4 from Michel Alexandre Salim --- (In reply to Robert-André Mauchin 🐧 from comment #1) > - You should provides a MIT license file (as required by this license) or > maybe you can add a header in each macros files. > Yeah. I considered adding one, but noticed python-rpm-macros also didn't have one. A bit stumped on what to put in the copyright line, but I can probably just put Fedora Project. > > Package approved. Please fix the aforementioned issue before import. > > Also I assume you have already talked to the lua-devel maintainer. If not, > talk to them before importing this package. > I'll cc: spot directly as he's the main admin for the package (heh, didn't notice I'm also an admin for it). Thanks! ❯ fedpkg request-repo lua-rpm-macros 1873676 https://pagure.io/releng/fedora-scm-requests/issue/28104 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858639] Review Request: qt-avif-image-plugin - Qt plug-in to read/write AVIF images
https://bugzilla.redhat.com/show_bug.cgi?id=1858639 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #12 from Fedora Update System --- FEDORA-2020-9c4dd47cd0 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-9c4dd47cd0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1873737] Review Request: rust-derive-new - `#[derive(new)]` implements simple constructor functions for structs and enums
https://bugzilla.redhat.com/show_bug.cgi?id=1873737 Neal Gompa changed: What|Removed |Added Status|NEW |POST CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Neal Gompa --- Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1873737] New: Review Request: rust-derive-new - `#[derive(new)]` implements simple constructor functions for structs and enums
https://bugzilla.redhat.com/show_bug.cgi?id=1873737 Bug ID: 1873737 Summary: Review Request: rust-derive-new - `#[derive(new)]` implements simple constructor functions for structs and enums Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: igor.ra...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-derive-new.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-derive-new-0.5.8-1.fc34.src.rpm Description: `#[derive(new)]` implements simple constructor functions for structs and enums. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1872291] Review Request: rust-dbus-codegen - Binary crate to generate Rust code from XML introspection data
https://bugzilla.redhat.com/show_bug.cgi?id=1872291 Peter Robinson changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-08-29 18:17:11 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1872296] Review Request: rust-dbus-crossroads - Framework for writing D-Bus method handlers
https://bugzilla.redhat.com/show_bug.cgi?id=1872296 Peter Robinson changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-08-29 18:17:02 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858639] Review Request: qt-avif-image-plugin - Qt plug-in to read/write AVIF images
https://bugzilla.redhat.com/show_bug.cgi?id=1858639 --- Comment #11 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/qt-avif-image-plugin -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1873407] Review Request: vdr-skinelchihd - A Elchi based skin with True Color support for the Video Disc Recorder
https://bugzilla.redhat.com/show_bug.cgi?id=1873407 --- Comment #3 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/vdr-skinelchihd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1873676] Review Request: lua-rpm-macros - The common Lua RPM macros
https://bugzilla.redhat.com/show_bug.cgi?id=1873676 --- Comment #3 from Miro Hrončok --- BTW > # For directory structure > Requires: redhat-rpm-config The directory is owned by rpm, not redhat-rpm-config. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1872508] Review Request: python-sphinx-hoverxref - Sphinx extension to add tooltips on cross references
https://bugzilla.redhat.com/show_bug.cgi?id=1872508 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- FEDORA-2020-31ee8a91e9 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-31ee8a91e9 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-31ee8a91e9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1872542] Review Request: lua-lunitx - Unit testing framework for Lua
https://bugzilla.redhat.com/show_bug.cgi?id=1872542 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- FEDORA-2020-9074133de4 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-9074133de4 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-9074133de4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1871824] Review Request: python-toposort - Implements a topological sort algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=1871824 --- Comment #9 from Fedora Update System --- FEDORA-2020-d31d40f153 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-d31d40f153 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-d31d40f153 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1867267] Review Request: wlr-sunclock - Show the sun's shadows on earth
https://bugzilla.redhat.com/show_bug.cgi?id=1867267 --- Comment #12 from Fedora Update System --- FEDORA-2020-397bd58048 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-397bd58048 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-397bd58048 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1867267] Review Request: wlr-sunclock - Show the sun's shadows on earth
https://bugzilla.redhat.com/show_bug.cgi?id=1867267 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- FEDORA-2020-69914a354e has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-69914a354e \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-69914a354e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1871824] Review Request: python-toposort - Implements a topological sort algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=1871824 --- Comment #8 from Fedora Update System --- FEDORA-2020-89166f0c2a has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-89166f0c2a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-89166f0c2a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1692560] Review Request: postgresqltuner - Script to analyze PostgreSQL database configuration and tuning
https://bugzilla.redhat.com/show_bug.cgi?id=1692560 --- Comment #23 from Fedora Update System --- FEDORA-EPEL-2020-d884e10277 has been pushed to the Fedora EPEL 6 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1873676] Review Request: lua-rpm-macros - The common Lua RPM macros
https://bugzilla.redhat.com/show_bug.cgi?id=1873676 Miro Hrončok changed: What|Removed |Added CC||mhron...@redhat.com --- Comment #2 from Miro Hrončok --- See also https://src.fedoraproject.org/rpms/lua/blob/master/f/lua.attr -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1692560] Review Request: postgresqltuner - Script to analyze PostgreSQL database configuration and tuning
https://bugzilla.redhat.com/show_bug.cgi?id=1692560 --- Comment #22 from Fedora Update System --- FEDORA-EPEL-2020-c998efb60b has been pushed to the Fedora EPEL 7 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1692560] Review Request: postgresqltuner - Script to analyze PostgreSQL database configuration and tuning
https://bugzilla.redhat.com/show_bug.cgi?id=1692560 --- Comment #21 from Fedora Update System --- FEDORA-EPEL-2020-2f9876b6cf has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1037427] Review Request: kdeneur - KDE frontend for X Neural Switcher (xneur)
https://bugzilla.redhat.com/show_bug.cgi?id=1037427 Wolnei Junior changed: What|Removed |Added Status|ASSIGNED|NEW CC||e...@wolnei.com.br -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1842225] Review Request: python-authlib - Build OAuth and OpenID Connect servers
https://bugzilla.redhat.com/show_bug.cgi?id=1842225 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #6 from Fedora Update System --- FEDORA-2020-e5da62d855 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-e5da62d855 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1871697] Review Request: dhall - A configuration language guaranteed to terminate
https://bugzilla.redhat.com/show_bug.cgi?id=1871697 --- Comment #5 from Robert-André Mauchin 🐧 --- NEEDINFO me when it's fixed and ready. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1873676] Review Request: lua-rpm-macros - The common Lua RPM macros
https://bugzilla.redhat.com/show_bug.cgi?id=1873676
Robert-André Mauchin 🐧 changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #1 from Robert-André Mauchin 🐧 ---
- You should provides a MIT license file (as required by this license) or
maybe you can add a header in each macros files.
Package approved. Please fix the aforementioned issue before import.
Also I assume you have already talked to the lua-devel maintainer. If not, talk
to them before importing this package.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[-]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 1 files have unknown license. Detailed
output of licensecheck in /home/bob/packaging/review/lua-rpm-
macros/review-lua-rpm-macros/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[!]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[Bug 1871765] Container Review Request: thoth-toolbox - This is a toolbox container image for Thoth tools
https://bugzilla.redhat.com/show_bug.cgi?id=1871765 Athos Ribeiro changed: What|Removed |Added CC||athoscribe...@gmail.com --- Comment #5 from Athos Ribeiro --- - The .osbs-repo-config file is not needed: Fedora's OSBS has no autorebuilds enabled. - pip content is not allowed, as per the guidelines as Qiyu pointed out. - The version should be set to 0 according to the guidelines. Alternatively, you should install specific versions of the package so a rebuild won't turn your version into a bogus one. - You could move the README.md to a help.md file and it should be converted to a man page in the image's root. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1871697] Review Request: dhall - A configuration language guaranteed to terminate
https://bugzilla.redhat.com/show_bug.cgi?id=1871697 --- Comment #4 from Jens Petersen --- So it turned out fortunately not to be such a broad bug as originally I had feared: a corner case where the current ghc-StateVar build's hash key contains the substring "rts" which I was filtering out too simplistically. > Sadly turns out this is caused by packaging/change of behavior of ghc-pkg-8.8. So please ignore this incorrect sentence ^ in the previous comment. I opened bug 1873687 against ghc-rpm-macros anyway. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1871765] Container Review Request: thoth-toolbox - This is a toolbox container image for Thoth tools
https://bugzilla.redhat.com/show_bug.cgi?id=1871765 --- Comment #4 from Qiyu Yan --- While I think using pip is not a good idea,since you are using something that haven't packaged into package collection yet, this is not compliance with guideline: https://docs.fedoraproject.org/en-US/containers/guidelines/contents/#_allowed_content What you need to do then - check if those pip packages have already been packaged, if so, use dnf to install instead of pip - if not so, package them (you can look for help from devel list) - ping me if those are done :) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1871765] Container Review Request: thoth-toolbox - This is a toolbox container image for Thoth tools
https://bugzilla.redhat.com/show_bug.cgi?id=1871765 Qiyu Yan changed: What|Removed |Added Assignee|nob...@fedoraproject.org|yanqiy...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1871765] Container Review Request: thoth-toolbox - This is a toolbox container image for Thoth tools
https://bugzilla.redhat.com/show_bug.cgi?id=1871765 --- Comment #3 from Qiyu Yan --- Changed format, this should make fedpkg happy. Most thing are just in same structure as what [toolbox] it self do, expect the name part, which I think is of no importance.(which I will confirm later) [toolbox]: https://src.fedoraproject.org/container/fedora-toolbox/blob/master/f/Dockerfile -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1871765] Container Review Request: thoth-toolbox - This is a toolbox container image for Thoth tools
https://bugzilla.redhat.com/show_bug.cgi?id=1871765 Qiyu Yan changed: What|Removed |Added CC||container-rev...@lists.fedo ||raproject.org Component|Package Review |Container Review Product|Fedora |Fedora Container Images Summary|Review Request: |Container Review Request: |thoth-toolbox - This is a |thoth-toolbox - This is a |toolbox container image for |toolbox container image for |Thoth tools |Thoth tools -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1871765] Review Request: thoth-toolbox - This is a toolbox container image for Thoth tools
https://bugzilla.redhat.com/show_bug.cgi?id=1871765 Qiyu Yan changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited --- Spec URL: n/a, its just a container image SRPM URL: n/a, its just a container image Description: This is a toolbox container image aggregating some of Thoth tools, including micropipenv and thamos Fedora Account System Username: goern additional information can be found at https://github.com/thoth-station/thoth-toolbox -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1871765] Review Request: thoth-toolbox - This is a toolbox container image for Thoth tools
https://bugzilla.redhat.com/show_bug.cgi?id=1871765 Qiyu Yan changed: What|Removed |Added CC||yanqiy...@gmail.com --- Comment #2 from Qiyu Yan --- Container review request shouldn't be here. See: https://fedoraproject.org/wiki/Container:Review_Process -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1870859] Review Request: emacs-auto-complete - Emacs auto-complete package
https://bugzilla.redhat.com/show_bug.cgi?id=1870859 Mohamed El Morabity changed: What|Removed |Added Link ID||Fedora Pagure ||releng/issue/9727 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861020] Review Request: x-tile - A GTK application to tile windows in different ways
https://bugzilla.redhat.com/show_bug.cgi?id=1861020 Mohamed El Morabity changed: What|Removed |Added Link ID||Fedora Pagure ||releng/issue/9726 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1870845] Review Request: emacs-popup - Visual Popup Interface Library for Emacs
https://bugzilla.redhat.com/show_bug.cgi?id=1870845 Mohamed El Morabity changed: What|Removed |Added Link ID||Fedora Pagure ||releng/issue/9727 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861020] Review Request: x-tile - A GTK application to tile windows in different ways
https://bugzilla.redhat.com/show_bug.cgi?id=1861020 Mohamed El Morabity changed: What|Removed |Added Link ID||Fedora Pagure 9726 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1873407] Review Request: vdr-skinelchihd - A Elchi based skin with True Color support for the Video Disc Recorder
https://bugzilla.redhat.com/show_bug.cgi?id=1873407 --- Comment #2 from MartinKG --- Many Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
