[Bug 1892756] Review Request: python-managesieve - Accessing a Sieve-Server for managing Sieve scripts
https://bugzilla.redhat.com/show_bug.cgi?id=1892756 --- Comment #17 from Fedora Update System --- FEDORA-EPEL-2020-09d5da6037 has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1893515] Review Request: python-adafruit-platformdetect - Platform detection module
https://bugzilla.redhat.com/show_bug.cgi?id=1893515 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #5 from Fedora Update System --- FEDORA-2020-ea4301b6a5 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-ea4301b6a5 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-ea4301b6a5 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1889652] Review Request: python-adafruit-pureio - Python access to Linux IO including I2C and SPI
https://bugzilla.redhat.com/show_bug.cgi?id=1889652 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #5 from Fedora Update System --- FEDORA-2020-330727f212 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-330727f212 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-330727f212 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1904172] Review Request: endlessh - SSH tarpit that slowly sends an endless banner
https://bugzilla.redhat.com/show_bug.cgi?id=1904172 Michel Alexandre Salim changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Michel Alexandre Salim --- Looks fine! APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1889021] Review Request: python-mrcrowbar - Library and framework for reverse engineering binary file formats
https://bugzilla.redhat.com/show_bug.cgi?id=1889021 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-12-05 01:38:43 --- Comment #7 from Fedora Update System --- FEDORA-2020-249018f223 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1900145] Review Request: perl-ProjectBuilder - perl modules from the project-builder.org project used by MondoRescue
https://bugzilla.redhat.com/show_bug.cgi?id=1900145 Bruno Cornec changed: What|Removed |Added Flags|needinfo?(br...@victoria.fr | |mug.org)| --- Comment #3 from Bruno Cornec --- Yes this SW works for a large set of LInux distributions (CentOS, RHEL, Fedora included) I'm not sure why the links are not working for you however, as I just checked again and they do for me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1894605] Review Request: realtime-tests - Suite of realtime tests including cyclictest
https://bugzilla.redhat.com/show_bug.cgi?id=1894605 Jiri Kastner changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #14 from Jiri Kastner --- looks good, setting review to + -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1894605] Review Request: realtime-tests - Suite of realtime tests including cyclictest
https://bugzilla.redhat.com/show_bug.cgi?id=1894605 John Kacur changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #13 from John Kacur --- I removed ExclusiveArch: x86_64 and replaced it with an ExcludeArch line that has architectures where the builds fail. Currently builds fail where numactl is not available. It might be possible to work around this in the future. The new src.rpm and spec file are here https://jkacur.fedorapeople.org/realtime-tests-1.9-6.fc33.src.rpm https://jkacur.fedorapeople.org/realtime-tests.spec I also did a koji build https://koji.fedoraproject.org/koji/taskinfo?taskID=56790256 Finally I did a copr build https://copr.fedorainfracloud.org/coprs/jkacur/realtime-tests/ Let me know if there is anything else you need. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1900189] Review Request: python-rdflib-jsonld - Python rdflib extension adding JSON-LD parser and serializer
https://bugzilla.redhat.com/show_bug.cgi?id=1900189 --- Comment #9 from Fedora Update System --- FEDORA-2020-2e34c7fd08 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1900181] Review Request: python-datrie - Efficiently stored Trie Data Structure for Python (uses libdatrie)
https://bugzilla.redhat.com/show_bug.cgi?id=1900181 --- Comment #9 from Fedora Update System --- FEDORA-2020-7d2e071a35 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880665] Review Request: python-pyotgw - Python library to interface with the OpenTherm Gateway
https://bugzilla.redhat.com/show_bug.cgi?id=1880665 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pyotgw -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1891646] Review Request: sip5 - SIP - Python/C++ Bindings Generator
https://bugzilla.redhat.com/show_bug.cgi?id=1891646 --- Comment #15 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/sip5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1897961] Review Request: R-conflicted - An Alternative Conflict Resolution Strategy
https://bugzilla.redhat.com/show_bug.cgi?id=1897961 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-conflicted -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824156] Review Request: exfatprogs - Userspace utilities for exFAT filesystems
https://bugzilla.redhat.com/show_bug.cgi?id=1824156 --- Comment #39 from Ben Cotton --- Expect an update at the end of the month. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824156] Review Request: exfatprogs - Userspace utilities for exFAT filesystems
https://bugzilla.redhat.com/show_bug.cgi?id=1824156 --- Comment #38 from Simone Caronni --- In the meanwhile... any update on the legal side by chance? Spec URL: https://slaanesh.fedorapeople.org/exfatprogs.spec SRPM URL: https://slaanesh.fedorapeople.org/exfatprogs-1.0.4-1.fc32.src.rpm * Fri Dec 04 2020 Simone Caronni - 1.0.4-1 - Update to 1.0.4. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1903656] Review Request: perl-File-DirList - Provide a sorted list of directory content
https://bugzilla.redhat.com/show_bug.cgi?id=1903656 Sandro Mani changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-12-04 14:55:42 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1900146] Review Request: perl-MondoRescue - perl modules for MondoRescue
https://bugzilla.redhat.com/show_bug.cgi?id=1900146 Jitka Plesnikova changed: What|Removed |Added Blocks|1900145 | Depends On||1900145 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1900145 [Bug 1900145] Review Request: perl-ProjectBuilder - perl modules from the project-builder.org project used by MondoRescue -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1900145] Review Request: perl-ProjectBuilder - perl modules from the project-builder.org project used by MondoRescue
https://bugzilla.redhat.com/show_bug.cgi?id=1900145 Jitka Plesnikova changed: What|Removed |Added Blocks||1900146 Depends On|1900146 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1900146 [Bug 1900146] Review Request: perl-MondoRescue - perl modules for MondoRescue -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1885495] Review Request: qatengine - Intel(R) QuickAssist Technology (QAT) OpenSSL Engine
https://bugzilla.redhat.com/show_bug.cgi?id=1885495 --- Comment #28 from Dinesh --- The spec file has been updated with clarifying the License. The updated spec file and srpm can be found here: Spec URL: https://copr-be.cloud.fedoraproject.org/results/dineshbx/qatengine/fedora-rawhide-x86_64/01811337-qatengine/qatengine.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/dineshbx/qatengine/fedora-rawhide-x86_64/01811337-qatengine/qatengine-0.6.3-1.fc34.src.rpm Build on copr: https://copr.fedorainfracloud.org/coprs/dineshbx/qatengine/build/1811337/ Build on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=56764736 I will be the maintainer. Fedora Account System Username: dineshbx -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1902632] Review Request: python-imbalanced-learn - A Python Package to Tackle the Imbalanced Datasets in Machine Learning
https://bugzilla.redhat.com/show_bug.cgi?id=1902632 --- Comment #2 from Iztok Fister Jr. --- Hi Aniket! Thank you very much for review. A new version has already been uploaded on GH. Tests are now enabled. One test is skipped. However, I downgraded a version (from 0.7.0 to 0.6.2). In fact, additional issues appeared when tests were enabled. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1884608] Review Request: dosbox-staging - DOS/x86 emulator focusing on ease of use
https://bugzilla.redhat.com/show_bug.cgi?id=1884608 --- Comment #12 from Patryk Obara --- No problem, glad you're back on it :) We did release 0.76.0 literally yesterday, but let's keep this review for 0.75.2 (in next version we added FluidSynth 2.x dependency, which is not available e.g. on Fedora 32). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1900228] Review Request: python-FireflyAlgorithm - Implementation of Firefly Algorithm (FA) for optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1900228 Iztok Fister Jr. changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-12-04 12:02:15 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1900145] Review Request: perl-ProjectBuilder - perl modules from the project-builder.org project used by MondoRescue
https://bugzilla.redhat.com/show_bug.cgi?id=1900145 Jitka Plesnikova changed: What|Removed |Added CC||jples...@redhat.com Flags||needinfo?(br...@victoria.fr ||mug.org) --- Comment #2 from Jitka Plesnikova --- Do you want to add the package to EPEL 7? If not, there is a lot of code which can be removed. Btw. the source link does not work. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1904172] Review Request: endlessh - SSH tarpit that slowly sends an endless banner
https://bugzilla.redhat.com/show_bug.cgi?id=1904172
Mikel Olasagasti Uranga changed:
What|Removed |Added
Flags|needinfo?(mikel@olasagasti. |
|info) |
--- Comment #3 from Mikel Olasagasti Uranga ---
Thanks for the review Michel Alexandre, I learned new things here.
Updated spec and srpm:
Spec URL: https://mikel.olasagasti.info/tmp/fedora/endlessh.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/endlessh-1.1-2.fc33.src.rpm
- Added missing %dir %{_sysconfdir}/%{name}
- Changed systemd to Req and added BR to systemd-rpm-macros
- Registered systemd unit
- Patched Makefile with sed during %install to use %{optflags}
- Change $RPM_BUILD_ROOT to %{buildroot} to use one style
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1902632] Review Request: python-imbalanced-learn - A Python Package to Tackle the Imbalanced Datasets in Machine Learning
https://bugzilla.redhat.com/show_bug.cgi?id=1902632
--- Comment #1 from Aniket Pradhan ---
Hey there Iztok!
Everything seems great, although you're not running the tests for the package.
From what I can see, if there is a Tensorflow/Keras dependency on the test, it
is automatically skipped if they are not installed on the system. So, I think
you can run and test the other remaining functionality of the package. And if
there are tests that do not skip automatically, you can always disable those
few tests.
Also, if possible, try adding in a doc package, but if it too is constrained by
the TF or Keras, no need to worry then.
Other than that, you can replace this line:
> %{?python_provide:%python_provide python3-%{pretty_name}}
so that it uses the `%{py_provides}` macro. For more info on that, refer here
[0]
[0]:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_py_provides_macro
Full review here:
This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
ones are mandatory, though)
- Remove this text
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License", "BSD 3-clause "New" or
"Revised" License BSD 2-clause "Simplified" License". 194 files have
unknown license. Detailed output of licensecheck in
/home/major/Documents/NeuroFedora/review/1902632-python-imbalanced-
learn/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the
[Bug 1902632] Review Request: python-imbalanced-learn - A Python Package to Tackle the Imbalanced Datasets in Machine Learning
https://bugzilla.redhat.com/show_bug.cgi?id=1902632 Aniket Pradhan changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1881611] Review Request: golang-github-projectdiscovery-httpx - Fast and multi-purpose HTTP toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=1881611 Bug 1881611 depends on bug 1881585, which changed state. Bug 1881585 Summary: Review Request: golang-github-projectdiscovery-fdmax - Helper Library to increase automatically the file descriptors https://bugzilla.redhat.com/show_bug.cgi?id=1881585 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1881585] Review Request: golang-github-projectdiscovery-fdmax - Helper Library to increase automatically the file descriptors
https://bugzilla.redhat.com/show_bug.cgi?id=1881585 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-12-04 09:23:16 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1881572] Review Request: golang-github-projectdiscovery-cdncheck - Filter to check for CDN IP addresses during port scanning
https://bugzilla.redhat.com/show_bug.cgi?id=1881572 --- Comment #2 from Fabian Affolter --- Thanks for your input. %changelog * Mon Nov 16 10:01:13 CET 2020 Fabian Affolter - 0-0.2.20201116git5bc57c3 - Tests requires network access (#1881572) - Update to latest commit Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=56756864 Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-projectdiscovery-cdncheck.spec https://fab.fedorapeople.org/packages/SRPMS/golang-github-projectdiscovery-cdncheck-0-0.2.20201116git5bc57c3.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1893515] Review Request: python-adafruit-platformdetect - Platform detection module
https://bugzilla.redhat.com/show_bug.cgi?id=1893515 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #4 from Fedora Update System --- FEDORA-2020-ea4301b6a5 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-ea4301b6a5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1884608] Review Request: dosbox-staging - DOS/x86 emulator focusing on ease of use
https://bugzilla.redhat.com/show_bug.cgi?id=1884608 François Cami changed: What|Removed |Added Assignee|nob...@fedoraproject.org|f...@fcami.net --- Comment #11 from François Cami --- Re-taking. Apologies for the delay, I started doing the review. Will be done soon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1889652] Review Request: python-adafruit-pureio - Python access to Linux IO including I2C and SPI
https://bugzilla.redhat.com/show_bug.cgi?id=1889652 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #4 from Fedora Update System --- FEDORA-2020-330727f212 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-330727f212 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880665] Review Request: python-pyotgw - Python library to interface with the OpenTherm Gateway
https://bugzilla.redhat.com/show_bug.cgi?id=1880665 --- Comment #4 from Fabian Affolter --- Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1902632] Review Request: python-imbalanced-learn - A Python Package to Tackle the Imbalanced Datasets in Machine Learning
https://bugzilla.redhat.com/show_bug.cgi?id=1902632 Aniket Pradhan changed: What|Removed |Added Status|NEW |ASSIGNED CC||aniketpradhan1...@gmail.com Assignee|nob...@fedoraproject.org|aniketpradhan1...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
