[Bug 1894605] Review Request: realtime-tests - Suite of realtime tests including cyclictest
https://bugzilla.redhat.com/show_bug.cgi?id=1894605 John Kacur changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-12-16 06:46:36 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1894605] Review Request: realtime-tests - Suite of realtime tests including cyclictest
https://bugzilla.redhat.com/show_bug.cgi?id=1894605
--- Comment #18 from John Kacur ---
(In reply to Jaroslav Škarvada from comment #15)
> John I will sponsor you. Few things I noted, please fix them:
>
> - The following lines are not needed, the implicit deps generator is quite
> good:
> %{?__python3:Requires: %{__python3}}
> ...
> Requires: bash
>
> - The following line is not needed, please drop it:
> rm -rf %{buildroot}
>
> - Please escape macros in the changelog, i.e.
> in the changelog change %description to %%description, and also probably
> change %s to %%s and %ld to %%ld
>
> Another thing I am just curious about:
> - Isn't better (and safer) to just state that only root could run it instead
> of giving it caps?
> %caps(cap_sys_rawio+ep) /usr/bin/cyclictest
I removed
%{?__python3:Requires: %{__python3}}
rm -rf %{buildroot}
and I escaped all the macros as you requested.
cyclictest uses caps to grant the user who joins the realtime group
access to smi registers in the analysis of realtime performance.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1905710] Review Request: libffi3.1 - Compatibility package for libffi SONAME bump.
https://bugzilla.redhat.com/show_bug.cgi?id=1905710
Nathan Scott changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #3 from Nathan Scott ---
Package LGTM... review notes follow.
[x] MUST: rpmlint must be run on the source rpm and all binary rpms the
build produces. The output should be posted in the review.(refer to
http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint)
libffi3.1.x86_64: W: spelling-error %description -l en_US libffi -> bailiff
libffi3.1.src: W: spelling-error %description -l en_US libffi -> bailiff
libffi3.1-devel.x86_64: W: spelling-error %description -l en_US libffi ->
bailiff
libffi3.1-devel.x86_64: W: no-documentation
5 packages and 0 specfiles checked; 0 errors, 4 warnings.
[x] MUST: The package must be named according to the
http://fedoraproject.org/wiki/Packaging/NamingGuidelines
[x] MUST: The spec file name must match the base package
%{name}, in the format %{name}.spec unless your
package has an exemption. (refer to
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name).
[x] MUST: The package must meet the
http://fedoraproject.org/wiki/Packaging/Guidelines.
[x] MUST: The package must be licensed with a Fedora approved license and
meet the http://fedoraproject.org/wiki/Packaging/LicensingGuidelines.
[x] MUST: The License field in the package spec file must match the actual
license. (refer to
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#ValidLicenseShortNames)
[x] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.(refer to
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License Text)
[x] MUST: The spec file must be written in American English. (refer to
http://fedoraproject.org/wiki/Packaging/Guidelines#summary)
[x] MUST: The spec file for the package MUST be legible. (refer to
http://fedoraproject.org/wiki/Packaging/Guidelines#Spec_Legibility)
[x] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this
task.
If no upstream URL can be specified for this package, please see the
http://fedoraproject.org/wiki/Packaging/SourceURL for how to deal with
this.
[x] MUST: The package MUST successfully compile and build into
binary rpms on at least one primary architecture. (refer to
http://fedoraproject.org/wiki/Packaging/Guidelines#Architecture_Support)
[-] MUST: If the package does not successfully compile, build or work on
an architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch
MUST have a bug filed in bugzilla, describing the reason that the package
does not compile/build/work on that architecture. The bug number MUST be
placed in a comment, next to the corresponding ExcludeArch line.
(refer to
http://fedoraproject.org/wiki/Packaging/Guidelines#Architecture_Build_Failures)
[x] MUST: All build dependencies must be listed in
BuildRequires, except for any that are listed in the
http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 section of
the
Packaging Guidelines ; inclusion of those as BuildRequires is
optional. Apply common sense.
[-] MUST: The spec file MUST handle locales properly. This is done by
using the %find_lang macro. Using
%{_datadir}/locale/* is strictly forbidden.(refer to
http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files)
[x] MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default
paths,
must call ldconfig in %post and %postun. (refer to
http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries)
[x] MUST: Packages must NOT bundle copies of system libraries.(refer to
http://fedoraproject.org/wiki/Packaging:Guidelines#Duplication_of_system_libraries)
[x] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization
for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. (refer to
http://fedoraproject.org/wiki/Packaging/Guidelines#RelocatablePackages)
[x] MUST: A package must own all directories that it creates. If it does
not create a directory that it uses, then it should require a package which
does create that directory. (refer to
http://fedoraproject.org/wiki/Packaging/Guidelines#FileAndDirectoryOwnership)
[x] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception:
[Bug 1905710] Review Request: libffi3.1 - Compatibility package for libffi SONAME bump.
https://bugzilla.redhat.com/show_bug.cgi?id=1905710 Nathan Scott changed: What|Removed |Added Status|NEW |ASSIGNED CC||nath...@redhat.com Assignee|codon...@redhat.com |nath...@redhat.com Flags|fedora-review+ |fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1843300] Review Request: cgreen - C unit-test library with mocks
https://bugzilla.redhat.com/show_bug.cgi?id=1843300 --- Comment #16 from Fedora Update System --- FEDORA-2020-93abc90e56 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-93abc90e56 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-93abc90e56 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1843300] Review Request: cgreen - C unit-test library with mocks
https://bugzilla.redhat.com/show_bug.cgi?id=1843300 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System --- FEDORA-2020-7f9fd147ff has been pushed to the Fedora 32 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-7f9fd147ff \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-7f9fd147ff See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1907097] Review Request: gxkb - X11 keyboard indicator and switcher
https://bugzilla.redhat.com/show_bug.cgi?id=1907097 --- Comment #9 from Fedora Update System --- FEDORA-2020-f950d91d8d has been pushed to the Fedora 32 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-f950d91d8d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f950d91d8d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1907097] Review Request: gxkb - X11 keyboard indicator and switcher
https://bugzilla.redhat.com/show_bug.cgi?id=1907097 Fedora Update System changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2020-12-16 01:42:55 --- Comment #8 from Fedora Update System --- FEDORA-2020-fd4e12a8a1 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1898100] BeeBEEP is a secure network chat. You can talk and send files with all your friends inside a local area network such of an office, home or internet cafe without a server.
https://bugzilla.redhat.com/show_bug.cgi?id=1898100 Troy Curtis changed: What|Removed |Added CC||t...@troycurtisjr.com Whiteboard||NotReady --- Comment #4 from Troy Curtis --- Setting to NotReady until some of the comments are addressed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1906980] Review Request: highway - Efficient and performance-portable SIMDEfficient and performance-portable SIMD
https://bugzilla.redhat.com/show_bug.cgi?id=1906980 Troy Curtis changed: What|Removed |Added CC||t...@troycurtisjr.com Whiteboard||NotReady --- Comment #3 from Troy Curtis --- Adding NotReady for now since it looks like Egor has some good suggestions and it sounds like there is some discussion with upstream needed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1872427] Review Request: ec2-hibinit-agent - support for hibernation for Amazon ec2
https://bugzilla.redhat.com/show_bug.cgi?id=1872427 David Duncan changed: What|Removed |Added Flags||needinfo?(ngomp...@gmail.co ||m) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1872427] Review Request: ec2-hibinit-agent - support for hibernation for Amazon ec2
https://bugzilla.redhat.com/show_bug.cgi?id=1872427 David Duncan changed: What|Removed |Added Flags|needinfo?(davd...@amazon.co | |m) | --- Comment #25 from David Duncan --- Spec URL: https://davdunc.fedorapeople.org/ec2-hibinit-agent.spec SRPM URL: https://davdunc.fedorapeople.org/ec2-hibinit-agent-1.0.3-3.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1905710] Review Request: libffi3.1 - Compatibility package for libffi SONAME bump.
https://bugzilla.redhat.com/show_bug.cgi?id=1905710 Carlos O'Donell changed: What|Removed |Added Assignee|nob...@fedoraproject.org|codon...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1902866] Review Request: rust-utf8-width - Determine the width of a UTF-8 character by providing its first byte
https://bugzilla.redhat.com/show_bug.cgi?id=1902866 Fabio Valentini changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-12-15 19:56:33 --- Comment #5 from Fabio Valentini --- Built for rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1658837 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1908038] Review Request: jline2 - Java library for handling console input
https://bugzilla.redhat.com/show_bug.cgi?id=1908038 Fabio Valentini changed: What|Removed |Added Status|NEW |CLOSED CC||decatho...@gmail.com Resolution|--- |NOTABUG Last Closed||2020-12-15 19:01:39 --- Comment #1 from Fabio Valentini --- You didn't need to open a review request for a compat package, "fedpkg request-repo" does not need a bug in this case. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1908038] Review Request: jline2 - Java library for handling console input
https://bugzilla.redhat.com/show_bug.cgi?id=1908038 Bug 1908038 depends on bug 1908037, which changed state. Bug 1908037 Summary: Review Request: jansi1 - Generate and interpret ANSI escape sequences in Java https://bugzilla.redhat.com/show_bug.cgi?id=1908037 What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1908037] Review Request: jansi1 - Generate and interpret ANSI escape sequences in Java
https://bugzilla.redhat.com/show_bug.cgi?id=1908037 Fabio Valentini changed: What|Removed |Added Status|NEW |CLOSED CC||decatho...@gmail.com Resolution|--- |NOTABUG Doc Type|--- |If docs needed, set a value Last Closed||2020-12-15 19:01:48 --- Comment #1 from Fabio Valentini --- You didn't need to open a review request for a compat package, "fedpkg request-repo" does not need a bug in this case. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1905710] Review Request: libffi3.1 - Compatibility package for libffi SONAME bump.
https://bugzilla.redhat.com/show_bug.cgi?id=1905710 Carlos O'Donell changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1905710] Review Request: libffi3.1 - Compatibility package for libffi SONAME bump.
https://bugzilla.redhat.com/show_bug.cgi?id=1905710 --- Comment #2 from Carlos O'Donell --- Since this is a compatibility package it is excluded from review requirements. https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuidelines/#_package_review_process "The package is being created so that multiple versions of the same package can coexist in the distribution (or coexist between EPEL and RHEL). The package MUST be properly named according to the naming guidelines and MUST NOT conflict with all other versions of the same package." Proper naming is being followed, we are using libffi3.1 to ship the version 3.1 of libffi (no delimiter required). I am moving directly now to request the package be created. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1908038] Review Request: jline2 - Java library for handling console input
https://bugzilla.redhat.com/show_bug.cgi?id=1908038 Jerry James changed: What|Removed |Added Depends On||1908037 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1908037 [Bug 1908037] Review Request: jansi1 - Generate and interpret ANSI escape sequences in Java -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1908037] Review Request: jansi1 - Generate and interpret ANSI escape sequences in Java
https://bugzilla.redhat.com/show_bug.cgi?id=1908037 Jerry James changed: What|Removed |Added Blocks||1908038 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1908038 [Bug 1908038] Review Request: jline2 - Java library for handling console input -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1908042] New: Review Request: material-icons-fonts - Google material design system icons
https://bugzilla.redhat.com/show_bug.cgi?id=1908042 Bug ID: 1908042 Summary: Review Request: material-icons-fonts - Google material design system icons Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: loganje...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://jjames.fedorapeople.org/material-icons-fonts/material-icons-fonts.spec SRPM URL: https://jjames.fedorapeople.org/material-icons-fonts/material-icons-fonts-4.0.0-1.fc34.src.rpm Fedora Account System Username: jjames Description: Material design icons is the official icon set from Google. The icons are designed under the material design guidelines. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1908041] New: Review Request: juniversalchardet - Java character encoding detection
https://bugzilla.redhat.com/show_bug.cgi?id=1908041 Bug ID: 1908041 Summary: Review Request: juniversalchardet - Java character encoding detection Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: loganje...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://jjames.fedorapeople.org/juniversalchardet/juniversalchardet.spec SRPM URL: https://jjames.fedorapeople.org/juniversalchardet/juniversalchardet-2.4.0-1.fc34.src.rpm Fedora Account System Username: jjames Description: Juniversalchardet is a Java port of universalchardet, that is, the encoding detector library of Mozilla. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1908039] New: Review Request: java-diff-utils - Java library to create and apply patches
https://bugzilla.redhat.com/show_bug.cgi?id=1908039 Bug ID: 1908039 Summary: Review Request: java-diff-utils - Java library to create and apply patches Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: loganje...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://jjames.fedorapeople.org/java-diff-utils/java-diff-utils.spec SRPM URL: https://jjames.fedorapeople.org/java-diff-utils/java-diff-utils-4.9-1.fc34.src.rpm Fedora Account System Username: jjames Description: The Java Diff Utils library is an open source library for performing comparison operations between texts: computing diffs, applying patches, generating or parsing unified diffs, generating diff output for easy display (e.g., side-by-side view), and so on. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1908040] New: Review Request: jol - Java Object Layout
https://bugzilla.redhat.com/show_bug.cgi?id=1908040 Bug ID: 1908040 Summary: Review Request: jol - Java Object Layout Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: loganje...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://jjames.fedorapeople.org/jol/jol.spec SRPM URL: https://jjames.fedorapeople.org/jol/jol-0.14-1.fc34.src.rpm Fedora Account System Username: jjames Description: JOL (Java Object Layout) is a tiny toolbox to analyze Java object layouts. These tools use Unsafe, JVMTI, and Serviceability Agent (SA) heavily to decode the actual object layout, footprint, and references. This makes JOL much more accurate than other tools relying on heap dumps, specification assumptions, etc. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1908038] New: Review Request: jline2 - Java library for handling console input
https://bugzilla.redhat.com/show_bug.cgi?id=1908038 Bug ID: 1908038 Summary: Review Request: jline2 - Java library for handling console input Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: loganje...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://jjames.fedorapeople.org/jline2/jline2.spec SRPM URL: https://jjames.fedorapeople.org/jline2/jline2-2.14.6-11.fc34.src.rpm Fedora Account System Username: jjames Description: JLine is a Java library for handling console input. It is similar in functionality to BSD editline and GNU readline. People familiar with the readline/editline capabilities for modern shells (such as bash and tcsh) will find most of the command editing features of JLine to be familiar. This package contains the current contents of the jline package (with a few minor tweaks) so that jline can move to the 3.x series. As such, this review falls under the exemption granted in https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Process. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1908037] New: Review Request: jansi1 - Generate and interpret ANSI escape sequences in Java
https://bugzilla.redhat.com/show_bug.cgi?id=1908037 Bug ID: 1908037 Summary: Review Request: jansi1 - Generate and interpret ANSI escape sequences in Java Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: loganje...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://jjames.fedorapeople.org/jansi1/jansi1.spec SRPM URL: https://jjames.fedorapeople.org/jansi1/jansi1-1.18-6.fc34.src.rpm Fedora Account System Username: jjames Description: Jansi is a small Java library that allows you to use ANSI escape sequences in your Java console applications. It implements ANSI support on platforms which don't support it like Windows and provides graceful degradation when output is sent to output devices which cannot support ANSI sequences. This package contains the current contents of the jansi package (with a few minor tweaks) so that jansi can move to the 2.x series. As such, this review falls under the exemption granted in https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Process. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1902866] Review Request: rust-utf8-width - Determine the width of a UTF-8 character by providing its first byte
https://bugzilla.redhat.com/show_bug.cgi?id=1902866 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-utf8-width -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1907976] Review Request: megapixels - A GTK3 camera application that knows how to deal with the media request api
https://bugzilla.redhat.com/show_bug.cgi?id=1907976 Torrey Sorensen changed: What|Removed |Added Blocks||1817424 (mobility) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1817424 [Bug 1817424] Tracker for mobility SIG activities -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1907976] Review Request: megapixels - A GTK3 camera application that knows how to deal with the media request api
https://bugzilla.redhat.com/show_bug.cgi?id=1907976 Torrey Sorensen changed: What|Removed |Added CC||sorensen...@tuta.io Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1907976] New: Review Request: megapixels - A GTK3 camera application that knows how to deal with the media request api
https://bugzilla.redhat.com/show_bug.cgi?id=1907976 Bug ID: 1907976 Summary: Review Request: megapixels - A GTK3 camera application that knows how to deal with the media request api Product: Fedora Version: rawhide OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: sorensen...@tuta.io QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://gitlab.com/fedora-mobile/megapixels/-/raw/master/megapixels.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/njha/mobile/fedora-rawhide-x86_64/01832873-megapixels/megapixels-0.13.1-2.fc34.src.rpm Copr Build: https://copr.fedorainfracloud.org/coprs/njha/mobile/build/1832873/ Description: A GTK3 camera application that knows how to deal with the media request api This Camera application is designed specifically for Mobile devices such as PinePhone. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1902866] Review Request: rust-utf8-width - Determine the width of a UTF-8 character by providing its first byte
https://bugzilla.redhat.com/show_bug.cgi?id=1902866 --- Comment #3 from Fabio Valentini --- Thank you! https://pagure.io/releng/fedora-scm-requests/issue/31351 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1884608] Review Request: dosbox-staging - DOS/x86 emulator focusing on ease of use
https://bugzilla.redhat.com/show_bug.cgi?id=1884608 Patryk Obara changed: What|Removed |Added Flags||needinfo?(f...@fcami.net) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1902866] Review Request: rust-utf8-width - Determine the width of a UTF-8 character by providing its first byte
https://bugzilla.redhat.com/show_bug.cgi?id=1902866
Stefano Figura changed:
What|Removed |Added
Status|NEW |POST
Flags|fedora-review? |fedora-review+
--- Comment #2 from Stefano Figura ---
LGTM!
-ACCEPT
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
=x=== MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License". 6 files have unknown
license. Detailed output of licensecheck in
/var/home/returntrip/1902866-rust-utf8-width/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust-
utf8-width-devel , rust-utf8-width+default-devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
