[Bug 1928111] Review Request: perl-Crypt-PBKDF2 - The PBKDF2 password hashing algorithm

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1928111

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
FEDORA-2021-1e98a98ae0 has been pushed to the Fedora 32 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing
--advisory=FEDORA-2021-1e98a98ae0`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2021-1e98a98ae0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1907048] Review Request: ghc-http-query - Simple http queries

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1907048

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2021-02-17 05:08:58



--- Comment #9 from Fedora Update System  ---
FEDORA-2021-19a8d719d2 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1924217] Review Request: python-yaml2ical - Convert YAML meeting descriptions into iCalendar files

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1924217

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2021-02-17 05:08:50



--- Comment #12 from Fedora Update System  ---
FEDORA-2021-059986b679 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1907048] Review Request: ghc-http-query - Simple http queries

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1907048



--- Comment #10 from Fedora Update System  ---
FEDORA-2021-bb70eb6b05 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1916936] Review Request: libdispatch - Apple's Grand Central Dispatch library

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1916936

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2021-02-17 05:09:00



--- Comment #32 from Fedora Update System  ---
FEDORA-2021-1076f40eaf has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1924217] Review Request: python-yaml2ical - Convert YAML meeting descriptions into iCalendar files

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1924217



--- Comment #13 from Fedora Update System  ---
FEDORA-2021-2e4e0daaa5 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1856005] Review Request: dmtcp - Checkpoint/Restart functionality for Linux processes

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1856005

Orion Poplawski  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #25 from Orion Poplawski  ---
Looks good.  Approved.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1929482] Review Request: lightly - A modern style for qt applications

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1929482



--- Comment #2 from Robert-André Mauchin 🐧  ---
Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=62128182


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1929482] Review Request: lightly - A modern style for qt applicationsA modern style for qt applicationsA modern style for qt applications

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1929482

Robert-André Mauchin 🐧  changed:

   What|Removed |Added

   Doc Type|--- |If docs needed, set a value



--- Comment #1 from Robert-André Mauchin 🐧  ---
Spec URL: https://eclipseo.fedorapeople.org/for-review/lightly.spec
SRPM URL:
https://eclipseo.fedorapeople.org/for-review/lightly-0.4-1.fc35.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1929482] New: Review Request: lightly - A modern style for qt applicationsA modern style for qt applicationsA modern style for qt applications

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1929482

Bug ID: 1929482
   Summary: Review Request: lightly - A modern style for qt
applicationsA modern style for qt applicationsA modern
style for qt applications
   Product: Fedora
   Version: rawhide
Status: NEW
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: zebo...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://eclipseo.fedorapeople.org/for-review/lightly.spec
SRPM URL: https://eclipseo.fedorapeople.org/for-review/

Description:
Lightly is a fork of breeze theme style that aims to be visually modern and
minimalistic.Lightly is a fork of breeze theme style that aims to be visually
modern and minimalistic.Lightly is a fork of breeze theme style that aims to be
visually modern and minimalistic.

Fedora Account System Username: eclipseo


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1576056] Review Request: python-pyte - Simple VTXXX-compatible linux terminal emulator

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1576056



--- Comment #10 from Robert-André Mauchin 🐧  ---
(In reply to Terje Røsten from comment #9)
> Fixed file listing and release:
> 
> spec: https://terjeros.fedorapeople.org/python-pyte/python-pyte.spec
> srpm:
> https://terjeros.fedorapeople.org/python-pyte/python-pyte-0.8.0-2.fc33.src.
> rpm
> user: terjeros
> koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=61532613
> lint: 2 packages and 0 specfiles checked; 0 errors, 0 warnings
> desc:
> In memory VTXXX-compatible terminal emulator.  XXX stands for
> a series of video terminals, developed by DEC between 1970 and 1995.

You should open your own bug and mark this one as Duplicate as the script to
create new repo checks who is the initial reporter of the bug.

NEEDINFO me for the new review if needed.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1912914] Review Request: ksc - kernel source checker

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1912914

Neal Gompa  changed:

   What|Removed |Added

  Flags|needinfo?(ngomp...@gmail.co |
   |m)  |



--- Comment #13 from Neal Gompa  ---
> %py3_install -- -O1

This should just be "%py3_install".


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1920754] Review Request: opendoas - Portable fork of the OpenBSD's doas commandPortable fork of the OpenBSD's doas command

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1920754



--- Comment #8 from Robert-André Mauchin 🐧  ---
(In reply to dan.cermak from comment #4)
> Looks good to me overall, only a few minor things:
> 
> - upstream publishes gpg signatures, consider using gpgverify
> - the source contains not only isc licensed files, but BSD 3 clause and 2
> clause as well (both in libopenbsd/)
> - consider declaring libopenbsd as a bundled dependency

Thanks for the review, I have fixed all aforementioned points.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1920754] Review Request: opendoas - Portable fork of the OpenBSD's doas commandPortable fork of the OpenBSD's doas command

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1920754



--- Comment #7 from Robert-André Mauchin 🐧  ---
Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=62124832


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1920754] Review Request: opendoas - Portable fork of the OpenBSD's doas commandPortable fork of the OpenBSD's doas command

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1920754



--- Comment #6 from Robert-André Mauchin 🐧  ---
Koji scratch build:


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1920754] Review Request: opendoas - Portable fork of the OpenBSD's doas commandPortable fork of the OpenBSD's doas command

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1920754



--- Comment #5 from Robert-André Mauchin 🐧  ---
New Spec URL: https://eclipseo.fedorapeople.org/for-review/opendoas.spec
New SRPM URL:
https://eclipseo.fedorapeople.org/for-review/opendoas-6.8.1-1.fc35.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1925709] Review Request: jo - Small utility to create JSON objects

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1925709



--- Comment #4 from c...@musicinmybrain.net ---
Thank you for the review!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1925709] Review Request: jo - Small utility to create JSON objects

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1925709

Robert-André Mauchin 🐧  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #3 from Robert-André Mauchin 🐧  ---
Package approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
 BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "Expat License GNU General Public
 License v2.0 or later", "*No copyright* Public domain", "GNU General
 Public License v2.0 or later", "Expat License", "GNU General Public
 License v2.0 or later [generated file]". 67 files have unknown
 license. Detailed output of licensecheck in
 /home/bob/packaging/review/jo/review-jo/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify

[Bug 1896497] Review Request: golang-github-google-dap - Go implementation of the Debug Adapter Protocol

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1896497



--- Comment #10 from Alejandro Sáez Morollón  ---
Awesome. Thanks a lot!

https://pagure.io/releng/fedora-scm-requests/issue/32144


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1896497] Review Request: golang-github-google-dap - Go implementation of the Debug Adapter Protocol

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1896497

Olivier Lemasle  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #9 from Olivier Lemasle  ---
Package approved again ;-)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1896497] Review Request: golang-github-google-dap - Go implementation of the Debug Adapter Protocol

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1896497

Olivier Lemasle  changed:

   What|Removed |Added

  Flags||fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1896497] Review Request: golang-github-google-dap - Go implementation of the Debug Adapter Protocol

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1896497

Olivier Lemasle  changed:

   What|Removed |Added

 Status|POST|ASSIGNED
  Flags|fedora-review+  |




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1856005] Review Request: dmtcp - Checkpoint/Restart functionality for Linux processes

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1856005



--- Comment #24 from Paul Grosu  ---
Hi Orion,

Spec URL: http://www.ccs.neu.edu/~pgrosu/fedora/rawhide/dmtcp.spec
SRPM URL:
http://www.ccs.neu.edu/~pgrosu/fedora/rawhide/dmtcp-2.6.1~rc1-0.1.fc35.src.rpm

We have now addressed the three remaining issues in this latest package.
The three issues addressed are:

1.  Replace:
  %dir %{_pkgdocdir}
  %{_pkgdocdir}
with:
  %{_pkgdocdir}/
> Done.

2.  Please change License to and add the following comment:
  # dmtcp.h is ASL-2.0
  License: LGPLv3+ and ASL-2.0
> Done.  We updated dmtcp.spec with the ASL-2.0 (Apache) license.

3.  Looks like the tarball in the srpm is different from what you get
when you download the source url.  This should be fixed.
> Done.

Thank you for mentoring us in properly packaging this for Fedora.

Best,
- Paul and Gene


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1896497] Review Request: golang-github-google-dap - Go implementation of the Debug Adapter Protocol

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1896497



--- Comment #8 from Alejandro Sáez Morollón  ---
(In reply to Olivier Lemasle from comment #7)
> Update is ok, thanks.
> Package approved.

For some reason I'm getting an error while requesting the repository:

Could not execute request_repo: The Bugzilla bug's review was approved over 60
days ago

According to this comment[0], it looks like you need to toggle the ACK flag.
Would you mind trying that?


[0] https://bugzilla.redhat.com/show_bug.cgi?id=1501522#c83


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1928111] Review Request: perl-Crypt-PBKDF2 - The PBKDF2 password hashing algorithm

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1928111



--- Comment #4 from Fedora Update System  ---
FEDORA-2021-1e98a98ae0 has been submitted as an update to Fedora 32.
https://bodhi.fedoraproject.org/updates/FEDORA-2021-1e98a98ae0


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1928111] Review Request: perl-Crypt-PBKDF2 - The PBKDF2 password hashing algorithm

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1928111

Paul Howarth  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED
   Fixed In Version||perl-Crypt-PBKDF2-0.161520-
   ||12.fc35



--- Comment #3 from Paul Howarth  ---
Unretired OK: https://pagure.io/releng/issue/10016

Built for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=62085976

Branch requested for F-34:
https://pagure.io/releng/fedora-scm-requests/issue/32142

Branch requested for F-33:
https://pagure.io/releng/fedora-scm-requests/issue/32143


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1912914] Review Request: ksc - kernel source checker

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1912914

Cestmir Kalina  changed:

   What|Removed |Added

  Flags||needinfo?(ngomp...@gmail.co
   ||m)



--- Comment #12 from Cestmir Kalina  ---
Changed the py3install and removed the extra requires. Do you figure there's
anything else? Thanks!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1927697] Review Request: ansible-collection-containers-podman - Ansible collection for Podman containers

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1927697



--- Comment #4 from Sagi Shnaidman  ---
Fixed all in a new version:

Spec URL:
https://raw.githubusercontent.com/sshnaidm/ansible-podman-collections/09865d14db79e6eb0416a364d9a7142e6cf38021/ansible-collection-containers-podman.spec
SRPM URL:
https://github.com/sshnaidm/ansible-podman-collections/raw/09865d14db79e6eb0416a364d9a7142e6cf38021/ansible-collection-containers-podman-1.4.1-1.fc33.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1912914] Review Request: ksc - kernel source checker

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1912914



--- Comment #11 from Neal Gompa  ---
> Requires: %{py3_dist requests}

Your setup.py has "install_requires=['requests']", so this is not needed, as
the dependency will be autogenerated.

If you're building for RHEL 8 (outside of EPEL), you can also have it turned on
in your spec file by adding a line to the spec with the following:
"%{?python_enable_dependency_generator}"


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1912914] Review Request: ksc - kernel source checker

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1912914

Neal Gompa  changed:

   What|Removed |Added

  Flags|needinfo?(ngomp...@gmail.co |
   |m)  |



--- Comment #10 from Neal Gompa  ---
> %py3_install -- -O1 --root %{buildroot}

"%py3_install" does --skip-build and already passes --root %{buildroot}, so we
don't need those extra options.

(The correct build options are done in "%py3_build" already)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1929202] Package sponsor needed: New package co-maintainer for protonvpn-cli-2.2.6-1

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1929202

Ankur Sinha (FranciscoD)  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||sanjay.an...@gmail.com
 Resolution|--- |NOTABUG
Last Closed||2021-02-16 13:20:55



--- Comment #1 from Ankur Sinha (FranciscoD)  ---
Hey Justin,

Please open a ticket here to request sponsorship for co-maintainers:
https://pagure.io/packager-sponsors/issues

To request a new package-maintainers group in FAS, please file a ticket with
Fedora infrastructure here: https://pagure.io/fedora-infrastructure/issues
(package groups are generally used to share responsibilities for multiple
packages: for a single package, you can just have multiple packagers with
admin/commit etc. access).

Cheers,
Ankur


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1929202] New: Package sponsor needed: New package co-maintainer for protonvpn-cli-2.2.6-1

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1929202

Bug ID: 1929202
   Summary: Package sponsor needed: New package co-maintainer for
protonvpn-cli-2.2.6-1
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: f...@jwf.io
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
   Link ID: Github ProtonVPN/linux-cli/issues/72
Classification: Fedora



== Summary

Sponsor a new co-packager and create a new packager group on src.fp.o for
"Proton packagers"


== Background

I am the current packager of the protonvpn-cli package in Fedora. I want to add
a new co-packager who is also an upstream developer of the original project. I
have done 1x1 coaching with this co-packager and shared where to find important
information about packaging according to the Fedora Packaging Guidelines.

The goal is to reduce my individual package load and also bring in a new
co-packager who is more directly involved with producing the upstream software.


== Details

This ticket is requesting the following:

1. A review of the uploaded RPM spec for protonvpn-cli-2.2.6 by calexandru2018
2. Sponsorship of a new packager for calexandru2018
3. Creation of a new packaging group on src.fedoraproject.org for "Proton
packagers"


== Outcome

Reduction of bus factor in a package focused on user privacy and security


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1912914] Review Request: ksc - kernel source checker

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1912914

Cestmir Kalina  changed:

   What|Removed |Added

  Flags||needinfo?(ngomp...@gmail.co
   ||m)



--- Comment #9 from Cestmir Kalina  ---
Thank you for the reply.

(In reply to Neal Gompa from comment #8)
> This package doesn't comply with the Python packaging guidelines:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
> 
> Some things I see that's wrong with it:
> 
> * Dependency generators are disabled, which is not something we generally
> permit.

The guideline states "Packages MAY use the automatic Python dependency
generator."
and "This generator is enabled by default in Fedora. If a packager wishes to
explicitly opt out of the generator because the upstream metadata are not
applicable, a packager SHOULD opt out explicitly by adding:

%{?python_disable_dependency_generator}"

This macro is not present in the spec file. Added egg-info. Using py3_dist.

> * The usage of %__python is not permitted

Removed.

> * This should use the %py3_build and %py3_install macros instead of calling
> setup.py manually

Changed.

> * URL does not point to the project home page

Changed to point to github page of the project.

Do you figure there's anything missing? Thanks!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1927444] Review Request: ocaml-luv - OCaml binding to libuv for cross-platform asynchronous I/O

2021-02-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1927444

Jan Staněk  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Jan Staněk  ---
New URLs are working, and the docs issue was addressed => APPROVED.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure