[Bug 1907041] Review Request: fcitx5-table-other - other tables for Fcitx5

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1907041

Qiyu Yan  changed:

   What|Removed |Added

   Doc Type|--- |If docs needed, set a value



--- Comment #1 from Qiyu Yan  ---
as for ownership for %{_datadir}/fcitx5/table, it will be owned by fcitx5-data
package then, I will change and update fcitx5 package.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1907041] Review Request: fcitx5-table-other - other tables for Fcitx5

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1907041

Qiyu Yan  changed:

   What|Removed |Added

Comment|0   |updated



--- Comment #0 has been edited ---

Spec URL:
https://yanqiyu.fedorapeople.org/fcitx5-table-other/fcitx5-table-other.spec
SRPM URL:
https://yanqiyu.fedorapeople.org/fcitx5-table-other/fcitx5-table-other-5.0.2-1.fc35.src.rpm
Description: fcitx-table-other provides some other tables 
for Fcitx, fork from ibus-table-others, scim-tables.
Fedora Account System Username: yanqiyu

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1907043] Review Request: fcitx5-unikey - Unikey support for Fcitx5

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1907043

Qiyu Yan  changed:

   What|Removed |Added

Comment|0   |updated



--- Comment #0 has been edited ---

Spec URL: https://yanqiyu.fedorapeople.org/fcitx5-unikey/fcitx5-unikey.spec
SRPM URL:
https://yanqiyu.fedorapeople.org/fcitx5-unikey/fcitx5-unikey-5.0.2-1.fc35.src.rpm
Description: Unikey (Vietnamese Input Method) engine support for Fcitx5.
Fedora Account System Username: yanqiyu

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1907044] Review Request: fcitx5-zhuyin - Libzhuyin Wrapper for Fcitx

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1907044

Qiyu Yan  changed:

   What|Removed |Added

Comment|0   |updated



--- Comment #0 has been edited ---

Spec URL: https://yanqiyu.fedorapeople.org/fcitx5-zhuyin/fcitx5-zhuyin.spec
SRPM URL:
https://yanqiyu.fedorapeople.org/fcitx5-zhuyin/fcitx5-zhuyin-5.0.2-1.fc35.src.rpm
Description: Libzhuyin Wrapper for Fcitx.
Fedora Account System Username: yanqiyu

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1907035] Review Request: fcitx5-anthy - Anthy Wrapper for Fcitx5

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1907035

Qiyu Yan  changed:

   What|Removed |Added

Comment|0   |updated



--- Comment #0 has been edited ---

Spec URL: https://yanqiyu.fedorapeople.org/fcitx5-anthy/fcitx5-anthy.spec
SRPM URL:
https://yanqiyu.fedorapeople.org/fcitx5-anthy/fcitx5-anthy-5.0.2-1.fc35.src.rpm
Description: Anthy Wrapper for Fcitx5 Ported from scim-anthy. Released under
GPL2+.
Fedora Account System Username: yanqiyu

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1907036] Review Request: fcitx5-hangul - Hangul Wrapper for Fcitx5

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1907036



--- Comment #2 from Qiyu Yan  ---
Thank you for the review, Robert-André, I will fix the problem before
importing.

https://pagure.io/releng/fedora-scm-requests/issue/32226


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1907037] Review Request: fcitx5-libthai - Libthai Wrapper for Fcitx5

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1907037



--- Comment #2 from Qiyu Yan  ---
Thanks for your review, will update and rmeove the empty file before import.

https://pagure.io/releng/fedora-scm-requests/issue/32224


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1925885] Review Request: ghc-bugzilla-redhat - A Haskell interface to the Bugzilla native REST API

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1925885



--- Comment #14 from Fedora Update System  ---
FEDORA-2021-6b70a3434e has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1925885] Review Request: ghc-bugzilla-redhat - A Haskell interface to the Bugzilla native REST API

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1925885

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2021-02-19 01:13:46



--- Comment #13 from Fedora Update System  ---
FEDORA-2021-cdf02c8d5a has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1917998] Review Request: oc-inject - Copy an executable to an OpenShift container and run it

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1917998

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2021-02-19 01:13:41



--- Comment #11 from Fedora Update System  ---
FEDORA-2021-03687eaf3c has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1930441] New: Review Request: hedley - A C/C++ header to help move #ifdefs out of your code

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1930441

Bug ID: 1930441
   Summary: Review Request: hedley - A C/C++ header to help move
#ifdefs out of your code
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: c...@musicinmybrain.net
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://gitlab.com/musicinmybrain/fedora-rpm/-/raw/77239b965a1691cdd054b536c1b0de8111c8a67e/hedley.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/117/62250117/hedley-15-1.fc35.src.rpm
Description:

Hedley is a single C/C++ header you can include in your project to enable
compiler-specific features while retaining compatibility with all compilers. It
contains dozens of macros to help make your code easier to use, harder to
misuse, safer, faster, and more portable.

You can safely include Hedley in your public API, and it works with virtually
any C or C++ compiler.

Fedora Account System Username: music

Koji builds:

F35: https://koji.fedoraproject.org/koji/taskinfo?taskID=62250116
F34: https://koji.fedoraproject.org/koji/taskinfo?taskID=62250163
F33: https://koji.fedoraproject.org/koji/taskinfo?taskID=62250167
F32: https://koji.fedoraproject.org/koji/taskinfo?taskID=62250171
EL8: https://koji.fedoraproject.org/koji/taskinfo?taskID=62250176

This is an extremely trivial package, and a good first package for a new
reviewer. Please see
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1929958] Review Request: jni-inchi - International Chemical Identifiers for Java

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1929958

Jerry James  changed:

   What|Removed |Added

  Flags|needinfo?(loganjerry@gmail. |
   |com)|



--- Comment #2 from Jerry James  ---
Yes, it needs the latest build of the inchi package, inchi-1.0.5-12.fc35.  I
had hoped that would have reached most mirrors by the time I sent the review
swap email, but apparently my hope was in vain.  It is available from koji:

https://koji.fedoraproject.org/koji/buildinfo?buildID=1711565

Hopefully it will be on the mirrors before too much longer.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1929958] Review Request: jni-inchi - International Chemical Identifiers for Java

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1929958

dan.cer...@cgc-instruments.com changed:

   What|Removed |Added

 CC||dan.cermak@cgc-instruments.
   ||com
   Doc Type|--- |If docs needed, set a value
  Flags||needinfo?(loganjerry@gmail.
   ||com)



--- Comment #1 from dan.cer...@cgc-instruments.com ---
The package fails to build in Rawhide for me:

JniInchiWrapper.c:25:10: fatal error: ichisize.h: No such file or directory
   25 | #include 
  |  ^~~~
compilation terminated.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1930386] New: Review Request: R-arules - Mining Association Rules and Frequent Itemsets

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1930386

Bug ID: 1930386
   Summary: Review Request: R-arules - Mining Association Rules
and Frequent Itemsets
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: iz...@iztok-jr-fister.eu
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://raw.githubusercontent.com/firefly-cpp/arules-rpm/main/R-arules.spec
SRPM URL:
https://github.com/firefly-cpp/arules-rpm/raw/main/R-arules-1.6-1.fc33.src.rpm
Description: Provides the infrastructure for representing, manipulating and
analyzing transaction data and patterns (frequent itemsets and association
rules). Also provides C implementations of the association mining algorithms
Apriori and Eclat. 

Fedora Account System Username: iztokf


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1930386] Review Request: R-arules - Mining Association Rules and Frequent Itemsets

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1930386

Iztok Fister Jr.  changed:

   What|Removed |Added

 Blocks||1276941 (fedora-neuro)
   Doc Type|--- |If docs needed, set a value





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1276941
[Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1928654] Review Request: ongres-stringprep - RFC 3454 Preparation of Internationalized Strings ("stringprep") in pure Java

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1928654



--- Comment #4 from Ondrej Dubaj  ---
Issue for creating new repository:

https://pagure.io/releng/fedora-scm-requests/issue/32207


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1924918] Review Request: reprotest - Build packages and check them for reproducibility

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1924918

frederic.pier...@qubes-os.org changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2021-02-18 14:35:32




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1909767] Review Request: kata-containers

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1909767

Christophe de Dinechin  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+
   |needinfo?(dinechin@redhat.c |
   |om) |



--- Comment #6 from Christophe de Dinechin  ---
Looks good to me, although I did not re-run the test scripts.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1928654] Review Request: ongres-stringprep - RFC 3454 Preparation of Internationalized Strings ("stringprep") in pure Java

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1928654



--- Comment #3 from Ondrej Dubaj  ---
Thank you!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1928654] Review Request: ongres-stringprep - RFC 3454 Preparation of Internationalized Strings ("stringprep") in pure Java

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1928654

Mikolaj Izdebski  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Mikolaj Izdebski  ---
Spec file looks fine - tt follows packaging guidelines, including Java
guidelines.
Source code it the SRPM matches upstream code.
Package builds fine in rawhide.
Buildrequires are correct, except that BR on maven-enforcer-plugin seems to be
unnecessary and it can be removed.
Auto-requires are generated, manual requires are absent.

rpmlint output:
ongres-stringprep.noarch: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

The code is licensed under BSD license, which matches License tag in spec file.
License text is installed as %license.
License review reveals references to ASL 2.0 license, but it only applies to
external dependency (Apache Velocity), which is not bundled in the package.

Package is APPROVED.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1927535] Review Request: fbrnch - Fedora packager tool to build package branches

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1927535



--- Comment #4 from Jens Petersen  ---
Thank you for the review, Tristan

https://pagure.io/releng/fedora-scm-requests/issue/32200


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1927535] Review Request: fbrnch - Fedora packager tool to build package branches

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1927535

Jens Petersen  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|tdeca...@redhat.com



--- Comment #3 from Jens Petersen  ---
(In reply to Tristan Cacqueray from comment #2)
> - I guess the crypto-policy-non-compliance-openssl warning is related to
> ghc-HsOpenSSL, could this be fixed in the future?

Good question: I think you are right.

I was hoping that ghc-HsOpenSSL-x509-system might help with this,
currently it seems mainly used via http-client-openssl.
So need to think on this.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1927535] Review Request: fbrnch - Fedora packager tool to build package branches

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1927535

Tristan Cacqueray  changed:

   What|Removed |Added

  Flags||fedora-review+




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1927535] Review Request: fbrnch - Fedora packager tool to build package branches

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1927535

Tristan Cacqueray  changed:

   What|Removed |Added

 CC||tdeca...@redhat.com



--- Comment #2 from Tristan Cacqueray  ---
Note:
- I guess the crypto-policy-non-compliance-openssl warning is related to
ghc-HsOpenSSL,
  could this be fixed in the future?


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
 publishes signatures.
 Note: gpgverify is not used.
[-]: Description and summary sections in the

Generic:
[x]: Rpmlint is run on all installed packages.
 Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
 is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
---
Checking: fbrnch-0.7.1-2.fc35.x86_64.rpm
  fbrnch-0.7.1-2.fc35.src.rpm
fbrnch.x86_64: W: spelling-error %description -l en_US repos -> ropes, reps,
repose
fbrnch.x86_64: W: spelling-error %description -l en_US srpms -> PMS
fbrnch.x86_64: W: spelling-error %description -l en_US copr -> corp, cope, cop
fbrnch.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/fbrnch
S

[Bug 1928654] Review Request: ongres-stringprep - RFC 3454 Preparation of Internationalized Strings ("stringprep") in pure Java

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1928654

Mikolaj Izdebski  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mizde...@redhat.com
   Assignee|nob...@fedoraproject.org|mizde...@redhat.com
  Flags||fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1927790] Review Request: rust-cxx - Safe interop between Rust and C++

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1927790

Jan Staněk  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2021-02-18 11:39:02



--- Comment #6 from Jan Staněk  ---
Package built for rawhide:
https://bodhi.fedoraproject.org/updates/FEDORA-2021-ebca44165e


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1927790] Review Request: rust-cxx - Safe interop between Rust and C++

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1927790
Bug 1927790 depends on bug 1927210, which changed state.

Bug 1927210 Summary: Review Request: rust-cxx-gen - C++ code generator for 
integrating `cxx` crate into higher level tools
https://bugzilla.redhat.com/show_bug.cgi?id=1927210

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1927353] Review Request: rust-cxx-build - C++ code generator for integrating `cxx` crate into a Cargo build.

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1927353
Bug 1927353 depends on bug 1927210, which changed state.

Bug 1927210 Summary: Review Request: rust-cxx-gen - C++ code generator for 
integrating `cxx` crate into higher level tools
https://bugzilla.redhat.com/show_bug.cgi?id=1927210

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1927210] Review Request: rust-cxx-gen - C++ code generator for integrating `cxx` crate into higher level tools

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1927210

Jan Staněk  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2021-02-18 10:22:33



--- Comment #4 from Jan Staněk  ---
Package built for rawhide:
https://bodhi.fedoraproject.org/updates/FEDORA-2021-8fba82b6d9


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1927697] Review Request: ansible-collection-containers-podman - Ansible collection for Podman containers

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1927697



--- Comment #5 from Parag AN(पराग)  ---
It is recommended practice that when you make a change to SPEC file, keep
increasing release tag and adding relevant changelog information.

I find that your SPEC file is updated but SRPM not. Please update SRPM file by
increasing release number.

Also, keep working on reviewing other people's package submission.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1908922] Review Request: libopenaptx - Open Source implementation of Audio Processing Technology codec (aptX)

2021-02-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1908922

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

  Flags|needinfo?(bcot...@redhat.co |
   |m)  |
   |needinfo?(wtaymans@redhat.c |
   |om) |



--- Comment #16 from Zbigniew Jędrzejewski-Szmek  ---
I assume the needinfo was by mistake.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure