[Bug 1929991] Review Request: python-backrefs - A wrapper around re and regex that adds additional back references
https://bugzilla.redhat.com/show_bug.cgi?id=1929991 Miro Hrončok changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #14 from Miro Hrončok --- APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1932734] Review Request: mkfontscale - Tool to generate legacy X11 font system index files
https://bugzilla.redhat.com/show_bug.cgi?id=1932734 Parag AN(पराग) changed: What|Removed |Added Assignee|nob...@fedoraproject.org|panem...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1926697] Review Request: openjdk-asmtools - An OpenSource project to develop tools for the production of proper and improper Java '.class' files
https://bugzilla.redhat.com/show_bug.cgi?id=1926697 --- Comment #39 from Jaya --- Thank you Jiri!! That highly simplified version :) Now the changes are done and verified. Spec file URL: https://jhuttana.fedorapeople.org/openjdk-asmtools.spec SRPM URL: https://jhuttana.fedorapeople.org/openjdk-asmtools-7.0.b10-0.1.20210122.git7eadbbf.fc35.src.rpm Man Page URL: https://jhuttana.fedorapeople.org/openjdk-asmtools.1 Launcher.in URL: https://jhuttana.fedorapeople.org/openjdk-asmtools.in -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1933942] Review Request: xcursorgen - xcursorgen prepares X11 cursor sets for use with libXcursor
https://bugzilla.redhat.com/show_bug.cgi?id=1933942 Peter Hutterer changed: What|Removed |Added Blocks||1933920 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1933920 [Bug 1933920] X.org Utility Deaggregation - xorg-x11-apps -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1929991] Review Request: python-backrefs - A wrapper around re and regex that adds additional back references
https://bugzilla.redhat.com/show_bug.cgi?id=1929991 --- Comment #13 from Parag Nemade --- Thank You Miro for checking this package license with Legal team. I have updated this package to remove unnecessary docs files now. Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/python-backrefs.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/python-backrefs-5.0.1-5.fc34.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934395] Review Request: xsetroot - Root window parameter setting utility for X
https://bugzilla.redhat.com/show_bug.cgi?id=1934395 --- Comment #3 from Fedora Update System --- FEDORA-2021-16525d15e0 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-16525d15e0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934392] Review Request: xrdb - X server resource database utility
https://bugzilla.redhat.com/show_bug.cgi?id=1934392 --- Comment #3 from Fedora Update System --- FEDORA-2021-16525d15e0 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-16525d15e0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934389] Review Request: xkill - Utility to force-close an X client's connection
https://bugzilla.redhat.com/show_bug.cgi?id=1934389 --- Comment #3 from Fedora Update System --- FEDORA-2021-16525d15e0 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-16525d15e0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934391] Review Request: xrandr - Commandline utility to change output properties
https://bugzilla.redhat.com/show_bug.cgi?id=1934391 --- Comment #3 from Fedora Update System --- FEDORA-2021-16525d15e0 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-16525d15e0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934393] Review Request: xrefresh - Refresh all or part of an X screen
https://bugzilla.redhat.com/show_bug.cgi?id=1934393 --- Comment #3 from Fedora Update System --- FEDORA-2021-16525d15e0 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-16525d15e0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934394] Review Request: xset - User preference utility for X
https://bugzilla.redhat.com/show_bug.cgi?id=1934394 --- Comment #3 from Fedora Update System --- FEDORA-2021-16525d15e0 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-16525d15e0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934387] Review Request: xinput - Utility to query X Input devices
https://bugzilla.redhat.com/show_bug.cgi?id=1934387 --- Comment #3 from Fedora Update System --- FEDORA-2021-16525d15e0 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-16525d15e0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1932760] Review Request: xisxwayland - Tool to check if the X server is XWayland
https://bugzilla.redhat.com/show_bug.cgi?id=1932760 --- Comment #3 from Fedora Update System --- FEDORA-2021-16525d15e0 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-16525d15e0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934396] Review Request: xstdcmap - Utility to define standard colormap properties
https://bugzilla.redhat.com/show_bug.cgi?id=1934396 --- Comment #3 from Fedora Update System --- FEDORA-2021-16525d15e0 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-16525d15e0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934390] Review Request: xmodmap - Edit and display the X11 core keyboard map
https://bugzilla.redhat.com/show_bug.cgi?id=1934390 --- Comment #3 from Fedora Update System --- FEDORA-2021-16525d15e0 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-16525d15e0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934386] Review Request: xhost - Manage hosts or users allowed to connect to the X server
https://bugzilla.redhat.com/show_bug.cgi?id=1934386 --- Comment #3 from Fedora Update System --- FEDORA-2021-16525d15e0 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-16525d15e0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934384] Review Request: sessreg - Utility to manage utmp/wtmp entries for X sessions
https://bugzilla.redhat.com/show_bug.cgi?id=1934384 --- Comment #3 from Fedora Update System --- FEDORA-2021-16525d15e0 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-16525d15e0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934385] Review Request: xgamma - X utility to query and alter the gamma correction of a monitor
https://bugzilla.redhat.com/show_bug.cgi?id=1934385 --- Comment #3 from Fedora Update System --- FEDORA-2021-16525d15e0 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-16525d15e0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934383] Review Request: rgb - X color name database
https://bugzilla.redhat.com/show_bug.cgi?id=1934383 --- Comment #3 from Fedora Update System --- FEDORA-2021-16525d15e0 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-16525d15e0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934382] Review Request: iceauth - Display the authorization information used in connecting with ICE
https://bugzilla.redhat.com/show_bug.cgi?id=1934382 --- Comment #3 from Fedora Update System --- FEDORA-2021-16525d15e0 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-16525d15e0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934402] Review Request: rust-case - Set of letter case string helpers
https://bugzilla.redhat.com/show_bug.cgi?id=1934402 --- Comment #4 from Sohan Kunkerkar --- > Please add the comment about why the "chmod -x" step is necessary to the > .spec file before committing it into dist-git. Sure thing! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1932760] Review Request: xisxwayland - Tool to check if the X server is XWayland
https://bugzilla.redhat.com/show_bug.cgi?id=1932760 Peter Hutterer changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||xisxwayland-1-1.fc35 Resolution|--- |NEXTRELEASE Last Closed||2021-03-04 02:03:01 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934395] Review Request: xsetroot - Root window parameter setting utility for X
https://bugzilla.redhat.com/show_bug.cgi?id=1934395 Peter Hutterer changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||xsetroot-1.1.2-1.fc35 Resolution|--- |NEXTRELEASE Last Closed||2021-03-04 01:56:57 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934396] Review Request: xstdcmap - Utility to define standard colormap properties
https://bugzilla.redhat.com/show_bug.cgi?id=1934396 Peter Hutterer changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||xstdcmap-1.0.4-1.fc35 Resolution|--- |NEXTRELEASE Last Closed||2021-03-04 01:56:36 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934394] Review Request: xset - User preference utility for X
https://bugzilla.redhat.com/show_bug.cgi?id=1934394 Peter Hutterer changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||xset-1.2.4-1.fc35 Resolution|--- |NEXTRELEASE Last Closed||2021-03-04 01:56:13 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934383] Review Request: rgb - X color name database
https://bugzilla.redhat.com/show_bug.cgi?id=1934383 Peter Hutterer changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||rgb-1.0.6-1.fc35 Resolution|--- |NEXTRELEASE Last Closed||2021-03-04 01:55:47 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934384] Review Request: sessreg - Utility to manage utmp/wtmp entries for X sessions
https://bugzilla.redhat.com/show_bug.cgi?id=1934384 Peter Hutterer changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||sessreg-1.1.2-1.fc35 Resolution|--- |NEXTRELEASE Last Closed||2021-03-04 01:55:07 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934387] Review Request: xinput - Utility to query X Input devices
https://bugzilla.redhat.com/show_bug.cgi?id=1934387 Peter Hutterer changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||xinput-1.6.3-1.fc35 Resolution|--- |NEXTRELEASE Last Closed||2021-03-04 01:54:29 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934385] Review Request: xgamma - X utility to query and alter the gamma correction of a monitor
https://bugzilla.redhat.com/show_bug.cgi?id=1934385 Peter Hutterer changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||xgamma-1.0.6-1.fc35 Resolution|--- |NEXTRELEASE Last Closed||2021-03-04 01:54:05 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934386] Review Request: xhost - Manage hosts or users allowed to connect to the X server
https://bugzilla.redhat.com/show_bug.cgi?id=1934386 Peter Hutterer changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||xhost-1.0.7-1.fc35 Resolution|--- |NEXTRELEASE Last Closed||2021-03-04 01:53:30 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934389] Review Request: xkill - Utility to force-close an X client's connection
https://bugzilla.redhat.com/show_bug.cgi?id=1934389 Peter Hutterer changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||xkill-1.0.5-1.fc35 Resolution|--- |NEXTRELEASE Last Closed||2021-03-04 01:53:04 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934390] Review Request: xmodmap - Edit and display the X11 core keyboard map
https://bugzilla.redhat.com/show_bug.cgi?id=1934390 Peter Hutterer changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||xmodmap-1.0.9-1.fc35 Resolution|--- |NEXTRELEASE Last Closed||2021-03-04 01:52:42 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934391] Review Request: xrandr - Commandline utility to change output properties
https://bugzilla.redhat.com/show_bug.cgi?id=1934391 Peter Hutterer changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||xrandr-1.5.1-1.fc35 Resolution|--- |NEXTRELEASE Last Closed||2021-03-04 01:52:11 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934392] Review Request: xrdb - X server resource database utility
https://bugzilla.redhat.com/show_bug.cgi?id=1934392 Peter Hutterer changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||xrdb-1.1.1-1.fc35 Resolution|--- |NEXTRELEASE Last Closed||2021-03-04 01:51:38 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934393] Review Request: xrefresh - Refresh all or part of an X screen
https://bugzilla.redhat.com/show_bug.cgi?id=1934393 Peter Hutterer changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||xrefresh-1.0.6-1.fc35 Resolution|--- |NEXTRELEASE Last Closed||2021-03-04 01:51:05 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934382] Review Request: iceauth - Display the authorization information used in connecting with ICE
https://bugzilla.redhat.com/show_bug.cgi?id=1934382 Peter Hutterer changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||iceauth-1.0.8-1.fc35 Resolution|--- |NEXTRELEASE Last Closed||2021-03-04 01:50:28 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934346] Review Request: viewres - X11 utility to display the widget hierarchy
https://bugzilla.redhat.com/show_bug.cgi?id=1934346 --- Comment #3 from Fedora Update System --- FEDORA-2021-f445c2dbfc has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-f445c2dbfc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934348] Review Request: listres - X11 utility to list application resources
https://bugzilla.redhat.com/show_bug.cgi?id=1934348 --- Comment #3 from Fedora Update System --- FEDORA-2021-f445c2dbfc has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-f445c2dbfc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934344] Review Request: appres - X11 utility to print application resources
https://bugzilla.redhat.com/show_bug.cgi?id=1934344 --- Comment #3 from Fedora Update System --- FEDORA-2021-f445c2dbfc has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-f445c2dbfc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934345] Review Request: editres - X11 utility to view and edit application resources
https://bugzilla.redhat.com/show_bug.cgi?id=1934345 --- Comment #3 from Fedora Update System --- FEDORA-2021-f445c2dbfc has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-f445c2dbfc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934348] Review Request: listres - X11 utility to list application resources
https://bugzilla.redhat.com/show_bug.cgi?id=1934348 Peter Hutterer changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||listres-1.0.4-1.fc35 Resolution|--- |NEXTRELEASE Last Closed||2021-03-04 01:05:00 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934346] Review Request: viewres - X11 utility to display the widget hierarchy
https://bugzilla.redhat.com/show_bug.cgi?id=1934346 Peter Hutterer changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||viewres-1.0.5-1.fc35 Resolution|--- |NEXTRELEASE Last Closed||2021-03-04 01:04:57 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934345] Review Request: editres - X11 utility to view and edit application resources
https://bugzilla.redhat.com/show_bug.cgi?id=1934345 Peter Hutterer changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||editres-1.0.7-1.fc35 Resolution|--- |NEXTRELEASE Last Closed||2021-03-04 01:04:55 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934344] Review Request: appres - X11 utility to print application resources
https://bugzilla.redhat.com/show_bug.cgi?id=1934344 Peter Hutterer changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||appres-1.0.5-1.fc35 Resolution|--- |NEXTRELEASE Last Closed||2021-03-04 01:04:52 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934902] Review Request: 3270-fonts - Monospaced font based on IBM 3270 terminals
https://bugzilla.redhat.com/show_bug.cgi?id=1934902 --- Comment #1 from Davide Cavalca --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=63038983 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934902] New: Review Request: 3270-fonts - Monospaced font based on IBM 3270 terminals
https://bugzilla.redhat.com/show_bug.cgi?id=1934902 Bug ID: 1934902 Summary: Review Request: 3270-fonts - Monospaced font based on IBM 3270 terminals Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: dcava...@fb.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://dcavalca.fedorapeople.org/review/3270-fonts/3270-fonts.spec SRPM URL: https://dcavalca.fedorapeople.org/review/3270-fonts/3270-fonts-2.2.1-1.fc35.src.rpm Description: This font is derived from the x3270 font, which, in turn, was translated from the one in Georgia Tech's 3270tool, which was itself hand-copied from a 3270 terminal. Fedora Account System Username: dcavalca -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1924660] Review Request: atari800 - An emulator of 8-bit Atari personal computers
https://bugzilla.redhat.com/show_bug.cgi?id=1924660
Lubomir Rintel changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||lkund...@v3.sk
Assignee|nob...@fedoraproject.org|lkund...@v3.sk
Doc Type|--- |If docs needed, set a value
--- Comment #1 from Lubomir Rintel ---
Thank you for packaging this. Here's my review:
* Package named correctly
* Latest version used
* SPEC file clean and legible
* Correct license tag used
* License good for Fedora
* Sane filelist
* Sane requires/provides
* No scriptlets shipped
* Correct compiler flags used
* Builds fine in mock
Below are some things I'd prefer you considered addressing before I approve
the package. All of them fairly minor:
1.) Please use the official dist tarball instead of just a git archive
> Source0:
> https://github.com/%{name}/%{name}/archive/ATARI800_%{ver_}/%{name}-%{version}.tar.gz
The official source tarball seems to be autotools' make dist generated:
https://github.com/atari800/atari800/releases/download/ATARI800_4_2_0/atari800-4.2.0-src.tgz
> BuildRequires: gcc, autoconf, automake
You don't need to drag in autoconf & automake once you use the dist tarball.
> autoreconf -f -i
Likewise, you don't need this.
2.) Please consider removing the author reference from description:
> %description
...
> Authors:
> David Firth
> and Atari800 Development Team (see CREDITS for a full list)
While the credit might be due, %description servers a different purpose --
to inform the user what the package contains and no more than that.
I believe shipping the CREDITS file is a sufficient way of letting the
interested users know who wrote the software.
3.) Don't bother removing $RPM_BUILD_ROOT
> %install
> rm -rf $RPM_BUILD_ROOT
rpmbuild does that already:
Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.PRXywD
+ umask 022
+ cd /home/lkundrak/rpmbuild/BUILD
+ '[' /home/lkundrak/rpmbuild/BUILDROOT/atari800-4.2.0-1.fc33.x86_64 '!=' /
']'
+ rm -rf /home/lkundrak/rpmbuild/BUILDROOT/atari800-4.2.0-1.fc33.x86_64
++ dirname /home/lkundrak/rpmbuild/BUILDROOT/atari800-4.2.0-1.fc33.x86_64
+ mkdir -p /home/lkundrak/rpmbuild/BUILDROOT
+ mkdir /home/lkundrak/rpmbuild/BUILDROOT/atari800-4.2.0-1.fc33.x86_64
+ cd atari800-ATARI800_4_2_0
+ rm -rf /home/lkundrak/rpmbuild/BUILDROOT/atari800-4.2.0-1.fc33.x86_64
+ /usr/bin/make install
DESTDIR=/home/lkundrak/rpmbuild/BUILDROOT/atari800-4.2.0-1.fc33.x86_64
'INSTALL=/usr/bin/install -p'
It may not have always does done, but modern versions do that, and
you already depend on new enough RPM by using macros such as
%make_install or %make_build.
> %make_install
4.) Please s/atari800.1.gz/atari800.1*/
> %files
...
> %{_mandir}/man1/atari800.1.gz
In theory, RPM might be configured not to compress manuals. It's a good
practice to use a wildcard here.
5. ) Please use %_pkgdocdir in place of /usr/share/doc/atari800
> %files
...
> %doc /usr/share/doc/atari800/README.TXT
> %doc /usr/share/doc/atari800/README
Or %{_docdir}/atari800; whichever you prefer.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1919704] Review Request: kirc - Tiny IRC client written in POSIX C99
https://bugzilla.redhat.com/show_bug.cgi?id=1919704 --- Comment #15 from Fedora Update System --- FEDORA-2021-38258ea463 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-38258ea463 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-38258ea463 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1920112] Review Request: rubygem-mixlib-log - A gem that provides a simple mixin for log functionality
https://bugzilla.redhat.com/show_bug.cgi?id=1920112 --- Comment #11 from Fedora Update System --- FEDORA-2021-4a266cf1a3 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-4a266cf1a3` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-4a266cf1a3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1919704] Review Request: kirc - Tiny IRC client written in POSIX C99
https://bugzilla.redhat.com/show_bug.cgi?id=1919704 --- Comment #14 from Fedora Update System --- FEDORA-EPEL-2021-a9b6ad3bb6 has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-a9b6ad3bb6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1920112] Review Request: rubygem-mixlib-log - A gem that provides a simple mixin for log functionality
https://bugzilla.redhat.com/show_bug.cgi?id=1920112 --- Comment #10 from Fedora Update System --- FEDORA-EPEL-2021-040d23010a has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-040d23010a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194 --- Comment #8 from Davide Cavalca --- Spec URL: https://dcavalca.fedorapeople.org/review/python-libcst/python-libcst.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-libcst/python-libcst-0.3.17-4.fc35.src.rpm Changelog: - Fix intersphinx inventory path - Fix %%py_provides gating -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1919704] Review Request: kirc - Tiny IRC client written in POSIX C99
https://bugzilla.redhat.com/show_bug.cgi?id=1919704 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System --- FEDORA-2021-54e00bc778 has been pushed to the Fedora 32 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-54e00bc778 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-54e00bc778 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1920112] Review Request: rubygem-mixlib-log - A gem that provides a simple mixin for log functionality
https://bugzilla.redhat.com/show_bug.cgi?id=1920112 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- FEDORA-2021-aa30d4725a has been pushed to the Fedora 32 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-aa30d4725a` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-aa30d4725a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934257] Review Request: python-asyncpg - A fast PostgreSQL Database Client Library for Python/asyncio
https://bugzilla.redhat.com/show_bug.cgi?id=1934257 c...@musicinmybrain.net changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1 from c...@musicinmybrain.net --- Fixed a bug finding the intersphinx inventory from python3-docs. New spec URL: https://gitlab.com/musicinmybrain/fedora-rpm/-/raw/ffc08e9f8fd731429c2bd5142625dec16fbbd256/python-asyncpg.spec New SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/2314/63032314/python-asyncpg-0.22.0-2.fc35.src.rpm New Koji builds: F35: https://koji.fedoraproject.org/koji/taskinfo?taskID=63032305 F34: https://koji.fedoraproject.org/koji/taskinfo?taskID=63032306 F33: https://koji.fedoraproject.org/koji/taskinfo?taskID=63032310 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1933988] Review Request: nativejit - Library for high-performance just-in-time compilation of expressions involving C data structures
https://bugzilla.redhat.com/show_bug.cgi?id=1933988 --- Comment #11 from c...@musicinmybrain.net --- Ok, a couple of other preliminary things from rpmlint: nativejit.x86_64: E: summary-too-long C Library for high-performance just-in-time compilation of expressions involving C data structures That’s easy to fix. And this: nativejit.x86_64: W: undefined-non-weak-symbol /usr/lib64/libNativeJIT.so.0 NativeJIT::rip nativejit.x86_64: W: undefined-non-weak-symbol /usr/lib64/libNativeJIT.so.0 NativeJIT::RegisterBase::c_names nativejit.x86_64: W: undefined-non-weak-symbol /usr/lib64/libNativeJIT.so.0 NativeJIT::rbp nativejit.x86_64: W: undefined-non-weak-symbol /usr/lib64/libNativeJIT.so.0 NativeJIT::RegisterBase::c_sizes nativejit.x86_64: W: undefined-non-weak-symbol /usr/lib64/libNativeJIT.so.0 NativeJIT::rsp nativejit.x86_64: W: undefined-non-weak-symbol /usr/lib64/libNativeJIT.so.0 NativeJIT::FunctionBuffer::EndFunctionBodyGeneration(NativeJIT::FunctionSpecification const&) nativejit.x86_64: W: undefined-non-weak-symbol /usr/lib64/libNativeJIT.so.0 NativeJIT::X64CodeGenerator::CodePrinter::PrintBytes(unsigned int, unsigned int) nativejit.x86_64: W: undefined-non-weak-symbol /usr/lib64/libNativeJIT.so.0 NativeJIT::CodeBuffer::AllocateLabel() nativejit.x86_64: W: undefined-non-weak-symbol /usr/lib64/libNativeJIT.so.0 NativeJIT::X64CodeGenerator::CodePrinter::CodePrinter(NativeJIT::X64CodeGenerator&) nativejit.x86_64: W: undefined-non-weak-symbol /usr/lib64/libNativeJIT.so.0 NativeJIT::X64CodeGenerator::IsDiagnosticsStreamAvailable() const nativejit.x86_64: W: undefined-non-weak-symbol /usr/lib64/libNativeJIT.so.0 NativeJIT::FunctionBuffer::BeginFunctionBodyGeneration() nativejit.x86_64: W: undefined-non-weak-symbol /usr/lib64/libNativeJIT.so.0 NativeJIT::LogThrowImpl(char const*, char const*, unsigned int, char const*, char const*, ...) nativejit.x86_64: W: undefined-non-weak-symbol /usr/lib64/libNativeJIT.so.0 NativeJIT::IosMiniStateRestorer::~IosMiniStateRestorer() nativejit.x86_64: W: undefined-non-weak-symbol /usr/lib64/libNativeJIT.so.0 NativeJIT::CodeBuffer::Emit32(unsigned int) nativejit.x86_64: W: undefined-non-weak-symbol /usr/lib64/libNativeJIT.so.0 NativeJIT::IosMiniStateRestorer::IosMiniStateRestorer(std::basic_ios >&) nativejit.x86_64: W: undefined-non-weak-symbol /usr/lib64/libNativeJIT.so.0 NativeJIT::X64CodeGenerator::GetDiagnosticsStream() const nativejit.x86_64: W: undefined-non-weak-symbol /usr/lib64/libNativeJIT.so.0 NativeJIT::Label::Label() nativejit.x86_64: W: undefined-non-weak-symbol /usr/lib64/libNativeJIT.so.0 NativeJIT::X64CodeGenerator::OpCodeName(NativeJIT::OpCode) nativejit.x86_64: W: undefined-non-weak-symbol /usr/lib64/libNativeJIT.so.0 NativeJIT::CodeBuffer::Emit8(unsigned char) nativejit.x86_64: W: undefined-non-weak-symbol /usr/lib64/libNativeJIT.so.0 NativeJIT::FunctionBuffer::GetEntryPoint() const nativejit.x86_64: W: undefined-non-weak-symbol /usr/lib64/libNativeJIT.so.0 NativeJIT::X64CodeGenerator::CodePrinter::GetPointerName(unsigned int) nativejit.x86_64: W: undefined-non-weak-symbol /usr/lib64/libNativeJIT.so.0 NativeJIT::CodeBuffer::CurrentPosition() const nativejit.x86_64: W: undefined-non-weak-symbol /usr/lib64/libNativeJIT.so.0 NativeJIT::FunctionSpecification::FunctionSpecification(Allocators::IAllocator&, int, unsigned int, unsigned int, unsigned int, NativeJIT::FunctionSpecification::BaseRegisterType, std::basic_ostream >*) I haven’t had time to try to understand why that is happening. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194 c...@musicinmybrain.net changed: What|Removed |Added Flags||needinfo?(code@musicinmybra ||in.net) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194
--- Comment #7 from c...@musicinmybrain.net ---
> Note that even with the intersphinx fix you suggested I still get: …
Hmm, you’re right. It looks like intersphinx does not like file:// URIs, but it
does accept plain old paths
(https://www.sphinx-doc.org/en/master/usage/extensions/intersphinx.html#confval-intersphinx_mapping).
That should have been:
# Use local intersphinx inventory
sed -r -i 's|https://docs.python.org/3|file:/%{_docdir}/python3-docs/html|' \
docs/source/conf.py
I had to fix this on my own package too:
https://bugzilla.redhat.com/show_bug.cgi?id=1934257
%if 0%{?fedora} < 33 || 0%{?rhel} < 9
is not correct; either %fedora or %rhel is undefined, so either 0%{?fedora} is
0, which is less than 33, or 0%{?rhel} is 0, which is less than 9. So it always
evaluates true.
If this came from pyp2rpm, then it is a bug in pyp2rpm.
If you are not building for EPEL, you can just check if 0%{?fedora} == 32.
I’m getting
- Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
Note: Unversionned Python dependency found.
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Python/#_dependencies
which I though was a false positive, triggered by the documentation package
%package -n python-%{pypi_name}-doc
It would be much more conventional to write that as
%packagedoc
which, with python-%{pypi_name} as the base name, would still give you the same
subpackage name.
I tested it with that change and still had the complaint, though.
I’m getting
Requires
python3-libcst (rpmlib, GLIBC filtered):
python(abi)
python3.9dist(pyyaml)
python3.9dist(typing-extensions)
python3.9dist(typing-inspect)
Provides
python3-libcst:
python-libcst
python3-libcst
python3.9-libcst
python3.9dist(libcst)
python3dist(libcst)
so something is going on that has nothing to do with the documentation.
I’ll post a full review after I figure out what the problem is.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1917991] Review Request: xsetpointer - X11 cursor image utility
https://bugzilla.redhat.com/show_bug.cgi?id=1917991 Peter Hutterer changed: What|Removed |Added Status|POST|CLOSED CC||peter.hutte...@redhat.com Resolution|--- |WONTFIX Last Closed||2021-03-03 22:20:57 --- Comment #3 from Peter Hutterer --- Mistaken packaging here, this utility is to be dropped, see Bug 1934365. It hasn't worked properly for over a decade now, let's close this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1933988] Review Request: nativejit - Library for high-performance just-in-time compilation of expressions involving C data structures
https://bugzilla.redhat.com/show_bug.cgi?id=1933988
c...@musicinmybrain.net changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|c...@musicinmybrain.net
Flags||fedora-review?
||needinfo?(trpost@rocketmail
||.com)
--- Comment #10 from c...@musicinmybrain.net ---
Okay, I looked into it further, and it seems COPASI already implements option
“1.” Look at
https://github.com/copasi/COPASI/blob/0dddbe0d84e4248270ff65d06ea2b3997cc4f3b9/copasi/math/CJitCompiler.cpp
to see how all JIT is disabled when a runtime CPU feature test shows SSE4 is
not available. So from a policy perspective, everything is fine.
You do need a quick feature test in the spec file to avoid running the tests on
build hosts without SSE4.2 (like mine!). Your %check could look like this:
if grep -E '\bsse4_2\b' /proc/cpuinfo >/dev/null
then
%ctest -- -VV
else
echo 'No SSE4.2 support on build host; skipping tests' 1>&2
fi
Or, if it’s more to your liking, use the other package you have under review:
BuildRequires: google-cpu_features
BuildRequires: jq
if list_cpu_features -j | jq -e '.flags | index("sse4_2")' >/dev/null
then
%ctest -- -VV
else
echo 'No SSE4.2 support on build host; skipping tests' 1>&2
fi
Personally, I would favor also adding a comment near the ExcludeArch mentioning
the SSE4.2 requirement and linking
https://pagure.io/packaging-committee/issue/1044, and perhaps mentioning the
SSE4.2 requirement in the package description as well.
-
Based on
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files,
you should write the shared library globs as
%{_libdir}/libCodeGen.so.0
%{_libdir}/libNativeJIT.so.0
instead of
%{_libdir}/libCodeGen.so.*
%{_libdir}/libNativeJIT.so.*
-
I’m not a big fan of claiming something as vague and generic as
/usr/include/Temporary, but I’m not sure there’s a reasonable way to avoid it.
-
I’m going to go ahead and claim this for review. Could you post an updated
version that skips the tests when necessary and adjusts the shared library
globs, and I’ll review that? Thanks.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1913737] Review Request: playonlinux - Graphical front-end for Wine
https://bugzilla.redhat.com/show_bug.cgi?id=1913737 --- Comment #10 from Robert Scheck --- Spec URL: http://labs.linuxnetz.de/bugzilla/playonlinux.spec SRPM URL: http://labs.linuxnetz.de/bugzilla/playonlinux-4.4-2.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1877240] Review Request: python-mock-ssh-server - SSH server for testing purposes
https://bugzilla.redhat.com/show_bug.cgi?id=1877240
Robert Scheck changed:
What|Removed |Added
CC||redhat-bugzilla@linuxnetz.d
||e
Assignee|m...@fabian-affolter.ch |redhat-bugzilla@linuxnetz.d
||e
Flags|fedora-review? |fedora-review+
|needinfo?(mail@fabian-affol |
|ter.ch) |
--- Comment #10 from Robert Scheck ---
As discussed with tibbs on #fedora-devel earlier today, this can be treated as
stalled reviewer, thus I'm finishing this hereby.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License", "*No copyright* Expat
License". 16 files have unknown license. Detailed output of
licensecheck in /home/robert/1877240-python-mock-ssh-
server/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separat
[Bug 1925761] Review Request: python-reedsolo - Pure-Python Reed Solomon encoder/decoder
https://bugzilla.redhat.com/show_bug.cgi?id=1925761 Julian Sikorski changed: What|Removed |Added Flags|needinfo?(beleg...@gmail.co | |m) | --- Comment #5 from Julian Sikorski --- Thanks for the review and sorry about the issues, I adapted the spec generated by rpmdev-newspec. Looks like it needs an update. New files: Spec URL: https://belegdol.fedorapeople.org/python-reedsolo.spec SRPM URL: https://belegdol.fedorapeople.org/python-reedsolo-1.5.4-3.fc33.src.rpm Changelog: - Add changelog.txt to %%doc - Add gcc to BuildRequires -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1877240] Review Request: python-mock-ssh-server - SSH server for testing purposes
https://bugzilla.redhat.com/show_bug.cgi?id=1877240 Raphael Groner changed: What|Removed |Added Flags||needinfo?(mail@fabian-affol ||ter.ch) --- Comment #9 from Raphael Groner --- ping -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1462467] Review Request: hollywood - Fill your console with Hollywood melodrama techno-babble
https://bugzilla.redhat.com/show_bug.cgi?id=1462467 --- Comment #18 from Raphael Groner --- Well, that would mean my first package for a 3rd party repo. But if it's still to skip mplayer only we should continue here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1933471] Review Request: golang-github-hub - A command-line tool that makes git easier to use with GitHub
https://bugzilla.redhat.com/show_bug.cgi?id=1933471 Phil Dibowitz changed: What|Removed |Added Flags|needinfo?(zebo...@gmail.com | |) | --- Comment #10 from Phil Dibowitz --- Spec URL: https://phildev.net/fedora/golang-github-hub.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/4171/63024171/golang-github-hub-2.14.2-2.fc35.src.rpm Meh, decided to just patch the source, it's a simple change. Dunno if fedora-review will use the above headers from a 2nd comment or not, I guess we'll find out. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1913737] Review Request: playonlinux - Graphical front-end for Wine
https://bugzilla.redhat.com/show_bug.cgi?id=1913737
Raphael Groner changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|projects...@smart.ms
--- Comment #9 from Raphael Groner ---
Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=63021594
GPL (v2 or later)
-
POL-POM-4-4.4/python/configurewindow/ConfigureWindow.py
POL-POM-4-4.4/python/debug.py
POL-POM-4-4.4/python/install/InstallWindow.py
POL-POM-4-4.4/python/mainwindow.py
POL-POM-4-4.4/python/options.py
POL-POM-4-4.4/python/setupwindow/POL_SetupFrame.py
POL-POM-4-4.4/python/setupwindow/gui_server.py
POL-POM-4-4.4/python/wine_versions/WineVersionsWindow.py
POL-POM-4-4.4/python/wrapper.py
MIT/X11 (BSD like)
--
POL-POM-4-4.4/src/check_direct_rendering.c
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
=> Licenses GPLv2 and MIT/X11 (latter one file only)
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "GPL (v2 or later)", "Unknown or
generated". 17 files have unknown license. Detailed output of
licensecheck in /home/builder/fedora-
review/1913737-playonlinux/playonlinux/licensecheck.txt
=> Add MIT for special file listed above or explain exception.
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/appdata
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
Note: Using prebuilt rpms.
=> Verified by succesful scratch build in rawhide.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[-]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[!]: Package complies to the Packaging Guidelines
=> License fix needed.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
[Bug 1913737] Review Request: playonlinux - Graphical front-end for Wine
https://bugzilla.redhat.com/show_bug.cgi?id=1913737 --- Comment #8 from Robert Scheck --- The playonlinux package is intended for Fedora and EPEL, while python3-natsort is only an issue for EPEL 8. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1803223] Review Request: golang-starlark - Starlark is a dialect of Python intended for use as a configuration language.
https://bugzilla.redhat.com/show_bug.cgi?id=1803223 Alejandro Sáez Morollón changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2021-03-03 18:45:08 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1896497] Review Request: golang-github-google-dap - Go implementation of the Debug Adapter Protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1896497 Alejandro Sáez Morollón changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2021-03-03 18:43:57 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1926697] Review Request: openjdk-asmtools - An OpenSource project to develop tools for the production of proper and improper Java '.class' files
https://bugzilla.redhat.com/show_bug.cgi?id=1926697
--- Comment #38 from jiri vanek ---
Hi!
you can simplify it a lot:
https://jvanek.fedorapeople.org/jaya/openjdk-asmtools.spec
https://jvanek.fedorapeople.org/jaya/openjdk-asmtools.in
Namely just added placeholder to the in file:
run @SCD@ "$@"
and simp;ifed loop to get rid of "if":
for launcher in "" "-jasm" "-jdis" "-jcoder" "-jdec" "-jcdec"; do
switch=`echo $launcher |sed "s/-//"`
cat %{SOURCE1} | sed "s/@SCD@/$switch/" >
$RPM_BUILD_ROOT%{_bindir}/%{name}$launcher
done
A must is to NOT mix spaces and tabs please.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1913737] Review Request: playonlinux - Graphical front-end for Wine
https://bugzilla.redhat.com/show_bug.cgi?id=1913737 --- Comment #7 from Raphael Groner --- Maybe wait for bug #1913757 about landing python3-natsort as required dependency in epel8. "ERROR: Option --old-chroot has been deprecated. Use --isolation=simple instead." "No matching package to install: 'python3-natsort'" https://koji.fedoraproject.org/koji/taskinfo?taskID=63018430 Though successful scratch build done in rawhide as this review seems file for. Is this request about epel8 only? Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=63018357 My system does not allow me to currently run any fedora-review against rawhide environment. Is it sufficient to have a final success with epel8 build? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1933988] Review Request: nativejit - Library for high-performance just-in-time compilation of expressions involving C data structures
https://bugzilla.redhat.com/show_bug.cgi?id=1933988 Antonio T. sagitter changed: What|Removed |Added Flags|needinfo?(trpost@rocketmail | |.com) | --- Comment #9 from Antonio T. sagitter --- Thank you Benjamin for your in-depth analysis but i have absolutely not idea of what's the best choice. I compile this software as-is provided by upstream, observations like yours are beyond my knowledge. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1913737] Review Request: playonlinux - Graphical front-end for Wine
https://bugzilla.redhat.com/show_bug.cgi?id=1913737 --- Comment #6 from Raphael Groner --- Please fix link for spec in raw format instead of html. https://src.fedoraproject.org/rpms/playonlinux/raw/6dbaaf6c6be94b2b75d48ee36deac7142ae0e676/f/playonlinux.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1462467] Review Request: hollywood - Fill your console with Hollywood melodrama techno-babble
https://bugzilla.redhat.com/show_bug.cgi?id=1462467 --- Comment #17 from Robert Scheck --- Honestly, if the package will require more and more dependencies from 3rd-party repositories with newer versions...does it really make sense for the Fedora repository? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194 --- Comment #6 from Davide Cavalca --- The SRPM should be fixed, sorry about that. Note that even with the intersphinx fix you suggested I still get: loading intersphinx inventory from file://usr/share/doc/python3-docs/html/objects.inv... WARNING: failed to reach any of the inventories with the following issues: intersphinx inventory 'file://usr/share/doc/python3-docs/html/objects.inv' not fetchable due to : No connection adapters were found for 'file://usr/share/doc/python3-docs/html/objects.inv' I also tried adding changing this to file:// but that doesn't seem to make a difference. However, this doesn't break the build and I do get what looks like a valid -doc package in the end. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194 Davide Cavalca changed: What|Removed |Added Flags|needinfo?(dcava...@fb.com) | --- Comment #5 from Davide Cavalca --- Spec URL: https://dcavalca.fedorapeople.org/review/python-libcst/python-libcst.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-libcst/python-libcst-0.3.17-3.fc35.src.rpm Changelog: - Fix docs build and enable it by default -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1858858] Wsdd package has incorrect firewalld settings, needs a sysconfig option for systemd file
https://bugzilla.redhat.com/show_bug.cgi?id=1858858 Sam P changed: What|Removed |Added Resolution|NOTABUG |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1933988] Review Request: nativejit - Library for high-performance just-in-time compilation of expressions involving C data structures
https://bugzilla.redhat.com/show_bug.cgi?id=1933988 --- Comment #8 from c...@musicinmybrain.net --- I guess a fourth allowable option is for the COPASI application to cleanly exit when SSE4.2 is not supported. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1858858] Wsdd package has incorrect firewalld settings, needs a sysconfig option for systemd file
https://bugzilla.redhat.com/show_bug.cgi?id=1858858 Sam P changed: What|Removed |Added Status|RELEASE_PENDING |CLOSED Resolution|--- |NOTABUG Last Closed||2021-03-03 17:31:24 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1462467] Review Request: hollywood - Fill your console with Hollywood melodrama techno-babble
https://bugzilla.redhat.com/show_bug.cgi?id=1462467 --- Comment #16 from Raphael Groner --- Thanks for your interest. (In reply to Robert Scheck from comment #15) > Is the package usable at all, if no 3rd-party repository is enabled? "We may want to use weak dependencies here instead, I can remove mplayer." > So are then e.g. just minor features missing? Yes. Weak dependency (for mplayer) may not work for cross-repos. > Aside of that, the latest version is 1.21 which might address the license > workaround in the spec file? ASL 2.0, see https://bazaar.launchpad.net/~kirkland/hollywood/trunk/view/head:/debian/copyright#L8 Though I fail to remember why added CC0 as well. Propably suggest from licensecheck script. Indeed, packaging version 1.12 seems to be very conservative. Going to take a closer look into more current version with obviously more 3rd-party support, besides fixes. https://bazaar.launchpad.net/~kirkland/hollywood/trunk/view/head:/debian/changelog -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1933988] Review Request: nativejit - Library for high-performance just-in-time compilation of expressions involving C data structures
https://bugzilla.redhat.com/show_bug.cgi?id=1933988
c...@musicinmybrain.net changed:
What|Removed |Added
Flags||needinfo?(trpost@rocketmail
||.com)
--- Comment #7 from c...@musicinmybrain.net ---
The library compiles with -mSSE4.2 so that the implementations of the two
overloads of NativeJIT::BitOp::GetNonZeroBitCount can use POPCNT/LZCNT. You are
already ExclusiveArch: x86_64, but the base x86_64 architecture does not
include these instructions. I recently raised this issue (admittedly, based on
a misunderstanding of the library in question at the time) and got FESCo to
record a policy: https://pagure.io/packaging-committee/issue/1044.
So you seem to have a few options:
1. Proceed with packaging this library as-is, with SSE4.2 instructions
possibly
sprinkled throughout due to the -mSSE4.2 option. This is allowable since
it
is a library. In the COPASI application, you will have to provide runtime
feature detection and a fallback that completely avoids calling any
functions
from this library, since any of them could include SSE4 instructions.
2. Patch this library to add runtime CPU detection and fallback
implementations,
compiling the optimized versions of these two routines with
__attribute__((__target__("sse4.2"))) or in a separate translation unit
with
-mSSE4.2. Remove -mSSE4.2 from the overall compiler flags. It may be
difficult
to avoid paying a possibly-significant performance penalty for added
indirection
at the granularity of a tiny inlinable function.
3. Give up the speed advantage of POPCNT/LZCNT: remove -mSSE4.2 from the
overall
compiler flags, and replace the two overloads of
NativeJIT::BitOp::GetNonZeroBitCount unconditionally with a generic
algorithm
like
https://graphics.stanford.edu/~seander/bithacks.html#CountBitsSetParallel.
This has the advantage of simplicity, and of not adding indirection. The
performance penalty will probably vary from trivial to substantial
depending on
how heavily the JIT’ed routines use these operations.
What do you think?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1462467] Review Request: hollywood - Fill your console with Hollywood melodrama techno-babble
https://bugzilla.redhat.com/show_bug.cgi?id=1462467 Robert Scheck changed: What|Removed |Added CC||redhat-bugzilla@linuxnetz.d ||e --- Comment #15 from Robert Scheck --- Is the package usable at all, if no 3rd-party repository is enabled? So are then e.g. just minor features missing? If the answer is "no", the package should IMHO get part of a 3rd-pary repository. Aside of that, the latest version is 1.21 which might address the license workaround in the spec file? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934704] Review Request: freight - A modern take on the Debian archive
https://bugzilla.redhat.com/show_bug.cgi?id=1934704 Sam P changed: What|Removed |Added Summary|Review Request: -|archive Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934704] New: Review Request: -
https://bugzilla.redhat.com/show_bug.cgi?id=1934704 Bug ID: 1934704 Summary: Review Request: - Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: dagofthed...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/survient/freight/fedora-rawhide-x86_64/02046746-freight/freight.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/survient/freight/fedora-rawhide-x86_64/02046746-freight/freight-0.3.12-1.fc35.src.rpm Description: freight programs create the files needed to serve a Debian archive. The actual serving is done via your favorite HTTP server. Fedora Account System Username: survient This is a review request to unretire an unmaintained package that I would like to take ownership of: https://pagure.io/releng/issue/10045 The upstream project was forked and has a newer release available than the original github project. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934402] Review Request: rust-case - Set of letter case string helpers
https://bugzilla.redhat.com/show_bug.cgi?id=1934402 Fabio Valentini changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Fabio Valentini --- It would be great if you added a comment above the chmod line (why is this necessary? those files should not have the executable bit set, and it breaks things). Upstream project seems to be dead, so I'm not sure if it's going to help if you open a pull request there to fix the permissions in the git repository. Other than that: Package generated with rust2rpm, simplifying the review. - package conforms to Rust Packaging Guidelines - package builds and installs successfully on rawhide - latest version is packaged - license matches upstream and license file is installed with %license - tests are run (but there are no tests in the project :sad-face:) Package APPROVED. Please add the comment about why the "chmod -x" step is necessary to the .spec file before committing it into dist-git. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1919704] Review Request: kirc - Tiny IRC client written in POSIX C99
https://bugzilla.redhat.com/show_bug.cgi?id=1919704 --- Comment #12 from Fedora Update System --- FEDORA-EPEL-2021-a9b6ad3bb6 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-a9b6ad3bb6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1913737] Review Request: playonlinux - Graphical front-end for Wine
https://bugzilla.redhat.com/show_bug.cgi?id=1913737 Raphael Groner changed: What|Removed |Added CC||projects...@smart.ms --- Comment #5 from Raphael Groner --- Are you interested in a review swap, maybe take a look into bug #1462467 or bug #1877240. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1919704] Review Request: kirc - Tiny IRC client written in POSIX C99
https://bugzilla.redhat.com/show_bug.cgi?id=1919704 --- Comment #11 from Fedora Update System --- FEDORA-2021-54e00bc778 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-54e00bc778 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934402] Review Request: rust-case - Set of letter case string helpers
https://bugzilla.redhat.com/show_bug.cgi?id=1934402 --- Comment #2 from Sohan Kunkerkar --- (In reply to Fabio Valentini from comment #1) > Do not just drop __brp_mangle_shebangs ... It might have unintended side > effects. > > Instead, fix the actual problem (e.g. removing executable bit from files > that are not supposed to be executables at the end of %prep), with something > like: > "chmod -x README.md src/lib.rs" (substitute for whatever the affected files > are). Thanks for the review. Fixed this in the latest push. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1925761] Review Request: python-reedsolo - Pure-Python Reed Solomon encoder/decoder
https://bugzilla.redhat.com/show_bug.cgi?id=1925761 --- Comment #4 from c...@musicinmybrain.net --- Created attachment 1760418 --> https://bugzilla.redhat.com/attachment.cgi?id=1760418&action=edit Example spec file incorporating review feedback For your convenience, I’ve attached a spec file that should incorporate all of my review feedback. Please feel free to use it as-is, modify it to your liking, or discard it and implement any needed changes yourself. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1925761] Review Request: python-reedsolo - Pure-Python Reed Solomon encoder/decoder
https://bugzilla.redhat.com/show_bug.cgi?id=1925761
c...@musicinmybrain.net changed:
What|Removed |Added
Flags||needinfo?(beleg...@gmail.co
||m)
--- Comment #3 from c...@musicinmybrain.net ---
I have a large number of small findings, all of which can be easily resolved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- The README.rst indicates the software may be used under Public Domain or MIT
terms. However, no copyright statement and MIT license text is included,
which is a problem since the MIT license requires that text to be reproduced
in all copies. See https://github.com/tomerfiliba/reedsolomon/issues/30 and
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text.
For now, the License field should be changed to “Public Domain”. When/if
upstream adds MIT license text, change the License field to “Public Domain or
MIT” and email the fedora-devel list about the change
(https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#License_Changes).
- There is a small typo in the description: “Codec ,” should be “Codec,”.
- There is no automatic %{description} macro akin to %{summary}, so the package
description is literally “%{description}”. The convention for Python packages
is something like this:
%global common_description %{expand:
A pure-python universal errors-and-erasures Reed-Solomon Codec, based on
the
wonderful tutorial at wikiversity, written by “Bobmath” and “LRQ3000”.}
%description %{common_description}
[…]
%description -n python3-%{srcname} %{common_description}
- The %python3_pkgversion macro is not needed for Fedora. It is needed for
EPEL. Since you are not planning to build for EPEL, please replace all
occurences with “3”, e.g.:
%package -n python3-%{srcname}
Additionally, even if you were packaging for EPEL,
%{?!python3_pkgversion:%global python3_pkgversion 3}
would not be needed because this macro is defined on all current EPEL and
Fedora releases.
- Please remove:
%{?python_enable_dependency_generator}
The Python dependency generator is enabled by default on all supported Fedora
releases and EPEL8, and is not available on EPEL7, so this line does nothing
in practice.
- The python_provide macro is obsolete and should not be used on Fedora. (It is
needed on EPEL.) See
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_py_provides_macro.
On Fedora 32, it is replaced by %py_provides; on Fedora 33 and later, it is
not needed for packages named python3-FOO where FOO is the name of the
importable Python package or module, such as this one. I like to use
conditional macros as a reminder to remove the unnecessary macro after Fedora
32 EOL. So
%{?python_provide:%python_provide python3-%{srcname}}
becomes
%if 0%{?fedora} == 32
%py_provides python3-%{srcname}
%endif
- You should add
%doc changelog.txt
to the %files section.
- The dependency
python%{python3_pkgversion}-setuptools
which becomes
python3-setuptools
after removing the unnecessary macro, is better written for Fedora as
python3dist(setuptools)
- There is no reason not to build the Cython compiled version. See
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_packages_using_cython
for guidance. You can remove
BuildArch: noarch
replace all occurences of python3_sitelib with python3_sitearch, add:
BuildRequires: python3dist(cython)
remove the pre-generated Cython C source by adding in %prep:
rm c%{srcname}.c
add to %files:
%{python3_sitearch}/c%{srcname}.cpython-%{python3_version_nodots}-x86_64-linux-gnu.so
and add to the package:
%py_provides python3-c%{srcname}
- The main source file has a shebang line (and one that uses #!/usr/bin/env,
which is forbidden by ) but is not a script. Please remove it in %prep or
with a patch. Open an issue and/or PR to remove it upstream (I already did
this), and link it in a comment. So, in %prep:
# Remove shebang in non-script source
# https://github.com/tomerfiliba/reedsolomon/pull/31
sed -r -i '1{/^#!/d}' %{srcname}.py
- The package has tests, which are included in the GitHub release tarball but
not in the PyPI tarball. You should switch to the GitHub tarball, and run the
tests in a %check section. We should not use nose, as upstream does, because
it is dead upstream and deprecated in Fedora
(https://fedoraproject.org/wiki/Changes/DeprecateNose), but we can run the
tests with pytest by adding
BuildRequires: python3dist(pytest)
and using the %pytest macro.
= MUST items =
Generic:
[x]: Package is licensed with an open-source
[Bug 1920112] Review Request: rubygem-mixlib-log - A gem that provides a simple mixin for log functionality
https://bugzilla.redhat.com/show_bug.cgi?id=1920112 --- Comment #8 from Fedora Update System --- FEDORA-EPEL-2021-040d23010a has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-040d23010a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1919704] Review Request: kirc - Tiny IRC client written in POSIX C99
https://bugzilla.redhat.com/show_bug.cgi?id=1919704 --- Comment #10 from Fedora Update System --- FEDORA-2021-38258ea463 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-38258ea463 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1920112] Review Request: rubygem-mixlib-log - A gem that provides a simple mixin for log functionality
https://bugzilla.redhat.com/show_bug.cgi?id=1920112 --- Comment #7 from Fedora Update System --- FEDORA-2021-4a266cf1a3 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-4a266cf1a3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1919704] Review Request: kirc - Tiny IRC client written in POSIX C99
https://bugzilla.redhat.com/show_bug.cgi?id=1919704 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #9 from Fedora Update System --- FEDORA-2021-cbf2a5aace has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-cbf2a5aace -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1920112] Review Request: rubygem-mixlib-log - A gem that provides a simple mixin for log functionality
https://bugzilla.redhat.com/show_bug.cgi?id=1920112 --- Comment #6 from Fedora Update System --- FEDORA-2021-faebc6480a has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-faebc6480a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1910018] Review Request: php-sanmai-phpunit-legacy-adapter - PHPUnit Legacy Versions Adapter
https://bugzilla.redhat.com/show_bug.cgi?id=1910018 --- Comment #8 from Fedora Update System --- FEDORA-2021-8ebfa6d550 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-8ebfa6d550 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-8ebfa6d550 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1932395] Review Request: perl-CPAN-02Packages-Search - Search Perl modules in 02packages.details.txt
https://bugzilla.redhat.com/show_bug.cgi?id=1932395 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-CPAN-02Packages-Search ||-0.001-1.fc35 Resolution|--- |RAWHIDE Last Closed||2021-03-03 15:12:36 --- Comment #6 from Petr Pisar --- Thank you for the review and the repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934346] Review Request: viewres - X11 utility to display the widget hierarchy
https://bugzilla.redhat.com/show_bug.cgi?id=1934346 --- Comment #2 from Tomas Hrcka --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/viewres -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
