[Bug 1937810] Review Request: sysmontask - Linux system monitor with the compactness and usefulness of WTM
https://bugzilla.redhat.com/show_bug.cgi?id=1937810 --- Comment #11 from Alessio --- Still talking about gi_composites.py file, the License: field in the spec file should contain "BSD and GPLv2+" based on what is stated on this [1] document? [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1927697] Review Request: ansible-collection-containers-podman - Ansible collection for Podman containers
https://bugzilla.redhat.com/show_bug.cgi?id=1927697 --- Comment #7 from Parag AN(पराग) --- Any update here? Did you get time to review packages? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1907044] Review Request: fcitx5-zhuyin - Libzhuyin Wrapper for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=1907044 --- Comment #5 from Qiyu Yan --- Thank you for the review, Robert-André. https://pagure.io/releng/fedora-scm-requests/issue/32808 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1907041] Review Request: fcitx5-table-other - other tables for Fcitx5
https://bugzilla.redhat.com/show_bug.cgi?id=1907041 --- Comment #5 from Qiyu Yan --- Thank you for the review, Robert-André. I will fix the capitalize. https://pagure.io/releng/fedora-scm-requests/issue/32805 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1907043] Review Request: fcitx5-unikey - Unikey support for Fcitx5
https://bugzilla.redhat.com/show_bug.cgi?id=1907043 --- Comment #4 from Qiyu Yan --- Thank you for the review, Robert-André. I will fix the mistake then. https://pagure.io/releng/fedora-scm-requests/issue/32802 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1549011] Review Request: i3blocks - highly flexible status line for the i3 window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1549011 Bob Hepple changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE Last Closed||2021-03-15 02:48:32 --- Comment #10 from Bob Hepple --- *** This bug has been marked as a duplicate of bug 1938637 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938637] Review Request: i3blocks - A feed generator for text based status bars
https://bugzilla.redhat.com/show_bug.cgi?id=1938637 Bob Hepple changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) CC||i...@redhat.com --- Comment #1 from Bob Hepple --- *** Bug 1549011 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938637] New: Review Request: i3blocks - A feed generator for text based status bars
https://bugzilla.redhat.com/show_bug.cgi?id=1938637 Bug ID: 1938637 Summary: Review Request: i3blocks - A feed generator for text based status bars Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: bob.hep...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/wef/i3blocks/fedora-rawhide-x86_64/02075664-i3blocks/i3blocks.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/wef/i3blocks/fedora-rawhide-x86_64/02075664-i3blocks/i3blocks-1.5-1.fc35.src.rpm Description: A feed generator for text based status bars i3blocks executes your command lines and generates a status line from their output. Commands are scheduled at configured time intervals, upon signal reception or on clicks. The generated line is meant to be displayed by the i3 window manager through its i3bar component, as an alternative to i3status. i3blocks is meant to be highly flexible but intuitive. No library package is required, just output what your status bar expects, from your favorite programming language and your preferred format. Fedora Account System Username: wef -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1929941] Review Request: python3-pyserial - Python serial port access library
https://bugzilla.redhat.com/show_bug.cgi?id=1929941 --- Comment #2 from Scott K Logan --- I had taken the pyserial spec from rawhide and made as few modifications as possible to make the package work for EPEL 7. Clearly the package has some things to address to meet today's packaging standards. I just started over and created a spec as if I was creating a new package. Since I'll be maintaining the package in EPEL 7, it makes sense. Thanks for your initial review. Please take a look at the re-written package: Spec URL: https://cottsay.fedorapeople.org/python3-pyserial/python3-pyserial.spec SRPM URL: https://cottsay.fedorapeople.org/python3-pyserial/python3-pyserial-3.4-12.el7.src.rpm Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=63796203 Thanks! --scott -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1919701] Review Request: xwm - Tiny XCB floating window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1919701 --- Comment #15 from Fedora Update System --- FEDORA-2021-32a6f6c822 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-32a6f6c822 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-32a6f6c822 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1931054] Review Request: python-pyte - In memory VT-compatible terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1931054 --- Comment #13 from Fedora Update System --- FEDORA-2021-0a59210dfe has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-0a59210dfe \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-0a59210dfe See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1919701] Review Request: xwm - Tiny XCB floating window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1919701 --- Comment #14 from Fedora Update System --- FEDORA-2021-cb50a67aa4 has been pushed to the Fedora 32 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-cb50a67aa4 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-cb50a67aa4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1931054] Review Request: python-pyte - In memory VT-compatible terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1931054 --- Comment #12 from Fedora Update System --- FEDORA-2021-b1cb08fefa has been pushed to the Fedora 32 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-b1cb08fefa \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-b1cb08fefa See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1919701] Review Request: xwm - Tiny XCB floating window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1919701 --- Comment #13 from Fedora Update System --- FEDORA-EPEL-2021-f5766f5ea9 has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-f5766f5ea9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1821189] Package Review: Snakemake - Workflow management system to create reproducible and scalable data analyses
https://bugzilla.redhat.com/show_bug.cgi?id=1821189 Bug 1821189 depends on bug 1931046, which changed state. Bug 1931046 Summary: Review Request: python-amply - A Python package for AMPL/GMPL datafile parsing https://bugzilla.redhat.com/show_bug.cgi?id=1931046 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1931046] Review Request: python-amply - A Python package for AMPL/GMPL datafile parsing
https://bugzilla.redhat.com/show_bug.cgi?id=1931046 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2021-03-15 01:19:22 --- Comment #8 from Fedora Update System --- FEDORA-2021-e010a39c25 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1925761] Review Request: python-reedsolo - Pure-Python Reed Solomon encoder/decoder
https://bugzilla.redhat.com/show_bug.cgi?id=1925761 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2021-03-15 01:08:12 --- Comment #18 from Fedora Update System --- FEDORA-2021-8414a74427 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1934194 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2021-03-15 01:08:15 --- Comment #18 from Fedora Update System --- FEDORA-2021-8f3008f667 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1919606] Review Request: rnnoise - Recurrent neural network for audio noise reduction
https://bugzilla.redhat.com/show_bug.cgi?id=1919606 Carl George 🤠 changed: What|Removed |Added Blocks||1921721 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1921721 [Bug 1921721] Feature request: Enable RNNoise in mumble -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1917075] Review Request: notekit - Hierarchical markdown notetaking application with tablet support
https://bugzilla.redhat.com/show_bug.cgi?id=1917075 --- Comment #5 from Lyes Saadi --- Spec URL: https://lyessa...@lyessaadi.fedorapeople.org/reviews/notekit/notekit.spec SRPM URL: https://lyessa...@lyessaadi.fedorapeople.org/reviews/notekit/notekit-0.1-2.fc33.src.rpm - Removing the git-core dependency - Checking for the validity of the Desktop and Metainfo files - Adding a License breakdown - Marking the Charter License as a License - "Unglobing" the icons/hicolor folder -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1917075] Review Request: notekit - Hierarchical markdown notetaking application with tablet support
https://bugzilla.redhat.com/show_bug.cgi?id=1917075
--- Comment #4 from Lyes Saadi ---
> - You should check the metainfo filein %install or %check:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage
>
> appstream-util validate-relax --nonet
> %{buildroot}%{_metainfodir}/*.metainfo.xml
>
> - And the desktop file:
>
>
> desktop-file-validate %{buildroot}/%{_datadir}/applications/%{uuid}.desktop
Aha! I've added the BuildRequires but somehow forgot to execute the commands
:P!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1526768] Review Request: clickhouse - a distributed column-oriented DBMS
https://bugzilla.redhat.com/show_bug.cgi?id=1526768 --- Comment #15 from Elliott Sales de Andrade --- This review died; you should probably just open a new one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1917073] Review Request: cLaTeXMath - A dynamic and cross-platform LaTeX rendering library
https://bugzilla.redhat.com/show_bug.cgi?id=1917073 --- Comment #8 from Lyes Saadi --- Spec URL: https://lyessa...@lyessaadi.fedorapeople.org/reviews/cLaTeXMath/cLaTeXMath.spec SRPM URL: https://lyessa...@lyessaadi.fedorapeople.org/reviews/cLaTeXMath/cLaTeXMath-0.0.3-2.fc33.src.rpm - Adding a -doc subpackage - Separating the LICENSE from the README.md Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=63775122 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1931054] Review Request: python-pyte - In memory VT-compatible terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1931054 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- FEDORA-2021-8daed5aa8d has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-8daed5aa8d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-8daed5aa8d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1917073] Review Request: cLaTeXMath - A dynamic and cross-platform LaTeX rendering library
https://bugzilla.redhat.com/show_bug.cgi?id=1917073 --- Comment #7 from Lyes Saadi --- > - Don't install this file: > > cLaTeXMath.x86_64: W: hidden-file-or-dir > /usr/share/clatexmath/.clatexmath-res_root > cLaTeXMath.x86_64: E: zero-length /usr/share/clatexmath/.clatexmath-res_root This file is actually surprisingly essential: https://github.com/NanoMichael/cLaTeXMath/blob/3bdd94b9b7263e1a30325d75aafe275a2f00fc45/src/latex.cpp#L48 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1917073] Review Request: cLaTeXMath - A dynamic and cross-platform LaTeX rendering library
https://bugzilla.redhat.com/show_bug.cgi?id=1917073 --- Comment #6 from Lyes Saadi --- First, sorry for the late answer... > - The fonts files could be replaced with symbolic links to the fonts > provided by texlive fonts packages. > This is a Should item so I wouldn't block the package on that alone. I've looked more into it, but, unfortunately, I am unable to find them under the ttf extension. The closest I've got is with texlive-amsfonts which distributes the fonts under the tfm, afm, pfm, pfb and mf extensions. Though, I have been able to find in the lyx-fonts package most of the math fonts in ttf. But I don't think it makes sense to link some while not linking others. On another note, should I try to create a font subpackage and to install them properly, similarly to what the lyx package does? > - Please add the license breakdown above the License: field Should this be done for individual fonts? Or can `res/` be generalized under multiple Licenses by saying "Fonts are under the OFL, Knuth and DoubleStroke licenses"? I am trying to track down each files' licenses. The `fonts/` folder seems to contain only OFL fonts, except for the `special.ttf` for which I have no idea from where it is. I have no idea about `cyrillic` and `greek` though... If it is necessary/recommended, I'll ask the maintainer to see if he can give me each file's origin. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1901118] Review Request: rust-pleaser - user execution with regex configuration
https://bugzilla.redhat.com/show_bug.cgi?id=1901118 --- Comment #4 from ed-fed...@s5h.net --- Hello, thanks again for looking. I believe this is now amended and ready to review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1937810] Review Request: sysmontask - Linux system monitor with the compactness and usefulness of WTM
https://bugzilla.redhat.com/show_bug.cgi?id=1937810 --- Comment #10 from Artem --- (In reply to Alessio from comment #8) > Excuse me @Artem, maybe you are more expert than me, but > SysMonTask-1.1.1_beta_b/sysmontask/gi_composites.py could be considered as a > bundled library? Good question and this is doesn't clear for me too. Some people think this should move into library. But at this moment this is more like a part of app and at least there already few apps packaged in Fedora which have this component: dnf -C repoquery --whatprovides \*gi_composites.py Last metadata expiration check: 0:48:47 ago on Sun 14 Mar 2021 06:16:40 PM EET. apostrophe-0:2.2.0.3-4.fc33.noarch apostrophe-0:2.3-1.fc33.noarch drawing-0:0.6.5-1.fc33.noarch lutris-0:0.5.7.1-3.fc33.x86_64 lutris-0:0.5.8.3-3.fc33.x86_64 piper-0:0.5.1-2.fc33.noarch pithos-0:1.4.1-9.fc32.noarch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938576] Review Request: golang-github-sophaskins-efs2tar - A tool to convert SGI efs filesystems to tarballs
https://bugzilla.redhat.com/show_bug.cgi?id=1938576 --- Comment #1 from Davide Cavalca --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=63765302 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938576] New: Review Request: golang-github-sophaskins-efs2tar - A tool to convert SGI efs filesystems to tarballs
https://bugzilla.redhat.com/show_bug.cgi?id=1938576 Bug ID: 1938576 Summary: Review Request: golang-github-sophaskins-efs2tar - A tool to convert SGI efs filesystems to tarballs Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: dcava...@fb.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-sophaskins-efs2tar/golang-github-sophaskins-efs2tar.spec SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-sophaskins-efs2tar/golang-github-sophaskins-efs2tar-0-0.1.20210314git4db1b0f.fc35.src.rpm Description: efs2tar is a tool that converts SGI EFS-formatted filesystem images (ie, the result of dd-ing a whole device in to a file) in to tarballs. It was based entirely on NetBSD's sys/fs/efs. Fedora Account System Username: dcavalca -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1937810] Review Request: sysmontask - Linux system monitor with the compactness and usefulness of WTM
https://bugzilla.redhat.com/show_bug.cgi?id=1937810 --- Comment #9 from Alessio --- (In reply to Alessio from comment #8) > Excuse me @Artem, maybe you are more expert than me, but > SysMonTask-1.1.1_beta_b/sysmontask/gi_composites.py could be considered as a > bundled library? Oh well, other packages have this file in their path. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1937810] Review Request: sysmontask - Linux system monitor with the compactness and usefulness of WTM
https://bugzilla.redhat.com/show_bug.cgi?id=1937810 --- Comment #8 from Alessio --- Excuse me @Artem, maybe you are more expert than me, but SysMonTask-1.1.1_beta_b/sysmontask/gi_composites.py could be considered as a bundled library? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1916518] Review Request: python-pyqt5-sip - The sip module support for PyQt5
https://bugzilla.redhat.com/show_bug.cgi?id=1916518 c...@musicinmybrain.net changed: What|Removed |Added Flags||needinfo?(s...@techie.net) --- Comment #3 from c...@musicinmybrain.net --- > Please hold off for now on reviewing this package as I'm wavering about > whether we should package this separately (vice having the python-qt5 package > build these itself, which is possible now with sip 5). Did you decide? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1909390] Review Request: gn - Meta-build system that generates build files for Ninja
https://bugzilla.redhat.com/show_bug.cgi?id=1909390 --- Comment #7 from c...@musicinmybrain.net --- Updated again while awaiting review… Spec URL: https://music.fedorapeople.org/gn-64b3b9401c1c3ed5f3c43c1cac00b91f83597ab8/gn.spec SRPM URL: https://music.fedorapeople.org/gn-64b3b9401c1c3ed5f3c43c1cac00b91f83597ab8/gn-1893-1.20210314git64b3b940.fc33.src.rpm Koji builds: F35: https://koji.fedoraproject.org/koji/taskinfo?taskID=63764650 F34: https://koji.fedoraproject.org/koji/taskinfo?taskID=63764655 F33: https://koji.fedoraproject.org/koji/taskinfo?taskID=63764659 F32: https://koji.fedoraproject.org/koji/taskinfo?taskID=63764662 EL8: https://koji.fedoraproject.org/koji/taskinfo?taskID=63764698 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1549011] Review Request: i3blocks - highly flexible status line for the i3 window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1549011 --- Comment #9 from Robert-André Mauchin 🐧 --- (In reply to Bob Hepple from comment #8) > I use i3blocks and would like to see this finalized. > > Can I help this along in some way? I have reviewer credentials. It seems the reporter has not answered for a while, if you want to maintain it, you would need to create a new review request and mark this one as Duplicate. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1893327] Review Request: human-theme-gtk - Human theme for GTK
https://bugzilla.redhat.com/show_bug.cgi?id=1893327
--- Comment #11 from Robert-André Mauchin 🐧 ---
(In reply to c...@luigifab.fr from comment #10)
> Hi, I work on the next release and I need to do a strange thing during
> installation.
>
> One of the installed file must be modified depending on Pango package
> version.
> For pango >= 1.44, I need to replace bottom="3" by bottom="4".
>
> I did that:
>
> %post
> currentver=`rpm -q --queryformat="%{RPMTAG_VERSION}" pango`
> requiredver=1.44
> if [ "$(printf '%s\n' "$requiredver" "$currentver" | sort -V | head -n1)" =
> "$requiredver" ]; then
> sed -i 's/ bottom="3"/ bottom="4"/g' %{_datadir}/themes/human-theme/metacity-1/metacity-theme-1.xml
> else
> sed -i 's/ bottom="4"/ bottom="3"/g' %{_datadir}/themes/human-theme/metacity-1/metacity-theme-1.xml
> fi
>
> rpmlint says:
>
> human-theme-gtk.noarch: W: percent-in-%post
> human-theme-gtk.noarch: W: dangerous-command-in-%post rpm
>
> It is good?
> Thanks
What happens when Pango is updated after the package is installed? This
wouldn't work.
Also all Pango on stable Fedora versions are at least 1.44
(https://src.fedoraproject.org/rpms/pango), so I don't know why this change is
required? I'd just change metacity-theme-1.xml with a patch.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1900145] Review Request: perl-ProjectBuilder - perl modules from the project-builder.org project used by MondoRescue
https://bugzilla.redhat.com/show_bug.cgi?id=1900145 c...@musicinmybrain.net changed: What|Removed |Added CC||c...@musicinmybrain.net --- Comment #6 from c...@musicinmybrain.net --- In addition to the good suggestions already given here, please consider applying the fedora-review tool to your own package, as a lot of the things that need to be changed are ones it will flag automatically. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938571] New: Review Request: ultimarc - Library and command line utility to configure Ultimarc boards
https://bugzilla.redhat.com/show_bug.cgi?id=1938571 Bug ID: 1938571 Summary: Review Request: ultimarc - Library and command line utility to configure Ultimarc boards Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: dcava...@fb.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://dcavalca.fedorapeople.org/review/ultimarc/ultimarc.spec SRPM URL: https://dcavalca.fedorapeople.org/review/ultimarc/ultimarc-1.1.0-1.20210314git540d403.fc35.src.rpm Description: This utility will configure the following Ultimarc boards: ServoStik, PACDrive, IPAC Ultimate, I-Pac 2, I-Pac 4, Mini-Pac, JPAC, UltraStik 360, PacLED64, U-HID and U-HID Nano. There is support for the PAC 2015 boards, UltraStik 2015 board and the previous generation of the PAC boards. It uses JSON configuration files to configure the different boards. It also supports the ability to change the device ID of the UltraStik 360 boards, allowing for the configuring of four different boards at once. Fedora Account System Username: dcavalca -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1901106] Review Request: rust-pam-sys - FFI rust crate
https://bugzilla.redhat.com/show_bug.cgi?id=1901106 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #4 from Robert-André Mauchin 🐧 --- Package approved. You still need to find a sponsor as described in https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1901114] Review Request: rust-pam - wrappers for PAM
https://bugzilla.redhat.com/show_bug.cgi?id=1901114 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #4 from Robert-André Mauchin 🐧 --- Package approved. You still need to find a sponsor as described in https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1901116] Review Request: rust-syslog - send messages to syslog
https://bugzilla.redhat.com/show_bug.cgi?id=1901116 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #3 from Robert-André Mauchin 🐧 --- Package approved. You still need to find a sponsor as described in https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1901118] Review Request: rust-pleaser - user execution with regex configuration
https://bugzilla.redhat.com/show_bug.cgi?id=1901118
--- Comment #3 from Robert-André Mauchin 🐧 ---
- I believe the main binary package should include the license as well:
%files -n %{crate}
%doc README.md
%license LICENSE
%{_bindir}/please
%{_bindir}/pleaseedit
%{_mandir}/man1/please.1*
%{_mandir}/man5/please.ini.5*
%config(noreplace) /etc/pam.d/please
%config(noreplace) /etc/pam.d/pleaseedit
%endif
- You didn't add a comment above the patch explaining what you have changed.
# Patch for syslog dependency
# - Bump syslog to 0.5
Patch0: pleaser-fix-metadata.diff
You also need to link to the upstream PR you opened bumping the dependency.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1907041] Review Request: fcitx5-table-other - other tables for Fcitx5
https://bugzilla.redhat.com/show_bug.cgi?id=1907041 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #4 from Robert-André Mauchin 🐧 --- - Summary is still not capitalized: fcitx5-table-other.noarch: W: summary-not-capitalized C other tables for Fcitx5 Summary:Other tables for Fcitx5 Pakage approved, please fix the aforementioned issue before import. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1907043] Review Request: fcitx5-unikey - Unikey support for Fcitx5
https://bugzilla.redhat.com/show_bug.cgi?id=1907043 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin 🐧 --- - It's GPLv2+ and LGPLv2+ License:GPLv2+ and LGPLv2+ There was a typo at LGPLv2+ (LGPL2+) Package approved, please fix the aforementioned issue. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1907044] Review Request: fcitx5-zhuyin - Libzhuyin Wrapper for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=1907044 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #4 from Robert-André Mauchin 🐧 --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1927033] Review Request: eth-fast-fabric - Intel Ethernet Fast Fabric Tools
https://bugzilla.redhat.com/show_bug.cgi?id=1927033
--- Comment #5 from Robert-André Mauchin 🐧 ---
(In reply to Jijun Wang from comment #4)
> Thanks for the feedback. Please see below for my response. I also updated
> github with the suggested changes, and did a koji build
> (https://koji.fedoraproject.org/koji/taskinfo?taskID=63599945).
> Please take a look and let me know any improvement you want me to do and
> whether you want me have another pre-release in github.
>
>
> - Any reason not to use the tarball from GitHub directly?
> eth-fast-fabric is for fabric management. It contains scripts that depend on
> other system tools. These tools cannot be autodetected as lib requires, so
> we need to explicitly defines Requires in spec file. In addition, we also
> need to specify BuildRequires. We intend to support different OSes. Given
> the lib names can be slightly different on different OSes, we use a script
> to generate spec file based on OS.
Ok
> So we cannot directly use the source
> tarball.
>
I don't follow. Even if you generate the spe file with a script, why can't you
use your tool to generate the correct archive url? Using macro like %{version}
would automatically keep the archive up to date. I don't understand why you
need to use a manually created archive while the github url would work as much.
> - Libraries required should be autodetected:
> Please wee above comment. I also removed the lib reqs that can be
> autodetected.
>
> - Please split your BuildRequires one per line:
> Changed as suggested.
>
> - Why do you need to set Epoch?
> During opa-ff distro inclusion RH set the epoch to 1. We carried that
> convention forward in eth-fast-fabric. Since we have released a version of
> eth-fast-fabric from github with epoch of 1, all future versions must now
> have epoch 1 or higher otherwise rpm upgrade will misinterpret which rpm is
> newer.
>
> - You mist respect the default Fedora CFLAGS and LDFLAGS during the build.
> It doesn't seem that your build script respect them.
> Changed as suggested.
>
> - What is $BUILD_ARGS?
> It’s for build arguments. We needn’t it in spec file. Removed it.
>
> - Should be in lib64:
> >
> > LIBDIR=%{_lɨbdir}
> >
> > The files in /lib looks weird though, it doesn't seem to be libraries? So
> > maybe it's okay. In that case use:
> >
> > LIBDIR=%{_prefix}/lib
> Changed to LIBDIR=%{_prefix}/lib as suggested.
>
> - You must use macros for directories:
> Changed as suggested.
>
> - Simplify this in %files fastfabric
> Changed as suggested.
>
> - Glob man pages extension as the compression might change in the future:
> Changed as suggested.
>
> - Just glob the man pages, no need to to specify all files manually:
> Changed as suggested.
>
> - Just include the whole directory too
> Changed as suggested.
>
> - own %{_sysconfdir}/eth-tools in basic
> Changed as suggested.
>
> - What are the files in /usr/lib/eth-tools ? They don't seem to be
> libraries.
> They are supporting scripts which are not intended for direct user
> invocation, but are needed by eth-fast-fabric. We had a similar situation in
> opa-ff and this is where RH requested we put them.
>
> - What's this:
> >
> > %preun fastfabric
> > cd /usr/src/eth/mpi_apps >/dev/null 2>&1
> > make -k clean >/dev/null 2>&1 || : # suppress all errors and return codes
> > from the make clean.
> >
> > Running make clean in preun on a system directory makes no sense/is
> > suspicious.
> eth-fast-fabric includes some mpi_apps in source form so end users can
> select the desired MPI to build them against such as openmpi, Intel MPI, or
> others. During uninstall, the makefile the user would use to clean the
> binaries is gone, so best to clean now.
>
Could you use the %ghost directive to reset the files generated by the user
that are not present at install?
> - Add a BuildRequires for make
> Changed as suggested.
>
> - Separate your changelog entries by a newline
> Changed as suggested.
>
> - I assume this is a typo and that you meant openssl:
> >
> > BuildRequires: penssl-devel
> Do not see it. Please let me know if it’s still a issue.
>
> - Release should start at 1
> We have released eth-fast-fabric. The version here intends to be our current
> release umber + 1, that is 163.
>
I believe the 13 should be part of the version not release, its ok for now but
please reset it next release.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1928694] Review Request: python-cffsubr - Standalone CFF subroutinizer based on the AFDKO tx tool
https://bugzilla.redhat.com/show_bug.cgi?id=1928694
c...@musicinmybrain.net changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #6 from c...@musicinmybrain.net ---
Thanks for packaging this! Approved, but please note the comment in Issues,
below.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= Issues =
- In the source RPM, the spec file has permissions 0400 (read-only, and only by
the owner). This may, or may not, cause problems when trying to import into
dist-git or build the package, but it is odd and surprising. I am not
blocking the package review on this, but please do change it (chmod 0644
python-cffsubr.spec).
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* Apache License 2.0",
"SIL Open Font License 1.1". 22 files have unknown license. Detailed
output of licensecheck in /home/reviewer/1928694-python-
cffsubr/20210314/1928694-python-cffsubr/licensecheck.txt
Note files with OFL are not installed, only used for testing; therefore
they are correctly not in the License field.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[Bug 1526768] Review Request: clickhouse - a distributed column-oriented DBMS
https://bugzilla.redhat.com/show_bug.cgi?id=1526768 Kfir Itzhak changed: What|Removed |Added CC||masterthekn...@gmail.com --- Comment #14 from Kfir Itzhak --- Hi, I rewrote an old SPEC file, and i'm using it to build ClickHouse for CentOS8 on x86 and aarch64, and currently working on getting it built on ppc64le. I would like to become a maintainer for this package on Fedora 32+ & RHEL8+ if possible. Kfir -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1901118] Review Request: rust-pleaser - user execution with regex configuration
https://bugzilla.redhat.com/show_bug.cgi?id=1901118 --- Comment #2 from ed-fed...@s5h.net --- Hello, I believe the changes requested are now done in the following: Spec URL: http://www.usenix.org.uk/rpm/rust-pleaser.spec SRPM URL: http://www.usenix.org.uk/rpm/rust-pleaser-0.3.25-1.fc35.src.rpm Thanks for looking -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1901116] Review Request: rust-syslog - send messages to syslog
https://bugzilla.redhat.com/show_bug.cgi?id=1901116 --- Comment #2 from ed-fed...@s5h.net --- Hello, I believe the changes are now in the following, thanks for looking. Spec URL: http://www.usenix.org.uk/rpm/rust-syslog.spec SRPM URL: http://www.usenix.org.uk/rpm/rust-syslog-5.0.0-1.fc35.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1901114] Review Request: rust-pam - wrappers for PAM
https://bugzilla.redhat.com/show_bug.cgi?id=1901114 --- Comment #3 from ed-fed...@s5h.net --- Hello, I believe the changes requested are now ready in the following: Spec URL: http://www.usenix.org.uk/rpm/rust-pam.spec SRPM URL: http://www.usenix.org.uk/rpm/rust-pam-0.7.0-1.fc35.src.rpm Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1901106] Review Request: rust-pam-sys - FFI rust crate
https://bugzilla.redhat.com/show_bug.cgi?id=1901106 --- Comment #3 from ed-fed...@s5h.net --- Thanks for looking, I believe the changes are now ready in the following: Spec URL: http://www.usenix.org.uk/rpm/rust-pam-sys.spec SRPM URL: http://www.usenix.org.uk/rpm/rust-pam-sys-0.5.6-1.fc35.src.rpm Description: Rust FFI wrappers for the Linux Pluggable Authentication Modules -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1931054] Review Request: python-pyte - In memory VT-compatible terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1931054 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #10 from Fedora Update System --- FEDORA-2021-8daed5aa8d has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-8daed5aa8d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1931054] Review Request: python-pyte - In memory VT-compatible terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1931054 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #10 from Fedora Update System --- FEDORA-2021-8daed5aa8d has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-8daed5aa8d --- Comment #10 from Fedora Update System --- FEDORA-2021-b1cb08fefa has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-b1cb08fefa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938522] Review Request: gnome-activity-journal - unretire and update to 1.0.0
https://bugzilla.redhat.com/show_bug.cgi?id=1938522 --- Comment #1 from crvi --- Tested on fedora rawhide docker image. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
