[Bug 1941896] Review Request: rust-rudo - rudo is a small equivalent of sudo writen in rust
https://bugzilla.redhat.com/show_bug.cgi?id=1941896 --- Comment #9 from Rémi Lauzier --- Thanks for the help! i got the package to compile and the man page to install. Can confirm that everything work on my end. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1935540] Review Request: libretls - Port of libtls from LibreSSL to OpenSSL
https://bugzilla.redhat.com/show_bug.cgi?id=1935540 --- Comment #19 from Fedora Update System --- FEDORA-EPEL-2021-347dc7561b has been pushed to the Fedora EPEL 7 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1941388] Review Request: softfloat - Berkeley IEEE Binary Floating-Point Library
https://bugzilla.redhat.com/show_bug.cgi?id=1941388 --- Comment #16 from Fedora Update System --- FEDORA-2021-6bb1ba4bd0 has been pushed to the Fedora 32 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-6bb1ba4bd0 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-6bb1ba4bd0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1941388] Review Request: softfloat - Berkeley IEEE Binary Floating-Point Library
https://bugzilla.redhat.com/show_bug.cgi?id=1941388 --- Comment #15 from Fedora Update System --- FEDORA-2021-2cb552bdcd has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-2cb552bdcd \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-2cb552bdcd See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942104] Review Request: ghc-hosc - Haskell Open Sound Control
https://bugzilla.redhat.com/show_bug.cgi?id=1942104 --- Comment #9 from Fedora Update System --- FEDORA-2021-1271ec83fd has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-1271ec83fd \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-1271ec83fd See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1925323] Review Request: google-compute-engine - Top-level package for enabling Google Compute Engine features
https://bugzilla.redhat.com/show_bug.cgi?id=1925323 --- Comment #4 from Neal Gompa --- (In reply to ericedens from comment #3) > If possible, it'd be nice to stay consistent with upstream. I did some > research, and these two reference (seem to) support using `/etc`: > > - "The /etc/ directory is reserved for configuration files that are local > to the machine" on > https://docs.fedoraproject.org/en-US/Fedora/14/html/ > Storage_Administration_Guide/s1-filesystem-fhs.html > - "Don’t use %config or %config(noreplace) under /usr. /usr is deemed to > not contain configuration files in Fedora" on > https://docs.fedoraproject.org/en-US/packaging-guidelines/ The first guide predates the changes to how configuration works, and the second guide is still correct. You would not mark this as a config file in /usr. If you're going to make user configuration get effectively blown away on upgrade, it's better to actually install it as a static regular file in /usr rather than what you're doing in /etc. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1941388] Review Request: softfloat - Berkeley IEEE Binary Floating-Point Library
https://bugzilla.redhat.com/show_bug.cgi?id=1941388 --- Comment #14 from Fedora Update System --- FEDORA-EPEL-2021-aaadac85ee has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-aaadac85ee See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1941388] Review Request: softfloat - Berkeley IEEE Binary Floating-Point Library
https://bugzilla.redhat.com/show_bug.cgi?id=1941388 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System --- FEDORA-2021-3207a60321 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-3207a60321 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-3207a60321 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942104] Review Request: ghc-hosc - Haskell Open Sound Control
https://bugzilla.redhat.com/show_bug.cgi?id=1942104 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- FEDORA-2021-cae035cf47 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-cae035cf47 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-cae035cf47 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938471] Review Request: disk-utilities - Collection of utilities for ripping, dumping, analysing, and modifying disk images
https://bugzilla.redhat.com/show_bug.cgi?id=1938471 --- Comment #18 from Fedora Update System --- FEDORA-2021-e03a72ed74 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 --- Comment #31 from Fedora Update System --- FEDORA-2021-56fe02602d has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1935540] Review Request: libretls - Port of libtls from LibreSSL to OpenSSL
https://bugzilla.redhat.com/show_bug.cgi?id=1935540 --- Comment #18 from Fedora Update System --- FEDORA-EPEL-2021-11c0280666 has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1936262] Review Request: lib3270 - TN3270 Protocol Library
https://bugzilla.redhat.com/show_bug.cgi?id=1936262 --- Comment #23 from Fedora Update System --- FEDORA-EPEL-2021-5f3bfd9abf has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1943353] Review Request: rust-tokio-stream - Utilities to work with Stream and tokio
https://bugzilla.redhat.com/show_bug.cgi?id=1943353 --- Comment #6 from Fedora Update System --- FEDORA-2021-c6c351209c has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1939978] Review Request: sugar-dimensions - Pattern matching game
https://bugzilla.redhat.com/show_bug.cgi?id=1939978 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #8 from Robert-André Mauchin --- > It's a license and the version used still contains same address hence I can't > just change it. It's allowed to patch the headers but not single license file. In any case please send a patch upstream. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1941896] Review Request: rust-rudo - rudo is a small equivalent of sudo writen in rust
https://bugzilla.redhat.com/show_bug.cgi?id=1941896 --- Comment #8 from Robert-André Mauchin --- Sent you a PR. Use go-md2man as indicated in the commit log. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1925323] Review Request: google-compute-engine - Top-level package for enabling Google Compute Engine features
https://bugzilla.redhat.com/show_bug.cgi?id=1925323 --- Comment #3 from ericedens --- If possible, it'd be nice to stay consistent with upstream. I did some research, and these two reference (seem to) support using `/etc`: - "The /etc/ directory is reserved for configuration files that are local to the machine" on https://docs.fedoraproject.org/en-US/Fedora/14/html/Storage_Administration_Guide/s1-filesystem-fhs.html - "Don’t use %config or %config(noreplace) under /usr. /usr is deemed to not contain configuration files in Fedora" on https://docs.fedoraproject.org/en-US/packaging-guidelines/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1943526] Review Request: libuev - Simple event loop for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1943526
Otto Urpelainen changed:
What|Removed |Added
Flags||needinfo?(alciregi@posteo.n
||et)
--- Comment #5 from Otto Urpelainen ---
Great, it is getting better. Another set of findings still:
- Main package documentation could be added: AUTHORS, ChangeLog, README
- Documentation for -devel:
- There is %{_pkgdocdir} which resolves to %{_docdir}/%{name}
- But do not do that if also %doc is used, reference:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation
- At the moment, part of the material goes to /usr/share/doc/libuev, other
part to /usr/share/doc/libuev-devel. Everything marked as -devel package docs
should go to -devel directory. I think using %doc only would correct this.
- In examples, .gitignore is not useful and should not be included.
Probably
the same also holds for Makefiles
- Directories without known owners: /usr/share/doc/libuev
I think this comes from the problem above where -devel installs docs to main
package's directory. You could run fedora-review after the changes and see if
the error remains. Or submit the new files and I will run it as usual.
Reference:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership
I slightly worry over licensing and libuev-2.3.2/src/bench.c which has
different license and copyright owner than the rest. But, it seem to be built
separately from the library and not installed, so it does not require License
entry for binary rpm, and includes the license in the file itself, so source
rpm licensing is ok as well. So, I think it can be like it is.
Apart from these, everything looks good. fedora-review was unable to download
Source, but perhaps that was a transient failure. I will ignore that for now
and see how it goes for the next version.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1925323] Review Request: google-compute-engine - Top-level package for enabling Google Compute Engine features
https://bugzilla.redhat.com/show_bug.cgi?id=1925323
--- Comment #2 from Neal Gompa ---
> # Omit 'noreplace' since the values in these values are required for a system
> to run
> # correctly on Google Compute Engine.
> %config /etc/dracut.conf.d/*
> %config /etc/modprobe.d/*
If these aren't actually intended to be user-modifiable, you should probably
install these into their /usr/lib counterparts:
%{_prefix}/lib/dracut/dracut.conf.d
%{_prefix}/lib/modprobe.d
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1941388] Review Request: softfloat - Berkeley IEEE Binary Floating-Point Library
https://bugzilla.redhat.com/show_bug.cgi?id=1941388 --- Comment #12 from Fedora Update System --- FEDORA-EPEL-2021-aaadac85ee has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-aaadac85ee -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1941388] Review Request: softfloat - Berkeley IEEE Binary Floating-Point Library
https://bugzilla.redhat.com/show_bug.cgi?id=1941388 --- Comment #11 from Fedora Update System --- FEDORA-2021-6bb1ba4bd0 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-6bb1ba4bd0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1925323] Review Request: google-compute-engine - Top-level package for enabling Google Compute Engine features
https://bugzilla.redhat.com/show_bug.cgi?id=1925323
--- Comment #1 from ericedens ---
`fedora-review -b 1925323 -m fedora-rawhide-x86_64`
This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
ones are mandatory, though)
- Remove this text
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* Apache License 2.0", "Unknown or generated",
"Apache License 2.0". 12 files have unknown license. Detailed output
of licensecheck in /home/ericedens/git/fedora-packages/google-compute-
engine/1925323-google-compute-engine/licensecheck.txt
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /etc/dhcp/dhclient.d,
/etc/dhcp
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: %config files are marked noreplace or the reason is justified.
Note: No (noreplace) in %config /etc/dracut.conf.d/* %config
/etc/modprobe.d/*
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Sources are verified with gpgverify
[Bug 1941388] Review Request: softfloat - Berkeley IEEE Binary Floating-Point Library
https://bugzilla.redhat.com/show_bug.cgi?id=1941388 --- Comment #10 from Fedora Update System --- FEDORA-2021-2cb552bdcd has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-2cb552bdcd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1941388] Review Request: softfloat - Berkeley IEEE Binary Floating-Point Library
https://bugzilla.redhat.com/show_bug.cgi?id=1941388 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED --- Comment #9 from Fedora Update System --- FEDORA-2021-3207a60321 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-3207a60321 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1925323] Review Request: google-compute-engine - Top-level package for enabling Google Compute Engine features
https://bugzilla.redhat.com/show_bug.cgi?id=1925323 ericedens changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited --- Spec URL: https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packages/fedora-rawhide-x86_64/02110119-google-compute-engine/google-compute-engine.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packages/fedora-rawhide-x86_64/02110119-google-compute-engine/google-compute-engine-20201207.00-1.fc35.src.rpm Description: The Google Compute Engine guest environment is comprised of several packages; this package is the top-level package that a user would install, and that will be installed in the Google Compute Engine kickstart. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1941896] Review Request: rust-rudo - rudo is a small equivalent of sudo writen in rust
https://bugzilla.redhat.com/show_bug.cgi?id=1941896 --- Comment #7 from Rémi Lauzier --- Hi! i manage to get the config file to install as file. i just have a problem with the man page. i must convert markdown to man page but i don't know how to do it. Thanks for your time! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1944912] Review Request: python-hypothesmith - Hypothesis strategies for generating Python programs
https://bugzilla.redhat.com/show_bug.cgi?id=1944912 Michel Alexandre Salim changed: What|Removed |Added Status|NEW |ASSIGNED CC||mic...@michel-slm.name Assignee|nob...@fedoraproject.org|mic...@michel-slm.name Doc Type|--- |If docs needed, set a value Flags||fedora-review? --- Comment #2 from Michel Alexandre Salim --- Taking this review -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1945307] New: Review Request: rust-sevctl - Administrative utility for AMD SEV
https://bugzilla.redhat.com/show_bug.cgi?id=1945307 Bug ID: 1945307 Summary: Review Request: rust-sevctl - Administrative utility for AMD SEV Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: cku...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/ckuehl/rust-sevctl/fedora-rawhide-x86_64/02108801-rust-sevctl/rust-sevctl.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ckuehl/rust-sevctl/fedora-rawhide-x86_64/02108801-rust-sevctl/rust-sevctl-0.1.0-1.fc35.src.rpm Description: Administrative utility for AMD SEV Fedora Account System Username: ckuehl Successful build in the COPR frontend: https://copr.fedorainfracloud.org/coprs/ckuehl/rust-sevctl/build/2108801/ I am one of the upstream maintainers for this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942392] Review Request: rust-vmm-sys-util - Helpers and utilities used by multiple rust-vmm components and VMMs
https://bugzilla.redhat.com/show_bug.cgi?id=1942392 Cole Robinson changed: What|Removed |Added CC||crobi...@redhat.com Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #11 from Cole Robinson --- I sponsored Sergio into the packagers group now... I think... the system changed recently but it shows he's a member here now: https://accounts.fedoraproject.org/user/slp/ Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1939978] Review Request: sugar-dimensions - Pattern matching game
https://bugzilla.redhat.com/show_bug.cgi?id=1939978 Ibiam changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited --- Spec URL: https://chimosky.fedorapeople.org/sugar-dimensions.spec SRPM URL: https://chimosky.fedorapeople.org/sugar-dimensions-60-2.fc32.src.rpm Description: The object is to find sets of three cards where each attribute—color, shape, number of elements, and shading—either match on all three cards or are different on all three cards. The current version doesn't yet support sharing with multiple players or saving to the Journal, but it can be played by a single player. Fedora Account System Username: chimosky -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1941994] Review Request: cockpit-machines - Cockpit component for managing virtual machines (split out from existing cockpit package)
https://bugzilla.redhat.com/show_bug.cgi?id=1941994 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/cockpit-machines -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1150393] Review Request: tengine - A high performance web server and reverse proxy server
https://bugzilla.redhat.com/show_bug.cgi?id=1150393 Danila Vershinin changed: What|Removed |Added CC||cia...@gmail.com --- Comment #15 from Danila Vershinin --- Tengine builds now freely available via third-party GetPageSpeed repository: https://nginx-extras.getpagespeed.com/tengine/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942392] Review Request: rust-vmm-sys-util - Helpers and utilities used by multiple rust-vmm components and VMMs
https://bugzilla.redhat.com/show_bug.cgi?id=1942392 Connor Kuehl changed: What|Removed |Added Flags|needinfo?(cku...@redhat.com | |) | --- Comment #10 from Connor Kuehl --- Thanks both of you! Sergio, you should be able to request a repo for this now. (Sorry if this message goes through multiple times, Bugzilla is giving me an error when I click submit). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942392] Review Request: rust-vmm-sys-util - Helpers and utilities used by multiple rust-vmm components and VMMs
https://bugzilla.redhat.com/show_bug.cgi?id=1942392 Connor Kuehl changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1945159] Review Request: rizin - reverse engineering framework, fork of radare2
https://bugzilla.redhat.com/show_bug.cgi?id=1945159 Riccardo Schirone changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1 from Riccardo Schirone --- For the licenses part, with the new release 0.2.0 that is probably going out quite soon, we have switched almost all files to SPDX and I'll be able to generate better reports which specify how each file is licensed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1945159] New: Review Request: rizin - reverse engineering framework, fork of radare2
https://bugzilla.redhat.com/show_bug.cgi?id=1945159 Bug ID: 1945159 Summary: Review Request: rizin - reverse engineering framework, fork of radare2 Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: rschiron...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://raw.githubusercontent.com/ret2libc/rizin-specs-fedora/master/rizin.spec SRPM URL: https://github.com/ret2libc/rizin-specs-fedora/raw/master/rizin-0.1.2-1.fc33.src.rpm Description: Rizin is a free and open-source Reverse Engineering framework, providing a complete binary analysis experience with features like Disassembler, Hexadecimal editor, Emulation, Binary inspection, Debugger, and more. Rizin is a fork of radare2 with a focus on usability, working features and code cleanliness. Fedora Account System Username: ret2libc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942392] Review Request: rust-vmm-sys-util - Helpers and utilities used by multiple rust-vmm components and VMMs
https://bugzilla.redhat.com/show_bug.cgi?id=1942392 Fabiano Fidêncio changed: What|Removed |Added Flags||needinfo?(cku...@redhat.com ||) --- Comment #9 from Fabiano Fidêncio --- (In reply to Sergio Lopez from comment #8) > (In reply to Connor Kuehl from comment #7) > > (In reply to Fabiano Fidêncio from comment #6) > > > [..] > > > [!]: License file installed when any subpackage combination is installed. > > > Sergio, license is only being installed as part of the > > > rust-vmm-sys-util-devel package. > > > > I think the root `rust-vmm-sys-util-devel` is required by the other > > subfeature versions, so running `dnf install rust-vmm-sys-util+serde-devel` > > should result in rust-vmm-sys-util-devel being installed with the license. > > Is that sufficient? > > I've just checked and all subpackages depend on the main one via > "crate(vmm-sys-util)": > > [slp@fedora noarch]$ rpm -qpR > rust-vmm-sys-util+default-devel-0.8.0-1.fc34.noarch.rpm > cargo > crate(vmm-sys-util) = 0.8.0 > rpmlib(CompressedFileNames) <= 3.0.4-1 > rpmlib(FileDigests) <= 4.6.0-1 > rpmlib(PayloadFilesHavePrefix) <= 4.0-1 > rpmlib(PayloadIsZstd) <= 5.4.18-1 > [slp@fedora noarch]$ rpm -qpR > rust-vmm-sys-util+serde-devel-0.8.0-1.fc34.noarch.rpm > cargo > crate(serde/default) >= 1.0.27 > crate(vmm-sys-util) = 0.8.0 > rpmlib(CompressedFileNames) <= 3.0.4-1 > rpmlib(FileDigests) <= 4.6.0-1 > rpmlib(PayloadFilesHavePrefix) <= 4.0-1 > rpmlib(PayloadIsZstd) <= 5.4.18-1 > [slp@fedora noarch]$ rpm -qpR > rust-vmm-sys-util+serde_derive-devel-0.8.0-1.fc34.noarch.rpm > cargo > crate(serde_derive/default) >= 1.0.27 > crate(vmm-sys-util) = 0.8.0 > rpmlib(CompressedFileNames) <= 3.0.4-1 > rpmlib(FileDigests) <= 4.6.0-1 > rpmlib(PayloadFilesHavePrefix) <= 4.0-1 > rpmlib(PayloadIsZstd) <= 5.4.18-1 > [slp@fedora noarch]$ rpm -qpR > rust-vmm-sys-util+with-serde-devel-0.8.0-1.fc34.noarch.rpm > cargo > crate(serde/default) >= 1.0.27 > crate(serde_derive/default) >= 1.0.27 > crate(vmm-sys-util) = 0.8.0 > rpmlib(CompressedFileNames) <= 3.0.4-1 > rpmlib(FileDigests) <= 4.6.0-1 > rpmlib(PayloadFilesHavePrefix) <= 4.0-1 > rpmlib(PayloadIsZstd) <= 5.4.18-1 > > This also seems to be what other packaged rust-crates do, such as > rust-memmap. > > > > [..] > > > [?]: Package functions as described. > > > Sergio, I haven't tested the package, I'd appreciate if Connor could > > > do. > > > > I have a package that only transiently depends on vmm-sys-util for unit > > tests, but a lot of the other required packages aren't packaged for Fedora > > yet since they depend on this one. So I think it would be nontrivial for me > > to position my other package to test this library. The unit tests that run > > for this package are all passing, which is good enough for me. > > FWIW, I have a second package ready for submission (vm-memory) that depends > on vmm-sys-util, and passes its own tests fine. Given that we're just > shipping some sources in the package, I think it should be fine. > > Thank you both! > Sergio. Perfect! Connor, please, could you set the "fedora-review" flag to "+"? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942392] Review Request: rust-vmm-sys-util - Helpers and utilities used by multiple rust-vmm components and VMMs
https://bugzilla.redhat.com/show_bug.cgi?id=1942392 --- Comment #8 from Sergio Lopez --- (In reply to Connor Kuehl from comment #7) > (In reply to Fabiano Fidêncio from comment #6) > > [..] > > [!]: License file installed when any subpackage combination is installed. > > Sergio, license is only being installed as part of the > > rust-vmm-sys-util-devel package. > > I think the root `rust-vmm-sys-util-devel` is required by the other > subfeature versions, so running `dnf install rust-vmm-sys-util+serde-devel` > should result in rust-vmm-sys-util-devel being installed with the license. > Is that sufficient? I've just checked and all subpackages depend on the main one via "crate(vmm-sys-util)": [slp@fedora noarch]$ rpm -qpR rust-vmm-sys-util+default-devel-0.8.0-1.fc34.noarch.rpm cargo crate(vmm-sys-util) = 0.8.0 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsZstd) <= 5.4.18-1 [slp@fedora noarch]$ rpm -qpR rust-vmm-sys-util+serde-devel-0.8.0-1.fc34.noarch.rpm cargo crate(serde/default) >= 1.0.27 crate(vmm-sys-util) = 0.8.0 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsZstd) <= 5.4.18-1 [slp@fedora noarch]$ rpm -qpR rust-vmm-sys-util+serde_derive-devel-0.8.0-1.fc34.noarch.rpm cargo crate(serde_derive/default) >= 1.0.27 crate(vmm-sys-util) = 0.8.0 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsZstd) <= 5.4.18-1 [slp@fedora noarch]$ rpm -qpR rust-vmm-sys-util+with-serde-devel-0.8.0-1.fc34.noarch.rpm cargo crate(serde/default) >= 1.0.27 crate(serde_derive/default) >= 1.0.27 crate(vmm-sys-util) = 0.8.0 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsZstd) <= 5.4.18-1 This also seems to be what other packaged rust-crates do, such as rust-memmap. > > [..] > > [?]: Package functions as described. > > Sergio, I haven't tested the package, I'd appreciate if Connor could > > do. > > I have a package that only transiently depends on vmm-sys-util for unit > tests, but a lot of the other required packages aren't packaged for Fedora > yet since they depend on this one. So I think it would be nontrivial for me > to position my other package to test this library. The unit tests that run > for this package are all passing, which is good enough for me. FWIW, I have a second package ready for submission (vm-memory) that depends on vmm-sys-util, and passes its own tests fine. Given that we're just shipping some sources in the package, I think it should be fine. Thank you both! Sergio. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1941994] Review Request: cockpit-machines - Cockpit component for managing virtual machines (split out from existing cockpit package)
https://bugzilla.redhat.com/show_bug.cgi?id=1941994 --- Comment #4 from Martin Pitt --- Thanks for your review, Robert! Katerina fixed the License: field in https://github.com/cockpit-project/cockpit-machines/commit/cc8c4afdc50f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1944554] Review Request: perl-Glib-IO - Perl binding to the GIO library
https://bugzilla.redhat.com/show_bug.cgi?id=1944554 Jitka Plesnikova changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|jples...@redhat.com Flags||fedora-review+ --- Comment #7 from Jitka Plesnikova --- (In reply to Michal Josef Spacek from comment #6) > (In reply to Petr Pisar from comment #5) > > The usage is this one: > > > > my $loop = Glib::MainLoop->new (); > > > > That does not load Glib module. The test just expects that Glib::MainLoop > > was imported > > implicitly somewhere somehow (probably by Glib transitively loaded by "use > > Glib::IO;" > > at line #5). It's maybe a deficiency in the test, but the RPM dependency > > should not be there: > > Yes, you are right. > I removed this dependency. > > https://skim.cz/tmp/perl-Glib-IO-2/perl-Glib-IO.spec > https://skim.cz/tmp/perl-Glib-IO-2/perl-Glib-IO-0.001-1.fc35.src.rpm > > Thanks. # Tests: -BuildRequires: perl(Glib) BuildRequires: perl(Test::More) Package looks good now. Resolution: Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1943526] Review Request: libuev - Simple event loop for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1943526 Alessio changed: What|Removed |Added Flags|needinfo?(alciregi@posteo.n | |et) | --- Comment #4 from Alessio --- Thank you very much. New files: Spec URL: https://alciregi.fedorapeople.org/uredir/libuev.spec SRPM URL: https://alciregi.fedorapeople.org/uredir/libuev-2.3.2-1.fc34.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1944554] Review Request: perl-Glib-IO - Perl binding to the GIO library
https://bugzilla.redhat.com/show_bug.cgi?id=1944554 --- Comment #6 from Michal Josef Spacek --- (In reply to Petr Pisar from comment #5) > The usage is this one: > > my $loop = Glib::MainLoop->new (); > > That does not load Glib module. The test just expects that Glib::MainLoop > was imported > implicitly somewhere somehow (probably by Glib transitively loaded by "use > Glib::IO;" > at line #5). It's maybe a deficiency in the test, but the RPM dependency > should not be there: Yes, you are right. I removed this dependency. https://skim.cz/tmp/perl-Glib-IO-2/perl-Glib-IO.spec https://skim.cz/tmp/perl-Glib-IO-2/perl-Glib-IO-0.001-1.fc35.src.rpm Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1944981] New: Review Request: php-doctrine-deprecations - A small layer on top of trigger_error or PSR-3 logging
https://bugzilla.redhat.com/show_bug.cgi?id=1944981 Bug ID: 1944981 Summary: Review Request: php-doctrine-deprecations - A small layer on top of trigger_error or PSR-3 logging Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@famillecollet.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://git.remirepo.net/cgit/rpms/php/doctrine/php-doctrine-deprecations.git/plain/php-doctrine-deprecations.spec?id=ad3492960871aa15e58e1e0ce1cc8522ed1b7bbd SRPM URL: https://rpms.remirepo.net/SRPMS/php-doctrine-deprecations-0.5.3-2.remi.src.rpm Description: A small (side-effect free by default) layer on top of trigger_error(E_USER_DEPRECATED) or PSR-3 logging. * no side-effects by default, making it a perfect fit for libraries that don't know how the error handler works they operate under * options to avoid having to rely on error handlers global state by using PSR-3 logging * deduplicate deprecation messages to avoid excessive triggering and reduce overhead We recommend to collect Deprecations using a PSR logger instead of relying on the global error handler. Autoloader: /usr/share/php/Doctrine/Deprecations/autoload.php Fedora Account System Username: remi --- New dependency of the Doctrine stack, for now already required by new doctrine/dbal version -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
