[Bug 1667725] Review Request: boost169 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1667725 --- Comment #18 from Denis Arnaud --- *** Bug 1210993 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1210993 Denis Arnaud changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE Last Closed||2021-06-16 06:46:44 --- Comment #29 from Denis Arnaud --- *** This bug has been marked as a duplicate of bug 1667725 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1972511] New: Review Request: gnome-shell-frippery - Extensions to provide a user experience more like that of GNOME 2
https://bugzilla.redhat.com/show_bug.cgi?id=1972511 Bug ID: 1972511 Summary: Review Request: gnome-shell-frippery - Extensions to provide a user experience more like that of GNOME 2 Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: dcava...@fb.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://dcavalca.fedorapeople.org/review/gnome-shell-frippery/gnome-shell-frippery.spec SRPM URL: https://dcavalca.fedorapeople.org/review/gnome-shell-frippery/gnome-shell-frippery-40.2-1.fc34.src.rpm Description: This package contains some GNOME Shell extensions to provide a user experience more like that of GNOME 2. Fedora Account System Username: dcavalca -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1957744] New RHEL9 package: debugedit - Tools for debuginfo creation
https://bugzilla.redhat.com/show_bug.cgi?id=1957744 Frank Ch. Eigler changed: What|Removed |Added Status|ASSIGNED|MODIFIED CC||f...@redhat.com Fixed In Version||debugedit-0.2-1.el9 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1972470] New: RFP: just
https://bugzilla.redhat.com/show_bug.cgi?id=1972470 Bug ID: 1972470 Summary: RFP: just Product: Fedora Version: rawhide Status: NEW Component: Package Review Severity: low Assignee: nob...@fedoraproject.org Reporter: ca...@rodarmor.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora I wanted to request that a program, written in Rust, be packaged for Fedora and included in the main package repository. I'm sorry if this isn't the right place to make such a request. I asked on IRC, but didn't get a response. The program is just, a command runner: https://github.com/casey/just It is written in rust, and is a command runner, a bit like make minus the build system. I wrote and maintain just, and am eager to work with packagers to make it easy to package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1971386] Review Request: tini - A tiny but valid init for containers
https://bugzilla.redhat.com/show_bug.cgi?id=1971386 --- Comment #14 from Fedora Update System --- FEDORA-EPEL-2021-b253df10a9 has been pushed to the Fedora EPEL 7 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-b253df10a9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1971394] Review Request: x11docker - Run GUI applications and desktops in Linux containers
https://bugzilla.redhat.com/show_bug.cgi?id=1971394 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- FEDORA-2021-286782014e has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-286782014e \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-286782014e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1971386] Review Request: tini - A tiny but valid init for containers
https://bugzilla.redhat.com/show_bug.cgi?id=1971386 --- Comment #13 from Fedora Update System --- FEDORA-2021-9f2524be9e has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-9f2524be9e \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-9f2524be9e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1971386] Review Request: tini - A tiny but valid init for containers
https://bugzilla.redhat.com/show_bug.cgi?id=1971386 --- Comment #12 from Fedora Update System --- FEDORA-EPEL-2021-b5abacf758 has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-b5abacf758 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1971386] Review Request: tini - A tiny but valid init for containers
https://bugzilla.redhat.com/show_bug.cgi?id=1971386 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- FEDORA-2021-d96b00b4ea has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-d96b00b4ea \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-d96b00b4ea See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming
https://bugzilla.redhat.com/show_bug.cgi?id=976793 --- Comment #21 from Jaroslav Škarvada --- Spec URL: https://jskarvad.fedorapeople.org/lunchbox/lunchbox.spec SRPM URL: https://jskarvad.fedorapeople.org/lunchbox/lunchbox-1.17.0-1.fc33.src.rpm I used lunchbox name with lowercase 'l' which seemed better to me. It's bundling some cmake macros from the Lunchbox upstream. Currently I don't know what to do with it, so I bundled them and encouraged upstream to bundle it to the release package. Another variant is to package it to individual package and encourage upstream to add it as a dep (currently upstream consumes it as a submodule). For the bundling probably FESCO exception will be needed. I also opened several upstream bugs, see the comments in the spec. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming
https://bugzilla.redhat.com/show_bug.cgi?id=976793 --- Comment #20 from Jaroslav Škarvada --- Tests temporary disabled due to: https://github.com/Eyescale/Lunchbox/issues/330 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming
https://bugzilla.redhat.com/show_bug.cgi?id=976793 Jaroslav Škarvada changed: What|Removed |Added Depends On||1972445 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1972445 [Bug 1972445] Review Request: servus - Zeroconf discovery in C++ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1972445] Review Request: servus - Zeroconf discovery in C++
https://bugzilla.redhat.com/show_bug.cgi?id=1972445 Jaroslav Škarvada changed: What|Removed |Added Blocks||976793 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=976793 [Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming
https://bugzilla.redhat.com/show_bug.cgi?id=976793 --- Comment #19 from Jaroslav Škarvada --- Unfortunately upstream complicates it even more. Now it requires Servus (bug 1972445) and what's worse it's bundling it as a git submodule. I encouraged upstream to add support for building with the system Servus. I could patch it myself, but at first we need Servus to get in. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1972445] New: Review Request: servus - Zeroconf discovery in C++
https://bugzilla.redhat.com/show_bug.cgi?id=1972445 Bug ID: 1972445 Summary: Review Request: servus - Zeroconf discovery in C++ Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jskar...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://jskarvad.fedorapeople.org/servus/servus.spec SRPM URL: https://jskarvad.fedorapeople.org/servus/servus-1.5.2-1.fc33.src.rpm Description: Servus is a small C++ network utility library that provides a zeroconf API, URI parsing and UUIDs. Fedora Account System Username: jskarvad It's prereq for Lunchbox (bug 976793). Regarding the name it's similar to Lunchbox, see the Lunchbox discussion. I also used the lowercase variant, which seems as better fit to me. It's bundling some cmake macros from the Lunchbox upstream. Currently I don't know what to do with it, so I bundled them and encouraged upstream to bundle it to the release package. Another variant is to package it to individual package and encourage upstream to add it as a dep (currently upstream consumes it as a submodule). For the bundling probably FESCO exception will be needed. I also opened several upstream bugs, see the comments in the spec. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1971386] Review Request: tini - A tiny but valid init for containers
https://bugzilla.redhat.com/show_bug.cgi?id=1971386 --- Comment #10 from Fedora Update System --- FEDORA-EPEL-2021-b253df10a9 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-b253df10a9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938451] Review Request: stellarsolver - The Cross Platform Sextractor and Internal Astrometric Solver
https://bugzilla.redhat.com/show_bug.cgi?id=1938451 Petr Menšík changed: What|Removed |Added Assignee|nob...@fedoraproject.org|pemen...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938451] Review Request: stellarsolver - The Cross Platform Sextractor and Internal Astrometric Solver
https://bugzilla.redhat.com/show_bug.cgi?id=1938451
--- Comment #9 from Petr Menšík ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* GNU General Public
License v2.0 or later", "*No copyright* GNU Lesser General Public
License v2.1 or later", "GNU General Public License v2.0 or later",
"GNU General Public License, Version 3 GNU General Public License,
Version 2", "BSD 3-clause "New" or "Revised" License GNU General
Public License v3.0 or later", "GNU General Public License v3.0 or
later", "BSD 3-clause "New" or "Revised" License", "GNU Lesser General
Public License, Version 3", "Expat License", "GNU Lesser General
Public License v3.0 or later", "Public domain GNU General Public
License v2.0 or later". 290 files have unknown license. Detailed
output of licensecheck in
/home/reviewer/fedora/rawhide/1938451-stellarsolver/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[!]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 2 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separat
[Bug 1938451] Review Request: stellarsolver - The Cross Platform Sextractor and Internal Astrometric Solver
https://bugzilla.redhat.com/show_bug.cgi?id=1938451 Petr Menšík changed: What|Removed |Added Status|NEW |ASSIGNED CC||pemen...@redhat.com --- Comment #8 from Petr Menšík --- Thanks for licenses fixed. Correct me if I am wrong, but sextractor is already packaged for Fedora [1]. Astrometry seems to exist as well [2]. Therefore just bundled(astronomy) should not be used, unless sources bundled in this package are modified and incompatible with last versions. If they are compatible, libraries should be used. Starting with BuildRequires: astrometry-devel Any downstream changes required to build with shared library astronomy should be reported back to upstream. There exists also python-sep package [3], which seems to package only python part of sep library. It seems a new package sep should be imported, providing both python and C-library, which can be then used both to provide python package and sep-devel library for reuse by this package. Until that is finished, I guess Provides: bundled(sep) is acceptable. It should be noted in spec as TODO, maybe even fill a bug on python-sep for missing C library for coordination. Ideally new review bug should be created for sep, this bug depending on it. Otherwise spec looks ready. From quick look to CMakeLists.txt, upstream does not even consider astrometry separate library. Can you try to build it using shared libraries with existing packages? I have seen astrometry.cfg in sources. Should it also Recommends: astrometry, at least? 1. https://src.fedoraproject.org/rpms/sextractor 2. https://src.fedoraproject.org/rpms/astrometry 3. https://src.fedoraproject.org/rpms/python-sep -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1963740] Package cryfs
https://bugzilla.redhat.com/show_bug.cgi?id=1963740 --- Comment #5 from Neal Gompa --- (In reply to Petr Menšík from comment #4) > If opensuse already has working spec file, it can be reused for Fedora > package. Usually with small modifications. Try opensuse spec file: > https://build.opensuse.org/package/show/security:privacy/cryfs > That spec file is a good reference, but it looks like basically the entire spec would be different to comply with Fedora's standards. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1963740] Package cryfs
https://bugzilla.redhat.com/show_bug.cgi?id=1963740 Petr Menšík changed: What|Removed |Added CC||pemen...@redhat.com --- Comment #4 from Petr Menšík --- If opensuse already has working spec file, it can be reused for Fedora package. Usually with small modifications. Try opensuse spec file: https://build.opensuse.org/package/show/security:privacy/cryfs Are you willing to maintain it on Fedora? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1971394] Review Request: x11docker - Run GUI applications and desktops in Linux containers
https://bugzilla.redhat.com/show_bug.cgi?id=1971394 --- Comment #8 from Fedora Update System --- FEDORA-2021-286782014e has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-286782014e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming
https://bugzilla.redhat.com/show_bug.cgi?id=976793 Jaroslav Škarvada changed: What|Removed |Added Flags|needinfo?(jskarvad@redhat.c | |om) | --- Comment #18 from Jaroslav Škarvada --- Rebasing to 1.17.0, the latest released upstream version. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1210993 Petr Menšík changed: What|Removed |Added CC||pemen...@redhat.com --- Comment #28 from Petr Menšík --- (In reply to Denis Arnaud from comment #25) > Note that a newer version (Boost1.69) has been accepted a while ago: > https://bugzilla.redhat.com/show_bug.cgi?id=1667725 > > Boost 1.72 (or even 1.73) should very soon make its way onto Fedora Rawhide. > I'll then most probably file a new review for it on EPEL. Your help will be > welcome at that point. If this version is too old to be included in EPEL, could it be closed? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1971386] Review Request: tini - A tiny but valid init for containers
https://bugzilla.redhat.com/show_bug.cgi?id=1971386 --- Comment #9 from Fedora Update System --- FEDORA-EPEL-2021-b5abacf758 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-b5abacf758 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1971386] Review Request: tini - A tiny but valid init for containers
https://bugzilla.redhat.com/show_bug.cgi?id=1971386 --- Comment #8 from Fedora Update System --- FEDORA-2021-d96b00b4ea has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-d96b00b4ea -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1971386] Review Request: tini - A tiny but valid init for containers
https://bugzilla.redhat.com/show_bug.cgi?id=1971386 --- Comment #7 from Fedora Update System --- FEDORA-2021-9f2524be9e has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-9f2524be9e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1971394] Review Request: x11docker - Run GUI applications and desktops in Linux containers
https://bugzilla.redhat.com/show_bug.cgi?id=1971394 --- Comment #7 from Davide Cavalca --- https://pagure.io/releng/fedora-scm-requests/issue/34651 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1971394] Review Request: x11docker - Run GUI applications and desktops in Linux containers
https://bugzilla.redhat.com/show_bug.cgi?id=1971394 Davide Cavalca changed: What|Removed |Added Status|POST|MODIFIED Fixed In Version||x11docker-6.9.0-2.fc35 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1971386] Review Request: tini - A tiny but valid init for containers
https://bugzilla.redhat.com/show_bug.cgi?id=1971386 --- Comment #6 from Davide Cavalca --- https://pagure.io/releng/fedora-scm-requests/issue/34647 https://pagure.io/releng/fedora-scm-requests/issue/34648 https://pagure.io/releng/fedora-scm-requests/issue/34649 https://pagure.io/releng/fedora-scm-requests/issue/34650 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1971222] Review Request: rust-plotters-bitmap - Plotters Bitmap Backend
https://bugzilla.redhat.com/show_bug.cgi?id=1971222 --- Comment #5 from Fabio Valentini --- fedora-review has been producing rather inconsistent results for me lately, with sometimes erroring out on mock/dnf problems or just silently ignoring errors. But it looks like plotters-bitmap has been updated upstream since I last looked at it, and it uses up-to-date dependencies now. Ignore my comment. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1971222] Review Request: rust-plotters-bitmap - Plotters Bitmap Backend
https://bugzilla.redhat.com/show_bug.cgi?id=1971222 --- Comment #4 from Robert-André Mauchin 🐧 --- (In reply to Fabio Valentini from comment #2) > Please check whether the built packages actually install on rawhide. Last I > checked, plotters 0.3 was utterly broken and used old versions of most > dependencies, leading to problems with packaging, making me put the plotters > 0.3 update on the back burner. I did not detect any issue installing with fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1969450] Review Request: cockpit-certificates - Cockpit user interface for certificates
https://bugzilla.redhat.com/show_bug.cgi?id=1969450
--- Comment #3 from Robert-André Mauchin 🐧 ---
(In reply to Katerina Koukiou from comment #2)
> (In reply to Robert-André Mauchin 🐧 from comment #1)
> > - the git info version should only be in Releases not Version;
> >
> > Version:1.5
> >
> > - Where does the 1.5 come from? I only see 1 in the tagged releases.
>
> Fixed upstream with
> https://github.com/skobyda/cockpit-certificates/pull/56/commits/
> 93e2b4196f840bdc89e2a6ffc0c627f544f3c8b8
>
> >
> > - The Release tag is weird, it should be something like;
> >
> > Release:1.20210608gitgccba50c%{?dist}
>
> This was just added by packit [1] because the build was generated from a PR,
> not a real release
>
> Release: 1%{?dist}
>
> is the original:
> https://github.com/skobyda/cockpit-certificates/blob/master/cockpit-
> certificates.spec.in#L3
>
> >
> > - This should either be a URL, or you should add a comment explaining how
> > the tarball was generated;
> >
> > Source0:cockpit-certificates-1.5.gccba50c.tar.gz
>
> I use packit [1] which creates a COPR build for each PR. To create the
> tarball packit runs the command as specified in the configuration file here:
> https://github.com/skobyda/cockpit-certificates/blob/master/packit.yml#L11
>
> `make dist-gzip`
>
> Running this command will generate the above tarball.
Add the command as a comment above the archive.
>
> The original cockpit-certificates.spec.in has the link to the github release
> artifact as seen here:
> https://github.com/skobyda/cockpit-certificates/blob/master/cockpit-
> certificates.spec.in#L8
>
> [1] https://packit.dev/
>
> >
> > - You can't ship the js already minified, you must provide the unminified
> > versions and then minify them in the build section
> >
> > See
> > https://docs.fedoraproject.org/en-US/packaging-guidelines/JavaScript/
> > #_compilationminification
> >
>
> That will not work. Building requires internet access, npm install, etc.,
> which is not allowed in package builds.
> (note that we do the same in cockpit, cockpit-ostree, cockpit-podman,
> cockpit-machines, see for example
> https://src.fedoraproject.org/rpms/cockpit-machines/blob/rawhide/f/cockpit-
> machines.spec)
>
That's why you predownload the node_modules amd cockpit lib in separate
archives as shown in the SPEC file I provided you. The build script must be run
within the SPEC.
> Also, keep in mind cockpit-* packages are not JS libs for other packages to
> consume, rather JS apps.
>
> > - The license field should represent all the bundled JS too
> >
> > - BuildRequires: libappstream-glib is included twice
> >
>
> Fixed upstream:
> https://github.com/skobyda/cockpit-certificates/pull/56/commits/
> b694e7562627474c6a39b3d75e120a9d28a717fa
>
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1972307] New: Review Request: golang-github-rjeczalik-notify - File system event notification library
https://bugzilla.redhat.com/show_bug.cgi?id=1972307 Bug ID: 1972307 Summary: Review Request: golang-github-rjeczalik-notify - File system event notification library Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: l...@sub-pop.net QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/linkdupont/yggdrasil/fedora-34-x86_64/02254295-golang-github-rjeczalik-notify/golang-github-rjeczalik-notify.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/linkdupont/yggdrasil/fedora-34-x86_64/02254295-golang-github-rjeczalik-notify/golang-github-rjeczalik-notify-0.9.2-1.20210615gite2a77dc.fc34.src.rpm Description: Notify is a high-level abstraction over filesystem watchers like inotify, kqueue, FSEvents, FEN or ReadDirectoryChangesW. Fedora Account System Username: linkdupont -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1971386] Review Request: tini - A tiny but valid init for containers
https://bugzilla.redhat.com/show_bug.cgi?id=1971386 Davide Cavalca changed: What|Removed |Added Status|POST|MODIFIED Fixed In Version||tini-0.19.0-1.fc35 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1972301] New: Review Request: golang-sr-spc-log - simple level log package
https://bugzilla.redhat.com/show_bug.cgi?id=1972301 Bug ID: 1972301 Summary: Review Request: golang-sr-spc-log - simple level log package Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: l...@sub-pop.net QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/linkdupont/yggdrasil/fedora-34-x86_64/02250989-golang-sr-spc-log/golang-sr-spc-log.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/linkdupont/yggdrasil/fedora-34-x86_64/02250989-golang-sr-spc-log/golang-sr-spc-log-0.1.0-1.fc34.src.rpm Description: Package log implements a simple level logging package that maintains API compatibility with the standard library log package. It extends the standard library log.Logger type with a Level type that can be used to define output verbosity. It adds additional methods that will be printed only if the logger is configured at or below a given level. Fedora Account System Username: linkdupont -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1916041] Review Request: rubygem-xmlrpc - XMLRPC is a lightweight protocol that enables remote procedure calls over HTTP
https://bugzilla.redhat.com/show_bug.cgi?id=1916041 Pavel Valena changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2021-06-15 12:40:56 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1971212] Review Request: mingw-sdl12-compat - MinGW Windows port of SDL 1.2 runtime compatibility library using SDL 2.0
https://bugzilla.redhat.com/show_bug.cgi?id=1971212 Neal Gompa changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||mingw-sdl12-compat-0.0.1~gi ||t.20210612.44f299f-1.fc35 Resolution|--- |RAWHIDE Last Closed||2021-06-15 12:17:47 --- Comment #3 from Neal Gompa --- Built in Rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1771969 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1971212] Review Request: mingw-sdl12-compat - MinGW Windows port of SDL 1.2 runtime compatibility library using SDL 2.0
https://bugzilla.redhat.com/show_bug.cgi?id=1971212 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-sdl12-compat -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1971386] Review Request: tini - A tiny but valid init for containers
https://bugzilla.redhat.com/show_bug.cgi?id=1971386 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/tini -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1971394] Review Request: x11docker - Run GUI applications and desktops in Linux containers
https://bugzilla.redhat.com/show_bug.cgi?id=1971394 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/x11docker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1916041] Review Request: rubygem-xmlrpc - XMLRPC is a lightweight protocol that enables remote procedure calls over HTTP
https://bugzilla.redhat.com/show_bug.cgi?id=1916041 Pavel Valena changed: What|Removed |Added Status|POST|MODIFIED Fixed In Version||rubygem-xmlrpc-0.3.2-1.fc35 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1972159] Review Request: rust-witx - Parse and validate witx file format
https://bugzilla.redhat.com/show_bug.cgi?id=1972159 Olivier Lemasle changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1 from Olivier Lemasle --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=70156342 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1972159] New: Review Request: rust-witx - Parse and validate witx file format
https://bugzilla.redhat.com/show_bug.cgi?id=1972159 Bug ID: 1972159 Summary: Review Request: rust-witx - Parse and validate witx file format Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: o.lema...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://olem.fedorapeople.org/reviews/rust-witx.spec SRPM URL: https://olem.fedorapeople.org/reviews/rust-witx-0.9.0-1.fc34.src.rpm Description: Parse and validate witx file format. Fedora Account System Username: olem -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1909380] Review Request: fierce - DNS reconnaissance tool
https://bugzilla.redhat.com/show_bug.cgi?id=1909380 Petr Menšík changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|pemen...@redhat.com Flags||needinfo?(mail@fabian-affol ||ter.ch) --- Comment #2 from Petr Menšík --- It requires just disabling test_recursive_query* tests during testing, because /etc/resolv.conf does not exist in mock environment. I were able to mockbuild it with simple change: --- ../srpm/fierce.spec 2021-06-15 11:52:22.996270762 +0200 +++ ../srpm-unpacked/fierce.spec2021-06-15 12:15:57.750292818 +0200 @@ -33,10 +33,11 @@ %py3_install %check -# Assertions are made for the pathes and requires an exisiting /etc/resolv.conf +# Assertions are made for the pathes %pytest -v tests -k "not test_parse_args_included_list_file and not test_parse_args_missing_list_file \ and not test_update_resolver and not test_query_no_nameservers and not test_query_nxdomain \ - and not test_query_timeout" + and not test_query_timeout and not test_recursive_query_basic_failure and not test_recursive_query_basic_success \ + and not test_recursive_query_long_domain_failure" %files %license LICENSE Then just "fedpkg --release rawhide mockbuild" in srpm-unpacked directory. If you are still looking for a package, can you update spec to compile also in mock? An alternative would be skipping the test in case dns.resolver.NoResolverConfiguration exception were raised. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1969450] Review Request: cockpit-certificates - Cockpit user interface for certificates
https://bugzilla.redhat.com/show_bug.cgi?id=1969450
--- Comment #2 from Katerina Koukiou ---
(In reply to Robert-André Mauchin 🐧 from comment #1)
> - the git info version should only be in Releases not Version;
>
> Version:1.5
>
> - Where does the 1.5 come from? I only see 1 in the tagged releases.
Fixed upstream with
https://github.com/skobyda/cockpit-certificates/pull/56/commits/93e2b4196f840bdc89e2a6ffc0c627f544f3c8b8
>
> - The Release tag is weird, it should be something like;
>
> Release:1.20210608gitgccba50c%{?dist}
This was just added by packit [1] because the build was generated from a PR,
not a real release
Release: 1%{?dist}
is the original:
https://github.com/skobyda/cockpit-certificates/blob/master/cockpit-certificates.spec.in#L3
>
> - This should either be a URL, or you should add a comment explaining how
> the tarball was generated;
>
> Source0:cockpit-certificates-1.5.gccba50c.tar.gz
I use packit [1] which creates a COPR build for each PR. To create the tarball
packit runs the command as specified in the configuration file here:
https://github.com/skobyda/cockpit-certificates/blob/master/packit.yml#L11
`make dist-gzip`
Running this command will generate the above tarball.
The original cockpit-certificates.spec.in has the link to the github release
artifact as seen here:
https://github.com/skobyda/cockpit-certificates/blob/master/cockpit-certificates.spec.in#L8
[1] https://packit.dev/
>
> - You can't ship the js already minified, you must provide the unminified
> versions and then minify them in the build section
>
> See
> https://docs.fedoraproject.org/en-US/packaging-guidelines/JavaScript/
> #_compilationminification
>
That will not work. Building requires internet access, npm install, etc., which
is not allowed in package builds.
(note that we do the same in cockpit, cockpit-ostree, cockpit-podman,
cockpit-machines, see for example
https://src.fedoraproject.org/rpms/cockpit-machines/blob/rawhide/f/cockpit-machines.spec)
Also, keep in mind cockpit-* packages are not JS libs for other packages to
consume, rather JS apps.
> - The license field should represent all the bundled JS too
>
> - BuildRequires: libappstream-glib is included twice
>
Fixed upstream:
https://github.com/skobyda/cockpit-certificates/pull/56/commits/b694e7562627474c6a39b3d75e120a9d28a717fa
>
> Here is my spec proposal to address the minify issue:
>
> =
> =
> %global commit ebd19355d3dca00f49f2def2f2e573fc50db0d99
> %global shortcommit %(c=%{commit}; echo ${c:0:7})
> %global snapshotdate20210611
>
> Name: cockpit-certificates
> Version:1.5
> Release:1.%{snapshotdate}git%{shortcommit}%{?dist}
> Summary:Cockpit user interface for certificates
> License:0BSD and AFL and ASL 2.0 and BSD and CC0 and CC-BY and ISC
> and LGPLv2+ and MIT and Unlicense
> URL:https://github.com/skobyda/cockpit-certificates
>
> Source0:%url/archive/%{commit}/%{name}-%{shortcommit}.tar.gz
> Source1:cockpit-lib.tar.gz
> Source2:%{name}-%{version}-nm.tgz
> Source3:%{name}-%{version}-bundled-licenses.txt
> Source10: get-cockpit-lib.sh
> Source11: packages-bundler.sh
>
> BuildArch: noarch
> BuildRequires: libappstream-glib
> BuildRequires: nodejs-devel
> BuildRequires: sassc
>
> Requires: cockpit-bridge
> Requires: certmonger
>
> %description
> Cockpit component for managing certificates with certmonger.
>
> %prep
> %setup -q -a 1 -n %{name}-%{commit}
> cp %{S:2} %{S:3} .
>
> %build
> tar xfz %{SOURCE2}
> ./node_modules/.bin/webpack-cli
>
> %install
> mkdir -p %{buildroot}%{_datadir}/cockpit/%{name}
> cp -a dist/* %{buildroot}%{_datadir}/cockpit/%{name}/
> mkdir -p %{buildroot}%{_metainfodir}
> cp -a org.cockpit-project.certificates.metainfo.xml
> %{buildroot}%{_metainfodir}/
> appstream-util validate-relax --nonet
> %{buildroot}%{_metainfodir}/org.cockpit-project.certificates.metainfo.xml
>
> %files
> %doc README.md
> %license LICENSE %{name}-%{version}-bundled-licenses.txt
> %{_datadir}/cockpit/%{name}/
> %{_datadir}/metainfo/org.cockpit-project.certificates.metainfo.xml
>
> # The changelog is automatically generated and merged
> %changelog
> =
> =
>
> SPEC:
> https://eclipseo.fedorapeople.org/cockpit-certificates/cockpit-certificates.
> spec
> SRPM:
> https://eclipseo.fedorapeople.org/cockpit-certificates/cockpit-certificates-
> 1.5-1.20210611gitebd1935.fc35.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fe
[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM
https://bugzilla.redhat.com/show_bug.cgi?id=1558683 --- Comment #38 from Alfredo Moralejo --- I think this package si not longer needed and this bz can be closed? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1853081] Review Request: mlxbf-bfscripts - Helper scripts for Mellanox BlueField systems
https://bugzilla.redhat.com/show_bug.cgi?id=1853081 Alaa Hleihel (NVIDIA Mellanox) changed: What|Removed |Added Blocks||1858600 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
