[Bug 1968733] Review Request: rust-imgui-sys - Raw FFI bindings to dear imgui
https://bugzilla.redhat.com/show_bug.cgi?id=1968733 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #5 from Fedora Update System --- FEDORA-2021-97a81ff9b8 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-97a81ff9b8 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-97a81ff9b8 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1965791] Review Request: virt-lightning - Deploy your testing VM in a couple of seconds
https://bugzilla.redhat.com/show_bug.cgi?id=1965791 --- Comment #12 from Fedora Update System --- FEDORA-2021-2ee866f7a7 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1965791] Review Request: virt-lightning - Deploy your testing VM in a couple of seconds
https://bugzilla.redhat.com/show_bug.cgi?id=1965791 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2021-06-21 00:53:50 --- Comment #11 from Fedora Update System --- FEDORA-2021-18732d0105 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1974148] Review Request: golang-github-xaionaro-metrics - An implementation of fast metrics for high-load-ed services on Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1974148 Davide Cavalca changed: What|Removed |Added Blocks||1974151 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1974151 [Bug 1974151] Review Request: golang-github-facebookincubator-contest - Run continuous and on-demand system testing for real and virtual hardware -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1973706] Review Request: golang-github-pressly-goose - Goose database migration tool
https://bugzilla.redhat.com/show_bug.cgi?id=1973706 Davide Cavalca changed: What|Removed |Added Blocks||1974151 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1974151 [Bug 1974151] Review Request: golang-github-facebookincubator-contest - Run continuous and on-demand system testing for real and virtual hardware -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1974151] Review Request: golang-github-facebookincubator-contest - Run continuous and on-demand system testing for real and virtual hardware
https://bugzilla.redhat.com/show_bug.cgi?id=1974151 Davide Cavalca changed: What|Removed |Added Depends On||1973706, 1973520, 1974148 Doc Type|--- |If docs needed, set a value --- Comment #1 from Davide Cavalca --- This depends on https://src.fedoraproject.org/rpms/golang-github-spf13-pflag/pull-request/3 as well Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1973520 [Bug 1973520] Review Request: golang-github-chappjc-logrus-prefix - Logrus Prefixed Log Formatter https://bugzilla.redhat.com/show_bug.cgi?id=1973706 [Bug 1973706] Review Request: golang-github-pressly-goose - Goose database migration tool https://bugzilla.redhat.com/show_bug.cgi?id=1974148 [Bug 1974148] Review Request: golang-github-xaionaro-metrics - An implementation of fast metrics for high-load-ed services on Golang -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1973520] Review Request: golang-github-chappjc-logrus-prefix - Logrus Prefixed Log Formatter
https://bugzilla.redhat.com/show_bug.cgi?id=1973520 Davide Cavalca changed: What|Removed |Added Blocks||1974151 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1974151 [Bug 1974151] Review Request: golang-github-facebookincubator-contest - Run continuous and on-demand system testing for real and virtual hardware -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1974151] New: Review Request: golang-github-facebookincubator-contest - Run continuous and on-demand system testing for real and virtual hardware
https://bugzilla.redhat.com/show_bug.cgi?id=1974151 Bug ID: 1974151 Summary: Review Request: golang-github-facebookincubator-contest - Run continuous and on-demand system testing for real and virtual hardware Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: dcava...@fb.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-facebookincubator-contest/golang-github-facebookincubator-contest.spec SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-facebookincubator-contest/golang-github-facebookincubator-contest-0-0.1.20210618gitceebc35.fc35.src.rpm Description: Run continuous and on-demand system testing for real and virtual hardware. Fedora Account System Username: dcavalca -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1973706] Review Request: golang-github-pressly-goose - Goose database migration tool
https://bugzilla.redhat.com/show_bug.cgi?id=1973706 Davide Cavalca changed: What|Removed |Added Summary|Review Request: |Review Request: |golang-github-pressly-goose |golang-github-pressly-goose |- Goose database migration |- Goose database migration |tool - fork of |tool |https://bitbucket.org/liams | |task/goose | Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1974148] Review Request: golang-github-xaionaro-metrics - An implementation of fast metrics for high-load-ed services on Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1974148 Davide Cavalca changed: What|Removed |Added Depends On||1973762, 1973778 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1973762 [Bug 1973762] Review Request: golang-github-xaionaro-atomicmap - High performance thread-safe implementation of hash map for Go https://bugzilla.redhat.com/show_bug.cgi?id=1973778 [Bug 1973778] Review Request: golang-github-trafficstars-metrics - An implementation of fast metrics for high-load-ed services on Golang -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1973778] Review Request: golang-github-trafficstars-metrics - An implementation of fast metrics for high-load-ed services on Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1973778 Davide Cavalca changed: What|Removed |Added Blocks||1974148 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1974148 [Bug 1974148] Review Request: golang-github-xaionaro-metrics - An implementation of fast metrics for high-load-ed services on Golang -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1973762] Review Request: golang-github-xaionaro-atomicmap - High performance thread-safe implementation of hash map for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1973762 Davide Cavalca changed: What|Removed |Added Blocks||1974148 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1974148 [Bug 1974148] Review Request: golang-github-xaionaro-metrics - An implementation of fast metrics for high-load-ed services on Golang -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1974148] New: Review Request: golang-github-xaionaro-metrics - An implementation of fast metrics for high-load-ed services on Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1974148 Bug ID: 1974148 Summary: Review Request: golang-github-xaionaro-metrics - An implementation of fast metrics for high-load-ed services on Golang Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: dcava...@fb.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-xaionaro-metrics/golang-github-xaionaro-metrics.spec SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-xaionaro-metrics/golang-github-xaionaro-metrics-0-0.1.20210620git68050b3.fc35.src.rpm Description: An implementation of fast metrics for high-load-ed services on Golang. Fedora Account System Username: dcavalca -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1973778] Review Request: golang-github-trafficstars-metrics - An implementation of fast metrics for high-load-ed services on Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1973778 --- Comment #2 from Davide Cavalca --- Sorry, I got this mixed up with another package. Let's try again. Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-trafficstars-metrics/golang-github-trafficstars-metrics.spec SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-trafficstars-metrics/golang-github-trafficstars-metrics-0-0.2.20210620git0250d8a.fc35.src.rpm Changelog: - Drop no longer needed ExcludeArch for i686 and armv7hl -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1973762] Review Request: golang-github-xaionaro-atomicmap - High performance thread-safe implementation of hash map for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1973762 --- Comment #3 from Davide Cavalca --- Sorry, I got this mixed up with another package. Let's try again. Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-xaionaro-atomicmap/golang-github-xaionaro-atomicmap.spec SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-xaionaro-atomicmap/golang-github-xaionaro-atomicmap-0-0.1.20210620git96a7f1f.fc35.src.rpm Changelog: - Bump to 96a7f1f95a7093253c3ca2a9dad34e56b63ea6a2 - Drop ExcludeArch for i686 and armv7hl as all tests are now passing -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1973762] Review Request: golang-github-xaionaro-atomicmap - High performance thread-safe implementation of hash map for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1973762 Davide Cavalca changed: What|Removed |Added Summary|Review Request: |Review Request: |golang-github-xaionaro-atom |golang-github-xaionaro-atom |icmap - A high performance |icmap - High performance |thread-safe implementation |thread-safe implementation |of hash map for Golang |of hash map for Go |(accent on high throughput, | |not at latency) | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1973762] Review Request: golang-github-xaionaro-atomicmap - A high performance thread-safe implementation of hash map for Golang (accent on high throughput, not at latency)
https://bugzilla.redhat.com/show_bug.cgi?id=1973762 Davide Cavalca changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #2 from Davide Cavalca --- Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-trafficstars-metrics/golang-github-trafficstars-metrics.spec SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-trafficstars-metrics/golang-github-xaionaro-atomicmap-0-0.1.20210620git96a7f1f.fc35.src.rpm Changelog: - Bump to 96a7f1f95a7093253c3ca2a9dad34e56b63ea6a2 - Drop ExcludeArch for i686 and armv7hl as all tests are now passing -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1973778] Review Request: golang-github-trafficstars-metrics - An implementation of fast metrics for high-load-ed services on Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1973778 --- Comment #1 from Davide Cavalca --- Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-trafficstars-metrics/golang-github-trafficstars-metrics.spec SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-trafficstars-metrics/golang-github-xaionaro-atomicmap-0-0.1.20210620git96a7f1f.fc35.src.rpm Changelog: - Bump to 96a7f1f95a7093253c3ca2a9dad34e56b63ea6a2 - Drop ExcludeArch for i686 and armv7hl as all tests are now passing -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1973733] Review Request: python-dbutils - tools providing solid, persistent and pooled connections
https://bugzilla.redhat.com/show_bug.cgi?id=1973733
Arthur Bols changed:
What|Removed |Added
CC||art...@bols.dev
--- Comment #2 from Arthur Bols ---
Note: This is a preliminary (unofficial) review!
Hello Pat,
I'm not a packager, but like to help out. Please remember that this is a
preliminary (unofficial) review.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- The description contains too long lines, please make sure that there are no
lines longer than 80 characters.
- Line 28 contains tabs instead of spaces.
- Please use the %py_provides macro for the "python3-DBUtils" provides. Please
see:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_py_provides_macro
Remarks:
- On lines 26-27 you've shortened the comment, maybe write it out in full?
It's just a small nitpick, that's why I put it here.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[!]: Package meets the Packaging Guidelines::Python
See the %py_provides issue above.
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requi
[Bug 1974115] Review Request: golang-github-google-goterm - Go Terminal library with PTY support and colors
https://bugzilla.redhat.com/show_bug.cgi?id=1974115 Davide Cavalca changed: What|Removed |Added Blocks||1974119 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1974119 [Bug 1974119] Review Request: golang-github-google-goexpect - Expect for Go -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1974119] Review Request: golang-github-google-goexpect - Expect for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1974119 Davide Cavalca changed: What|Removed |Added Depends On||1974115, 1973969 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1973969 [Bug 1973969] Review Request: golang-github-ziutek-telnet - Package to handle a telnet connection https://bugzilla.redhat.com/show_bug.cgi?id=1974115 [Bug 1974115] Review Request: golang-github-google-goterm - Go Terminal library with PTY support and colors -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1973969] Review Request: golang-github-ziutek-telnet - Package to handle a telnet connection
https://bugzilla.redhat.com/show_bug.cgi?id=1973969 Davide Cavalca changed: What|Removed |Added Blocks||1974119 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1974119 [Bug 1974119] Review Request: golang-github-google-goexpect - Expect for Go -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1974119] New: Review Request: golang-github-google-goexpect - Expect for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1974119 Bug ID: 1974119 Summary: Review Request: golang-github-google-goexpect - Expect for Go Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: dcava...@fb.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-google-goexpect/golang-github-google-goexpect.spec SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-google-goexpect/golang-github-google-goexpect-0-0.1.20210619gitab937bf.fc35.src.rpm Description: Expect for Go. Fedora Account System Username: dcavalca -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1973680] Review Request: python-stopit - Raise asynchronous exceptions in other threads and more
https://bugzilla.redhat.com/show_bug.cgi?id=1973680 Ben Beasley changed: What|Removed |Added CC||c...@musicinmybrain.net Assignee|nob...@fedoraproject.org|c...@musicinmybrain.net Flags||fedora-review? ||needinfo?(code@musicinmybra ||in.net) --- Comment #4 from Ben Beasley --- Thanks for the preliminary review and helpful feedback, Arthur! I’m claiming the review and will go through the details within the next day or so (hopefully sooner). The handling of the license situation looks good; the PR was the right thing to do, and both the LICENSE file and README.rst say MIT which supports GPLv3 in setup.py being a copy-paste error. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1974118] New: Review Request: python-typer-cli - Run Typer scripts with completion, without creating a package
https://bugzilla.redhat.com/show_bug.cgi?id=1974118 Bug ID: 1974118 Summary: Review Request: python-typer-cli - Run Typer scripts with completion, without creating a package Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: c...@musicinmybrain.net QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://music.fedorapeople.org/python-typer-cli.spec SRPM URL: https://music.fedorapeople.org/python-typer-cli-0.0.11-1.fc34.src.rpm Description: Run Typer scripts with completion, without having to create a package, using Typer CLI. There is an optional utility tool called Typer CLI, additional to Typer itself. Its main feature is to provide ✨ completion ✨ in the Terminal for your own small programs built with Typer. …without you having to create a complete installable Python package. It’s probably most useful if you have a small custom Python script using Typer (maybe as part of some project), for some small tasks, and it’s not complex/important enough to create a whole installable Python package for it (something to be installed with pip). In that case, you can install Typer CLI, and run your program with the typer command in your Terminal, and it will provide completion for your script. You can also use Typer CLI to generate Markdown documentation for your own Typer programs 📝. Documentation: https://typer.tiangolo.com/typer-cli/ Source Code for Typer CLI: https://github.com/tiangolo/typer-cli Fedora Account System Username: music Koji scratch builds: F35: https://koji.fedoraproject.org/koji/taskinfo?taskID=70493695 (F34 and F33 are planned after dependency python-typer reaches stable there.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1974115] New: Review Request: golang-github-google-goterm - Go Terminal library with PTY support and colors
https://bugzilla.redhat.com/show_bug.cgi?id=1974115 Bug ID: 1974115 Summary: Review Request: golang-github-google-goterm - Go Terminal library with PTY support and colors Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: dcava...@fb.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-google-goterm/golang-github-google-goterm.spec SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-google-goterm/golang-github-google-goterm-0-0.1.20210619git555d40f.fc35.src.rpm Description: Go Terminal library with PTY support and colors. Fedora Account System Username: dcavalca -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1974114] Review Request: python-environs - Python library for parsing environment variables
https://bugzilla.redhat.com/show_bug.cgi?id=1974114 Antonio T. sagitter changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1 from Antonio T. sagitter --- Build log: https://download.copr.fedorainfracloud.org/results/sagitter/ForTesting/fedora-rawhide-x86_64/02265920-python-environs/build.log.gz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1974114] New: Review Request: python-environs - Python library for parsing environment variables
https://bugzilla.redhat.com/show_bug.cgi?id=1974114 Bug ID: 1974114 Summary: Review Request: python-environs - Python library for parsing environment variables Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: trp...@rocketmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/sagitter/ForTesting/fedora-rawhide-x86_64/02265920-python-environs/python-environs.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/sagitter/ForTesting/fedora-rawhide-x86_64/02265920-python-environs/python-environs-9.3.2-1.fc35.src.rpm Description: Environs is Python library for parsing environment variables. It allows you to store configuration separate from your code. Fedora Account System Username: sagitter -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1974112] New: Review Request: golang-github-google-tpm - Go library that communicates directly with a TPM device
https://bugzilla.redhat.com/show_bug.cgi?id=1974112 Bug ID: 1974112 Summary: Review Request: golang-github-google-tpm - Go library that communicates directly with a TPM device Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: dcava...@fb.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-google-tpm/golang-github-google-tpm.spec SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-google-tpm/golang-github-google-tpm-0.3.2-1.fc35.src.rpm Description: Go-TPM is a Go library that communicates directly with a TPM device. The libraries don't implement the entire spec for neither 1.2 nor 2.0. Fedora Account System Username: dcavalca -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1974112] Review Request: golang-github-google-tpm - Go library that communicates directly with a TPM device
https://bugzilla.redhat.com/show_bug.cgi?id=1974112 --- Comment #1 from Davide Cavalca --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=70491731 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1507327] Review Request: mod_security3 - ModSecurity v3 Apache Connector
https://bugzilla.redhat.com/show_bug.cgi?id=1507327 --- Comment #9 from Othman Madjoudj --- (In reply to Mattia Verga from comment #8) > I previously didn't look throughly and I'm a bit confused here: this review > is for package 'mod_security3' and the repo 'mod_security3' was created, but > the latest spec file you uploaded in this review is named 'libmodsecurity', > which seems to exist in Fedora repositories and at a first glance it seems > the same as this one... Starting from mod_security v3, upstream split the core filtering library from the Apache module, so it can be used with different webservers (right now Microsoft IIS and Nginx are supported). libmodsecurity is already pushed in Fedora and EPEL long time ago, this review is for mod_security3 which itself depends on libmodsecurity, at the time of the review it was still in beta/RC. I hope that clears up the confusion. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1973682] Review Request: jsonnet - A data templating language
https://bugzilla.redhat.com/show_bug.cgi?id=1973682
Ben Beasley changed:
What|Removed |Added
Flags|needinfo?(code@musicinmybra |needinfo?(riehe...@fnal.gov
|in.net) |)
--- Comment #3 from Ben Beasley ---
This fails to build on either x86_64 or aarch64 for me, so here are some
initial comments without the aid of fedora-review (and without digging into the
source tree for now). The first is the cause of the build failure.
= Issues =
- It’s my understanding that the *-static virtual Provides for header-only
libraries
(https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries)
should not be arched. Some packages providing them unfortunately violate this,
which can lead to occasional build failures, but “json” is not one of them.
Please change
> BuildRequires: json-devel json-static%{?_isa}
to
> BuildRequires: json-devel json-static
to resolve this.
- Please explain/justify the makefile patch in a spec file comment, and either
indicate that it is not suitable for upstream, or point out that you have
offered it upstream. See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_all_patches_should_have_an_upstream_bug_link_or_comment.
- I don’t think you should add -std=c++0x to the build flags unless it’s
entirely unavoidable. See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags. You
should try to build the C++ code with the same C++ standard that is the default
for g++ in Fedora—I think this is currently equivalent to gnu++17.
Consider that there is no ABI compatibility across different C++ standards,
so when library packages in Fedora use different C++ flags from the
distribution defaults, dependent packages can fail to link or, worse, crash at
runtime.
- The License field is incorrect; you must use one of the short identifiers
from
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses.
“Apache License 2.0” is written as “ASL 2.0”.
The “very permissive license” on the MD5 implementation has a name; it is the
RSA license. It is approved for Fedora
(https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses,
https://fedoraproject.org/wiki/Licensing/RSA).
Since it’s not clear to me that the terms of the RSA license are encompassed
by the Apache license, I think it should be included in the License field. See
https://fedoraproject.org/wiki/Licensing:FAQ#What_is_.22effective_license.22_and_do_I_need_to_know_that_for_the_License:_tag.3F
and
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios.
I think the License field should look like this.
> # The entire source is ASL 2.0 except third_party/md5/, which is RSA
> License:ASL 2.0 and RSA
- This
> %{__make} install DESTDIR=%{buildroot} PREFIX=%{_prefix}
should be written as
> %{make_install} PREFIX=%{_prefix}
Importantly, the macro sets INSTALL="%{_bindir}/install -p" so that file
mtimes are preserved.
- You should include the shared library SONAME version in the file globs so you
do not roll an update with an soversion bump by accident. (For Rawhide, these
updates require advance notification and should include rebuilds of any
dependent packages in a side
tag—https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/#_rawhide. For
stable releases, these updates are allowed only in exceptional circumstances.)
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files,
and https://src.fedoraproject.org/rpms/libpri/blob/rawhide/f/libpri.spec for an
example. (You don’t have to put the soversion in a macro, but I find it
convenient.)
- The -devel package correctly requires the base package with a fully-versioned
dependency,
> Requires: %{srcname} = %{version}-%{release}
but this should be arched as well:
> Requires: %{srcname}%{?_isa} = %{version}-%{release}
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package.
- You can drop
> %license LICENSE
from the %files section for the -devel package since it requires the base
package, so the LICENSE file will always be installed. See
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#subpackage-licensing.
- Assuming the tests do not have parallel-make bugs, you can and should write
> %{__make} test
as
> %{make_build} test
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of
[Bug 1507327] Review Request: mod_security3 - ModSecurity v3 Apache Connector
https://bugzilla.redhat.com/show_bug.cgi?id=1507327 --- Comment #8 from Mattia Verga --- I previously didn't look throughly and I'm a bit confused here: this review is for package 'mod_security3' and the repo 'mod_security3' was created, but the latest spec file you uploaded in this review is named 'libmodsecurity', which seems to exist in Fedora repositories and at a first glance it seems the same as this one... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1973680] Review Request: python-stopit - Raise asynchronous exceptions in other threads and more
https://bugzilla.redhat.com/show_bug.cgi?id=1973680 --- Comment #3 from Arthur Bols --- Note: This is a preliminary (unofficial) review! Thank you for the update! The description looks better now. The list seems a bit redundant now, but changing the '>' to '*' also looks better, so It's fine for me. I think the package can be approved. I'd love to help out, I'll stop by. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1507327] Review Request: mod_security3 - ModSecurity v3 Apache Connector
https://bugzilla.redhat.com/show_bug.cgi?id=1507327 Othman Madjoudj changed: What|Removed |Added Flags|needinfo?(athma...@gmail.co | |m) | --- Comment #7 from Othman Madjoudj --- (In reply to Mattia Verga from comment #6) > This package was never imported, but the repo was created... Othman, do you > want to push it to the repos, or should we properly retire the package? Yes, I'm planning to import it on the current Fedora Rawhide and EPEL8 if possible, and retire mod_sec2 and leave it only on the old branches. Initially, I thought it was easy to share the rules and keep both of them in parallel, afterward I realized that the format of the rules is not grantee to be compatible with the old mod_sec2 ie. to keep mod_sec2 one needs to keep the old rules as well. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1973680] Review Request: python-stopit - Raise asynchronous exceptions in other threads and more
https://bugzilla.redhat.com/show_bug.cgi?id=1973680 --- Comment #2 from Aniket Pradhan --- Hey Arthur! Thanks for the review and your suggestions are really helpful. * I have fixed the license in setup.py using sed. Hopefully, upstream would patch the issue soon. * rpmlint only reports spelling errors. I think it should be fine. * Added the paragraph to the description. Since the description can span multiple lines and can be broken into paragraphs, I think the list should be fine. * The find command is from a generic spec file that I keep. It basically removes the unnecessary shebangs from files. Although it might not be required here, I usually prefer it to remain in the spec so that no such shebangs come in place in case of an update. Thanks for the preliminary review. Please do let me know if any other information is required. Also, in case you are interested in packaging, do check out our channel #fedora-neuro or https://neuro.fedoraproject.org/ as we could definitely use your help :D -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
