[Bug 1975619] New: Review Request: rust-smallstr - String-like container based on smallvec
https://bugzilla.redhat.com/show_bug.cgi?id=1975619 Bug ID: 1975619 Summary: Review Request: rust-smallstr - String-like container based on smallvec Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: dcava...@fb.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://dcavalca.fedorapeople.org/review/rust-smallstr/rust-smallstr.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-smallstr/rust-smallstr-0.2.0-1.fc35.src.rpm Description: String-like container based on smallvec. Fedora Account System Username: dcavalca -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1975615] New: Review Request: rust-macroquad_macro - Proc macro for macroquad
https://bugzilla.redhat.com/show_bug.cgi?id=1975615 Bug ID: 1975615 Summary: Review Request: rust-macroquad_macro - Proc macro for macroquad Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: remilauz...@protonmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/remilauzier/zemeroth/fedora-rawhide-x86_64/02296566-rust-macroquad_macro/rust-macroquad_macro.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/remilauzier/zemeroth/fedora-rawhide-x86_64/02296566-rust-macroquad_macro/rust-macroquad_macro-0.1.5-1.fc35.src.rpm Description: Proc macro for macroquad Fedora Account System Username: remilauzier -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1975602] Review Request: rust-rental-impl - An implementation detail of rental
https://bugzilla.redhat.com/show_bug.cgi?id=1975602 Rémi Lauzier changed: What|Removed |Added Blocks||1975612 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1975612 [Bug 1975612] Review Request: rust-rental - A macro to generate safe self-referential structs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1975612] Review Request: rust-rental - A macro to generate safe self-referential structs
https://bugzilla.redhat.com/show_bug.cgi?id=1975612 Rémi Lauzier changed: What|Removed |Added CC||remilauz...@protonmail.com Depends On||1975602 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1975602 [Bug 1975602] Review Request: rust-rental-impl - An implementation detail of rental -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1975612] New: Review Request: rust-rental - A macro to generate safe self-referential structs
https://bugzilla.redhat.com/show_bug.cgi?id=1975612 Bug ID: 1975612 Summary: Review Request: rust-rental - A macro to generate safe self-referential structs Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: remilauz...@protonmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/remilauzier/rust-simp/fedora-rawhide-x86_64/02296551-rust-rental/rust-rental.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/remilauzier/rust-simp/fedora-rawhide-x86_64/02296551-rust-rental/rust-rental-0.5.6-1.fc35.src.rpm Description: A macro to generate safe self-referential structs Fedora Account System Username: remilauzier -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1974787] Review Request: python-apt - Python bindings for APT
https://bugzilla.redhat.com/show_bug.cgi?id=1974787
--- Comment #1 from Carl George 🤠 ---
The python_provide macros should be removed, as it's deprecated. The provides
for python-apt happens automatically in Fedora, and isn't applicable to EPEL8.
-%{?python_provide:%python_provide python3-apt}
There are tests upstream, please add a %check section and run the tests.
There is a shebang in /usr/lib64/python3.10/site-packages/apt/auth.py that is
causing a non-executable-script rpmlint error.
There are lots of rpmlint incorrect-fsf-address errors, please work with the
upstream to fix those (not a blocker).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1975602] New: Review Request: rust-rental-impl - An implementation detail of rental
https://bugzilla.redhat.com/show_bug.cgi?id=1975602 Bug ID: 1975602 Summary: Review Request: rust-rental-impl - An implementation detail of rental Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: remilauz...@protonmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/remilauzier/rust-simp/fedora-rawhide-x86_64/02296502-rust-rental-impl/rust-rental-impl.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/remilauzier/rust-simp/fedora-rawhide-x86_64/02296502-rust-rental-impl/rust-rental-impl-0.5.5-1.fc35.src.rpm Description: An implementation detail of rental Fedora Account System Username: remilauzier -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1974787] Review Request: python-apt - Python bindings for APT
https://bugzilla.redhat.com/show_bug.cgi?id=1974787 Carl George 🤠 changed: What|Removed |Added CC||c...@redhat.com Assignee|nob...@fedoraproject.org|c...@redhat.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1972307] Review Request: golang-github-rjeczalik-notify - File system event notification library
https://bugzilla.redhat.com/show_bug.cgi?id=1972307
Carl George 🤠 changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Carl George 🤠 ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Unknown or generated", "Expat
License". 6 files have unknown license. Detailed output of
licensecheck in /home/carl/packaging/reviews/golang-github-rjeczalik-
notify/1972307-golang-github-rjeczalik-notify/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Spec use %global instead of %define unless justified.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: ta
[Bug 1975590] New: Review Request: rust-takeable-option - A small wrapper around option
https://bugzilla.redhat.com/show_bug.cgi?id=1975590 Bug ID: 1975590 Summary: Review Request: rust-takeable-option - A small wrapper around option Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: remilauz...@protonmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/remilauzier/rust-simp/fedora-rawhide-x86_64/02296500-rust-takeable-option/rust-takeable-option.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/remilauzier/rust-simp/fedora-rawhide-x86_64/02296500-rust-takeable-option/rust-takeable-option-0.5.0-1.fc35.src.rpm Description: A small wrapper around option Fedora Account System Username: remilauzier -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1972301] Review Request: golang-sr-spc-log - simple level log package
https://bugzilla.redhat.com/show_bug.cgi?id=1972301
--- Comment #1 from Carl George 🤠 ---
If you like you can remove the forgeurl definition, that's set automatically
based on goipath. I initially thought several of the others macro definitions
weren't necessary, but after tinkering with it I see that they are necessary
because the forge macros don't seem to like sourcehut.
-%global forgeurlhttps://git.sr.ht/~spc/go-log
I recommend setting the tag based on the version, to avoid having to change the
version in two places.
-%global tag 0.1.0
+%global tag %{version}
Strangely the license and readme aren't being included in the package. That
should be automatic with the gopkgfiles macro, but it appears there are
multiple bugs with the go forge macros and sourcehut. I discovered that you
can work around it by setting the topdir macro.
+%global topdir %{repo}-%{tag}
You should fill out a summary. Here's my suggestion, feel free to adjust as
you see fit.
-Summary:None
+Summary:Level logging for Go
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
needinfo canceled: [Bug 1364631] Review Request: nodejs-glob-stream - A wrapper around node-glob to make it streamy
Product: Fedora Version: rawhide Component: Package Review Package Review has canceled Package Review 's request for Jared Smith 's needinfo: Bug 1364631: Review Request: nodejs-glob-stream - A wrapper around node-glob to make it streamy https://bugzilla.redhat.com/show_bug.cgi?id=1364631 --- Comment #7 from Package Review --- This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1972159] Review Request: rust-witx - Parse and validate witx file format
https://bugzilla.redhat.com/show_bug.cgi?id=1972159 --- Comment #2 from Olivier Lemasle --- Package updated (bump upstream to latest version 0.9.1) Spec URL: https://olem.fedorapeople.org/reviews/rust-witx.spec SRPM URL: https://olem.fedorapeople.org/reviews/rust-witx-0.9.1-1.fc34.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1975535] Review Request: xcompmgr - X11 composite manager
https://bugzilla.redhat.com/show_bug.cgi?id=1975535 Davide Cavalca changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #2 from Davide Cavalca --- Note: this is a retired package, so I'll file a ticket to get it unretired once approved: https://src.fedoraproject.org/rpms/xcompmgr -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1975535] Review Request: xcompmgr - X11 composite manager
https://bugzilla.redhat.com/show_bug.cgi?id=1975535 --- Comment #1 from Davide Cavalca --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=70705960 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1975535] New: Review Request: xcompmgr - X11 composite manager
https://bugzilla.redhat.com/show_bug.cgi?id=1975535 Bug ID: 1975535 Summary: Review Request: xcompmgr - X11 composite manager Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: dcava...@fb.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://dcavalca.fedorapeople.org/review/xcompmgr/xcompmgr.spec SRPM URL: https://dcavalca.fedorapeople.org/review/xcompmgr/xcompmgr-1.1.8-2.fc35.src.rpm Description: xcompmgr is a sample compositing manager for X servers supporting the XFIXES, DAMAGE, and COMPOSITE extensions. It enables basic eye-candy effects Fedora Account System Username: dcavalca -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1975024] Review Request: buttermanager - Summary: Tool for managing Btrfs snapshots, balancing filesystems and more
https://bugzilla.redhat.com/show_bug.cgi?id=1975024 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/buttermanager -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1975024] Review Request: buttermanager - Summary: Tool for managing Btrfs snapshots, balancing filesystems and more
https://bugzilla.redhat.com/show_bug.cgi?id=1975024 Michel Alexandre Salim changed: What|Removed |Added Status|ASSIGNED|POST --- Comment #4 from Michel Alexandre Salim --- Will fix the desktop file installation when importing. For docs... yeah, this is borderline so I'll not split it yet. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1975463] Review Request: rust-safe_arch - exposes `core::arch` safely via `#[cfg()]`
https://bugzilla.redhat.com/show_bug.cgi?id=1975463 Rémi Lauzier changed: What|Removed |Added Blocks||1975487 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1975487 [Bug 1975487] Review Request: rust-wide - A crate to help you go wide -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1975487] Review Request: rust-wide - A crate to help you go wide
https://bugzilla.redhat.com/show_bug.cgi?id=1975487 Rémi Lauzier changed: What|Removed |Added CC||remilauz...@protonmail.com Depends On||1975463 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1975463 [Bug 1975463] Review Request: rust-safe_arch - exposes `core::arch` safely via `#[cfg()]` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1973733] Review Request: python-dbutils - tools providing solid, persistent and pooled connections
https://bugzilla.redhat.com/show_bug.cgi?id=1973733 Pat Riehecky changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2021-06-23 19:18:18 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1975487] New: Review Request: rust-wide - A crate to help you go wide
https://bugzilla.redhat.com/show_bug.cgi?id=1975487 Bug ID: 1975487 Summary: Review Request: rust-wide - A crate to help you go wide Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: remilauz...@protonmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/remilauzier/wide/fedora-rawhide-x86_64/02296037-rust-wide/rust-wide.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/remilauzier/wide/fedora-rawhide-x86_64/02296037-rust-wide/rust-wide-0.6.5-1.fc35.src.rpm Description: A crate to help you go wide Fedora Account System Username: remilauzier -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1973682] Review Request: jsonnet - A data templating language
https://bugzilla.redhat.com/show_bug.cgi?id=1973682 Pat Riehecky changed: What|Removed |Added Flags|needinfo?(riehe...@fnal.gov | |) | --- Comment #19 from Pat Riehecky --- Updated with the proposed feedback (I think I missed the source URL comment earlier): SPEC: https://download.copr.fedorainfracloud.org/results/jcpunk/jsonnet/fedora-34-x86_64/02296050-jsonnet/jsonnet.spec SRPM: https://download.copr.fedorainfracloud.org/results/jcpunk/jsonnet/fedora-34-x86_64/02296050-jsonnet/jsonnet-0.17.0-1.fc34.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1974114] Review Request: python-environs - Python library for parsing environment variables
https://bugzilla.redhat.com/show_bug.cgi?id=1974114 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-environs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1973733] Review Request: python-dbutils - tools providing solid, persistent and pooled connections
https://bugzilla.redhat.com/show_bug.cgi?id=1973733 --- Comment #14 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-dbutils -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1973682] Review Request: jsonnet - A data templating language
https://bugzilla.redhat.com/show_bug.cgi?id=1973682 --- Comment #18 from Ben Beasley --- Created attachment 1793588 --> https://bugzilla.redhat.com/attachment.cgi?id=1793588&action=edit Candidate patch to stop overriding build flags Patch mentioned in latest review -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1973682] Review Request: jsonnet - A data templating language
https://bugzilla.redhat.com/show_bug.cgi?id=1973682
Ben Beasley changed:
What|Removed |Added
Flags|needinfo?(code@musicinmybra |needinfo?(riehe...@fnal.gov
|in.net) |)
--- Comment #17 from Ben Beasley ---
I’m not quite done picking at the details, but we’re getting very close.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= Issues =
- Unless I am missing something, you should set -DBUILD_STATIC_LIBS:BOOL=OFF,
and remove the -static subpackage. From
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_static_libraries,
“In general, packagers SHOULD NOT ship static libraries.”
- The build system is still overriding the optimization flags (adding -O3) and
the C++ standard flags (forcing C++11) from the environment
(https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags).
I am attaching a patch that should correct this.
Note that linking C++ code compiled with different standard versions is not
reliable, as there is no ABI compatibility across different standards—so when
library packages in Fedora use different C++ flags from the distribution
defaults, dependent packages can fail to link or, worse, crash at runtime.
- I missed this before, but please split the shared libraries into a -libs
subpackage. See https://bugzilla.redhat.com/show_bug.cgi?id=1955394#c5 and
the following discussion for an explanation of how this helps with multilib
filtering.
Once you’ve done this, you’ll have to change
Requires: %{name}%{?_isa} = %{version}-%{release}
to
Requires: %{name}-libs%{?_isa} = %{version}-%{release}
in the -devel package, and add it in the base package.
You should also add the same fully-versioned dependency to the
python3-jsonnet subpackage; even though it automatically depends on the
shared library, we want the version and release to stay in sync within
subpackages built from the same source.
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package.
- As long as you are packaging the (currently un-built but partially usable)
documentation, you might as well throw in the examples/ to the -doc
subpackage—probably without the check.sh scripts.
= Notes (no change required) =
- I still think that
Source0:%{url}/archive/v%{version}/%{name}-%{version}.tar.gz
would result in a better archive name than the current
Source0:%{url}/archive/refs/tags/v%{version}.tar.gz
but you are not required to change it.
- I very much agree with your choice to remove the dependency on the base
package from the -doc subpackage; I was going to request that, but you beat
me to it.
- The patch to link the Python extension dynamically is great. I’m not sure I
would have taken the time to figure that out. Static linking across
subpackages of the same source RPM is not against the Fedora guidelines, but
it’s always nice to reduce duplication.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[!]: Package contains no static executables.
Static library (.a) is built and installed.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
There is a Python extension module, correctly installed.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* Apache License 2.0",
"Apache License 2.0", "*No copyright* Creative Commons Attribution 2.5
Generic License", "NTP License". 483 files have unknown license.
Detailed output of licensecheck in
/home/reviewer/1973682-jsonnet/licensecheck.txt
Note that the RSA license is incorrectly detected as “NTP License”
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[!]: %build honors applicable compiler flags or justifies otherwise.
See Issues.
[x]: Package contains no bundled libraries
[Bug 1975463] Review Request: rust-safe_arch - exposes `core::arch` safely via `#[cfg()]`
https://bugzilla.redhat.com/show_bug.cgi?id=1975463 --- Comment #1 from Rémi Lauzier --- endline encoding fix https://github.com/Lokathor/safe_arch/pull/101 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1975463] New: Review Request: rust-safe_arch - exposes `core::arch` safely via `#[cfg()]`
https://bugzilla.redhat.com/show_bug.cgi?id=1975463 Bug ID: 1975463 Summary: Review Request: rust-safe_arch - exposes `core::arch` safely via `#[cfg()]` Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: remilauz...@protonmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/remilauzier/wide/fedora-rawhide-x86_64/02296019-rust-safe_arch/rust-safe_arch.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/remilauzier/wide/fedora-rawhide-x86_64/02296019-rust-safe_arch/rust-safe_arch-0.6.0-1.fc35.src.rpm Description: exposes `core::arch` safely via `#[cfg()]` Fedora Account System Username: remilauzier -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1974358] Review Request: fdr - Flight Data Recorder
https://bugzilla.redhat.com/show_bug.cgi?id=1974358 Steve Dickson changed: What|Removed |Added Flags||needinfo?(mikel@olasagasti. ||info) --- Comment #4 from Steve Dickson --- fdr.spec has been updated: https://github.com/oracle/fdr/blob/master/buildrpm/1.3/fdr.spec fdr-1.3-1.fc33.src.rpm: http://people.redhat.com/steved/fdr/fdr-1.3-1.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1973733] Review Request: python-dbutils - tools providing solid, persistent and pooled connections
https://bugzilla.redhat.com/show_bug.cgi?id=1973733 --- Comment #13 from Ben Beasley --- > I've never needed `fedpkg request-repo` before I mentioned it only because it’s the only method I’ve ever used for opening those tickets. Consider opening a ticket at https://pagure.io/releng/issues asking for help finding the problem, or going to #fedora-releng on IRC (libera.chat). It’s mostly just robots reading the issues and comments in https://pagure.io/releng/fedora-scm-requests/. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1973733] Review Request: python-dbutils - tools providing solid, persistent and pooled connections
https://bugzilla.redhat.com/show_bug.cgi?id=1973733 --- Comment #12 from Pat Riehecky --- Even with the elements matching where I know to make them match, I got closed invalid. https://pagure.io/releng/fedora-scm-requests/issue/35196 I've never needed `fedpkg request-repo` before -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1973682] Review Request: jsonnet - A data templating language
https://bugzilla.redhat.com/show_bug.cgi?id=1973682 Ben Beasley changed: What|Removed |Added Flags||needinfo?(code@musicinmybra ||in.net) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1973733] Review Request: python-dbutils - tools providing solid, persistent and pooled connections
https://bugzilla.redhat.com/show_bug.cgi?id=1973733 --- Comment #11 from Pat Riehecky --- Ah, my RHBZ email was indeed not right. I've re-run fedpkg request-repo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers
https://bugzilla.redhat.com/show_bug.cgi?id=1970050
--- Comment #9 from Peter Hunt ---
some small tweaks, here's a diff with explanations inline
```
# duplicated with the declaration at the top needed for gometa
34a35,36
> # https://github.com/cri-o/cri-o
> %global goipath github.com/cri-o/cri-o
# update url
44c45
< URL:https://github.com/cri-o/cri-o
---
> URL:https://github.com/rclone/rclone
# our obs instance doesn't provide go_compiler, but does provide golang. every
rhel (centos) needs to require golang
50,53d50
< %if 0%{?rhel}
< BuildRequires: golang
< %endif
<
56a54,55
> # If go_compiler is not set to 1, there is no virtual provide. Use golang
> instead.
> BuildRequires: %{?go_compiler:compiler(go-compiler)}%{!?go_compiler:golang}
# need to add go-rpm-macros in fedora
62d59
< BuildRequires: go-rpm-macros
# import_path is no longer defined
125,129c122,126
< export LDFLAGS="-X
%{goipath}/internal/pkg/criocli.DefaultsPath=%{criocli_path}
< -X %{goipath}/internal/version.buildDate=%{build_timestamp}
< -X %{goipath}/internal/version.gitCommit=%{commit0}
< -X %{goipath}/internal/version.version=%{version}
< -X %{goipath}/internal/version.gitTreeState=%{git_tree_state} "
---
> export LDFLAGS="-X
> %{import_path}/internal/pkg/criocli.DefaultsPath=%{criocli_path}
> -X %{import_path}/internal/version.buildDate=%{build_timestamp}
> -X %{import_path}/internal/version.gitCommit=%{commit0}
> -X %{import_path}/internal/version.version=%{version}
> -X %{import_path}/internal/version.gitTreeState=%{git_tree_state}"
# only call set_build_flags on fedora where it's defined
135d131
< %if 0%{?fedora}
137d132
< %endif
# remove commented out fields
188a184,185
> #install -dp
> %%{buildroot}%%{_libexecdir}/%%{service_name}/%%{service_name}-wipe
> #install -dp %%{buildroot}%%{_prefix}/lib/systemd/system-preset
```
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1974114] Review Request: python-environs - Python library for parsing environment variables
https://bugzilla.redhat.com/show_bug.cgi?id=1974114
Ben Beasley changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #5 from Ben Beasley ---
Package approved; please see the note under Issues, below.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= Issues =
- You should add “examples” to %doc. The number and size of files is still
small enough that (subjectively) a -doc subpackage is not required,
although you are welcome to make one if you like. (If you do add a -doc
subpackage, make sure it includes a copy of the LICENSE file, since it
does not need to depend on the python3-environ package.)
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License", "*No copyright* Expat
License". 22 files have unknown license. Detailed output of
licensecheck in /home/reviewer/1974114-python-
environs/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upst
[Bug 1974377] Review Request: rust-clang-ast - Data structures for processing Clang's `-ast-dump=json` format
https://bugzilla.redhat.com/show_bug.cgi?id=1974377 Jan Staněk changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2021-06-23 13:02:04 --- Comment #7 from Jan Staněk --- Successfully built in rawhide: https://bodhi.fedoraproject.org/updates/FEDORA-2021-ff9c7e3722 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1975297] New: Review Request: fx-completion - Shell completion for fx
https://bugzilla.redhat.com/show_bug.cgi?id=1975297
Bug ID: 1975297
Summary: Review Request: fx-completion - Shell completion for
fx
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nob...@fedoraproject.org
Reporter: c...@musicinmybrain.net
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL: https://music.fedorapeople.org/fx-completion.spec
SRPM URL: https://music.fedorapeople.org/fx-completion-1.0.5-1.fc34.src.rpm
Description:
Shell completion for fx.
The completions are installed system-wide.
Currently, bash is the only supported shell.
Fedora Account System Username: music
Koji scratch builds:
F35: https://koji.fedoraproject.org/koji/taskinfo?taskID=70681894
F34: https://koji.fedoraproject.org/koji/taskinfo?taskID=70681919
(Support for F33 and EPEL7–8 is not planned.)
You can test functionality in the mock chroot by:
> echo '{ "a": "foo", "b": "bar" }' > data.json
> fx data.json [TAB TAB]
> # Expect auto-completion including object members “a” and “b”
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1972445] Review Request: servus - Zeroconf discovery in C++
https://bugzilla.redhat.com/show_bug.cgi?id=1972445 --- Comment #4 from Rafael Jeffman --- Otto, Agreed. Thank your for correcting me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1828984] Re-Review Request: culmus-fonts - Fonts for Hebrew from Culmus project
https://bugzilla.redhat.com/show_bug.cgi?id=1828984 Parag Nemade changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2021-06-23 11:47:44 --- Comment #3 from Parag Nemade --- Sorry for the much delay. Finally this work is in rawhide now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers
https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #8 from Neal Gompa --- What about what Robert proposed didn't work in OBS? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1975046] Review Request: python-aesara - Python optimizing compiler for evaluating mathematical expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1975046 Arthur Bols changed: What|Removed |Added CC||art...@bols.dev --- Comment #2 from Arthur Bols --- Hi, Please note that this a preliminary review. I checked the license situation (and reread the licensing guidelines) and I think it should be fine. rpmlint reports errors for check_blas.py and check_multi_gpu.py even though you tried to fix it :/ python3-aesara.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/aesara/misc/check_blas.py 644 /usr/bin/env python python3-aesara.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/aesara/misc/check_multi_gpu.py 644 /usr/bin/env python Would it be better to use the sources from github? This way you could include the tests and create a *-doc package. Some small suggestions: - Change pytest to the %pytest macro. - Change python3-setuptools to python3dist(setuptools) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1965241] Review Request: rust-drg - Command line tool to interact with a drogue-cloud instance
https://bugzilla.redhat.com/show_bug.cgi?id=1965241 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #3 from Fedora Update System --- FEDORA-2021-d858d5ec0a has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-d858d5ec0a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1974114] Review Request: python-environs - Python library for parsing environment variables
https://bugzilla.redhat.com/show_bug.cgi?id=1974114 Antonio T. sagitter changed: What|Removed |Added Flags|needinfo?(trpost@rocketmail | |.com) | --- Comment #4 from Antonio T. sagitter --- Thank you very much Ben. I never used pyproject-rpm-macros before. SRPM: https://download.copr.fedorainfracloud.org/results/sagitter/ForTesting/fedora-rawhide-x86_64/02295558-python-environs/python-environs-9.3.2-2.fc35.src.rpm SPEC: https://download.copr.fedorainfracloud.org/results/sagitter/ForTesting/fedora-rawhide-x86_64/02295558-python-environs/python-environs.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
