[Bug 2119983] Review Request: c-icap - An implementation of an ICAP server

2022-09-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=2119983



--- Comment #10 from Frank Crawford  ---
Note, I've added it as a issue in the C-ICAP Github repo that it would be good
to move away from BDB.  Will see what comes from it.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2123954] Review Request: python-PyMunin3 - Python module for developing Munin Multigraph Plugins

2022-09-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=2123954



--- Comment #12 from Sandro  ---
Any update on this?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2123954
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 1881793] Review Request: golang-github-emersion-ical - An iCalendar library for Go.

2022-09-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1881793

proletarius...@protonmail.com changed:

   What|Removed |Added

  Flags|needinfo?(proletarius101@pr |
   |otonmail.com)   |



--- Comment #4 from proletarius...@protonmail.com ---
Yes but how can I get sponsored?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1881793
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 840551] Review Request: sugar-kuku - arithmetic education game

2022-09-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=840551

timeline  changed:

   What|Removed |Added

 CC||bonbap2...@gmail.com



--- Comment #78 from timeline  ---
Great information, I will recommend it to my friends for them to check out.
Thanks for sharing! If you have more time, please visit:
https://wheelspinner.tools


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=840551
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2106611] Review Request: passt - User-mode networking daemons for virtual machines and namespaces

2022-09-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=2106611



--- Comment #32 from Fedora Update System  ---
FEDORA-2022-a9152a0bbe has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2106611
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2106611] Review Request: passt - User-mode networking daemons for virtual machines and namespaces

2022-09-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=2106611



--- Comment #31 from Fedora Update System  ---
FEDORA-2022-70d28f3e7e has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2106611
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2127314] Review Request: gnome-browser-connector - GNOME Shell browser connector

2022-09-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=2127314

Kalev Lember  changed:

   What|Removed |Added

 Blocks||2106868





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2106868
[Bug 2106868] Project name and source repository changed to
gnome-browser-connector
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2127314
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2127314] New: Review Request: gnome-browser-connector - GNOME Shell browser connector

2022-09-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=2127314

Bug ID: 2127314
   Summary: Review Request: gnome-browser-connector - GNOME Shell
browser connector
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: klem...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://kalev.fedorapeople.org/gnome-browser-connector.spec
SRPM URL:
https://kalev.fedorapeople.org/gnome-browser-connector-42.1-1.fc38.src.rpm
Description:
Native host messaging connector that provides integration with GNOME Shell and
the corresponding extensions repository https://extensions.gnome.org.

Fedora Account System Username: kalev

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=92052166

This is largely just a rename from chrome-gnome-shell to
gnome-browser-connection and the packaging is mostly based on
chrome-gnome-shell packaging. Once the new package is in, we'll retire
chrome-gnome-shell. See https://bugzilla.redhat.com/show_bug.cgi?id=2106868 for
details.

I've talked to Pete Walter and he's fine with retiring chrome-gnome-shell.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2127314
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2126943] Review Request: perl-Template-Plugin-CGI - Simple Template Toolkit plugin interfacing to the CGI.pm module

2022-09-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=2126943



--- Comment #7 from Damian Wrobel  ---
(In reply to Petr Pisar from comment #1)
> URL and Source0 addresses are usable. Ok.
> Source0 archive (SHA512:
> 2ca0a9f0a72a2c26e73a5e7202ae3773349c032acc0c15b016a84e629fe326ac1fd53f45f0ffa
> 6d23311bc1fa7f7ac1645df187373c59f5c6b1046985655d1cd) is original. Ok.
> Summary verified from lib/Template/Plugin/CGI.pm. Ok.
> TODO: I recommed spelling "the CGI.pm module" without the file name

Done.

> extension as "the CGI module".
> 
> Description verified from lib/Template/Plugin/CGI.pm. Ok.
> 
> FIX: The License is incomplete. Licenses found in the archive are:

Done.

> 
> lib/Template/Plugin/CGI.pm:11:  GPL-1.0-or-later OR Artistic-1.0-Perl
> /Tlibemplate/Plugin/CGI.pm:126: GPL-1.0-or-later OR Artistic-1.0-Perl
> lib/Template/Plugin/CGI.pm:141: X11
> Makefile.PL:16: An unspecified MIT variant
> LICENSE: MIT text.
> 
> The license tag must comprehend all the licenses.
> 
> The first two occurrences (GPL-1.0-or-later OR Artistic-1.0-Perl) must be
> added.
> Reading the POD, one can see doubled NAME and other sections. That's
> probably a copy-and-paste mistake, but we need to respect all the licenses.
> 
> The last three licenses are probably a sloppy expression for a single MIT
> license  and author did not mean X11
> variant of MIT license  as suggested at
> lib/Template/Plugin/CGI.pm:141.
> 
> Please change the License tag to "(GPL-1.0-or-later OR Artistic-1.0-Perl)
> AND MIT" and contact upstream to clarify and preferably correct the mistakes.
> 
> No XS code, noArch BuildArch is Ok.
> 
> TODO: Qualify 'perl(ExtUtils::MakeMaker)' with >= '6.76' because of

Done.

> Makefile.PL arguments NO_PACKLIST=1 NO_PERLLOCAL=1.
> FIX: Build-require 'perl(CGI) >= 4.44' (lib/Template/Plugin/CGI.pm:26,
> META.json:32).
> FIX: Build-require 'perl(strict)' (Makefile.PL:2).
> FIX: Build-require 'perl(warnings)' (Makefile.PL:3).
> FIX: Build-require 'perl(base)' (lib/Template/Plugin/CGI.pm:25).
> FIX: Build-require 'perl(lib)' (t/cgi.t:20).
> FIX: Build-require 'perl(Template) >= 3.100' (t/cgi.t:21).
> FIX: Build-require 'perl(Template::Test)' (t/cgi.t:22).
> 
> FIX: Remove unused dependencies: perl(Carp), perl(CGI::Cookie),
> perl(CGI::File::Temp), perl(CGI::Util), perl(constant), perl(Cwd),
> perl(Encode*, perl(Exporter), perl(Exporter::Heavy), perl(File::Path),
> perl(File::Spec::Unix), perl(File::Temp), perl(HTML::Entities),
> perl(HTML::Parser), perl(List::Util), perl(parent), perl(Scalar::Util),
> perl(Socket), perl(Storable), perl(Template::Base),
> perl(Template::Constants), perl(Test2::Bundle::Extended),
> perl(Test2::Plugin::NoWarnings), perl(Test2::Suite),
> perl(Test2::Tools::Explain), perl(Test::Builder), perl(Test::CPAN::Meta),
> perl(Term::Cap), perl(Text::ParseWords).
> Where did you get these dependencies from? I cannot see them used anywhere
> in the code.
> 

Done. With the exceptions aforementioned in #c6

> TODO: Unset AUTHOR_TESTING environment variable %check section to make the
> tests more reproducible (t/author-pod-syntax.t:4).

Done.

> 
> FIX: The packeged module was part for perl-Template-Toolkit. You need to add
> "Conflicts: perl-Template-Toolkit < 3.010-5" to prevent from installing both
> of them at the same time.
> 

Done.

> Please correct the FIX items, consider fixing TODO items, and provide an
> updated spec file.

Please find updated files:
Spec URL:
https://dwrobel.fedorapeople.org/projects/rpmbuild/SPECS/perl-Template-Plugin-CGI.spec
SRPM URL:
https://dwrobel.fedorapeople.org/projects/rpmbuild/SRPMS/perl-Template-Plugin-CGI-3.101-2.fc38.src.rpm

Fedora Review Log:
https://download.copr.fedorainfracloud.org/results/dwrobel/perl-Template-Plugin-CGI/fedora-rawhide-x86_64/04838758-perl-Template-Plugin-CGI/fedora-review/review.txt

Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=92042450


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2126943
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2126943] Review Request: perl-Template-Plugin-CGI - Simple Template Toolkit plugin interfacing to the CGI.pm module

2022-09-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=2126943



--- Comment #6 from Damian Wrobel  ---
(In reply to Petr Pisar from comment #1)

I'm in a process of fixing the issue and have the following doubts:

> FIX: Build-require 'perl(Template) >= 3.100' (t/cgi.t:21).
This doesn't exist. dnf builddeps comlains:

No matching package to install: 'perl(Template) >= 3.100'


> 
> FIX: Remove unused dependencies: perl(Carp), perl(CGI::Cookie),
> perl(Template::Constants), perl(Test2::Bundle::Extended),
> perl(Test2::Plugin::NoWarnings), perl(Test2::Suite),
> perl(Test2::Tools::Explain), perl(Test::Builder), perl(Test::CPAN::Meta),
> perl(Term::Cap), perl(Text::ParseWords).
> Where did you get these dependencies from? I cannot see them used anywhere
> in the code.

Test seems to require the following:
# === Test Requires ===
# 
# Module Want Have
# - - 
# ExtUtils::MakeMaker any 7.64
# File::Spec  any 3.84
# File::Temp  any   0.2311
# IO::Handle  any 1.48
# IPC::Open3  any 1.22
# Template  3.1003.101
# Test2::Bundle::Extended any  missing <= you recommended to remove it
# Test2::Plugin::NoWarnings   any  missing <= you recommended to remove it
# Test2::Suiteany  missing <= you recommended to remove it
# Test2::Tools::Explain   any  missing <= you recommended to remove it
# Test::Builder   any 1.302191
# Test::CPAN::Metaany  missing <= you recommended to remove it
# Test::More  any 1.302191

So, It's probably good to keep them.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2126943
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2126943] Review Request: perl-Template-Plugin-CGI - Simple Template Toolkit plugin interfacing to the CGI.pm module

2022-09-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=2126943



--- Comment #5 from Damian Wrobel  ---
For the reverse direction I'm getting:

[dw@dell Plugin]$ scandeps.pl -V -B -R CGI.pm 
# Template/Plugin.pm [module]
# Template/Plugin/CGI.pm [module]
# base.pm [module]
# strict.pm [module]
# warnings.pm [module]
#
# Legend: [C]ore [X]ternal [S]ubmodule [?]NotOnCPAN
'Template::Plugin' => '0', #? # Template::Plugin::CGI
'base' => '0', #   C? # Template::Plugin::CGI
'strict'   => '0', #   C? # Template::Plugin::CGI
'warnings' => '0', #   C? # Template::Plugin::CGI

While cpanspec gives me:

[dw@dell cpan]$ cpanspec Template-Plugin-CGI-3.101.tar.gz 
[dw@dell cpan]$ grep '^BuildRequires:' perl-Template-Plugin-CGI.spec 
BuildRequires:  perl(CGI) >= 4.44
BuildRequires:  perl(ExtUtils::MakeMaker)
BuildRequires:  perl(File::Spec)
BuildRequires:  perl(File::Temp)
BuildRequires:  perl(IO::Handle)
BuildRequires:  perl(IPC::Open3)
BuildRequires:  perl(Template) >= 3.100
BuildRequires:  perl(Test2::Bundle::Extended)
BuildRequires:  perl(Test2::Plugin::NoWarnings)
BuildRequires:  perl(Test2::Suite)
BuildRequires:  perl(Test2::Tools::Explain)
BuildRequires:  perl(Test::Builder)
BuildRequires:  perl(Test::CPAN::Meta)
BuildRequires:  perl(Test::More)

Is there any authoritative method of automatically retriving list of BRs for a
perl module a I could use?


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2126943
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2126943] Review Request: perl-Template-Plugin-CGI - Simple Template Toolkit plugin interfacing to the CGI.pm module

2022-09-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=2126943



--- Comment #4 from Damian Wrobel  ---
Here is what I see:

[dw@dell Plugin]$ scandeps.pl CGI.pm 
'CGI::Cookie' => '4.54',
'CGI::File::Temp' => '4.54',
'CGI::Util'   => '4.54',
'Carp'=> '1.52',
'Cwd' => '3.80',
'Encode'  => '3.17',
'Encode::Alias'   => '2.24',
'Encode::Config'  => '2.05',
'Encode::Encoding'=> '2.08',
'Encode::MIME::Name'  => '1.03',
'Exporter'=> '5.76',
'Exporter::Heavy' => '5.76',
'Fh'  => '4.54',
'File::Path'  => '2.18',
'File::Spec'  => '3.80',
'File::Spec::Unix'=> '3.80',
'File::Temp'  => '0.2311',
'HTML::Entities'  => '3.78',
'HTML::Parser'=> '3.78',
'List::Util'  => '1.63',
'Scalar::Util'=> '1.63',
'Socket'  => '2.035',
'Storable'=> '3.25',
'Template::Base'  => '3.010',
'Template::Constants' => '3.010',
'Template::Plugin'=> '3.010',
'Term::Cap'   => '1.17',
'Text::ParseWords'=> '3.31',
'constant'=> '1.33',
'parent'  => '0.238',

[dw@dell Plugin]$ rpm -qf /usr/bin/scandeps.pl
perl-Module-ScanDeps-1.31-6.fc36.noarch


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2126943
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2126943] Review Request: perl-Template-Plugin-CGI - Simple Template Toolkit plugin interfacing to the CGI.pm module

2022-09-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=2126943



--- Comment #3 from Petr Pisar  ---
Your are completely right: If a Perl module requires CGI::Cookie, then an RPM
package which delivers the module should require perl(CGI::Cookie). Not
perl(CGI).

However, in Template-Plugin-CGI-3.101 I cannot see anywhere e.g. CGI::Cookie to
be mentioned. Neither "grep -Hnr CGI::Cookie" command shows it, neither
"cpanspec Template-Plugin-CGI-3.101.tar.gz" generates it.

I did not know scandeps.pl tool, but I think tool is broken or I cannot use it
properly. First you want to run it with -R, otherwise it reports dependencies
of dependencies. (Which is why your original spec file contains to much
modules. RPM packages should not list transitive dependencies in general).
Second you want to call it with -B, otherwise it hides core modules. Third it
hides uninstalled direct dependencies, it probably only does dynamic analysis
from %INC hash after loading the file or it does not account that current perl
does not have ./ in @INC. Dynamic analysis is not bad, but we also need static
analysis because Perl can load modules only in a specific code path (e.g. from
a called subroutine.) See:

$ scandeps.pl -V -B -R ./lib/Template/Plugin/CGI.pm 
# Could not find source file 'Template/Plugin/CGI.pm' in @INC or @IncludeLibs.
Skipping it.
# Could not find source file 'Template/Plugin.pm' in @INC or @IncludeLibs.
Skipping it.
# Could not find source file 'CGI.pm' in @INC or @IncludeLibs. Skipping it.
# Template/Plugin/CGI.pm []
# base.pm [module]
# strict.pm [module]
# warnings.pm [module]
#
# Legend: [C]ore [X]ternal [S]ubmodule [?]NotOnCPAN
'base' => '0', #   C? # Template::Plugin::CGI
'strict'   => '0', #   C? # Template::Plugin::CGI
'warnings' => '0', #   C? # Template::Plugin::CGI

It is missing Template::Plugin and CGI.

For scanning sources for Perl dependencies I use tangerine tool (installed from
a same-named RPM package).

That's why I think the dependency I listed should not be there.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2126943
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2125956] Review Request: qbe - A pure C embeddable compiler backend

2022-09-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=2125956

Timothée Floure  changed:

   What|Removed |Added

 Resolution|--- |RAWHIDE
 Status|ASSIGNED|CLOSED
Last Closed||2022-09-15 15:21:02



--- Comment #8 from Timothée Floure  ---
Many thanks! I'll make it so the timestamps are preserved. The other two issues
are only transient.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2125956
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2127168] New: Review Request: xdg-desktop-portal-lxqt - A backend implementation for xdg-desktop-portal that is using Qt/KF5/libfm-qt

2022-09-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=2127168

Bug ID: 2127168
   Summary: Review Request: xdg-desktop-portal-lxqt - A backend
implementation for xdg-desktop-portal that is using
Qt/KF5/libfm-qt
   Product: Fedora
   Version: rawhide
Status: NEW
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: szts...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



SPEC URL:
https://download.copr.fedorainfracloud.org/results/zsun/review-lxqt/fedora-rawhide-x86_64/04838442-xdg-desktop-portal-lxqt/xdg-desktop-portal-lxqt.spec

SRPM URL:
https://download.copr.fedorainfracloud.org/results/zsun/review-lxqt/fedora-rawhide-x86_64/04838442-xdg-desktop-portal-lxqt/xdg-desktop-portal-lxqt-0.2.0-1.fc38.src.rpm

Description:
xdg-desktop-portal-lxqt is a backend implementation for xdg-desktop-portal that
is using Qt/KF5/libfm-qt

Fedora Account System Username: zsun

Copr build
https://copr.fedorainfracloud.org/coprs/zsun/review-lxqt/build/4838442/

And copr fedora-review:
https://download.copr.fedorainfracloud.org/results/zsun/review-lxqt/fedora-rawhide-x86_64/04838442-xdg-desktop-portal-lxqt/fedora-review/review.txt


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2127168
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2119983] Review Request: c-icap - An implementation of an ICAP server

2022-09-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=2119983



--- Comment #9 from Simone Caronni  ---
Spec URL: https://slaanesh.fedorapeople.org/c-icap.spec
SRPM URL: https://slaanesh.fedorapeople.org/c-icap-0.5.10-6.fc36.src.rpm

I've bundled libdb 5.3.28 (last one with a valid license for Fedora) inside the
package, like all packages with BDB needs are now doing (pretty pointless in my
opinion).

I've added the necessary provide:

$ rpm -qp --provides c-icap-libs-0.5.10-6.fc36.x86_64.rpm | grep bundle
bundled(libdb) = 5.3.28

Detailed change here:
https://github.com/scaronni/c-icap/commit/070551ee4fdc9f88e8f7cfb1673827259b26ea1b


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2121114] Review Request: python-pep440 - A simple package with utils to check whether versions number match Pep 440

2022-09-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=2121114

Maíra Canal  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |ERRATA
Last Closed||2022-09-15 13:44:43




-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2121114
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2126943] Review Request: perl-Template-Plugin-CGI - Simple Template Toolkit plugin interfacing to the CGI.pm module

2022-09-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=2126943



--- Comment #2 from Damian Wrobel  ---
(In reply to Petr Pisar from comment #1)

Thank you for taking the review and for your valuable comments. I'll fix the
issues.

> 
> FIX: Remove unused dependencies: perl(Carp), perl(CGI::Cookie),

> Where did you get these dependencies from? I cannot see them used anywhere
> in the code.
> 

It's a sum (excluding duplicates) from the following two tools: 
 $ scandeps.pl lib/Template/Plugin/CGI.pm 
 $ cpanspec Template-Plugin-CGI-3.101.tar.gz

I'm not an expert in perl, but I liked the output in the form of:

 perl(CGI::Cookie)
 perl(CGI::File::Temp)
 perl(CGI::Util)

instead of using

 perl(CGI)

alone just to avoid a situation which we have in bug#2124543#c3.

My assumption is (maybe I'm wrong) that if at some point in time someone will
decide
to spin off or move e.g CGI:Util to a separate package then this would be
transparent to me
(it might still require to package CGI::Util, though).

So, is it acceptable to use this "more granular" form of "Requires:" or I have
to use just the top module name (in the above example perl(CGI))?


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2126943
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2074709] Review Request: python-pyqt6 - PyQt6 is Python bindings for Qt6

2022-09-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=2074709



--- Comment #16 from Onuralp SEZER  ---
No problem, you're welcome :)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2074709
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2074709] Review Request: python-pyqt6 - PyQt6 is Python bindings for Qt6

2022-09-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=2074709



--- Comment #15 from Sandro Mani  ---
My bad, I was looking for python-qt6... Thanks!


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2074709
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2074709] Review Request: python-pyqt6 - PyQt6 is Python bindings for Qt6

2022-09-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=2074709

Onuralp SEZER  changed:

   What|Removed |Added

  Flags|needinfo?(thunderbirdtr@fed |
   |oraproject.org) |



--- Comment #14 from Onuralp SEZER  ---
PyQt6 is already in F36-37-38 and sure I can add you as well.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2074709
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2074709] Review Request: python-pyqt6 - PyQt6 is Python bindings for Qt6

2022-09-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=2074709

Sandro Mani  changed:

   What|Removed |Added

  Flags||needinfo?(thunderbirdtr@fed
   ||oraproject.org)
 CC||thunderbirdtr@fedoraproject
   ||.org



--- Comment #13 from Sandro Mani  ---
@thunderbir...@fedoraproject.org Could you import the package? Or feel free to
add me to the package and I'm happy to help.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2074709
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2126943] Review Request: perl-Template-Plugin-CGI - Simple Template Toolkit plugin interfacing to the CGI.pm module

2022-09-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=2126943



--- Comment #1 from Petr Pisar  ---
URL and Source0 addresses are usable. Ok.
Source0 archive (SHA512:
2ca0a9f0a72a2c26e73a5e7202ae3773349c032acc0c15b016a84e629fe326ac1fd53f45f0ffa6d23311bc1fa7f7ac1645df187373c59f5c6b1046985655d1cd)
is original. Ok.
Summary verified from lib/Template/Plugin/CGI.pm. Ok.
TODO: I recommed spelling "the CGI.pm module" without the file name extension
as "the CGI module".

Description verified from lib/Template/Plugin/CGI.pm. Ok.

FIX: The License is incomplete. Licenses found in the archive are:

lib/Template/Plugin/CGI.pm:11:  GPL-1.0-or-later OR Artistic-1.0-Perl
/Tlibemplate/Plugin/CGI.pm:126: GPL-1.0-or-later OR Artistic-1.0-Perl
lib/Template/Plugin/CGI.pm:141: X11
Makefile.PL:16: An unspecified MIT variant
LICENSE: MIT text.

The license tag must comprehend all the licenses.

The first two occurrences (GPL-1.0-or-later OR Artistic-1.0-Perl) must be
added.
Reading the POD, one can see doubled NAME and other sections. That's probably a
copy-and-paste mistake, but we need to respect all the licenses.

The last three licenses are probably a sloppy expression for a single MIT
license  and author did not mean X11
variant of MIT license  as suggested at
lib/Template/Plugin/CGI.pm:141.

Please change the License tag to "(GPL-1.0-or-later OR Artistic-1.0-Perl) AND
MIT" and contact upstream to clarify and preferably correct the mistakes.

No XS code, noArch BuildArch is Ok.

TODO: Qualify 'perl(ExtUtils::MakeMaker)' with >= '6.76' because of Makefile.PL
arguments NO_PACKLIST=1 NO_PERLLOCAL=1.
FIX: Build-require 'perl(CGI) >= 4.44' (lib/Template/Plugin/CGI.pm:26,
META.json:32).
FIX: Build-require 'perl(strict)' (Makefile.PL:2).
FIX: Build-require 'perl(warnings)' (Makefile.PL:3).
FIX: Build-require 'perl(base)' (lib/Template/Plugin/CGI.pm:25).
FIX: Build-require 'perl(lib)' (t/cgi.t:20).
FIX: Build-require 'perl(Template) >= 3.100' (t/cgi.t:21).
FIX: Build-require 'perl(Template::Test)' (t/cgi.t:22).

FIX: Remove unused dependencies: perl(Carp), perl(CGI::Cookie),
perl(CGI::File::Temp), perl(CGI::Util), perl(constant), perl(Cwd),
perl(Encode*, perl(Exporter), perl(Exporter::Heavy), perl(File::Path),
perl(File::Spec::Unix), perl(File::Temp), perl(HTML::Entities),
perl(HTML::Parser), perl(List::Util), perl(parent), perl(Scalar::Util),
perl(Socket), perl(Storable), perl(Template::Base), perl(Template::Constants),
perl(Test2::Bundle::Extended), perl(Test2::Plugin::NoWarnings),
perl(Test2::Suite), perl(Test2::Tools::Explain), perl(Test::Builder),
perl(Test::CPAN::Meta), perl(Term::Cap), perl(Text::ParseWords).
Where did you get these dependencies from? I cannot see them used anywhere in
the code.

TODO: Unset AUTHOR_TESTING environment variable %check section to make the
tests more reproducible (t/author-pod-syntax.t:4).

FIX: The packeged module was part for perl-Template-Toolkit. You need to add
"Conflicts: perl-Template-Toolkit < 3.010-5" to prevent from installing both of
them at the same time.

Please correct the FIX items, consider fixing TODO items, and provide an
updated spec file.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2126943
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2087174] Review Request: telepathy-idle - IRC connection manager for Telepathy

2022-09-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=2087174

Ali Erdinc Koroglu  changed:

   What|Removed |Added

 CC||aekoro...@linux.intel.com



--- Comment #16 from Ali Erdinc Koroglu  ---
Yep I did, thanks

https://bodhi.fedoraproject.org/updates/FEDORA-2022-d23557aec2


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2087174
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2087174] Review Request: telepathy-idle - IRC connection manager for Telepathy

2022-09-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=2087174



--- Comment #15 from Mamoru TASAKA  ---
Please rebuild this package also on F-37, and submit to bodhi (submitting to
bodhi is needed for F-37) - unless this,
polari dependency issue on F-37 cannot be resolved.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2087174
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue