[Bug 2117232] Review Request: python-m3u8 - Python module m3u8 parser
https://bugzilla.redhat.com/show_bug.cgi?id=2117232
--- Comment #7 from Felix Wang ---
2. I suggest change %{python3_sitelib}/%{srcname}-%{version}-py?.??.egg-info to
%{python3_sitelib}/%{srcname}-%{version}-py%{python3_version}.egg-info
3. There is a naming rule about python library, which add a subpackage using
the python3- prefix. ref:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/#_naming
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2117232
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2117232] Review Request: python-m3u8 - Python module m3u8 parser
https://bugzilla.redhat.com/show_bug.cgi?id=2117232 Felix Wang changed: What|Removed |Added CC||topa...@outlook.com --- Comment #6 from Felix Wang --- There is a line existed in %prep of SPEC file: sed -i -e 's|3.2.0|3.3.0|' setup.py why does it exist? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2117232 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2173751] Review Request: mod_auth_cas - unretire package
https://bugzilla.redhat.com/show_bug.cgi?id=2173751 Scott Williams changed: What|Removed |Added Link ID||Github ||apereo/mod_auth_cas/pull/20 ||9 Github ||thansen11/mod_auth_cas_rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2173751 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2173751] Review Request: mod_auth_cas - unretire package
https://bugzilla.redhat.com/show_bug.cgi?id=2173751 --- Comment #10 from Scott Williams --- Patch submitted upstream: https://github.com/apereo/mod_auth_cas/pull/209 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2173751 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2173751] Review Request: mod_auth_cas - unretire package
https://bugzilla.redhat.com/show_bug.cgi?id=2173751 --- Comment #9 from Scott Williams --- For what it's worth, I'm trying to see if I can submit a patch upstream to support PCRE2. I'm pretty close to getting it working, but working around kids is hard.. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2173751 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 1816301] Review Request: openfoam - computational fluid dynamics
https://bugzilla.redhat.com/show_bug.cgi?id=1816301 --- Comment #34 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5590469 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-1816301-openfoam/fedora-rawhide-x86_64/05590469-openfoam2212/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1816301 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 1816301] Review Request: openfoam - computational fluid dynamics
https://bugzilla.redhat.com/show_bug.cgi?id=1816301 --- Comment #33 from Jakub Kadlčík --- Created attachment 1947793 --> https://bugzilla.redhat.com/attachment.cgi?id=1947793&action=edit The .spec file difference from Copr build 5572620 to 5590469 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1816301 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2174227] Review Request: rust-imagequant-sys - Convert 24/32-bit images to 8-bit palette with alpha channel
https://bugzilla.redhat.com/show_bug.cgi?id=2174227 blinxen changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2023-03-03 21:16:33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2174227 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2174227] Review Request: rust-imagequant-sys - Convert 24/32-bit images to 8-bit palette with alpha channel
https://bugzilla.redhat.com/show_bug.cgi?id=2174227 --- Comment #9 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-imagequant-sys -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2174227 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 1816301] Review Request: openfoam - computational fluid dynamics
https://bugzilla.redhat.com/show_bug.cgi?id=1816301 --- Comment #32 from mark.ole...@esi-group.com --- Made changes to compile with gcc-13. Tested locally, and retested with fedora-37. So another attempt... spec: https://download.copr.fedorainfracloud.org/results/openfoam/openfoam/fedora-37-x86_64/05579789-openfoam2212/openfoam2212.spec srpm: https://download.copr.fedorainfracloud.org/results/openfoam/openfoam/fedora-37-x86_64/05579789-openfoam2212/openfoam2212-2212.230110-230228.fc37.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1816301 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations
https://bugzilla.redhat.com/show_bug.cgi?id=2166884 --- Comment #14 from Iñaki Ucar --- (In reply to Benson Muite from comment #13) > Can the files doc/naming.md and doc/tuning.md be packaged? These are part of the documentation, so they are included now as man pages. > The source also includes a library of additional helper routines, > libcscutils. Given that these are used in the examples, maybe it > is helpful to also package them. Some modifications are needed > to obtain shared libraries, in particular a static library > liblua.a is created, even if one sets CMake to create shared > libraries. Checking what is needed to change this. This is a helper library they use for many projects and should not be packaged according to the maintainer. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2166884 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations
https://bugzilla.redhat.com/show_bug.cgi?id=2166884 --- Comment #13 from Benson Muite --- Can the files doc/naming.md and doc/tuning.md be packaged? The source also includes a library of additional helper routines, libcscutils. Given that these are used in the examples, maybe it is helpful to also package them. Some modifications are needed to obtain shared libraries, in particular a static library liblua.a is created, even if one sets CMake to create shared libraries. Checking what is needed to change this. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2166884 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2173236] Review Request: SLiM - simple login manager
https://bugzilla.redhat.com/show_bug.cgi?id=2173236 --- Comment #22 from One Of The Robs --- (In reply to Ranjan Maitra from comment #21) > I can attach a screenshot that i took while running it on qemu. That would be helpful. I've updated an old / spare machine to F37 so I can have a look at trying to recreate the problem. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2173236 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2173523] Review Request: qt6-qtspeech - Speech component
https://bugzilla.redhat.com/show_bug.cgi?id=2173523 --- Comment #17 from Jan Grulich --- d) Reported: https://bugzilla.redhat.com/show_bug.cgi?id=2175241 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2173523 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2174227] Review Request: rust-imagequant-sys - Convert 24/32-bit images to 8-bit palette with alpha channel
https://bugzilla.redhat.com/show_bug.cgi?id=2174227
Fabio Valentini changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
Status|ASSIGNED|POST
--- Comment #8 from Fabio Valentini ---
Ok, package looks good to me.
You might want to consider replacing "%{_libdir}/%{lib}.so.0*"
with "%{_libdir}/%{lib}.so.0{,.*}".
(see
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files)
but that's a minor thing.
The ABI / API compatibility with libimagequant v2 is not part of the package
review, but please make sure that maintainers of dependent packages (and the
"devel" list) are notified of the change.
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- license of statically linked components is reflected in License tag
- shared C-ABI library built and installed correctly
- package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org:
project: $crate
homepage: https://crates.io/crates/$crate
backend: crates.io
version scheme: semantic
version filter: alpha;beta;rc;pre
distro: Fedora
Package: rust-$crate
- track package in koschei for all built branches
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2174227
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2173236] Review Request: SLiM - simple login manager
https://bugzilla.redhat.com/show_bug.cgi?id=2173236 --- Comment #21 from Ranjan Maitra --- (In reply to One Of The Robs from comment #20) > Do you mean it doesn't launch automatically, or that when you run it you get > a crash? > Try using the "preview" mode to see whether it's basically working (this > doesn't test everything but gets most of it) > > If it's a matter of not getting auto-started then look to see what the > systemd service file looks like. There is a patch applied on Devuan because > the CMakeLists.txt erroneously lost the install step for that file, although > a first glance suggested that Fedora (like Gentoo) doesn't actually use the > default install anyway. > > Regards, > Rob Thanks, Rob! It installs just fine, but it does not start (crashes). I can attach a screenshot that i took while running it on qemu. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2173236 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2173716] Review Request: rust-test-case-macros - Procedural macro attribute for generating parametrized test cases
https://bugzilla.redhat.com/show_bug.cgi?id=2173716 Fabio Valentini changed: What|Removed |Added Resolution|--- |ERRATA Status|POST|CLOSED Last Closed||2023-03-03 15:27:08 --- Comment #7 from Fabio Valentini --- Imported, built, and submitted: https://bodhi.fedoraproject.org/updates/FEDORA-2023-617e48c47d https://bodhi.fedoraproject.org/updates/FEDORA-2023-aa61180662 https://bodhi.fedoraproject.org/updates/FEDORA-2023-17198904f9 https://bodhi.fedoraproject.org/updates/FEDORA-2023-2258507395 Thanks everybody! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2173716 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161525] Review Request: jupyterlab - JupyterLab computational environment
https://bugzilla.redhat.com/show_bug.cgi?id=2161525
Karolina Surma changed:
What|Removed |Added
Flags||fedora-review+
Assignee|nob...@fedoraproject.org|ksu...@redhat.com
Status|NEW |POST
--- Comment #27 from Karolina Surma ---
I installed the package on my Rawhide machine and checked around half of the
menu items, no issues spotted.
I don't see anything striking in the package metadata, nor the build logs.
Things in the specfile are commented around, I find it sufficient. Please raise
the uncovered issues with upstream.
Package APPROVED.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
Note: Unversionned Python dependency found.
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Python/#_dependencies
That's a new one -- It seems it comes from python-jupyter-filesystem though, so
this is not an issue (see Requires below)
[?]: Package contains desktop file if it is a GUI application.
- Notebook has got one, maybe the Lab could too? (Not a MUST item).
[?]: (Possible future enhancement) There's `%{_datadir}/jupyter/lab` in the
files -- if other extension packages will use this directory, maybe it'll make
sense in to include it into python-jupyter-filesystem.
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file third-party-licenses.json is not marked as %license
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/LicensingGuidelines/#_license_text
Decided that's moot. License texts were marked correctly.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 3-Clause License", "MIT License
BSD 3-Clause License", "*No copyright* BSD 3-Clause License", "BSD
3-Clause License [generated file]", "*No copyright* [generated file]",
"MIT License", "BSD 0-Clause License", "Apache License 2.0", "*No
copyright* Apache License 2.0". 555 files have unknown license.
Detailed output of licensecheck in
/home/ksurma/tmp/2161525-jupyterlab/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[?]: Package contains desktop file if it is a GUI application.
- Notebook has got one, maybe the Lab could too?
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build tim
[Bug 2173677] Review Request: regextester - Regex Tester for elementary OS
https://bugzilla.redhat.com/show_bug.cgi?id=2173677 --- Comment #19 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5590018 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2173677-regextester/fedora-rawhide-x86_64/05590018-regextester/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2173677 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2173677] Review Request: regextester - Regex Tester for elementary OS
https://bugzilla.redhat.com/show_bug.cgi?id=2173677 --- Comment #18 from Jakub Kadlčík --- Created attachment 1947704 --> https://bugzilla.redhat.com/attachment.cgi?id=1947704&action=edit The .spec file difference from Copr build 5586818 to 5590018 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2173677 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175159] Review Request: jurand - A tool for manipulating Java symbols
https://bugzilla.redhat.com/show_bug.cgi?id=2175159 --- Comment #9 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/jurand -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2175159 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2174763] Review Request: lujavrite - Lua library for calling Java code
https://bugzilla.redhat.com/show_bug.cgi?id=2174763 Mikolaj Izdebski changed: What|Removed |Added Resolution|--- |RAWHIDE Status|ASSIGNED|CLOSED Last Closed||2023-03-03 15:13:40 --- Comment #7 from Mikolaj Izdebski --- Package was added to rawhide: https://bodhi.fedoraproject.org/updates/FEDORA-2023-7ae81b4ed5 Closing this review. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2174763 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations
https://bugzilla.redhat.com/show_bug.cgi?id=2166884 --- Comment #12 from Iñaki Ucar --- Nice, thanks. Any other issues here? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2166884 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2173677] Review Request: regextester - Regex Tester for elementary OS
https://bugzilla.redhat.com/show_bug.cgi?id=2173677 --- Comment #17 from Gwyn Ciesla --- SRPM: https://fedorapeople.org/~limb/review/regextester/regextester-1.1.1-5.fc37.src.rpm SPEC: https://fedorapeople.org/~limb/review/regextester/regextester.spec Fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2173677 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175159] Review Request: jurand - A tool for manipulating Java symbols
https://bugzilla.redhat.com/show_bug.cgi?id=2175159 Mikolaj Izdebski changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2175159 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175159] Review Request: jurand - A tool for manipulating Java symbols
https://bugzilla.redhat.com/show_bug.cgi?id=2175159
--- Comment #8 from Mikolaj Izdebski ---
Pacakge is approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* Apache License 2.0", "Unknown or generated". 39
files have unknown license. Detailed output of licensecheck in
/var/lib/copr-rpmbuild/results/jurand/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[?]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/b
[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations
https://bugzilla.redhat.com/show_bug.cgi?id=2166884 --- Comment #11 from Benson Muite --- Co-ownership of directories is possible, though here seems not needed: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_the_directory_is_also_owned_by_a_package_implementing_required_functionality_of_your_package Made a pull request: https://src.fedoraproject.org/rpms/gcc/pull-request/39 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2166884 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175159] Review Request: jurand - A tool for manipulating Java symbols
https://bugzilla.redhat.com/show_bug.cgi?id=2175159 --- Comment #7 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5589833 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2175159-jurand/fedora-rawhide-x86_64/05589833-jurand/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2175159 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175159] Review Request: jurand - A tool for manipulating Java symbols
https://bugzilla.redhat.com/show_bug.cgi?id=2175159 --- Comment #6 from Jakub Kadlčík --- Created attachment 1947703 --> https://bugzilla.redhat.com/attachment.cgi?id=1947703&action=edit The .spec file difference from Copr build 5589492 to 5589833 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2175159 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175159] Review Request: jurand - A tool for manipulating Java symbols
https://bugzilla.redhat.com/show_bug.cgi?id=2175159 --- Comment #5 from Marián Konček --- Updated package: Spec URL: https://download.copr.fedorainfracloud.org/results/mkoncek/jurand/fedora-rawhide-x86_64/05589825-jurand/jurand.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mkoncek/jurand/fedora-rawhide-x86_64/05589825-jurand/jurand-1.0.2-1.fc39.src.rpm Changes: * Executable installed as /usr/bin/jurand instead of /usr/bin/java_remove_symbols * Changed %changelog entry and email address * Added %dir entries in %files section -- removing RPM warnings -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2175159 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2117232] Review Request: python-m3u8 - Python module m3u8 parser
https://bugzilla.redhat.com/show_bug.cgi?id=2117232 Jakub Kadlčík changed: What|Removed |Added URL||https://github.com/globocom ||/m3u8 --- Comment #5 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5589713 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2117232-python-m3u8/fedora-rawhide-x86_64/05589713-python-m3u8/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2117232 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175182] Review Request: python-intern - Python SDK for interacting with neuroscience data via the Boss API
https://bugzilla.redhat.com/show_bug.cgi?id=2175182 Jakub Kadlčík changed: What|Removed |Added URL||https://github.com/jhuapl-b ||oss/intern --- Comment #1 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5589703 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2175182-python-intern/fedora-rawhide-x86_64/05589703-python-intern/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2175182 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2117232] Review Request: python-m3u8 - Python module m3u8 parser
https://bugzilla.redhat.com/show_bug.cgi?id=2117232 --- Comment #4 from MartinKG --- Update to 3.4.0 Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-m3u8.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-m3u8-3.4.0-1.fc37.src.rpm %changelog * Fri Mar 03 2023 Martin Gansser 3.4.0-1 - Update to 3.4.0 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2117232 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175182] Review Request: python-intern - Python SDK for interacting with neuroscience data via the Boss API
https://bugzilla.redhat.com/show_bug.cgi?id=2175182 Ben Beasley changed: What|Removed |Added Blocks||1276941 (fedora-neuro) Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2175182 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175182] New: Review Request: python-intern - Python SDK for interacting with neuroscience data via the Boss API
https://bugzilla.redhat.com/show_bug.cgi?id=2175182 Bug ID: 2175182 Summary: Review Request: python-intern - Python SDK for interacting with neuroscience data via the Boss API Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: c...@musicinmybrain.net QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://music.fedorapeople.org/python-intern-1.4.0-1.fc37.src.rpm SRPM URL: https://music.fedorapeople.org/python-intern.spec Description: intern (Integrated Toolkit for Extensible and Reproducible Neuroscience) is a Python 3 module that enables big-data neuroscience. Currently, it provides an interface to common big-data neuroimaging databases such as BossDB, CloudVolume, DVID, and other standard formats. Fedora Account System Username: music Koji scratch builds: F39: https://koji.fedoraproject.org/koji/taskinfo?taskID=98238244 F38: https://koji.fedoraproject.org/koji/taskinfo?taskID=98238320 F37: https://koji.fedoraproject.org/koji/taskinfo?taskID=98238333 F36: https://koji.fedoraproject.org/koji/taskinfo?taskID=98238335 The above are forced to build on all architectures for testing, e.g., $ koji build --scratch f39 --arch_override='x86_64 i686 ppc64le aarch64 s390x' python-intern-1.4.0-1.fc37.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2175182 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2173523] Review Request: qt6-qtspeech - Speech component
https://bugzilla.redhat.com/show_bug.cgi?id=2173523 --- Comment #16 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5589677 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2173523-qt6-qtspeech/fedora-rawhide-x86_64/05589677-qt6-qtspeech/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2173523 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2173523] Review Request: qt6-qtspeech - Speech component
https://bugzilla.redhat.com/show_bug.cgi?id=2173523 --- Comment #15 from Jakub Kadlčík --- Created attachment 1947695 --> https://bugzilla.redhat.com/attachment.cgi?id=1947695&action=edit The .spec file difference from Copr build 5575930 to 5589677 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2173523 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175162] Review Request: vkroots - A stupid simple method of making Vulkan layers, at home!
https://bugzilla.redhat.com/show_bug.cgi?id=2175162 --- Comment #17 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5589666 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2175162-vkroots/fedora-rawhide-x86_64/05589666-vkroots/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2175162 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175162] Review Request: vkroots - A stupid simple method of making Vulkan layers, at home!
https://bugzilla.redhat.com/show_bug.cgi?id=2175162 --- Comment #16 from Jakub Kadlčík --- Created attachment 1947693 --> https://bugzilla.redhat.com/attachment.cgi?id=1947693&action=edit The .spec file difference from Copr build 5589497 to 5589666 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2175162 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2174382] Review Request: rubygem-sys-filesystem - Interface for gathering filesystem information
https://bugzilla.redhat.com/show_bug.cgi?id=2174382 --- Comment #3 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-sys-filesystem -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2174382 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175162] Review Request: vkroots - A stupid simple method of making Vulkan layers, at home!
https://bugzilla.redhat.com/show_bug.cgi?id=2175162 --- Comment #15 from Onuralp Sezer --- Spec URL: https://thunderbirdtr.fedorapeople.org/vkroots.spec SRPM URL: https://thunderbirdtr.fedorapeople.org/vkroots-0%5e20230103git2675710-1.fc38.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2175162 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175162] Review Request: vkroots - A stupid simple method of making Vulkan layers, at home!
https://bugzilla.redhat.com/show_bug.cgi?id=2175162 --- Comment #14 from Onuralp Sezer --- I added everything under devel subpackage. Github issue opened for license https://github.com/Joshua-Ashton/vkroots/issues/4 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2175162 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2128257] Review Request: motion - A motion detection system
https://bugzilla.redhat.com/show_bug.cgi?id=2128257
--- Comment #6 from Vitaly Zaitsev ---
Small fixes:
> %attr(0700,%{name},video) /run/%{name}/
%attr(0700,%{name},video) %dir /run/%{name}/
> %attr(-,%{name},video) %dir %{_localstatedir}/log/%{name}/
%attr(0700,%{name},video) %dir %{_localstatedir}/log/%{name}/
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2128257
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2128257] Review Request: motion - A motion detection system
https://bugzilla.redhat.com/show_bug.cgi?id=2128257
--- Comment #5 from Vitaly Zaitsev ---
> Note: No gcc, gcc-c++ or clang found in BuildRequires
BuildRequires: gcc-c++
> License: GPL-2.0-or-later
License: GPL-2.0-or-later AND BSD-3-Clause
> motion.x86_64: W: tmpfile-not-in-filelist /run/motion
%install
...
install -D -d -m 0700 %{buildroot}/run/%{name}
touch %{buildroot}/run/%{name}/%{name}.pid
%files
...
%attr(0700,%{name},video) /run/%{name}/
%verify(not size mtime md5) /run/%{name}/%{name}.pid
> motion.x86_64: W: tmpfile-not-in-filelist /var/log/motion.log
Please remove this from tmpfiles config and use classic installation:
%install
...
install -D -d -m 0700 %{buildroot}%{_localstatedir}/log/%{name}/
%files
...
%attr(-,%{name},video) %dir %{_localstatedir}/log/%{name}/
%ghost %{_localstatedir}/log/%{pypi_name}/%{name}.log
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2128257
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175162] Review Request: vkroots - A stupid simple method of making Vulkan layers, at home!
https://bugzilla.redhat.com/show_bug.cgi?id=2175162 --- Comment #13 from Neal Gompa --- Two things left: * You need to put everything into a devel subpackage * You need to file an upstream issue for vkroots to include copies of the licenses referenced, since I could not find any... -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2175162 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175162] Review Request: vkroots - A stupid simple method of making Vulkan layers, at home!
https://bugzilla.redhat.com/show_bug.cgi?id=2175162 --- Comment #11 from Jakub Kadlčík --- Created attachment 1947689 --> https://bugzilla.redhat.com/attachment.cgi?id=1947689&action=edit The .spec file difference from Copr build 5589456 to 5589497 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2175162 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175162] Review Request: vkroots - A stupid simple method of making Vulkan layers, at home!
https://bugzilla.redhat.com/show_bug.cgi?id=2175162 --- Comment #12 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5589497 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2175162-vkroots/fedora-rawhide-x86_64/05589497-vkroots/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2175162 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175162] Review Request: vkroots - A stupid simple method of making Vulkan layers, at home!
https://bugzilla.redhat.com/show_bug.cgi?id=2175162 --- Comment #10 from Onuralp Sezer --- I removed it. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2175162 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175159] Review Request: jurand - A tool for manipulating Java symbols
https://bugzilla.redhat.com/show_bug.cgi?id=2175159 --- Comment #3 from Jakub Kadlčík --- Created attachment 1947688 --> https://bugzilla.redhat.com/attachment.cgi?id=1947688&action=edit The .spec file difference from Copr build 5589376 to 5589492 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2175159 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175159] Review Request: jurand - A tool for manipulating Java symbols
https://bugzilla.redhat.com/show_bug.cgi?id=2175159 --- Comment #4 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5589492 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2175159-jurand/fedora-rawhide-x86_64/05589492-jurand/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2175159 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2128257] Review Request: motion - A motion detection system
https://bugzilla.redhat.com/show_bug.cgi?id=2128257
--- Comment #4 from Vitaly Zaitsev ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
Note: No gcc, gcc-c++ or clang found in BuildRequires
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU General Public License, Version
2", "GNU General Public License v2.0 or later", "*No copyright* GNU
General Public License, Version 2", "*No copyright* GNU General Public
License v2.0 or later", "BSD 3-Clause License". 45 files have unknown
license. Detailed output of licensecheck in /var/lib/copr-
rpmbuild/results/motion/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 286720 bytes in 8 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: systemd_post is invoked in %post, systemd_preun in %preun, and
systemd_postun in %postun for Systemd service files.
Note: Systemd service file(s) in motion
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: P
[Bug 2175162] Review Request: vkroots - A stupid simple method of making Vulkan layers, at home!
https://bugzilla.redhat.com/show_bug.cgi?id=2175162 --- Comment #9 from Neal Gompa --- > %post -p /sbin/ldconfig Not needed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2175162 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175162] Review Request: vkroots - A stupid simple method of making Vulkan layers, at home!
https://bugzilla.redhat.com/show_bug.cgi?id=2175162 --- Comment #8 from Onuralp Sezer --- I removed it. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2175162 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175162] Review Request: vkroots - A stupid simple method of making Vulkan layers, at home!
https://bugzilla.redhat.com/show_bug.cgi?id=2175162 --- Comment #7 from Neal Gompa --- > BuildArch: noarch You can't have header only libraries be noarch. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2175162 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175162] Review Request: vkroots - A stupid simple method of making Vulkan layers, at home!
https://bugzilla.redhat.com/show_bug.cgi?id=2175162 --- Comment #5 from Onuralp Sezer --- Spec URL: https://thunderbirdtr.fedorapeople.org/vkroots.spec SRPM URL: https://thunderbirdtr.fedorapeople.org/vkroots-0%5e20230103git2675710-1.fc38.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2175162 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175162] Review Request: vkroots - A stupid simple method of making Vulkan layers, at home!
https://bugzilla.redhat.com/show_bug.cgi?id=2175162 --- Comment #6 from Onuralp Sezer --- All done. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2175162 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175159] Review Request: jurand - A tool for manipulating Java symbols
https://bugzilla.redhat.com/show_bug.cgi?id=2175159 Mikolaj Izdebski changed: What|Removed |Added CC||mizde...@redhat.com Status|NEW |ASSIGNED Flags||fedora-review? Assignee|nob...@fedoraproject.org|mizde...@redhat.com -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2175159 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175159] Review Request: jurand - A tool for manipulating Java symbols
https://bugzilla.redhat.com/show_bug.cgi?id=2175159 --- Comment #2 from Marián Konček --- Updated package: Spec URL: https://download.copr.fedorainfracloud.org/results/mkoncek/jurand/fedora-rawhide-x86_64/05589477-jurand/jurand.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mkoncek/jurand/fedora-rawhide-x86_64/05589477-jurand/jurand-1.0.1-1.fc39.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2175159 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175162] Review Request: vkroots - A stupid simple method of making Vulkan layers, at home!
https://bugzilla.redhat.com/show_bug.cgi?id=2175162 --- Comment #4 from Neal Gompa --- You're also missing "BuildRequires: meson". -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2175162 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175162] Review Request: vkroots - A stupid simple method of making Vulkan layers, at home!
https://bugzilla.redhat.com/show_bug.cgi?id=2175162
--- Comment #3 from Neal Gompa ---
Spec review
===
> %global git_date %%(date +'%Y%m%d')
This date needs to be fixed, not floating. Base it on the commit date.
> Version:0
> Release:1.%{git_date}git%{shortcommit}%{?dist}
Please use modern snapshot versioning. It'd look something like this:
> Version:0^%{git_date}git%{shortcommit}
> Release:1%{?dist}
Cf.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots
> Source:
> https://github.com/Joshua-Ashton/vkroots/archive/%{commit}/%{name}-%{shortcommit}.tar.gz
The source can be simplified to
"%{url}/archive/%{commit}/%{name}-%{shortcommit}.tar.gz"
> License:LGPL-2.1-only
The license is "LGPL-2.1-or-later AND (Apache-2.0 or MIT)"
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2175162
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175162] Review Request: vkroots - A stupid simple method of making Vulkan layers, at home!
https://bugzilla.redhat.com/show_bug.cgi?id=2175162 Jakub Kadlčík changed: What|Removed |Added URL||https://github.com/Joshua-A ||shton/vkroots --- Comment #2 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5589456 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2175162-vkroots/fedora-rawhide-x86_64/05589456-vkroots/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2175162 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175162] Review Request: vkroots - A stupid simple method of making Vulkan layers, at home!
https://bugzilla.redhat.com/show_bug.cgi?id=2175162 Neal Gompa changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Doc Type|--- |If docs needed, set a value CC||ngomp...@gmail.com Flags||fedora-review? --- Comment #1 from Neal Gompa --- Taking this review. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2175162 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175162] New: Review Request: vkroots - A stupid simple method of making Vulkan layers, at home!
https://bugzilla.redhat.com/show_bug.cgi?id=2175162 Bug ID: 2175162 Summary: Review Request: vkroots - A stupid simple method of making Vulkan layers, at home! Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: thunderbir...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://thunderbirdtr.fedorapeople.org/vkroots.spec SRPM URL: https://thunderbirdtr.fedorapeople.org/vkroots-0-1.20230303git2675710.fc38.src.rpm Description: A stupid simple method of making Vulkan layers, at home! Fedora Account System Username: thunderbirdtr -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2175162 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2173523] Review Request: qt6-qtspeech - Speech component
https://bugzilla.redhat.com/show_bug.cgi?id=2173523 --- Comment #13 from Benson Muite --- e) Should the installed examples have desktop files? f) When running QML example, get error messages such as: OpenType support missing for "Noto Sans", script 20 OpenType support missing for "Noto Sans", script 13 OpenType support missing for "Noto Sans", script 11 OpenType support missing for "Droid Sans", script 11 OpenType support missing for "DejaVu Sans", script 11 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2173523 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175159] Review Request: jurand - A tool for manipulating Java symbols
https://bugzilla.redhat.com/show_bug.cgi?id=2175159 Jakub Kadlčík changed: What|Removed |Added URL||https://github.com/fedora-j ||ava/jurand --- Comment #1 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5589376 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2175159-jurand/fedora-rawhide-x86_64/05589376-jurand/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2175159 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175159] New: Review Request: jurand - A tool for manipulating Java symbols
https://bugzilla.redhat.com/show_bug.cgi?id=2175159 Bug ID: 2175159 Summary: Review Request: jurand - A tool for manipulating Java symbols Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mkon...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/mkoncek/jurand/fedora-38-x86_64/05589367-jurand/jurand.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mkoncek/jurand/fedora-38-x86_64/05589367-jurand/jurand-1.0.0-1.fc38.src.rpm Description: A tool for manipulating Java symbols. Fedora Account System Username: mkoncek -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2175159 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2174763] Review Request: lujavrite - Lua library for calling Java code
https://bugzilla.redhat.com/show_bug.cgi?id=2174763 --- Comment #6 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/lujavrite -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2174763 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2128257] Review Request: motion - A motion detection system
https://bugzilla.redhat.com/show_bug.cgi?id=2128257 Jakub Kadlčík changed: What|Removed |Added URL||https://motion-project.gith ||ub.io/ --- Comment #3 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5589334 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2128257-motion/fedora-rawhide-x86_64/05589334-motion/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2128257 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2174763] Review Request: lujavrite - Lua library for calling Java code
https://bugzilla.redhat.com/show_bug.cgi?id=2174763
Marián Konček changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #5 from Marián Konček ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* Apache License 2.0",
"Apache License 2.0". 2 files have unknown license. Detailed output of
licensecheck in /home/mkoncek/Work/Fedora-
packages/lujavrite/2174763-lujavrite/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[?]: Package should compile and build into binary rpms on all supp
[Bug 2128257] Review Request: motion - A motion detection system
https://bugzilla.redhat.com/show_bug.cgi?id=2128257 --- Comment #2 from Vasiliy Glazov --- Spec URL: https://gist.githubusercontent.com/Vascom/28d6d07ee5c429bbaf46b1eb29b2dcd9/raw/3fd7b56146571f8d536117532f219b2d0304e12b/motion.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/3830/98233830/motion-4.5.1-3.fc39.src.rpm Updated. But with last two changes I need help. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2128257 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175126] Review Request: python-oracledb - OracleDB Driver
https://bugzilla.redhat.com/show_bug.cgi?id=2175126 --- Comment #4 from Jakub Kadlčík --- Created attachment 1947683 --> https://bugzilla.redhat.com/attachment.cgi?id=1947683&action=edit The .spec file difference from Copr build 5588895 to 5589299 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2175126 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175126] Review Request: python-oracledb - OracleDB Driver
https://bugzilla.redhat.com/show_bug.cgi?id=2175126 --- Comment #5 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5589299 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2175126-python-oracledb/fedora-rawhide-x86_64/05589299-python-oracledb/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2175126 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175126] Review Request: python-oracledb - OracleDB Driver
https://bugzilla.redhat.com/show_bug.cgi?id=2175126 --- Comment #3 from Steve Traylen --- [fedora-review-service-build] with the brackets -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2175126 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2174763] Review Request: lujavrite - Lua library for calling Java code
https://bugzilla.redhat.com/show_bug.cgi?id=2174763 --- Comment #3 from Jakub Kadlčík --- Created attachment 1947669 --> https://bugzilla.redhat.com/attachment.cgi?id=1947669&action=edit The .spec file difference from Copr build 5586049 to 5589119 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2174763 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2174763] Review Request: lujavrite - Lua library for calling Java code
https://bugzilla.redhat.com/show_bug.cgi?id=2174763 --- Comment #4 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5589119 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2174763-lujavrite/fedora-rawhide-x86_64/05589119-lujavrite/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2174763 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2174763] Review Request: lujavrite - Lua library for calling Java code
https://bugzilla.redhat.com/show_bug.cgi?id=2174763 --- Comment #2 from Mikolaj Izdebski --- Updated packages: Spec URL: https://mizdebsk.fedorapeople.org/review/lujavrite/lujavrite.spec SRPM URL: https://mizdebsk.fedorapeople.org/review/lujavrite/lujavrite-1.0.2-1.fc39.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2174763 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2174763] Review Request: lujavrite - Lua library for calling Java code
https://bugzilla.redhat.com/show_bug.cgi?id=2174763 Marián Konček changed: What|Removed |Added Status|NEW |ASSIGNED CC||mkon...@redhat.com Flags||fedora-review? Assignee|nob...@fedoraproject.org|mkon...@redhat.com -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2174763 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2172016] Review Request: modulemaker-maven-plugin - A plugin for creating module-info.class files
https://bugzilla.redhat.com/show_bug.cgi?id=2172016 Marián Konček changed: What|Removed |Added Resolution|--- |RAWHIDE Status|ASSIGNED|CLOSED Last Closed||2023-03-03 09:59:14 --- Comment #5 from Marián Konček --- Build done in koji https://koji.fedoraproject.org/koji/buildinfo?buildID=2156536 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2172016 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175126] Review Request: python-oracledb - OracleDB Driver
https://bugzilla.redhat.com/show_bug.cgi?id=2175126 Steve Traylen changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #2 from Steve Traylen --- Corrected the release to %autorelease. fedora-review-service-build -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2175126 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175126] Review Request: python-oracledb - OracleDB Driver
https://bugzilla.redhat.com/show_bug.cgi?id=2175126 Jakub Kadlčík changed: What|Removed |Added URL||https://oracle.github.io/py ||thon-oracledb/ --- Comment #1 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5588895 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2175126-python-oracledb/fedora-rawhide-x86_64/05588895-python-oracledb/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2175126 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2175126] New: Review Request: python-oracledb - OracleDB Driver
https://bugzilla.redhat.com/show_bug.cgi?id=2175126 Bug ID: 2175126 Summary: Review Request: python-oracledb - OracleDB Driver Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: steve.tray...@cern.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: http://cern.ch/straylen/rpms/python-oracledb/python-oracledb.spec SRPM URL: http://cern.ch/straylen/rpms/python-oracledb/python-oracledb-1.2.2-1.fc39.src.rpm Description: The python-oracledb driver is a Python programming language extension module allowing Python programs to connect to Oracle Database. Python-oracledb is the new name for Oracle's popular cx_Oracle driver Fedora Account System Username: stevetraylen -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2175126 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2161525] Review Request: jupyterlab - JupyterLab computational environment
https://bugzilla.redhat.com/show_bug.cgi?id=2161525 --- Comment #26 from Lumír Balhar --- (In reply to Miro Hrončok from comment #25) > I've noticed one thing. %global _description and %descriptinn is rather far > away from each other, and the %_description macro is now only used once. > Maybe it might be cleaner to drop it and write the text directly into > %description? Fixed. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2161525 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2173677] Review Request: regextester - Regex Tester for elementary OS
https://bugzilla.redhat.com/show_bug.cgi?id=2173677 --- Comment #16 from Vasiliy Glazov --- Validation failed. Seems need "--nonet" for appdata validation. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2173677 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2173236] Review Request: SLiM - simple login manager
https://bugzilla.redhat.com/show_bug.cgi?id=2173236 --- Comment #20 from One Of The Robs --- Do you mean it doesn't launch automatically, or that when you run it you get a crash? Try using the "preview" mode to see whether it's basically working (this doesn't test everything but gets most of it) If it's a matter of not getting auto-started then look to see what the systemd service file looks like. There is a patch applied on Devuan because the CMakeLists.txt erroneously lost the install step for that file, although a first glance suggested that Fedora (like Gentoo) doesn't actually use the default install anyway. Regards, Rob -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2173236 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
