[Bug 2174384] Review Request: contour-terminal - Modern C++ Terminal Emulator

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2174384



--- Comment #6 from Felix Wang  ---
The failure is because of the missing BuildRequires, I can successfully built
on my copr.
ref: https://copr.fedorainfracloud.org/coprs/topazus/raku/build/5597199/


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2174384
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2173523] Review Request: qt6-qtspeech - Speech component

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2173523

Jan Grulich  changed:

   What|Removed |Added

 Resolution|--- |RAWHIDE
 Status|POST|CLOSED
Last Closed||2023-03-06 06:55:53




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2173523
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2174384] Review Request: contour-terminal - Modern C++ Terminal Emulator

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2174384

Jakub Kadlčík  changed:

   What|Removed |Added

URL||https://github.com/contour-
   ||terminal/contour



--- Comment #5 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5597218
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2174384-contour-terminal/fedora-rawhide-x86_64/05597218-contour-terminal/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2174384
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2174384] Review Request: contour-terminal - Modern C++ Terminal Emulator

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2174384



--- Comment #4 from Felix Wang  ---
I may have corrected as you pointed out.
SPEC URL:
https://download.copr.fedorainfracloud.org/results/topazus/raku/fedora-rawhide-x86_64/05597199-contour-terminal/contour-terminal.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/topazus/raku/fedora-rawhide-x86_64/05597199-contour-terminal/contour-terminal-0.3.11.258-1.fc39.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2174384
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2173523] Review Request: qt6-qtspeech - Speech component

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2173523



--- Comment #24 from Fedora Admin user for bugzilla script actions 
 ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/qt6-qtspeech


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2173523
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2154514] Review Request: hare - The Hare programming language

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2154514

Benson Muite  changed:

   What|Removed |Added

  Flags||needinfo?(timothee.floure@p
   ||osteo.net)



--- Comment #2 from Benson Muite  ---
qbe 1.1 is available https://c9x.me/compile/releases.html


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2154514
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2157252] Review Request: workflow - C++ parallel computing and asynchronous networking engine

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2157252

Benson Muite  changed:

   What|Removed |Added

 Resolution|--- |RAWHIDE
 Status|POST|CLOSED
Last Closed||2023-03-06 05:56:02




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2157252
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2174384] Review Request: contour-terminal - Modern C++ Terminal Emulator

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2174384



--- Comment #3 from Benson Muite  ---
Desktop files should be validated and have a recommended installation
procedure:

https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files
https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/

Please give the spec file the same name as the package, contour-terminal.spec


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2174384
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2175597] New: Review Request: python-sphinxcontrib-images - Sphinx extension for thumbnails

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2175597

Bug ID: 2175597
   Summary: Review Request: python-sphinxcontrib-images - Sphinx
extension for thumbnails
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: s...@techie.net
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://www.techie.net/~talbert/python-sphinxcontrib-images.spec
SRPM URL:
https://www.techie.net/~talbert/python-sphinxcontrib-images-0.9.4-1.fc39.src.rpm
Description: Easy thumbnails in Sphinx documentation (focused on HTML).
Fedora Account System Username: swt2c


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2175597
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2174384] Review Request: contour-terminal - Modern C++ Terminal Emulator

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2174384
Bug 2174384 depends on bug 2174383, which changed state.

Bug 2174383 Summary: Review Request: libunicode - Modern C++17 Unicode library
https://bugzilla.redhat.com/show_bug.cgi?id=2174383

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |ERRATA




-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2174384
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2174383] Review Request: libunicode - Modern C++17 Unicode library

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2174383

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |ERRATA
Last Closed||2023-03-06 01:10:36



--- Comment #14 from Fedora Update System  ---
FEDORA-2023-3a16d3bec7 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2174383
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2174383] Review Request: libunicode - Modern C++17 Unicode library

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2174383

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #13 from Fedora Update System  ---
FEDORA-2023-3a16d3bec7 has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-3a16d3bec7


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2174383
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2174384] Review Request: contour-terminal - Modern C++ Terminal Emulator

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2174384



--- Comment #2 from Felix Wang  ---
As the dependent bugzilla review request was approved, we may start to move on
this.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2174384
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2174383] Review Request: libunicode - Modern C++17 Unicode library

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2174383



--- Comment #12 from Felix Wang  ---
Very appreciated for your reviewing work.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2174383
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2174383] Review Request: libunicode - Modern C++17 Unicode library

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2174383



--- Comment #11 from Fedora Admin user for bugzilla script actions 
 ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/libunicode


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2174383
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2161739



--- Comment #17 from John Wass  ---
> If you need a different version, please file a new bug against the Fedora / 
> rust-pyo3-log component.

Ok, thanks. I will note that for future reference.

Wasn't trying to be vague, but wasn't sure if this was the right place for my
details. Just wanted to quote that comment of yours describing the reasoning
behind selecting 0.7, for context.

> What are you working on that only supports pyo3 0.15?

The other project is fapolicy-analyzer, which needs to support Python 3.6,
which Pyo3 dropped support for starting @ 0.16. My Rust components are just now
being bridged into the Python logger, otherwise I would have commented on this
sooner.

> I'm not sure how "compatible" pyo3-log 0.8 really is with older PyO3 versions

I can't speak for much other than having plugged 0.8.1 into my project and it
(1) compiles (2) writes the logs as expected.  Happy to help provide additional
feedback if requested.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2161739
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2161739



--- Comment #16 from Fabio Valentini  ---
Yes. This is the ticket for the initial package review, which has concluded.
If you need a different version, please file a new bug against the Fedora /
rust-pyo3-log component.

As far as I can tell (since you haven't given me any specifics of what you're
working on), we have two options here:

1. Update rust-pyo3-log to v0.8.1, and add a rust-pyo3-log0.7 compat package
that will be used by matrix-synapse.
2. Add a rust-pyo3-log0.5 compat package (which was the version originally
targeted at pyo3 0.15).

I'm not sure how "compatible" pyo3-log 0.8 really is with older PyO3 versions,
but if upstream claims it is ... well.

However: At this point, I'd rather not package any more software that depends
on PyO3 v0.15.
That version has been obsolete for over a year, and I'd rather start to *drop*
software that depends on it than add more ...
What are you working on that only supports pyo3 0.15?


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2161739
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2161739



--- Comment #15 from John Wass  ---
Ok. If a project needs to use pyo3-log with a currently unsupported pyo3
(0.15), should that request be in a new bz issue?


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2161739
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2161739



--- Comment #14 from Fabio Valentini  ---
Well, for now, the only thing that matters is that it's compatible with what
matrix-synapse needs.
As soon as they update their pyo3-log dependency, we can do so, too.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2161739
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2161739

John Wass  changed:

   What|Removed |Added

 CC||jwa...@gmail.com



--- Comment #13 from John Wass  ---
> There have also been new releases of the pyo3-log crate (v0.8.0 and v0.8.1), 
> but it looks like matrix-synapse
> depends on v0.7, so I would continue with the review of v0.7.0 and only 
> update to a later version once
> matrix-synapse requires it?

It looks like pyo3-log @ 0.8.1 changed to a range for it's pyo3 dependency. 
Not having that range, this pyo3-log does not appear to be compatible across
available Fedora pyo3 versions (0.15/0.16/0.17).

A quick test here can be done with `cargo new ...` then `cargo add "pyo3@..."`
and `cargo add "pyo3-log@..."`.

This package, at 0.7.0, is compatible with pyo3 0.17.  At 0.8.1 it could work
across all available Fedora versions.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2161739
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2174383] Review Request: libunicode - Modern C++17 Unicode library

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2174383

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags||fedora-review+



--- Comment #10 from Zbigniew Jędrzejewski-Szmek  ---
Using unicode-ucd is nice. We avoid having two independent version
of the same dataset. I would suggest that you subscribe to notifications
about unicode-ucd so that you know when to rebuild this package.

+ package name is OK
+ latest version
+ license is acceptable for Fedora (Apache-2.0)
+ license is specified correctly (SPDX)
+ builds and installs OK
+ BR/R/P look OK
+ rpmlint and fedora-review don't find any major issues, see below.

rpmlint:
> libunicode.x86_64: W: library-not-linked-against-libc 
> /usr/lib64/libunicode_ucd.so.0.2.0
Seems to be a false positive.
> libunicode-tools.x86_64: W: no-manual-page-for-binary unicode-query
As mentioned above, this is just nice-to-have.
> 6 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has 
> taken 1.1 s 

Package is APPROVED.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2174383
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2173178] Review Request: kde-inotify-survey - inotify monitor for kde

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2173178



--- Comment #11 from Benson Muite  ---
Examining this.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2173178
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2117232] Review Request: python-m3u8 - Python module m3u8 parser

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2117232



--- Comment #9 from MartinKG  ---
(In reply to Felix Wang from comment #7)
> 2. I suggest change %{python3_sitelib}/%{srcname}-%{version}-py?.??.egg-info
> to %{python3_sitelib}/%{srcname}-%{version}-py%{python3_version}.egg-info 
> 3. There is a naming rule about python library, which add a subpackage using
> the python3- prefix. ref:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/
> #_naming

fix package:

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-m3u8.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/python-m3u8-3.4.0-2.fc37.src.rpm

%changelog
* Sun Mar 05 2023 Martin Gansser  3.4.0-2
- remove version fix in setup.py
- use python3 version naming for info file
- use naming rule for python library


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2117232
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2150240] Review Request: celestia-data - Data, models and textures for Celestia

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2150240

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |ERRATA
Last Closed||2023-03-05 16:28:39



--- Comment #18 from Fedora Update System  ---
FEDORA-2023-361e30a2ff has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2150240
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2150240] Review Request: celestia-data - Data, models and textures for Celestia

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2150240

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #17 from Fedora Update System  ---
FEDORA-2023-361e30a2ff has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-361e30a2ff


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2150240
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2157252] Review Request: workflow - C++ parallel computing and asynchronous networking engine

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2157252



--- Comment #28 from Fedora Admin user for bugzilla script actions 
 ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/workflow


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2157252
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2157252] Review Request: workflow - C++ parallel computing and asynchronous networking engine

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2157252

Benson Muite  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



--- Comment #27 from Benson Muite  ---
Thanks.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2157252
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2102388] Review Request: delve - Delve is a debugger for the Go programming language

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2102388



--- Comment #25 from Andreas Schneider  ---
Looking at the build.log from a fedora-review run, it doesn't look like tests
are being executed:

Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.pzbvFD
+ umask 022
+ cd /builddir/build/BUILD
+ cd delve-1.20.1
+ export GO111MODULE=off
+ GO111MODULE=off
+ export
GOPATH=/builddir/build/BUILDROOT/delve-1.20.1-2.fc39.x86_64//usr/share/gocode:/usr/share/gocode
+
GOPATH=/builddir/build/BUILDROOT/delve-1.20.1-2.fc39.x86_64//usr/share/gocode:/usr/share/gocode
+
delvepath=/builddir/build/BUILDROOT/delve-1.20.1-2.fc39.x86_64//usr/share/gocode/src/github.com/go-delve/delve
+ cp -r _fixtures
/builddir/build/BUILDROOT/delve-1.20.1-2.fc39.x86_64//usr/share/gocode/src/github.com/go-delve/delve
+ cp -r pkg/dwarf/line/_testdata
/builddir/build/BUILDROOT/delve-1.20.1-2.fc39.x86_64//usr/share/gocode/src/github.com/go-delve/delve/pkg/dwarf/line
+ pushd
/builddir/build/BUILDROOT/delve-1.20.1-2.fc39.x86_64//usr/share/gocode/src/github.com/go-delve/delve
~/build/BUILDROOT/delve-1.20.1-2.fc39.x86_64/usr/share/gocode/src/github.com/go-delve/delve
~/build/BUILD/delve-1.20.1
++ go list ./...
++ grep -v cmd
++ grep -v scripts
pkg/proc/internal/ebpf/trace_bpfel_x86.go:125:12: pattern trace_bpfel_x86.o: no
matching files found
+ rm -rf
/builddir/build/BUILDROOT/delve-1.20.1-2.fc39.x86_64//usr/share/gocode/src/github.com/go-delve/delve/_fixtures
+ rm -rf
/builddir/build/BUILDROOT/delve-1.20.1-2.fc39.x86_64//usr/share/gocode/src/github.com/go-delve/delve/pkg/dwarf/line/_testdata
+ popd


The only indicator is that there is an error from a test, however the error
doesn't make %check fail!


$ go test -count=1 github.com/go-delve/delve/pkg/proc/internal/ebpf
pkg/proc/internal/ebpf/trace_bpfel_x86.go:125:12: pattern trace_bpfel_x86.o: no
matching files found
$ echo $?
1

(The test fails because trace_bpfel_x86.o isn't copied over.)

The loops seems to be problematic here! It hides the exit code of the test.
However we could just run it once with:

go list ./... | awk '!/(cmd|scripts)/ {print $1}' | xargs %{gotest}


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2102388
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2166884

Benson Muite  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #16 from Benson Muite  ---
Package is approved.  Though it could be made easier to use. Octave interface
may be a useful addition for some users.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2166884
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2166884] Review Request: mepack - A Fortran software library for solving dense Sylvester-like matrix equations

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2166884



--- Comment #15 from Benson Muite  ---
cscutils is used in several of their other projects:
https://gitlab.mpi-magdeburg.mpg.de/mess/cmess-releases/-/tree/master/libcscutils
https://gitlab.mpi-magdeburg.mpg.de/software/flexiblas-release/-/tree/master/libcscutils

Maybe it should be packaged separately?  Almost all examples use matrices
stored in hdf5
format.

The code does run, but have not checked correctness.  Instructions for using it
from Fortran
without CMake would be helpful, for example

gfortran  mepack_example.f90  -I /usr/lib64/gfortran/modules/mepack/ -L
/usr/lib64/ -lmepack -llapack -lblas


The main reference:
M. Köhler. 2021. Approximate Solution of Non-Symmetric Generalized Eigenvalue
Problems and Linear Matrix Equation on HPC Platforms. Dissertation. Logos
Verlag Berlin, Magdeburg, Germany.

does not seem to be available for download, though one of the cited references
Gardiner et al. is available:
https://doi.org/10.1145/146847.146930


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2166884
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2150240] Review Request: celestia-data - Data, models and textures for Celestia

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2150240



--- Comment #16 from Fedora Admin user for bugzilla script actions 
 ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/celestia-data


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2150240
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2157252] Review Request: workflow - C++ parallel computing and asynchronous networking engine

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2157252

Troy Curtis  changed:

   What|Removed |Added

  Flags||fedora-review+




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2157252
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2157252] Review Request: workflow - C++ parallel computing and asynchronous networking engine

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2157252

Troy Curtis  changed:

   What|Removed |Added

  Flags|fedora-review+  |
   |needinfo?(troy@troycurtisjr |
   |.com)   |



--- Comment #26 from Troy Curtis  ---
Everything looks good. I'm not sure why rpmlint says there's no documentation,
clearly there is, in the rpm, in the right place annotated as %doc. As
discussed
in the comments, the address might be old, but it matches the license of the
original code thus shouldn't be changed.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
 BuildRequires against gcc, gcc-c++ or clang.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "*No copyright* Apache License 2.0",
 "GNU General Public License, Version 2", "Apache License 2.0", "GNU
 General Public License v2.0 or later [obsolete FSF postal address
 (Temple Place)]", "zlib License", "BSD 2-Clause License". 110 files
 have unknown license. Detailed output of licensecheck in

/home/troycurtisjr/working/oss/fedora/reviews/2157252-workflow/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 614400 bytes in 90 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not

[Bug 2169846] Review Request: python-moddb - ModDB Reader for Python

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2169846

Ben Beasley  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+
   |needinfo?(code@musicinmybra |
   |in.net) |



--- Comment #7 from Ben Beasley  ---
The package is APPROVED, although I have a few suggestions:

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


= Notes (no change required for approval) =

- There is a typo in the changelog entry (Initital/initial)

- You can write the _description macro without backslash-continuations as:

%global _description %{expand:
The goal of the library is to be able to navigate ModDB purely
programmatically through scraping and parsing of the various models
present on the website. This is based off a command of my bot which
can parse either a game or a mod, this command gave birth to the
original library which was extremely limited in its abilities and
only able to parse a few pages with inconsistencies. This library
is a much more mature and professional attempt at the whole idea,
adding on a much deeper understanding of OOP.}

  Personally, I would edit the upstream description to remove the first-person
  perspective (“my”).

- The Summary should not end with a period.

  rpmlint says:

python-moddb.src: W: summary-ended-with-dot A Python scraper/parser for
ModDB.
python3-moddb.noarch: W: summary-ended-with-dot A Python scraper/parser for
ModDB.

- You can, if you like, write the Source0 more concisely:

Source0:%{url}/archive/v%{version}/moddb-%{version}.tar.gz

- It would be good to add a spec-file comment in %check explaining why you
  aren’t running the upstream tests, e.g.:

%check
# Upstream tests generally require network access and authentication
%pyproject_check_import

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "MIT License", "*No copyright* MIT
 License". 64 files have unknown license. Detailed output of
 licensecheck in /home/reviewer/2169846-python-moddb/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.

 $ rpm -qL -p results/python3-moddb-0.8.1-1.fc39.noarch.rpm 
 /usr/lib/python3.11/site-packages/moddb-0.8.1.dist-info/LICENSE

[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using onl

[Bug 2117232] Review Request: python-m3u8 - Python module m3u8 parser

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2117232



--- Comment #8 from MartinKG  ---
(In reply to Felix Wang from comment #6)
> There is a line existed in %prep of SPEC file:
> sed -i -e 's|3.2.0|3.3.0|' setup.py
> why does it exist?

The developer forgot to change the version in the setup.py file when updating
to version 3.3.0 and I forgot to remove it when updating again.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2117232
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2173523] Review Request: qt6-qtspeech - Speech component

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2173523

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2173523
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2173523] Review Request: qt6-qtspeech - Speech component

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2173523

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review+  |fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2173523
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=587978

Michal Ambroz  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
  Alias||rr_whatweb
 Resolution|--- |CURRENTRELEASE
Last Closed|2021-06-16 00:45:22 |2023-03-05 11:46:42



--- Comment #56 from Michal Ambroz  ---
Thank you Otto for review. 
Package is on its way to Fedora.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=587978
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=587978

Leon Fauster  changed:

   What|Removed |Added

 CC||leonfaus...@googlemail.com



--- Comment #55 from Leon Fauster  ---
JFYI / EPEL(

# LANG=C yum install whatweb --enablerepo=epel-testing 
Last metadata expiration check: 0:04:59 ago on Sun Mar  5 12:23:44 2023.
Error: 
 Problem: conflicting requests
  - nothing provides rubygem-addressable needed by whatweb-0.5.5-4.el8.noarch
(try to add '--skip-broken' to skip uninstallable packages)


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=587978
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2150240] Review Request: celestia-data - Data, models and textures for Celestia

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2150240

Benson Muite  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #15 from Benson Muite  ---
Thanks. Approved.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2150240
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2173523] Review Request: qt6-qtspeech - Speech component

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2173523

marcd...@fedoraproject.org changed:

   What|Removed |Added

 CC||marcd...@fedoraproject.org



--- Comment #20 from marcd...@fedoraproject.org ---
Perhaps the issue with the example is not intrinsic to the review at hand?

It's not my review but perhaps is a bit strict to block the package just
because of this ;-)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2173523
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2150240] Review Request: celestia-data - Data, models and textures for Celestia

2023-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2150240



--- Comment #14 from Mattia Verga  ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/mattia/Astronomy/fedora-rawhide-x86_64/05517384-celestia-data/celestia-data.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/mattia/Astronomy/fedora-rawhide-x86_64/05517384-celestia-data/celestia-data-1.7.0~20230223ffc806d-1.fc39.src.rpm

Basically, the only thing that changed is the removal of "Obsoletes:" as the
upgrade path will be handled in main celestia package. Everything else is the
same.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2150240
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue