[Bug 2165381] Review Request: ancient - Modern decompressor for old data compression formats

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2165381



--- Comment #15 from Fedora Update System  ---
FEDORA-2023-c15f9d4a7d has been submitted as an update to Fedora 36.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-c15f9d4a7d


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2165381
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2165381] Review Request: ancient - Modern decompressor for old data compression formats

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2165381



--- Comment #14 from Fedora Update System  ---
FEDORA-2023-89c62dc3f4 has been submitted as an update to Fedora 37.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-89c62dc3f4


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2165381
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2165381] Review Request: ancient - Modern decompressor for old data compression formats

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2165381



--- Comment #13 from Fedora Update System  ---
FEDORA-2023-2bf1e6c40c has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-2bf1e6c40c


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2165381
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2165381] Review Request: ancient - Modern decompressor for old data compression formats

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2165381

Charles R. Anderson  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2023-03-09 04:42:58



--- Comment #12 from Charles R. Anderson  ---
https://bodhi.fedoraproject.org/updates/FEDORA-2023-6a39297686


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2165381
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176241] Review Request: golang-github-zcalusic-sysinfo - Sysinfo is a Go library providing Linux OS / kernel / hardware system information

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176241



--- Comment #5 from Jakub Kadlčík  ---
Created attachment 1949195
  --> https://bugzilla.redhat.com/attachment.cgi?id=1949195&action=edit
The .spec file difference from Copr build 5603636 to 5617056


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2176241
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176241] Review Request: golang-github-zcalusic-sysinfo - Sysinfo is a Go library providing Linux OS / kernel / hardware system information

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176241



--- Comment #4 from Link Dupont  ---
Spec URL:
https://linkdupont.fedorapeople.org/golang-github-zcalusic-sysinfo.spec
SRPM URL:
https://linkdupont.fedorapeople.org/golang-github-zcalusic-sysinfo-0.9.5-2.fc39.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2176241
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2174487] Review Request: esmi_ib_library - E-SMI: EPYC™ System management Interface In-band Library

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2174487



--- Comment #19 from Fedora Update System  ---
FEDORA-2023-b4b332a3ce has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-b4b332a3ce

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2174487
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2173123] Review Request: python-postorius - Web UI for GNU Mailman

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2173123



--- Comment #8 from Fedora Update System  ---
FEDORA-2023-64d3cc740b has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-64d3cc740b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2173123
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2173743] Review Request: python-hyperkitty - A web interface to access GNU Mailman v3 archives

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2173743

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
FEDORA-2023-64d3cc740b has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-64d3cc740b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2173743
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2174438] Review Request: painless-password-rotation - Automates password rotation using HashiCorp Vault

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2174438



--- Comment #11 from Jakub Kadlčík  ---
Created attachment 1949167
  --> https://bugzilla.redhat.com/attachment.cgi?id=1949167&action=edit
The .spec file difference from Copr build 5615159 to 5616498


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2174438
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2174438] Review Request: painless-password-rotation - Automates password rotation using HashiCorp Vault

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2174438



--- Comment #12 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5616498
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2174438-painless-password-rotation/fedora-rawhide-x86_64/05616498-painless-password-rotation/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2174438
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2174438] Review Request: painless-password-rotation - Automates password rotation using HashiCorp Vault

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2174438



--- Comment #10 from Salman Butt  ---
Due to a technical issue and error on my part, i had to re-create the upstream
repo.
I hope this does not cause any confusion. Verison tag is back to 0.1
Will follow proper versioning and best practice form this point onwards.

Updates:

Spec URL: https://cn137.fedorapeople.org/painless-password-rotation.spec
SRPM URL:
https://cn137.fedorapeople.org/painless-password-rotation-0.1-1.fc39.src.rpm
Koji Scratch Build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=98463393


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2174438
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176200] Review Request: rust-blowfish - Blowfish block cipher

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176200

Sandro Mani  changed:

   What|Removed |Added

 Resolution|--- |RAWHIDE
 Status|POST|CLOSED
Last Closed||2023-03-08 23:02:48



--- Comment #4 from Sandro Mani  ---
Thanks!


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2176200
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176200] Review Request: rust-blowfish - Blowfish block cipher

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176200



--- Comment #3 from Fedora Admin user for bugzilla script actions 
 ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-blowfish


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2176200
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176670] Review Request: fedora-iot-config - ostree configuration file for Fedora IoT

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176670

Jakub Kadlčík  changed:

   What|Removed |Added

URL||https://fedoraproject.org/



--- Comment #1 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5616167
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2176670-fedora-iot-config/fedora-rawhide-x86_64/05616167-fedora-iot-config/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2176670
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176670] New: Review Request: fedora-iot-config - ostree configuration file for Fedora IoT

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176670

Bug ID: 2176670
   Summary: Review Request: fedora-iot-config - ostree
configuration file for Fedora IoT
   Product: Fedora
   Version: rawhide
Status: NEW
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: pwha...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



SPEC:
https://pwhalen.fedorapeople.org/packages/fedora-iot-config/fedora-iot-config.spec
SRPM:
https://pwhalen.fedorapeople.org/packages/fedora-iot-config/fedora-iot-config-0.0-1.fc37.src.rpm

Description:
Fedora IoT configuration file for ostree repositories.

FAS: pwhalen

Scratch: https://koji.fedoraproject.org/koji/taskinfo?taskID=98466256


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2176670
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176241] Review Request: golang-github-zcalusic-sysinfo - Sysinfo is a Go library providing Linux OS / kernel / hardware system information

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176241



--- Comment #3 from Mikel Olasagasti Uranga  ---
Please, upload an updated srpm created with the new spec.

> golang-github-zcalusic-sysinfo.x86_64: E: summary-too-long Sysinfo is a Go 
> library providing Linux OS / kernel / hardware system information

Reduce the Summary


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2176241
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2161739] Review Request: rust-pyo3-log - Logging bridge from pyo3 native extension to python

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2161739



--- Comment #18 from Fabio Valentini  ---
I've checked, and the latest matrix-synapse release also started depending on
v0.8.1.
Since nothing in Fedora currently depends on pyo3-log, I've gone ahead and
submitted updates for the package. :)


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2161739
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176200] Review Request: rust-blowfish - Blowfish block cipher

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176200

Fabio Valentini  changed:

   What|Removed |Added

   Doc Type|--- |If docs needed, set a value
 CC||decatho...@gmail.com
   Assignee|nob...@fedoraproject.org|decatho...@gmail.com
  Flags||fedora-review+
 Status|NEW |POST



--- Comment #2 from Fabio Valentini  ---
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable
for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

I think this is your first Rust package? Just a general word of advice:
Due to peculiarities of how Rust packaging works, it is necessary to
re-generate spec files with rust2rpm for every new version of a crate.
For example, the list of "+feature-devel" subpackages needs to be kept in sync
with "features" from upstream metadata in Cargo.toml.
rpmautospec helps with this (because you don't need to take care to preserve
changelog etc.).

As soon as the repository for rust-pbkdf2_0.9 is ready, I will build v0.10 and
v0.9, and review the other two packages.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2176200
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2162851] Review Request: symcrypt - Cryptographic library

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2162851



--- Comment #9 from Benson Muite  ---
Thanks for updated patch. May need to explicitly link glibc:
https://download.copr.fedorainfracloud.org/results/fed500/SymCrypt/fedora-rawhide-aarch64/05615546-SymCrypt/fedora-review/review.txt


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2162851
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2175893] Review Request: autorestic - Config driven, easy backup cli for restic

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2175893
Bug 2175893 depends on bug 2175886, which changed state.

Bug 2175886 Summary: Review Request: golang-github-buger-goterm - Advanced 
terminal output in Go
https://bugzilla.redhat.com/show_bug.cgi?id=2175886

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE




-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2175893
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2175886] Review Request: golang-github-buger-goterm - Advanced terminal output in Go

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2175886

Major Hayden 🤠  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2023-03-08 18:08:36



--- Comment #4 from Major Hayden 🤠  ---
Done! https://bodhi.fedoraproject.org/updates/FEDORA-2023-33fa27a583


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2175886
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176394



--- Comment #9 from Jakub Kadlčík  ---
Created attachment 1949132
  --> https://bugzilla.redhat.com/attachment.cgi?id=1949132&action=edit
The .spec file difference from Copr build 5615144 to 5615532


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2176394
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176394



--- Comment #10 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5615532
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2176394-xine-ui/fedora-rawhide-x86_64/05615532-xine-ui/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2176394
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176394



--- Comment #8 from Xavier Bachelot  ---
Fixed skins URLs.

Spec URL: https://www.bachelot.org/fedora/SPECS/xine-ui.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/xine-ui-0.99.14-3.fc39.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2176394
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2175818] Review Request: input-leap - Share mouse and keyboard between multiple computers over the network

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2175818



--- Comment #20 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5615441
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2175818-input-leap/fedora-rawhide-x86_64/05615441-input-leap/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2175818
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2173751] Review Request: mod_auth_cas - unretire package

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2173751



--- Comment #20 from Scott Williams  ---
Patches submitted to Tim's repo:
https://github.com/thansen11/mod_auth_cas_rpm/pull/3/files


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2175818] Review Request: input-leap - Share mouse and keyboard between multiple computers over the network

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2175818



--- Comment #19 from Jakub Kadlčík  ---
Created attachment 1949127
  --> https://bugzilla.redhat.com/attachment.cgi?id=1949127&action=edit
The .spec file difference from Copr build 5603815 to 5615441


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2175818
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176131] Review Request: fim - Lightweight universal image viewer

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176131

Lukas Javorsky  changed:

   What|Removed |Added

  Flags||needinfo?(ado...@redhat.com
   ||)




-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2176131
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176131] Review Request: fim - Lightweight universal image viewer

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176131



--- Comment #2 from Lukas Javorsky  ---
My notes:
- Change the license name to the commonly used GPLv2 and GPLv3 (look at files
config.guess and config.sub)
- Add version-release to the changelog entry
- Take a look at the checksum error for the key
- Resolve "Bad spec filename" error
- Check all failures from Fedora review tool


Output from the Fedora review tool from comment#1:

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Sources used to build the package match the upstream source, as provided
  in the spec URL.
  Note: Check did not completechecksum differs and there are problems
  running diff. Please verify manually.
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/


= MUST items =

C/C++:
[-]: Package does not contain kernel modules.
[-]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
 BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
 Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "GNU General Public License, Version
 2", "FSF All Permissive License", "*No copyright* GNU General Public
 License", "[generated file]", "GNU General Public License v2.0 or
 later", "FSF Unlimited License (with License Retention) GNU General
 Public License v2.0 or later [generated file]", "GNU General Public
 License v2.0 or later [generated file]", "GNU General Public License
 v3.0 or later", "FSF Unlimited License [generated file]", "X11 License
 [generated file]", "*No copyright* GNU General Public License, Version
 2", "GNU Library General Public License v2 or later". 154 files have
 unknown license. Detailed output of licensecheck in /var/lib/copr-
 rpmbuild/results/fim/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 696320 bytes in 16 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Spec f

[Bug 2175886] Review Request: golang-github-buger-goterm - Advanced terminal output in Go

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2175886



--- Comment #3 from Major Hayden 🤠  ---
Thank you, Link!

Repo requested: https://pagure.io/releng/fedora-scm-requests/issue/51833


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2175886
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2175886] Review Request: golang-github-buger-goterm - Advanced terminal output in Go

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2175886



--- Comment #2 from Fedora Admin user for bugzilla script actions 
 ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-buger-goterm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2175886
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2175818] Review Request: input-leap - Share mouse and keyboard between multiple computers over the network

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2175818



--- Comment #18 from Ali Erdinc Koroglu  ---
SPEC Url:
https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/05615430-input-leap/input-leap.spec
SRPM Url:
https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/05615430-input-leap/input-leap-2.4.0%5E20230306gite71fbbfe-1.fc39.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2175818
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2173751] Review Request: mod_auth_cas - unretire package

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2173751



--- Comment #19 from Scott Williams  ---
"We don't necessarily need to wait for upstream to merge that and the pcre2
change.  We can include them in the package as patch files, with comments
linking to their upstream PRs.  In fact I recommend doing that."

The m4 one should be trivially easy.  The pcre2 PR was submitted against HEAD,
so I might create a branch against current release tag and see if I can
cherry-pick the commits into it to make the patch.  It's been over a decade
since I've rolled a significant custom .patch and last time I used regular old
diff, so this'll give me a chance to try out using `git format-patch`. 

Tim, how about I create the patches and you can plug them into the spec with
the other change?  I'll submit the patch files in a PR against your repo.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2173751
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2173940] Review Request: golang-github-quic-qpack - A minimal QPACK RFC9204 implementation in Go

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2173940

Link Dupont  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Link Dupont  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: There is no build directory. Running licensecheck on vanilla
 upstream sources. Licenses found: "Unknown or generated", "MIT
 License". 26 files have unknown license. Detailed output of
 licensecheck in /home/link/2173940-golang-github-quic-
 qpack/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 163840 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
 publishes signatures.
 Note: gpgverify is not used.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: Spec use %global instead of %define unless justified.

= EXTRA items =

Generic:
[x]: Rpmlint

[Bug 2165381] Review Request: ancient - Modern decompressor for old data compression formats

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2165381



--- Comment #11 from Fedora Admin user for bugzilla script actions 
 ---
The Pagure repository was created at https://src.fedoraproject.org/rpms/ancient


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2165381
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2173940] Review Request: golang-github-quic-qpack - A minimal QPACK RFC9204 implementation in Go

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2173940

Link Dupont  changed:

   What|Removed |Added

 CC||l...@sub-pop.net
   Doc Type|--- |If docs needed, set a value
  Flags||fedora-review?
   Assignee|nob...@fedoraproject.org|l...@sub-pop.net




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2173940
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2175886] Review Request: golang-github-buger-goterm - Advanced terminal output in Go

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2175886

Link Dupont  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Link Dupont  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: There is no build directory. Running licensecheck on vanilla
 upstream sources. Licenses found: "MIT License", "Unknown or
 generated". 17 files have unknown license. Detailed output of
 licensecheck in /home/link/2175886-golang-github-buger-
 goterm/licensecheck.txt
[-]: Package does not own files or directories owned by other packages.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
 publishes signatures.
 Note: gpgverify is not used.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: Spec use %global instead of %define unless justified.

= EXTRA items =

Generic:
[x]: Rpmlin

[Bug 2175886] Review Request: golang-github-buger-goterm - Advanced terminal output in Go

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2175886

Link Dupont  changed:

   What|Removed |Added

 CC||l...@sub-pop.net
   Assignee|nob...@fedoraproject.org|l...@sub-pop.net
  Flags||fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2175886
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176342] Review Request: yggdrasil-worker-package-manager - Package manager worker for yggdrasil

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176342



--- Comment #1 from Link Dupont  ---
Spec URL:
https://linkdupont.fedorapeople.org/yggdrasil-worker-package-manager.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-rawhide-x86_64/05604871-yggdrasil-worker-package-manager/yggdrasil-worker-package-manager-0.2.0-1.fc39.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2176342
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176394



--- Comment #7 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5615144
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2176394-xine-ui/fedora-rawhide-x86_64/05615144-xine-ui/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2176394
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176394



--- Comment #6 from Jakub Kadlčík  ---
Created attachment 1949075
  --> https://bugzilla.redhat.com/attachment.cgi?id=1949075&action=edit
The .spec file difference from Copr build 5613863 to 5615144


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2176394
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2174438] Review Request: painless-password-rotation - Automates password rotation using HashiCorp Vault

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2174438



--- Comment #8 from Jakub Kadlčík  ---
Created attachment 1949074
  --> https://bugzilla.redhat.com/attachment.cgi?id=1949074&action=edit
The .spec file difference from Copr build 5603067 to 5615159


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2174438
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2174438] Review Request: painless-password-rotation - Automates password rotation using HashiCorp Vault

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2174438



--- Comment #9 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5615159
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2174438-painless-password-rotation/fedora-rawhide-x86_64/05615159-painless-password-rotation/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2174438
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2168538] Review Request: minidlna - Lightweight DLNA/UPnP-AV server targeted at embedded systems

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2168538



--- Comment #8 from Jakub Kadlčík  ---
Created attachment 1949060
  --> https://bugzilla.redhat.com/attachment.cgi?id=1949060&action=edit
The .spec file difference from Copr build 5528322 to 5615128


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2168538
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2168538] Review Request: minidlna - Lightweight DLNA/UPnP-AV server targeted at embedded systems

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2168538



--- Comment #9 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5615128
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2168538-minidlna/fedora-rawhide-x86_64/05615128-minidlna/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2168538
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2174438] Review Request: painless-password-rotation - Automates password rotation using HashiCorp Vault

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2174438



--- Comment #7 from Salman Butt  ---
Summary of Changes:
* Added preserve timestamp
* Updated BuildRequires
(https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_systemd)

In regards to file: painless-password-rotation.noarch: E: non-readable
/etc/sysconfig/vault-rotate 600
This is intentionally set to 0600 since it is meant to store a token that the
API uses to communicate with the Vault Server
The token should only be accessed by the root user to avoid misuse and
potential sealing of the server; brute force attempts.

Spec URL: https://cn137.fedorapeople.org/painless-password-rotation.spec
SRPM URL:
https://cn137.fedorapeople.org/painless-password-rotation-0.3-2.fc39.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2174438
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176394



--- Comment #5 from Xavier Bachelot  ---
Thanks Neal, all (and more) fixed:
- Use SPDX License: tag
- Drop useless conditionals
- Drop useless comments
- Add EL7 cond for %%post/%%postun
- Escape unescaped %% in %%changelog
- Drop very old Obsoletes:/Provides: for xine/xine-skins

Spec URL: https://www.bachelot.org/fedora/SPECS/xine-ui.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/xine-ui-0.99.14-2.fc39.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2176394
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2175818] Review Request: input-leap - Share mouse and keyboard between multiple computers over the network

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2175818



--- Comment #17 from Brian J. Murrell  ---
Heh, yes.  I tend to forget that synergy is dead to me, but not everyone.

So I agree that probably only Obsoletes+Provides for barrier is appropriate.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2175818
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2175159] Review Request: jurand - A tool for manipulating Java symbols

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2175159

Mikolaj Izdebski  changed:

   What|Removed |Added

 Resolution|--- |RAWHIDE
 Status|ASSIGNED|CLOSED
Last Closed||2023-03-08 14:22:58



--- Comment #10 from Mikolaj Izdebski  ---
Package has been built for rawhide.
Bodhi update: https://bodhi.fedoraproject.org/updates/FEDORA-2023-d30349c2f7
This update has been submitted for stable by bodhi.
Closing review as resolved.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2175159
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2158825] Review Request: python-hid-parser - Parse HID report descriptors

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2158825

Jakub Kadlčík  changed:

   What|Removed |Added

URL||https://github.com/FFY00/py
   ||thon-hid-parser



--- Comment #4 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5614988
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2158825-python-hid-parser/fedora-rawhide-x86_64/05614988-python-hid-parser/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2158825
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176391



--- Comment #11 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5614984
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2176391-vcdimager/fedora-rawhide-x86_64/05614984-vcdimager/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2176391
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176391



--- Comment #10 from Jakub Kadlčík  ---
Created attachment 1949047
  --> https://bugzilla.redhat.com/attachment.cgi?id=1949047&action=edit
The .spec file difference from Copr build 5614851 to 5614984


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2176391
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2158825] Review Request: python-hid-parser - Parse HID report descriptors

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2158825

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

  Flags|needinfo?(dominik@greysecto |
   |r.net)  |



--- Comment #3 from Dominik 'Rathann' Mierzejewski  ---
Thanks for the review, Troy.
I was on vacation, sorry for delayed response.

(In reply to Troy Curtis from comment #2)
> Issues
> ==
> - This project can use the build dependency generator instead of manually
> specifying them (other than python3-devel of course):
> 
> %generate_buildrequires
> %pyproject_buildrequires -x test
> 
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
> #Automatically-generated-dependencies

Done.

Spec URL:
https://rathann.fedorapeople.org/review/python-hid-parser/python-hid-parser.spec
SRPM URL:
https://rathann.fedorapeople.org/review/python-hid-parser/python-hid-parser-0.0.3-2.fc37.src.rpm

* Wed Mar 08 2023 Dominik Mierzejewski  - 0.0.3-2
- use automatic BuildRequires generation
- conditionalize running tests


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2158825
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2175818] Review Request: input-leap - Share mouse and keyboard between multiple computers over the network

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2175818



--- Comment #16 from Ali Erdinc Koroglu  ---
Ok, we can obsolete barrier (primary developers moved to inputleap) but not
sure about synergy.

https://github.com/symless/synergy-core/commits/master
https://src.fedoraproject.org/rpms/synergy/commits/rawhide


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2175818
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176391



--- Comment #9 from Xavier Bachelot  ---
Fixed License: to use SPDX and manpages to use a glob instead of fixed .gz.


Spec URL: https://www.bachelot.org/fedora/SPECS/vcdimager.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/vcdimager-2.0.1-16.fc39.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2176391
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


needinfo canceled: [Bug 2042375] Review Request: gpu-trace - Simple script to collect GPU traces

2023-03-08 Thread bugzilla


Product: Fedora
Version: rawhide
Component: Package Review

Dorinda  has canceled Package Review
's request for Dorinda
's needinfo:
Bug 2042375: Review Request: gpu-trace -  Simple script to collect GPU traces
https://bugzilla.redhat.com/show_bug.cgi?id=2042375
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2042375] Review Request: gpu-trace - Simple script to collect GPU traces

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2042375

Dorinda  changed:

   What|Removed |Added

  Flags|needinfo?(dbas...@redhat.co |
   |m)  |




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2042375
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2175818] Review Request: input-leap - Share mouse and keyboard between multiple computers over the network

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2175818



--- Comment #15 from Brian J. Murrell  ---
Ahh.  Good catch on replacing synergy as well Neal.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2175818
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176391



--- Comment #8 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5614851
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2176391-vcdimager/fedora-rawhide-x86_64/05614851-vcdimager/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2176391
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176391



--- Comment #7 from Jakub Kadlčík  ---
Created attachment 1949028
  --> https://bugzilla.redhat.com/attachment.cgi?id=1949028&action=edit
The .spec file difference from Copr build 5613857 to 5614851


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2176391
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2175818] Review Request: input-leap - Share mouse and keyboard between multiple computers over the network

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2175818



--- Comment #14 from Neal Gompa  ---
That means we need "Obsoletes+Provides" stanza for barrier (and potentially
synergy too...)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2175818
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2175818] Review Request: input-leap - Share mouse and keyboard between multiple computers over the network

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2175818



--- Comment #13 from Neal Gompa  ---
No, the package replacement needs to be part of this package review, since it
is intended to replace barrier and synergy.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2175818
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2175818] Review Request: input-leap - Share mouse and keyboard between multiple computers over the network

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2175818



--- Comment #12 from Brian J. Murrell  ---
Hi Ali.

It seems like adding Obsoletes: would be part of the package approval process
(it's going to modify the specfile after all) and discussing it afterward would
be like discussing how to get the toothpaste out of the tube after it's already
all been squeezed out.

Or am I misunderstanding something?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2175818
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176394



--- Comment #4 from Neal Gompa  ---
> It also contains the %{!?_without_caca:color ascii art and} framebuffer 
> version%{!?_without_caca:s}.

One more of the conditional goop that can be dropped too.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2176394
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176394



--- Comment #3 from Neal Gompa  ---
Initial spec review:

> %{!?_without_caca:BuildRequires:  libcaca-devel}
> %{!?_without_lirc:BuildRequires:  lirc-devel}

We can drop the conditional goop here since it's available everywhere xine-lib
is (EPEL9 and Fedora)

> %if 0%{!?_without_lirc}
> export LIRC_CFLAGS="-llirc_client"
> export LIRC_LIBS="-llirc_client"
> %endif

Ditto for here too.

> %if 0%{?rhel} && 0%{?rhel} < 8
> %post
> # Mime type
> update-desktop-database &> /dev/null || :
> update-mime-database %{_datadir}/mime &> /dev/null || :
> # Icon cache
> touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
> 
> %postun
> # Mime type
> update-desktop-database &> /dev/null || :
> update-mime-database %{_datadir}/mime &> /dev/null || :
> # Icon cache
> if [ $1 -eq 0 ] ; then
> touch --no-create %{_datadir}/icons/hicolor &>/dev/null
> gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
> fi
> 
> %posttrans
> gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
> %endif

We can drop all this since this package can't be built on anything older than
EPEL 9.

> %{!?_without_caca:%{_bindir}/cacaxine}

We can drop the conditional goop here since it's available everywhere xine-lib
is (EPEL9 and Fedora)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2176394
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176391



--- Comment #4 from Xavier Bachelot  ---
Thanks Neal.

All fixed in :
Spec URL: https://www.bachelot.org/fedora/SPECS/vcdimager.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/vcdimager-2.0.1-15.fc39.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2176391
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176391



--- Comment #6 from Neal Gompa  ---
> %{_mandir}/man1/cdxa2mpeg.1.gz
> %{_mandir}/man1/vcd-info.1.gz
> %{_mandir}/man1/vcdimager.1.gz
> %{_mandir}/man1/vcdxbuild.1.gz
> %{_mandir}/man1/vcdxgen.1.gz
> %{_mandir}/man1/vcdxminfo.1.gz
> %{_mandir}/man1/vcdxrip.1.gz

Please use "1*" here, because we don't guarantee gzipped man pages


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2176391
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176391



--- Comment #5 from Neal Gompa  ---
Oh I missed one...

> License: GPLv2+

This needs to be "GPL-2.0-or-later" now.

Cf.
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_valid_license_short_names


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2176391
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2162851] Review Request: symcrypt - Cryptographic library

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2162851



--- Comment #8 from Petr Menšík  ---
Created attachment 1949025
  --> https://bugzilla.redhat.com/attachment.cgi?id=1949025&action=edit
Include all headers patch

Additional change on top of previous. Make devel require pkgconfig to own
%_libdir/pkgconfig directory. And include also static headers from source dir
into headers, making them hopefully usable. Because there are quite a lot
required local files, move headers into %_includedir/SymCrypt subdirectory.
Should provide working pkg-config including those paths.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2162851
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176391



--- Comment #3 from Neal Gompa  ---
Initial spec review:

> Requires(post):  info
> Requires(preun): info

This is only needed for EL7. EL8 and newer have file triggers so this should be
dropped for them.

> find $RPM_BUILD_ROOT -type f -name "*.la" -exec rm -f {} ';'

This should be %{buildroot} for consistency

> %post libs -p /sbin/ldconfig
> %postun libs -p /sbin/ldconfig

This is only needed for EL7. If you want to have EL7 compatibility, please
switch to "%ldconfig_scriptlets libs" instead, so it becomes a no-op on EL8+
and Fedora.

> %post
> for infofile in vcdxrip.info vcdimager.info vcd-info.info; do
>   /sbin/install-info %{_infodir}/${infofile} %{_infodir}/dir 2>/dev/null || :
> done
> 
> %preun
> if [ $1 -eq 0 ]; then
>   for infofile in vcdxrip.info vcdimager.info vcd-info.info; do
> /sbin/install-info --delete %{_infodir}/${infofile} %{_infodir}/dir \
>   2>/dev/null || :
>   done
> fi

This is only needed for EL7. EL8 and newer have file triggers so this should be
dropped for them.

> %{_bindir}/*
> %{_mandir}/man1/*

This kind of globbing is not explicit/specific enough, there's no way to tell
if the package may add conflicting binaries.

Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2176391
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176391

Neal Gompa  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?
 Status|NEW |ASSIGNED



--- Comment #2 from Neal Gompa  ---
Taking this review.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2176391
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176394

Neal Gompa  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
 Status|NEW |ASSIGNED
  Flags||fedora-review?



--- Comment #2 from Neal Gompa  ---
Taking this review.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2176394
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2162851] Review Request: symcrypt - Cryptographic library

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2162851

Petr Menšík  changed:

   What|Removed |Added

 Status|POST|ASSIGNED



--- Comment #7 from Petr Menšík  ---
Oh, found created SymCrypt-devel package is not usable. It is missing main
symcrypt.h header and its dependencies. It seems those headers should go into
subdirectory, because they need a lot of files with names unrelated to the
package.

Tried to use it for building SymCrypt-OpenSSL, but found there are missing
headers in it.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2162851
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176241] Review Request: golang-github-zcalusic-sysinfo - Sysinfo is a Go library providing Linux OS / kernel / hardware system information

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176241



--- Comment #2 from Link Dupont  ---
Wow, I didn't notice that the spec produced by a build does not contain the
autochangelog bits. I did use autochangelog. Here's the spec I used to produce
the srpm.

https://linkdupont.fedorapeople.org/golang-github-zcalusic-sysinfo.spec


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2176241
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2162851] Review Request: symcrypt - Cryptographic library

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2162851



--- Comment #6 from Benson Muite  ---
Thanks. Made most of the updates. Getting following from fedora-review on
AArch64, see 
https://copr.fedorainfracloud.org/coprs/fed500/SymCrypt/build/5612997/

SymCrypt.aarch64: E: undefined-non-weak-symbol
/usr/lib64/libsymcrypt.so.103.1.0 __aarch64_ldset4_relax
(/usr/lib64/libsymcrypt.so.103.1.0)
SymCrypt.aarch64: E: undefined-non-weak-symbol
/usr/lib64/libsymcrypt.so.103.1.0 __aarch64_ldadd8_relax
(/usr/lib64/libsymcrypt.so.103.1.0)
SymCrypt-devel.aarch64: E: no-ldconfig-symlink /usr/lib64/libsymcrypt.so
SymCrypt-devel.aarch64: W: no-documentation
SymCrypt-devel.aarch64: W: library-not-linked-against-libc
/usr/lib64/libsymcrypt.so
SymCrypt.aarch64: W: library-not-linked-against-libc
/usr/lib64/libsymcrypt.so.103.1.0
SymCrypt-debuginfo.aarch64: E: files-duplicated-waste 1445656
SymCrypt-devel.aarch64: E: double-slash-in-pkgconfig-path
/usr/lib64/pkgconfig/symcrypt.pc includedir=${prefix}//usr/include/symcrypt

Once have resolved, will upload to the repo.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2162851
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176394

Jakub Kadlčík  changed:

   What|Removed |Added

URL||http://www.xine-project.org
   ||/



--- Comment #1 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5613863
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2176394-xine-ui/fedora-rawhide-x86_64/05613863-xine-ui/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2176394
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176171] Review Request: R-httr2 - Perform HTTP Requests and Process the Responses

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176171



--- Comment #3 from Iñaki Ucar  ---
A test and a vignette seem to require Internet access, and the checks fail.
Again, I would remove that test and check without rebuilding vignettes.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2176171
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176391

Jakub Kadlčík  changed:

   What|Removed |Added

URL||http://www.gnu.org/software
   ||/vcdimager/



--- Comment #1 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5613857
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2176391-vcdimager/fedora-rawhide-x86_64/05613857-vcdimager/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2176391
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176171] Review Request: R-httr2 - Perform HTTP Requests and Process the Responses

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176171

Iñaki Ucar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|i.uca...@gmail.com
  Flags||fedora-review?




-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2176171
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176394

Xavier Bachelot  changed:

   What|Removed |Added

   Doc Type|--- |If docs needed, set a value
 CC||ngomp...@gmail.com




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2176394
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176394] New: Review Request: xine-ui - A skinned xlib-based gui for xine-lib

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176394

Bug ID: 2176394
   Summary: Review Request: xine-ui - A skinned xlib-based gui for
xine-lib
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: xav...@bachelot.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://www.bachelot.org/fedora/SPECS/xine-ui.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/xine-ui-0.99.14-1.fc39.src.rpm
Description: xine-ui is the traditional, skinned GUI for xine-lib

Fedora Account System Username: xavierb


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2176394
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176171] Review Request: R-httr2 - Perform HTTP Requests and Process the Responses

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176171

Iñaki Ucar  changed:

   What|Removed |Added

 CC||i.uca...@gmail.com



--- Comment #2 from Iñaki Ucar  ---
I would just remove the particular test file that uses docopt instead of
packaging it... Packages should work fine without Suggests, including tests
(except of course for the test suite), so this kind of thing is a bug really.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2176171
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176391] Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176391

Xavier Bachelot  changed:

   What|Removed |Added

   Doc Type|--- |If docs needed, set a value
 CC||ngomp...@gmail.com




-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2176391
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176391] New: Review Request: vcdimager - VideoCD (pre-)mastering and ripping tool

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176391

Bug ID: 2176391
   Summary: Review Request: vcdimager - VideoCD (pre-)mastering
and ripping tool
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: xav...@bachelot.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://www.bachelot.org/fedora/SPECS/vcdimager.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/vcdimager-2.0.1-14.fc39.src.rpm
Description:
VCDImager allows you to create VideoCD BIN/CUE CD images from MPEG
files. These can be burned with cdrdao or any other program capable of
burning BIN/CUE files.

Also included is VCDRip which does the reverse operation, that is to
rip MPEG streams from images or burned VideoCDs and to show
information about a VideoCD.

Fedora Account System Username: xavierb


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2176391
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176241] Review Request: golang-github-zcalusic-sysinfo - Sysinfo is a Go library providing Linux OS / kernel / hardware system information

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176241

Mikel Olasagasti Uranga  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|mi...@olasagasti.info
   Doc Type|--- |If docs needed, set a value
 CC||mi...@olasagasti.info
 Status|NEW |ASSIGNED
  Flags||fedora-review?



--- Comment #1 from Mikel Olasagasti Uranga  ---
> ## START: Set by rpmautospec
> ## (rpmautospec version 0.3.5)
> ## RPMAUTOSPEC: autorelease, autochangelog
> %define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
> release_number = 1;
> base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
> print(release_number + base_release_number - 1);
> }%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
> ## END: Set by rpmautospec

Is this block required nowadays?

> %global golicenses  LICENSE

You're missing cpuid/LICENSE, you can try with something like:

%global golicenses  LICENSE cpuid-LICENSE
(...)
%install
%gopkginstall
mv cpuid/LICENSE cpuid-LICENSE
(...)
%license LICENSE cpuid-LICENSE


> %changelog
> * Tue Mar 07 2023 Link Dupont  - 0.9.5-1
> - Intitial package

I suggest to use %autochangelog to make it easier to maintain the spec in the
future, but not a hard requirement.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2176241
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176170] Review Request: R-docopt - Command-Line Interface Specification Language

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176170

Iñaki Ucar  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|i.uca...@gmail.com
  Flags||fedora-review+
   Doc Type|--- |If docs needed, set a value
 Status|NEW |POST
 CC||i.uca...@gmail.com



--- Comment #2 from Iñaki Ucar  ---
All ok (copying the review below for reference). Package approved.
Just please use the URL field as specified in the package guidelines upon
package import:

URL:  https://CRAN.R-project.org/package=%{packname}
Source:   %{url}&version=%{packver}#/%{packname}_%{packver}.tar.gz


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package have the default element marked as %%doc :DESCRIPTION, NEWS
- Package requires R-core.


= MUST items =

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
 Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "*No copyright* MIT License", "Unknown or generated", "MIT
 License". 24 files have unknown license. Detailed output of
 licensecheck in /var/lib/copr-
 rpmbuild/results/R-docopt/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

R:
[x]: Package contains the mandatory BuildRequires.
[x]: The package has the standard %install section.

= SHOULD items =

Generic:
[!]: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep

[Bug 2172050] Review Request: build-helper-maven-plugin - Build Helper Maven Plugin

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2172050

Mikolaj Izdebski  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2023-03-08 09:53:16



--- Comment #6 from Mikolaj Izdebski  ---
Renamed package was pushed to rawhide:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-4cf91103db
Closing.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2172050
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2172052] Review Request: maven-bundle-plugin - Maven Bundle Plugin

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2172052

Mikolaj Izdebski  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2023-03-08 09:53:11



--- Comment #6 from Mikolaj Izdebski  ---
Renamed package was pushed to rawhide:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-663517ef98
Closing.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2172052
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2176131] Review Request: fim - Lightweight universal image viewer

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2176131

Lukas Javorsky  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|ljavo...@redhat.com
 CC||ljavo...@redhat.com
 Blocks||177841 (FE-NEEDSPONSOR)
  Flags||fedora-review?





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2176131
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=177841

Lukas Javorsky  changed:

   What|Removed |Added

 Depends On||2176131





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2176131
[Bug 2176131] Review Request: fim - Lightweight universal image viewer
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=177841
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2172050] Review Request: build-helper-maven-plugin - Build Helper Maven Plugin

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2172050

Mikolaj Izdebski  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED




-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2172050
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2172052] Review Request: maven-bundle-plugin - Maven Bundle Plugin

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2172052

Mikolaj Izdebski  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED




-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2172052
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2172052] Review Request: maven-bundle-plugin - Maven Bundle Plugin

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2172052



--- Comment #5 from Fedora Admin user for bugzilla script actions 
 ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/maven-bundle-plugin


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2172052
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue


[Bug 2172050] Review Request: build-helper-maven-plugin - Build Helper Maven Plugin

2023-03-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2172050



--- Comment #5 from Fedora Admin user for bugzilla script actions 
 ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/build-helper-maven-plugin


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2172050
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue