[Bug 2101811] Review Request: ghc-shell-monad - Shell monad
https://bugzilla.redhat.com/show_bug.cgi?id=2101811 Jens Petersen changed: What|Removed |Added Severity|unspecified |low -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2101811 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219471] Review Request: rust-prodash - Dashboard for visualizing progress of asynchronous and possibly blocking tasks
https://bugzilla.redhat.com/show_bug.cgi?id=2219471 Fedora Update System changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2023-07-06 04:12:09 --- Comment #10 from Fedora Update System --- FEDORA-2023-4a0d885d08 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2219471 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219471%23c10 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219471] Review Request: rust-prodash - Dashboard for visualizing progress of asynchronous and possibly blocking tasks
https://bugzilla.redhat.com/show_bug.cgi?id=2219471 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #9 from Fedora Update System --- FEDORA-2023-4a0d885d08 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-4a0d885d08 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2219471 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219471%23c9 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219471] Review Request: rust-prodash - Dashboard for visualizing progress of asynchronous and possibly blocking tasks
https://bugzilla.redhat.com/show_bug.cgi?id=2219471 --- Comment #8 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-prodash -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2219471 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219471%23c8 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2216600] Review Request: kaidan - A XMPP client based on KDE Framework
https://bugzilla.redhat.com/show_bug.cgi?id=2216600 Fedora Review Service changed: What|Removed |Added URL||https://www.kaidan.im --- Comment #6 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6145392 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2216600-kaidan/fedora-rawhide-x86_64/06145392-kaidan/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2216600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202216600%23c6 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2216600] Review Request: kaidan - A XMPP client based on KDE Framework
https://bugzilla.redhat.com/show_bug.cgi?id=2216600 --- Comment #5 from Felix Wang --- Note: At present, the build of qxmpp package failed on f37, due to the issue of https://bugzilla.redhat.com/show_bug.cgi?id=2216479 Ref: https://src.fedoraproject.org/rpms/qxmpp/c/4302e2d9de0e5aeab8ff40571a8a004919061dbf?branch=rawhide -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2216600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202216600%23c5 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2216600] Review Request: kaidan - A XMPP client based on KDE Framework
https://bugzilla.redhat.com/show_bug.cgi?id=2216600 --- Comment #4 from Felix Wang --- Thanks for your advice of reviewing this package. SPEC URL: https://topazus.fedorapeople.org/rpms/kaidan.spec SRPM URL: https://topazus.fedorapeople.org/rpms/kaidan-0.9.1-1.fc39.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2216600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202216600%23c4 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2216600] Review Request: kaidan - A XMPP client based on KDE Framework
https://bugzilla.redhat.com/show_bug.cgi?id=2216600
--- Comment #3 from Felix Wang ---
> First, add the following as a build dependancy:
> BuildRequires: kf5-rpm-macros
> %build
> %cmake_kf5
> %cmake_build
> Next, those should be added as requirements. I have a couple packages myself
> built for KDE and I was instructed to add this for packages using the QML
> module:>
> # QML module dependencies
> Requires: kf5-kirigami2%{?_isa}
> Requires: kf5-kirigami2-addons%{?_isa}
> Requires: kf5-kquickcharts%{?_isa}
> Requires: qt5-qtgraphicaleffects%{?_isa}
> Requires: qt5-qtquickcontrols2%{?_isa}
> Requires: qt5-qtwebchannel%{?_isa}
> Requires: qt5-qtwebengine%{?_isa}
Done.
> Next, under files, replace:
> %{_datadir}/icons/hicolor/*/apps/%{name}.*
> with:
> %{_datadir}/icons/hicolor/128x128/apps/kaidan.png
> %{_datadir}/icons/hicolor/scalable/apps/kaidan.svg
> Reason: For shared folders, you should not be using wildcards
> (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists)
I see the posted link, it seemed it said that it should not use wilcards to
include all files of a directory.
Anyway, it is a proper suggestion and can explicitly list all files in the
directory.
> Packagers SHOULD NOT simply glob everything under a shared directory.
> In particular, the following SHOULD NOT be used in %files:
> %{_bindir}/*
> %{_datadir}/*
> %{_includedir}/*
> %{_mandir}/*
> %{_docdir}/*
> Lastly, the Source0 should use the KDE invent tags system, specially if
> Kaidan ever becomes part of the KDE gear. In this > case, it would look
> something like:
> Source0:
> https://invent.kde.org/network/%{name}/-/archive/v%{version}/%{name}-v%{version}.tar.gz
Done.
> %if 0%{?fedora} || 0%{?epel} > 7
> # handled by qt5-srpm-macros, which defines %%qt5_qtwebengine_arches
> # Package doesn't build on arches that qtwebengine is not built on.
> ExclusiveArch: %{qt5_qtwebengine_arches}
> %endif
Added this.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2216600
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202216600%23c3
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219161] Review Request: python-multiecho - Combine multi-echoes from a multi-echo fMRI acquisition
https://bugzilla.redhat.com/show_bug.cgi?id=2219161 --- Comment #12 from Fedora Update System --- FEDORA-2023-266fe74b3b has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-266fe74b3b \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-266fe74b3b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2219161 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219161%23c12 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2208531] Review Request: glsl-language-server - Language server implementation for GLSL
https://bugzilla.redhat.com/show_bug.cgi?id=2208531 --- Comment #12 from Fedora Update System --- FEDORA-2023-8aeb5f5290 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2208531 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202208531%23c12 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219161] Review Request: python-multiecho - Combine multi-echoes from a multi-echo fMRI acquisition
https://bugzilla.redhat.com/show_bug.cgi?id=2219161 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- FEDORA-2023-0f6002ce59 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-0f6002ce59 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-0f6002ce59 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2219161 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219161%23c11 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219919] Review Request: rust-equivalent - Traits for key comparison in maps
https://bugzilla.redhat.com/show_bug.cgi?id=2219919 Fedora Update System changed: What|Removed |Added Resolution|--- |ERRATA Status|MODIFIED|CLOSED Last Closed||2023-07-06 01:18:24 --- Comment #6 from Fedora Update System --- FEDORA-2023-845dde2b09 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2219919 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219919%23c6 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219911] Review Request: rust-allocator-api2 - Mirror of Rust's allocator API
https://bugzilla.redhat.com/show_bug.cgi?id=2219911 Fedora Update System changed: What|Removed |Added Resolution|--- |ERRATA Status|MODIFIED|CLOSED Last Closed||2023-07-06 01:18:20 --- Comment #9 from Fedora Update System --- FEDORA-2023-845dde2b09 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2219911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219911%23c9 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219919] Review Request: rust-equivalent - Traits for key comparison in maps
https://bugzilla.redhat.com/show_bug.cgi?id=2219919 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #5 from Fedora Update System --- FEDORA-2023-845dde2b09 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-845dde2b09 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2219919 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219919%23c5 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219911] Review Request: rust-allocator-api2 - Mirror of Rust's allocator API
https://bugzilla.redhat.com/show_bug.cgi?id=2219911 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #8 from Fedora Update System --- FEDORA-2023-845dde2b09 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-845dde2b09 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2219911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219911%23c8 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2214429] Review Request: rust-axum - Web framework that focuses on ergonomics and modularity
https://bugzilla.redhat.com/show_bug.cgi?id=2214429 Bug 2214429 depends on bug 2214389, which changed state. Bug 2214389 Summary: Review Request: rust-sync_wrapper - Tool for enlisting the compiler’s help in proving the absence of concurrency https://bugzilla.redhat.com/show_bug.cgi?id=2214389 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2214429 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2214385] Review Request: rust-serde_path_to_error - Path to the element that failed to deserialize
https://bugzilla.redhat.com/show_bug.cgi?id=2214385 Fabio Valentini changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Fixed In Version||rust-serde_path_to_error-0. ||1.11-1.fc39 Last Closed||2023-07-06 00:16:53 --- Comment #5 from Fabio Valentini --- Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-75f9d221e0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2214385 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202214385%23c5 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2214429] Review Request: rust-axum - Web framework that focuses on ergonomics and modularity
https://bugzilla.redhat.com/show_bug.cgi?id=2214429 Bug 2214429 depends on bug 2214385, which changed state. Bug 2214385 Summary: Review Request: rust-serde_path_to_error - Path to the element that failed to deserialize https://bugzilla.redhat.com/show_bug.cgi?id=2214385 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2214429 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2214389] Review Request: rust-sync_wrapper - Tool for enlisting the compiler’s help in proving the absence of concurrency
https://bugzilla.redhat.com/show_bug.cgi?id=2214389 Fabio Valentini changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||rust-sync_wrapper-0.1.2-1.f ||c39 Resolution|--- |RAWHIDE Last Closed||2023-07-06 00:16:34 --- Comment #5 from Fabio Valentini --- Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-188e6b67b9 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2214389 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202214389%23c5 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2214390] Review Request: rust-hdrhistogram - Port of HdrHistogram to Rust
https://bugzilla.redhat.com/show_bug.cgi?id=2214390 Fabio Valentini changed: What|Removed |Added Resolution|--- |RAWHIDE Fixed In Version||rust-hdrhistogram-7.5.2-1.f ||c39 Status|POST|CLOSED Last Closed||2023-07-06 00:15:57 --- Comment #5 from Fabio Valentini --- Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-f4b70e6687 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2214390 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202214390%23c5 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2214392] Review Request: rust-tower - Library of modular and reusable components for building robust clients and servers
https://bugzilla.redhat.com/show_bug.cgi?id=2214392 Bug 2214392 depends on bug 2214390, which changed state. Bug 2214390 Summary: Review Request: rust-hdrhistogram - Port of HdrHistogram to Rust https://bugzilla.redhat.com/show_bug.cgi?id=2214390 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2214392 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2214390] Review Request: rust-hdrhistogram - Port of HdrHistogram to Rust
https://bugzilla.redhat.com/show_bug.cgi?id=2214390 --- Comment #4 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-hdrhistogram -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2214390 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202214390%23c4 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2214390] Review Request: rust-hdrhistogram - Port of HdrHistogram to Rust
https://bugzilla.redhat.com/show_bug.cgi?id=2214390 --- Comment #3 from Fabio Valentini --- Thanks for the review! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2214390 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202214390%23c3 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2214389] Review Request: rust-sync_wrapper - Tool for enlisting the compiler’s help in proving the absence of concurrency
https://bugzilla.redhat.com/show_bug.cgi?id=2214389 --- Comment #4 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sync_wrapper -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2214389 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202214389%23c4 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2214389] Review Request: rust-sync_wrapper - Tool for enlisting the compiler’s help in proving the absence of concurrency
https://bugzilla.redhat.com/show_bug.cgi?id=2214389 --- Comment #3 from Fabio Valentini --- Thanks for the review! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2214389 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202214389%23c3 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2214385] Review Request: rust-serde_path_to_error - Path to the element that failed to deserialize
https://bugzilla.redhat.com/show_bug.cgi?id=2214385 --- Comment #4 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-serde_path_to_error -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2214385 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202214385%23c4 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2214385] Review Request: rust-serde_path_to_error - Path to the element that failed to deserialize
https://bugzilla.redhat.com/show_bug.cgi?id=2214385 --- Comment #3 from Fabio Valentini --- Thanks for the review! I'll update the package ASAP. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2214385 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202214385%23c3 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219919] Review Request: rust-equivalent - Traits for key comparison in maps
https://bugzilla.redhat.com/show_bug.cgi?id=2219919 --- Comment #4 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-equivalent -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2219919 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219919%23c4 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2214338] Review Request: rust-databake - Trait that lets structs represent themselves as (const) Rust expressions
https://bugzilla.redhat.com/show_bug.cgi?id=2214338 Fabio Valentini changed: What|Removed |Added Resolution|--- |RAWHIDE Fixed In Version||rust-databake-0.1.5-1.fc39 Status|POST|CLOSED Last Closed||2023-07-05 23:12:36 --- Comment #5 from Fabio Valentini --- Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-22be7fee6a -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2214338 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202214338%23c5 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2214339] Review Request: rust-gimoji - Easily add emojis to your git commit messages
https://bugzilla.redhat.com/show_bug.cgi?id=2214339 Bug 2214339 depends on bug 2214338, which changed state. Bug 2214338 Summary: Review Request: rust-databake - Trait that lets structs represent themselves as (const) Rust expressions https://bugzilla.redhat.com/show_bug.cgi?id=2214338 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2214339 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219471] Review Request: rust-prodash - Dashboard for visualizing progress of asynchronous and possibly blocking tasks
https://bugzilla.redhat.com/show_bug.cgi?id=2219471 Fabio Valentini changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #7 from Fabio Valentini --- Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches === It would be great if you added a comment in the spec file to describe what the patch does (something like "remove unused optional features with missing dependencies"). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2219471 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219471%23c7 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219919] Review Request: rust-equivalent - Traits for key comparison in maps
https://bugzilla.redhat.com/show_bug.cgi?id=2219919
blinxen changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|h-k...@hotmail.com
Status|NEW |POST
Doc Type|--- |If docs needed, set a value
CC||h-k...@hotmail.com
Flags||fedora-review+
--- Comment #3 from blinxen ---
Taking this review
General comments:
- Package was generated with rust2rpm and no changes were made
APPROVED
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* Apache License 2.0",
"MIT License". 5 files have unknown license. Detailed output of
licensecheck in /var/lib/copr-rpmbuild/results/rust-
equivalent/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust-
equivalent-devel , rust-equivalent+default-devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources
[Bug 2214390] Review Request: rust-hdrhistogram - Port of HdrHistogram to Rust
https://bugzilla.redhat.com/show_bug.cgi?id=2214390
blinxen changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|h-k...@hotmail.com
Doc Type|--- |If docs needed, set a value
CC||h-k...@hotmail.com
Flags||fedora-review+
Status|NEW |POST
--- Comment #2 from blinxen ---
Taking this review
General comments:
- Package was generated with rust2rpm and tests were deactivated
- Tests were deactivated because of missing dependencies --> Should be OK but
as always running tests would be preffered
Questions:
- The cargo.toml file defines:
```
[profile.release]
debug=true
```
From my understanding [1] this would only make sense when building a binary.
Does this have any affect on library crates? (This is not really an issue, so
approving should be OK)
[1] https://doc.rust-lang.org/cargo/reference/profiles.html#debug
APPROVED
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* Apache License 2.0",
"MIT License", "*No copyright* Apache License (v2.0) or MIT license".
57 files have unknown license. Detailed output of licensecheck in
/var/lib/copr-rpmbuild/results/rust-hdrhistogram/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include
[Bug 2214389] Review Request: rust-sync_wrapper - Tool for enlisting the compiler’s help in proving the absence of concurrency
https://bugzilla.redhat.com/show_bug.cgi?id=2214389
blinxen changed:
What|Removed |Added
Doc Type|--- |If docs needed, set a value
Assignee|nob...@fedoraproject.org|h-k...@hotmail.com
Flags||fedora-review+
Status|NEW |POST
CC||h-k...@hotmail.com
--- Comment #2 from blinxen ---
Taking this review
General comments:
- Package was generated with rust2rpm and no changes were made
APPROVED
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* Apache License 2.0",
"Apache License 2.0". 4 files have unknown license. Detailed output of
licensecheck in /var/lib/copr-rpmbuild/results/rust-
sync_wrapper/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust-
sync_wrapper-devel , rust-sync_wrapper+default-devel , rust-
sync_wrapper+futures-devel , rust-sync_wrapper+futures-core-devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with
[Bug 2214385] Review Request: rust-serde_path_to_error - Path to the element that failed to deserialize
https://bugzilla.redhat.com/show_bug.cgi?id=2214385
blinxen changed:
What|Removed |Added
Status|NEW |POST
CC||h-k...@hotmail.com
Doc Type|--- |If docs needed, set a value
Assignee|nob...@fedoraproject.org|h-k...@hotmail.com
Flags||fedora-review+
--- Comment #2 from blinxen ---
Taking this review
General comments:
- Package was generated with rust2rpm and no changes were made
- Packaged crate has a newer release 0.1.13, might want to update first before
building this in rawhide
APPROVED
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* Apache License 2.0",
"*No copyright* MIT License". 14 files have unknown license. Detailed
output of licensecheck in /var/lib/copr-rpmbuild/results/rust-
serde_path_to_error/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[-]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust-
serde_path_to_error-devel , rust-serde_path_to_error+default-devel
[?]:
[Bug 2219911] Review Request: rust-allocator-api2 - Mirror of Rust's allocator API
https://bugzilla.redhat.com/show_bug.cgi?id=2219911 --- Comment #7 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-allocator-api2 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2219911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219911%23c7 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219911] Review Request: rust-allocator-api2 - Mirror of Rust's allocator API
https://bugzilla.redhat.com/show_bug.cgi?id=2219911 --- Comment #6 from Fabio Valentini --- Thanks for the review! I've also filed an upstream PR to make the license file stuff more in line with standard Rust project practices. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2219911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219911%23c6 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2214338] Review Request: rust-databake - Trait that lets structs represent themselves as (const) Rust expressions
https://bugzilla.redhat.com/show_bug.cgi?id=2214338 --- Comment #4 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-databake -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2214338 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202214338%23c4 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2214338] Review Request: rust-databake - Trait that lets structs represent themselves as (const) Rust expressions
https://bugzilla.redhat.com/show_bug.cgi?id=2214338 --- Comment #3 from Fabio Valentini --- Thanks for the review! Yeah I added the "-a" flag because otherwise tests don't compile (they require additional features to be enabled). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2214338 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202214338%23c3 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2214338] Review Request: rust-databake - Trait that lets structs represent themselves as (const) Rust expressions
https://bugzilla.redhat.com/show_bug.cgi?id=2214338 blinxen changed: What|Removed |Added Assignee|nob...@fedoraproject.org|h-k...@hotmail.com Status|NEW |POST Flags||fedora-review+ CC||h-k...@hotmail.com --- Comment #2 from blinxen --- Taking this review General comments: - Package was generated with rust2rpm and the "-a" was added to all "%cargo*" commands Since this package only builds in rawhide and fedora-review is currently broken in rawhide I can't paste the review template here. But this package fulfills all fedora packaging requirements. APPROVED -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2214338 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202214338%23c2 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219911] Review Request: rust-allocator-api2 - Mirror of Rust's allocator API
https://bugzilla.redhat.com/show_bug.cgi?id=2219911 blinxen changed: What|Removed |Added Flags|fedora-review? |fedora-review+ Status|ASSIGNED|POST --- Comment #5 from blinxen --- APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2219911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219911%23c5 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219911] Review Request: rust-allocator-api2 - Mirror of Rust's allocator API
https://bugzilla.redhat.com/show_bug.cgi?id=2219911 --- Comment #4 from Fabio Valentini --- Good catch, I've updated the linked files. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2219911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219911%23c4 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219911] Review Request: rust-allocator-api2 - Mirror of Rust's allocator API
https://bugzilla.redhat.com/show_bug.cgi?id=2219911
blinxen changed:
What|Removed |Added
Flags||fedora-review?
CC||h-k...@hotmail.com
Assignee|nob...@fedoraproject.org|h-k...@hotmail.com
Doc Type|--- |If docs needed, set a value
Status|NEW |ASSIGNED
--- Comment #3 from blinxen ---
Taking this review
General comments:
- Package was generated with rust2rpm and documentation tests were deactivated
- Deactivating documentation tests is OK
Issues:
- The package specifies the `COPYING` file as the license but the actual
license files are under `licenses/`. Please add them to the license files
specification.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file APACHE is not marked as %license
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/LicensingGuidelines/#_license_text
= MUST items =
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Apache License 2.0", "MIT License". 28
files have unknown license. Detailed output of licensecheck in
/var/lib/copr-rpmbuild/results/rust-allocator-api2/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires
[Bug 2217097] Review Request: rocm-smi - ROCm System Management Interface Library
https://bugzilla.redhat.com/show_bug.cgi?id=2217097 --- Comment #16 from Jeremy Newton --- FYI https://pagure.io/releng/issue/11509 I'll get rocblas working locally while we wait. Once I confirm it works locally, I'll push a review for tensile. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2217097 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202217097%23c16 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2216600] Review Request: kaidan - A XMPP client based on KDE Framework
https://bugzilla.redhat.com/show_bug.cgi?id=2216600
--- Comment #2 from Steve Cossette ---
Oh this is also probably required, considering qml uses the qtwebengine:
%if 0%{?fedora} || 0%{?epel} > 7
# handled by qt5-srpm-macros, which defines %%qt5_qtwebengine_arches
# Package doesn't build on arches that qtwebengine is not built on.
ExclusiveArch: %{qt5_qtwebengine_arches}
%endif
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2216600
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202216600%23c2
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2216600] Review Request: kaidan - A XMPP client based on KDE Framework
https://bugzilla.redhat.com/show_bug.cgi?id=2216600
Steve Cossette changed:
What|Removed |Added
Doc Type|--- |If docs needed, set a value
Flags||fedora-review?
Assignee|nob...@fedoraproject.org|farch...@gmail.com
CC||farch...@gmail.com
--- Comment #1 from Steve Cossette ---
Some early cleanup stuff I found in the spec:
First, add the following as a build dependancy:
BuildRequires: kf5-rpm-macros
Then, replace:
%build
%cmake \
-GNinja \
-DCMAKE_BUILD_TYPE=Release \
-DUSE_KNOTIFICATIONS=ON \
-DBUILD_TESTS=ON \
%cmake_build
With:
%build
%cmake_kf5
%cmake_build
Next, those should be added as requirements. I have a couple packages myself
built for KDE and I was instructed to add this for packages using the QML
module:
# QML module dependencies
Requires: kf5-kirigami2%{?_isa}
Requires: kf5-kirigami2-addons%{?_isa}
Requires: kf5-kquickcharts%{?_isa}
Requires: qt5-qtgraphicaleffects%{?_isa}
Requires: qt5-qtquickcontrols2%{?_isa}
Requires: qt5-qtwebchannel%{?_isa}
Requires: qt5-qtwebengine%{?_isa}
Next, under files, replace:
%{_datadir}/icons/hicolor/*/apps/%{name}.*
with:
%{_datadir}/icons/hicolor/128x128/apps/kaidan.png
%{_datadir}/icons/hicolor/scalable/apps/kaidan.svg
Reason: For shared folders, you should not be using wildcards
(https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists)
Lastly, the Source0 should use the KDE invent tags system, specially if Kaidan
ever becomes part of the KDE gear. In this case, it would look something like:
Source0:
https://invent.kde.org/network/%{name}/-/archive/v%{version}/%{name}-v%{version}.tar.gz
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2216600
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202216600%23c1
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2081113] Review Request: rdkit - Chemical informatics and machine learning toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=2081113 Antonio T. sagitter changed: What|Removed |Added Flags||needinfo?(mark.e.fuller@gmx ||.de) --- Comment #7 from Antonio T. sagitter --- Spec URL: https://download.copr.fedorainfracloud.org/results/sagitter/ForTesting/fedora-rawhide-x86_64/06144147-rdkit/rdkit.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/sagitter/ForTesting/fedora-rawhide-x86_64/06144147-rdkit/rdkit-2023.03.2-1.fc39.src.rpm Hi Mark. This is a new release of RDKIT, we can restart this review if you can. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2081113 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202081113%23c7 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219919] Review Request: rust-equivalent - Traits for key comparison in maps
https://bugzilla.redhat.com/show_bug.cgi?id=2219919 Fedora Review Service changed: What|Removed |Added URL||https://crates.io/crates/eq ||uivalent --- Comment #2 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6144166 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2219919-rust-equivalent/fedora-rawhide-x86_64/06144166-rust-equivalent/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2219919 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219919%23c2 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219919] Review Request: rust-equivalent - Traits for key comparison in maps
https://bugzilla.redhat.com/show_bug.cgi?id=2219919 --- Comment #1 from Fabio Valentini --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=102967118 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2219919 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219919%23c1 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219919] New: Review Request: rust-equivalent - Traits for key comparison in maps
https://bugzilla.redhat.com/show_bug.cgi?id=2219919 Bug ID: 2219919 Summary: Review Request: rust-equivalent - Traits for key comparison in maps Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: decatho...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://decathorpe.fedorapeople.org/rust-equivalent.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-equivalent-1.0.0-1.fc38.src.rpm Description: Traits for key comparison in maps. Fedora Account System Username: decathorpe -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2219919 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219919%23c0 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219471] Review Request: rust-prodash - Dashboard for visualizing progress of asynchronous and possibly blocking tasks
https://bugzilla.redhat.com/show_bug.cgi?id=2219471 --- Comment #6 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6144146 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2219471-rust-prodash/fedora-rawhide-x86_64/06144146-rust-prodash/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2219471 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219471%23c6 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219471] Review Request: rust-prodash - Dashboard for visualizing progress of asynchronous and possibly blocking tasks
https://bugzilla.redhat.com/show_bug.cgi?id=2219471 --- Comment #5 from Fedora Review Service --- Created attachment 1974160 --> https://bugzilla.redhat.com/attachment.cgi?id=1974160=edit The .spec file difference from Copr build 6138349 to 6144146 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2219471 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219471%23c5 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219471] Review Request: rust-prodash - Dashboard for visualizing progress of asynchronous and possibly blocking tasks
https://bugzilla.redhat.com/show_bug.cgi?id=2219471 --- Comment #4 from blinxen --- I deactivated all features which don't build / install. I kept the rest even though I don't need all features. `gix` only requires the `progress-tree` feature. Updated files can be found under: Spec URL: https://blinxen.fedorapeople.org/rust-prodash/rust-prodash.spec SRPM URL: https://blinxen.fedorapeople.org/rust-prodash/rust-prodash-25.0.0-1.fc39.src.rpm P.S I will review some of your packages later in return for reviewing my package reviews :D -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2219471 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219471%23c4 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219911] Review Request: rust-allocator-api2 - Mirror of Rust's allocator API
https://bugzilla.redhat.com/show_bug.cgi?id=2219911 Fedora Review Service changed: What|Removed |Added URL||https://crates.io/crates/al ||locator-api2 --- Comment #2 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6144108 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2219911-rust-allocator-api2/fedora-rawhide-x86_64/06144108-rust-allocator-api2/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2219911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219911%23c2 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219911] Review Request: rust-allocator-api2 - Mirror of Rust's allocator API
https://bugzilla.redhat.com/show_bug.cgi?id=2219911 --- Comment #1 from Fabio Valentini --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=102966088 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2219911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219911%23c1 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219911] New: Review Request: rust-allocator-api2 - Mirror of Rust's allocator API
https://bugzilla.redhat.com/show_bug.cgi?id=2219911 Bug ID: 2219911 Summary: Review Request: rust-allocator-api2 - Mirror of Rust's allocator API Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: decatho...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://decathorpe.fedorapeople.org/rust-allocator-api2.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-allocator-api2-0.2.15-1.fc38.src.rpm Description: Mirror of Rust's allocator API. Fedora Account System Username: decathorpe -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2219911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219911%23c0 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219683] Review Request: rust-maybe-async - Procedural macro to unify SYNC and ASYNC implementation
https://bugzilla.redhat.com/show_bug.cgi?id=2219683 blinxen changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2023-07-05 17:51:12 --- Comment #6 from blinxen --- Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-e48f7130eb -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2219683 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219683%23c6 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219655] Review Request: rust-gix-command - Handle gitoxide internal git command execution
https://bugzilla.redhat.com/show_bug.cgi?id=2219655 blinxen changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2023-07-05 17:50:53 --- Comment #5 from blinxen --- Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-48304f8d51 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2219655 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219655%23c5 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219161] Review Request: python-multiecho - Combine multi-echoes from a multi-echo fMRI acquisition
https://bugzilla.redhat.com/show_bug.cgi?id=2219161 --- Comment #10 from Fedora Update System --- FEDORA-2023-266fe74b3b has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-266fe74b3b -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2219161 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219161%23c10 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219161] Review Request: python-multiecho - Combine multi-echoes from a multi-echo fMRI acquisition
https://bugzilla.redhat.com/show_bug.cgi?id=2219161 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #9 from Fedora Update System --- FEDORA-2023-0f6002ce59 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-0f6002ce59 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2219161 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219161%23c9 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219683] Review Request: rust-maybe-async - Procedural macro to unify SYNC and ASYNC implementation
https://bugzilla.redhat.com/show_bug.cgi?id=2219683 --- Comment #5 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-maybe-async -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2219683 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219683%23c5 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219655] Review Request: rust-gix-command - Handle gitoxide internal git command execution
https://bugzilla.redhat.com/show_bug.cgi?id=2219655 --- Comment #4 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gix-command -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2219655 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219655%23c4 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219683] Review Request: rust-maybe-async - Procedural macro to unify SYNC and ASYNC implementation
https://bugzilla.redhat.com/show_bug.cgi?id=2219683 Fabio Valentini changed: What|Removed |Added Flags|fedora-review? |fedora-review+ Status|ASSIGNED|POST --- Comment #4 from Fabio Valentini --- Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches === It would be great if you could review one of my packages in return. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2219683 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219683%23c4 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219161] Review Request: python-multiecho - Combine multi-echoes from a multi-echo fMRI acquisition
https://bugzilla.redhat.com/show_bug.cgi?id=2219161 --- Comment #8 from Ben Beasley --- Building for F38/F37. Rawhide will have to wait until python-nibabel builds with Python 3.12. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2219161 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219161%23c8 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219655] Review Request: rust-gix-command - Handle gitoxide internal git command execution
https://bugzilla.redhat.com/show_bug.cgi?id=2219655 Fabio Valentini changed: What|Removed |Added Flags|fedora-review? |fedora-review+ Status|ASSIGNED|POST --- Comment #3 from Fabio Valentini --- Thanks, works now! === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide ! test suite is run and all unit tests pass (disabled with explanation) - latest version of the crate is packaged - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches === It would be great if you could review one of my packages in return. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2219655 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219655%23c3 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219161] Review Request: python-multiecho - Combine multi-echoes from a multi-echo fMRI acquisition
https://bugzilla.redhat.com/show_bug.cgi?id=2219161 --- Comment #7 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-multiecho -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2219161 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219161%23c7 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219683] Review Request: rust-maybe-async - Procedural macro to unify SYNC and ASYNC implementation
https://bugzilla.redhat.com/show_bug.cgi?id=2219683 --- Comment #3 from blinxen --- For some reason the parent directory (rust-maybe-async) did not have execute permissions. Should be fine now. > Side note: The correct term is "procedural macro", not "procedure macro". Nice catch, will updated the summary and description. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2219683 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219683%23c3 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2218461] Review Request: lomt-junction-fonts - A humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=2218461 --- Comment #1 from Arthur Bols --- Hi Benson, Some things I noticed: - Use rpmautospec macros (%autorelease, %autochangelog) You're not required to use them, but it is recommended. More info: https://fedoraproject.org/wiki/Changes/rpmautospec https://fedoraproject.org/wiki/Changes/Rpmautospec_by_Default - BuildRequires: fontforge This doesn't seem to be necessary - Add the readme.markdown to documentation - fullname in incorrect format According to the packaging guidelines: "Fontconfig rules MUST rewrite fullname to
[Bug 2219655] Review Request: rust-gix-command - Handle gitoxide internal git command execution
https://bugzilla.redhat.com/show_bug.cgi?id=2219655 --- Comment #2 from blinxen --- For some reason the parent directory (rust-gix-command) did not have execute permissions. Should be fine now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2219655 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219655%23c2 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219161] Review Request: python-multiecho - Combine multi-echoes from a multi-echo fMRI acquisition
https://bugzilla.redhat.com/show_bug.cgi?id=2219161 Ben Beasley changed: What|Removed |Added Status|POST|ASSIGNED --- Comment #6 from Ben Beasley --- Thanks! That was fast! Correcting the status to ASSIGNED since the dist-git request automation is picky about that. I’ll import this once the Python 3.12 side tag merge is complete. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2219161 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219161%23c6 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219161] Review Request: python-multiecho - Combine multi-echoes from a multi-echo fMRI acquisition
https://bugzilla.redhat.com/show_bug.cgi?id=2219161
Ankur Sinha (FranciscoD) changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #5 from Ankur Sinha (FranciscoD) ---
LGTM XXX APPROVED XXX
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Apache License 2.0", "MIT License",
"*No copyright* MIT License Apache License", "*No copyright* Apache
License 2.0". 11 files have unknown license. Detailed output of
licensecheck in /home/asinha/dump/fedora-reviews/2219161-python-
multiecho/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
^
Tests pass
[x]: Latest version is packaged.
[x]: Package does not
[Bug 2183981] Review Request: dsda-doom - Speedrun-oriented Doom source port
https://bugzilla.redhat.com/show_bug.cgi?id=2183981 saturi...@proton.me changed: What|Removed |Added CC||saturi...@proton.me --- Comment #3 from saturi...@proton.me --- prboom-plus has been recently archived: https://github.com/coelckers/prboom-plus dsda-doom is the de facto continuation now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2183981 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202183981%23c3 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219161] Review Request: python-multiecho - Combine multi-echoes from a multi-echo fMRI acquisition
https://bugzilla.redhat.com/show_bug.cgi?id=2219161 Ankur Sinha (FranciscoD) changed: What|Removed |Added Flags||fedora-review? Status|NEW |ASSIGNED CC||sanjay.an...@gmail.com Assignee|nob...@fedoraproject.org|sanjay.an...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2219161 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2072972] Review Request: perl-IP-Geolocation-MMDB - Read MaxMind DB files
https://bugzilla.redhat.com/show_bug.cgi?id=2072972 Andreas Vögele changed: What|Removed |Added Resolution|--- |RAWHIDE Fixed In Version||perl-IP-Geolocation-MMDB-1. ||010-1.fc39 Status|ASSIGNED|CLOSED Last Closed||2023-07-05 13:33:42 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2072972 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
https://bugzilla.redhat.com/show_bug.cgi?id=453422 Karl Anderson changed: What|Removed |Added CC||nocew63...@dronetz.com --- Comment #182 from Karl Anderson --- If you're encountering difficulties with Songbird, it's important to note that it may not be compatible with current versions of Mozilla Firefox or other modern web browsers. As a result, it's recommended to explore alternative media players that are actively maintained and compatible with the latest browser versions. There are numerous media players available that offer similar functionality to Songbird, such as VLC, foobar2000, Winamp, and MusicBee. These players are regularly updated and provide a wide range of features to enhance your music listening experience. https://medcraveonline.com/articles/hotmail-signup/ -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=453422 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%20453422%23c182 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219471] Review Request: rust-prodash - Dashboard for visualizing progress of asynchronous and possibly blocking tasks
https://bugzilla.redhat.com/show_bug.cgi?id=2219471 Fabio Valentini changed: What|Removed |Added Assignee|nob...@fedoraproject.org|decatho...@gmail.com CC||decatho...@gmail.com Flags||fedora-review? Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED --- Comment #3 from Fabio Valentini --- Some of the subpackages fail to install due to missing dependencies: === Problem 1: conflicting requests - nothing provides (crate(compound_duration/default) >= 1.2.0 with crate(compound_duration/default) < 2.0.0~) needed by rust-prodash+compound_duration-devel-25.0.0-1.fc39.noarch Problem 2: conflicting requests - nothing provides (crate(crosstermion) >= 0.11.0 with crate(crosstermion) < 0.12.0~) needed by rust-prodash+crosstermion-devel-25.0.0-1.fc39.noarch Problem 3: conflicting requests - nothing provides (crate(human_format/default) >= 1.0.3 with crate(human_format/default) < 2.0.0~) needed by rust-prodash+human_format-devel-25.0.0-1.fc39.noarch Problem 4: conflicting requests - nothing provides (crate(crosstermion/crossterm) >= 0.11.0 with crate(crosstermion/crossterm) < 0.12.0~) needed by rust-prodash+render-line-crossterm-devel-25.0.0-1.fc39.noarch Problem 5: conflicting requests - nothing provides (crate(crosstermion/color) >= 0.11.0 with crate(crosstermion/color) < 0.12.0~) needed by rust-prodash+render-line-devel-25.0.0-1.fc39.noarch Problem 6: conflicting requests - nothing provides (crate(crosstermion/termion) >= 0.11.0 with crate(crosstermion/termion) < 0.12.0~) needed by rust-prodash+render-line-termion-devel-25.0.0-1.fc39.noarch Problem 7: conflicting requests - nothing provides (crate(crosstermion/input-async-crossterm) >= 0.11.0 with crate(crosstermion/input-async-crossterm) < 0.12.0~) needed by rust-prodash+render-tui-crossterm-devel-25.0.0-1.fc39.noarch - nothing provides (crate(crosstermion/tui-react-crossterm) >= 0.11.0 with crate(crosstermion/tui-react-crossterm) < 0.12.0~) needed by rust-prodash+render-tui-crossterm-devel-25.0.0-1.fc39.noarch Problem 8: conflicting requests - nothing provides (crate(crosstermion/input-async) >= 0.11.0 with crate(crosstermion/input-async) < 0.12.0~) needed by rust-prodash+render-tui-devel-25.0.0-1.fc39.noarch Problem 9: conflicting requests - nothing provides (crate(crosstermion/tui-react-termion) >= 0.11.0 with crate(crosstermion/tui-react-termion) < 0.12.0~) needed by rust-prodash+render-tui-termion-devel-25.0.0-1.fc39.noarch Problem 10: conflicting requests - nothing provides (crate(tui-react/default) >= 0.20.0 with crate(tui-react/default) < 0.21.0~) needed by rust-prodash+tui-react-devel-25.0.0-1.fc39.noarch Problem 11: package rust-prodash+unit-human-devel-25.0.0-1.fc39.noarch requires crate(prodash/human_format) = 25.0.0, but none of the providers can be installed - conflicting requests - nothing provides (crate(human_format/default) >= 1.0.3 with crate(human_format/default) < 2.0.0~) needed by rust-prodash+human_format-devel-25.0.0-1.fc39.noarch Problem 12: package rust-prodash+unit-duration-devel-25.0.0-1.fc39.noarch requires crate(prodash/compound_duration) = 25.0.0, but none of the providers can be installed - conflicting requests - nothing provides (crate(compound_duration/default) >= 1.2.0 with crate(compound_duration/default) < 2.0.0~) needed by rust-prodash+compound_duration-devel-25.0.0-1.fc39.noarch === I would recommend to remove features you don't need, and fix the rest. For example, I would drop crosstermion / tui / tui-react dependencies if possible - they frequently publish breaking releases, keeping up with them is quite painful. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2219471 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219471%23c3 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219655] Review Request: rust-gix-command - Handle gitoxide internal git command execution
https://bugzilla.redhat.com/show_bug.cgi?id=2219655 Fabio Valentini changed: What|Removed |Added CC||decatho...@gmail.com Flags||fedora-review? Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|decatho...@gmail.com --- Comment #1 from Fabio Valentini --- Not sure what's happening here: > ERROR: 'Error HTTP Error 403: Forbidden downloading > https://blinxen.fedorapeople.org/rust-gix-command/rust-gix-command-0.2.6-1.fc39.src.rpm' -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2219655 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219655%23c1 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2219683] Review Request: rust-maybe-async - Procedure macro to unify SYNC and ASYNC implementation
https://bugzilla.redhat.com/show_bug.cgi?id=2219683 Fabio Valentini changed: What|Removed |Added Flags||fedora-review? CC||decatho...@gmail.com Doc Type|--- |If docs needed, set a value Assignee|nob...@fedoraproject.org|decatho...@gmail.com Status|NEW |ASSIGNED --- Comment #1 from Fabio Valentini --- Not sure what's happening here: > ERROR: 'Error HTTP Error 403: Forbidden downloading > https://blinxen.fedorapeople.org/rust-maybe-async/rust-maybe-async-0.2.7-1.fc39.src.rpm' -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2219683 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202219683%23c1 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2168538] Review Request: minidlna - Lightweight DLNA/UPnP-AV server targeted at embedded systems
https://bugzilla.redhat.com/show_bug.cgi?id=2168538 --- Comment #24 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6143079 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2168538-minidlna/fedora-rawhide-x86_64/06143079-minidlna/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2168538 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202168538%23c24 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2168538] Review Request: minidlna - Lightweight DLNA/UPnP-AV server targeted at embedded systems
https://bugzilla.redhat.com/show_bug.cgi?id=2168538 --- Comment #23 from Fedora Review Service --- Created attachment 1974077 --> https://bugzilla.redhat.com/attachment.cgi?id=1974077=edit The .spec file difference from Copr build 6140215 to 6143079 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2168538 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202168538%23c23 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2168538] Review Request: minidlna - Lightweight DLNA/UPnP-AV server targeted at embedded systems
https://bugzilla.redhat.com/show_bug.cgi?id=2168538 Dominik 'Rathann' Mierzejewski changed: What|Removed |Added Flags||needinfo?(benson_muite@emai ||lplus.org) --- Comment #22 from Dominik 'Rathann' Mierzejewski --- (In reply to Benson Muite from comment #21) > Package Review Thanks! [...] > Comments: > a) Any response from upstream on "E: > missing-call-to-setgroups-before-setuid" ? > tried using setreuid and setregid instead, error message no longer appears But that has a diifferent effect and is probably not what upstream meant here. [...] > Perhaps check with upstream if this is ok I reported the issue upstream: https://sourceforge.net/p/minidlna/bugs/356/ Is there anything else or can this package be approved? Spec URL: https://rathann.fedorapeople.org/review/minidlna/minidlna.spec SRPM URL: https://rathann.fedorapeople.org/review/minidlna/minidlna-1.3.3-2.fc39.src.rpm * Wed Jul 05 2023 Dominik Mierzejewski - 1.3.3-2 - fix missing-call-to-setgroups-before-setuid rpmlint error - add weak dependency on logrotate -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2168538 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202168538%23c22 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2036288] Review Request: netrate - Network interface traffic meter
https://bugzilla.redhat.com/show_bug.cgi?id=2036288 Artur Frenszek-Iwicki changed: What|Removed |Added Resolution|--- |RAWHIDE Fixed In Version||netrate-0.1-4.fc39 Status|ASSIGNED|CLOSED Last Closed||2023-07-05 09:03:25 --- Comment #19 from Artur Frenszek-Iwicki --- Closing this since netrate-0.1-4.fc39 has been built and is now available in the repo. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2036288 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202036288%23c19 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification
https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #31 from Jordi Sanfeliu --- Petr, Do you know why the build failed? I'm reading the logs but I cannot see where is the cause. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1877006 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%201877006%23c31 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
