[Bug 2136547] Review Request: dnf-repo - DNF wrapper tool to control repos
https://bugzilla.redhat.com/show_bug.cgi?id=2136547 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2024-05-01 04:14:18 --- Comment #29 from Fedora Update System --- FEDORA-2024-626dfb6391 (dnf-repo-0.6-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2136547 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202136547%23c29 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2256940] Review Request: smplayer - A graphical frontend for mplayer and mpv
https://bugzilla.redhat.com/show_bug.cgi?id=2256940 --- Comment #32 from Fedora Update System --- FEDORA-2024-06a997a645 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-06a997a645 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-06a997a645 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2256940 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202256940%23c32 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2256940] Review Request: smplayer - A graphical frontend for mplayer and mpv
https://bugzilla.redhat.com/show_bug.cgi?id=2256940 --- Comment #31 from Fedora Update System --- FEDORA-EPEL-2024-b2bf9b752c has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-b2bf9b752c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2256940 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202256940%23c31 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2256940] Review Request: smplayer - A graphical frontend for mplayer and mpv
https://bugzilla.redhat.com/show_bug.cgi?id=2256940 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #30 from Fedora Update System --- FEDORA-2024-51f649032a has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-51f649032a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-51f649032a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2256940 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202256940%23c30 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2277858] Review Request: rust-async_http_range_reader - Library for streaming reading of files over HTTP using range requests
https://bugzilla.redhat.com/show_bug.cgi?id=2277858 Bug 2277858 depends on bug 2251680, which changed state. Bug 2251680 Summary: rust-axum-0.7.5 is available https://bugzilla.redhat.com/show_bug.cgi?id=2251680 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2277858 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2275318] Review Request: golang-github-gosimple-unidecode - Unicode transliterator in Golang
https://bugzilla.redhat.com/show_bug.cgi?id=2275318 Renich Bon Ciric changed: What|Removed |Added CC||ren...@woralelandia.com Assignee|nob...@fedoraproject.org|ren...@woralelandia.com Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2275318 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2275317] Review Request: golang-github-gosimple-slug - URL-friendly slugify with multiple languages support
https://bugzilla.redhat.com/show_bug.cgi?id=2275317 Renich Bon Ciric changed: What|Removed |Added Doc Type|--- |If docs needed, set a value Assignee|nob...@fedoraproject.org|ren...@woralelandia.com CC||ren...@woralelandia.com -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2275317 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2263601] Review Request: vectorscan - A portable fork of hyperscan, used as a high performance pcre replacement
https://bugzilla.redhat.com/show_bug.cgi?id=2263601 --- Comment #20 from Jason Taylor --- I agree, good a time as any to move this forward. I will see what the package retirement/notification process is so I make sure everyone is notified that needs to be. Sounds good, more than happy to help with maintenance on vectorscan. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2263601 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202263601%23c20 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2263601] Review Request: vectorscan - A portable fork of hyperscan, used as a high performance pcre replacement
https://bugzilla.redhat.com/show_bug.cgi?id=2263601 --- Comment #19 from Jeremy Linton --- Also, Jason, its probably easier if you are just added as a co-maintainer of vectorscan rather than trying to continue maintaining hyperscan. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2263601 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202263601%23c19 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2256940] Review Request: smplayer - A graphical frontend for mplayer and mpv
https://bugzilla.redhat.com/show_bug.cgi?id=2256940 --- Comment #29 from Fedora Update System --- FEDORA-EPEL-2024-b2bf9b752c (smplayer-23.12.0-4.el9) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-b2bf9b752c -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2256940 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202256940%23c29 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2256940] Review Request: smplayer - A graphical frontend for mplayer and mpv
https://bugzilla.redhat.com/show_bug.cgi?id=2256940 --- Comment #28 from Fedora Update System --- FEDORA-2024-06a997a645 (smplayer-23.12.0-4.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-06a997a645 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2256940 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202256940%23c28 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2256940] Review Request: smplayer - A graphical frontend for mplayer and mpv
https://bugzilla.redhat.com/show_bug.cgi?id=2256940 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #27 from Fedora Update System --- FEDORA-2024-51f649032a (smplayer-23.12.0-4.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-51f649032a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2256940 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202256940%23c27 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 1816301] Review Request: openfoam - computational fluid dynamics
https://bugzilla.redhat.com/show_bug.cgi?id=1816301
--- Comment #50 from Benson Muite ---
>> a) In the spec file, can you change
>> Prefix: /usr/lib/openfoam
>> to
>> Prefix: %{_libdir}/openfoam
> OK to leave as is?
> With the %{_libdir} macro it would expand to /usr/lib64 on openSUSE (for
> example), since their site CONFIG_SITE has %{_lib} as lib64 > for x86_64.
> I'd prefer to have a fixed/known install location, and also reuse as much as
> of the spec as possible for both targets.
Probably adding an if statement is preferable if the behavior on OpenSUSE
should differ. Otherwise an
exemption is needed:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_multilib_exempt_locations
>> b) Please also change
>> Release:240429%{?dist}
>> to
>> Release:1%{?dist}
>>
>> This is used to indicate changes in the spec file, for example due to
>> rebuilds or changes
>> to other options when the sources are not changed. It is independent of the
>> actual release version of the sources.
> Interesting. On previous copr builds it seems to ignore the auto increment
> entirely (but my memory might be foggy), which is why I
> forced to have the build date there too.
> I can revert back without problem. Interesting, the openSUSE builds
> prefer "0" instead of "1" for their Release, which is where they slap
> in the special handling. Would "0%{?dist}" also work for Fedora, or
> just "1%{?dist}" ?
Fedora starts at 1. This is incremented for very spec file change without a
corresponding source version change.
It is possible to use the %autorelease macro to manage this.
See https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/
> With the "1%{?dist}" (or "0%{?dist}") I guess that the previously built
> versions (with the date as release stamp) will mask out the
> revised one. I'll need to see how to fix that I guess.
Can bump the epoch if there are many people using the copr build. You could
also create a new copr repo, and delete both
copr repos once the package is accepted.
>> c) In the files listing, please change
>>
>> %{prefix}/%{projectDir}/COPYING
>> %{prefix}/%{projectDir}/README.md
>> %{prefix}/%{projectDir}/ThirdParty/README
> DONE
Thanks.
>> d) Is there any way to get wmake to mostly use Fedora specific build flags?
> We have provision for passing in extra stuff via the
> FOAM_EXTRA_CFLAGS FOAM_EXTRA_CXXFLAGS FOAM_EXTRA_LDFLAGS
> environment variables. Just not entirely sure should then be in there
> for the spec file...
> Something like this?
> #-
> %build
> # Mimic set_build_flags macro, but with wmake names
> %if 0%{?fedora}%{?rhel}
> FOAM_EXTRA_CFLAGS="${FOAM_EXTRA_CFLAGS:-%{?build_cflags}}"
> FOAM_EXTRA_CXXFLAGS="${FOAM_EXTRA_CXXFLAGS:-%{?build_cxxflags}}"
> FOAM_EXTRA_LDFLAGS="${FOAM_EXTRA_LDFLAGS:-%{?build_ldflags}}"
> export FOAM_EXTRA_CFLAGS FOAM_EXTRA_CXXFLAGS FOAM_EXTRA_LDFLAGS
> %endif
This seems better.
e) Please name the latest release version openfoam without anything additional
see:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#multiple
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1816301
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%201816301%23c50
--
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2256940] Review Request: smplayer - A graphical frontend for mplayer and mpv
https://bugzilla.redhat.com/show_bug.cgi?id=2256940 --- Comment #26 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/smplayer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2256940 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202256940%23c26 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2049400] Review Request: aws-c-cal - Aws Crypto Abstraction Layer: Cross-Platform, C99 wrapper for cryptography primitives.
https://bugzilla.redhat.com/show_bug.cgi?id=2049400 --- Comment #18 from Dominik Wombacher --- (In reply to Nikola Forró from comment #17) > > I would suggest to sync with David Duncan, he's the main admin of the > dist-git repo and can give you access, then you can proceed with the import. > In my opinion it makes no sense to import the originally approved files > first. Agree. I had a call with David. We going to update aws-c-common to the latest version. It's a dependency to update aws-c-cal. In parallel, we have to sort out the package group sponsor topic for me. Otherwise he can't add me as co-maintainer. When that's done I will import aws-c-cal in an updated version. I don't expect fundamental changes with the package. It should still be pretty close to what was approved. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2049400 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202049400%23c18 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2256940] Review Request: smplayer - A graphical frontend for mplayer and mpv
https://bugzilla.redhat.com/show_bug.cgi?id=2256940 Neal Gompa changed: What|Removed |Added Flags|fedora-review? |fedora-review+ Status|ASSIGNED|POST --- Comment #25 from Neal Gompa --- Review notes: * Packaging complies with the guidelines * Package builds and installs * No serious issues from rpmlint * Licensing is correct and license files are correctly installed PACKAGE APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2256940 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202256940%23c25 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2049400] Review Request: aws-c-cal - Aws Crypto Abstraction Layer: Cross-Platform, C99 wrapper for cryptography primitives.
https://bugzilla.redhat.com/show_bug.cgi?id=2049400 --- Comment #17 from Nikola Forró --- (In reply to Dominik Wombacher from comment #16) > Regarding this one, aws-c-cal: > Should I, on behalf of David Duncan, attach an updated spec and srpm based > on latest upstream to process with the import into > https://src.fedoraproject.org/rpms/aws-c-cal ? > Or is the process to import the files that were originally approved and then > update the package as soon it's imported in dist-git? > Who can do the import? What's the next step? I would suggest to sync with David Duncan, he's the main admin of the dist-git repo and can give you access, then you can proceed with the import. In my opinion it makes no sense to import the originally approved files first. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2049400 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202049400%23c17 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2256940] Review Request: smplayer - A graphical frontend for mplayer and mpv
https://bugzilla.redhat.com/show_bug.cgi?id=2256940 --- Comment #23 from Fedora Review Service --- Created attachment 2030300 --> https://bugzilla.redhat.com/attachment.cgi?id=2030300&action=edit The .spec file difference from Copr build 6880716 to 7393742 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2256940 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202256940%23c23 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2256940] Review Request: smplayer - A graphical frontend for mplayer and mpv
https://bugzilla.redhat.com/show_bug.cgi?id=2256940 --- Comment #24 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7393742 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256940-smplayer/fedora-rawhide-x86_64/07393742-smplayer/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2256940 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202256940%23c24 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2256940] Review Request: smplayer - A graphical frontend for mplayer and mpv
https://bugzilla.redhat.com/show_bug.cgi?id=2256940 --- Comment #22 from Sergio Basto --- [fedora-review-service-build] -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2256940 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202256940%23c22 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2158000] Review Request: light - Control backlight controllers
https://bugzilla.redhat.com/show_bug.cgi?id=2158000 --- Comment #73 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7393499 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2158000-light/fedora-rawhide-x86_64/07393499-light/fedora-review/review.txt Found issues: - License file COPYING is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/light Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2158000 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202158000%23c73 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2158000] Review Request: light - Control backlight controllers
https://bugzilla.redhat.com/show_bug.cgi?id=2158000 --- Comment #72 from Jakub Kadlčík --- Spec URL: https://frostyx.fedorapeople.org/light.spec SRPM URL: https://frostyx.fedorapeople.org/light-1.2.2-9.fc38.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2158000 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202158000%23c72 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2049400] Review Request: aws-c-cal - Aws Crypto Abstraction Layer: Cross-Platform, C99 wrapper for cryptography primitives.
https://bugzilla.redhat.com/show_bug.cgi?id=2049400 --- Comment #16 from Dominik Wombacher --- (In reply to Nikola Forró from comment #15) > (In reply to Dominik Wombacher from comment #14) > > Right, sorry, I didn't mean I have anything against packaging aws-c-cal > separately, but I was under the impression that David initially intended to > package aws-crt-python the "proper" way and this review request was the > first step toward that, and when that idea was abandoned and aws-crt-python > packaged the way it is, the review request no longer made sense. > Ah ok, yeah could be possible, it's been a while. > > So that means, there is no reason not to finalize the process and add > > aws-c-cal to the already created repo? > > And we should actually do the same with the rest of the libraries and if > > possible use them during package building? > > I would say so. Sounds good. There are more and more packages that leverage some of the AWS C libs. I'm on my way to brush up old spec files and raise new requests for the different libs. Regarding this one, aws-c-cal: Should I, on behalf of David Duncan, attach an updated spec and srpm based on latest upstream to process with the import into https://src.fedoraproject.org/rpms/aws-c-cal ? Or is the process to import the files that were originally approved and then update the package as soon it's imported in dist-git? Who can do the import? What's the next step? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2049400 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202049400%23c16 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2276780] Review Request: python-drain3 - Persistent & streaming log template miner
https://bugzilla.redhat.com/show_bug.cgi?id=2276780 --- Comment #3 from Miroslav Suchý --- > Should we point the package to a git tag instead of a commit, since it is > available? No. The 0.9.11 is two years old release. Therefore I packaged last commit. I put a comment to spec to explain it. I believe that I resolved all other issues (thank you for them). Spec URL: https://download.copr.fedorainfracloud.org/results/msuchy/package-review/fedora-rawhide-x86_64/07393402-python-drain3/python-drain3.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/msuchy/package-review/fedora-rawhide-x86_64/07393402-python-drain3/python-drain3-0.9.11-20240424git76d12de.1.fc41.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2276780 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202276780%23c3 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2277910] Review Request: lean4 - Functional programming language and theorem prover
https://bugzilla.redhat.com/show_bug.cgi?id=2277910 Fabio Valentini changed: What|Removed |Added CC||decatho...@gmail.com --- Comment #4 from Fabio Valentini --- Sorry, I'm slightly confused why you think stripping the binaries manually is necessary? This will break debuginfo generation built-in to RPM (and indeed you defined %debug_package to %nil to fix that). -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2277910 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202277910%23c4 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2277759] Review Request: python-crypt-r - A copy of the `crypt` module that was removed in Python 3.13
https://bugzilla.redhat.com/show_bug.cgi?id=2277759 --- Comment #1 from Miro Hrončok --- Scratchbuild: https://koji.fedoraproject.org/koji/taskinfo?taskID=11707 (s390x still waits for a builder, the rest is OK). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2277759 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202277759%23c1 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2009155] Review Request: python-oslo-messaging - OpenStack common messaging library
https://bugzilla.redhat.com/show_bug.cgi?id=2009155
--- Comment #15 from Jakub Kadlčík ---
Hello Hirotaka,
> [fedora-review-service-build]
Just to clarify, you tried to trigger the build correctly. There problem why it
wasn't triggered was likely this:
https://github.com/FrostyX/fedora-review-service/issues/42
> Name: python-oslo-messaging
Nitpick: You can use python-%{pkg_name}
> License:ASL 2.0
Since recently, Fedora migrated to using SPDX expressions for license names, so
the "ASL 2.0" isn't valid anymore, see
$ license-validate "ASL 2.0"
$ echo $?
The correct license name should be:
$ license-fedora2spdx "ASL 2.0"
Apache-2.0
> %{py3_install}
Just for the record, the specfile follows the 201x-era guidelines
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/
but there is now more current approach using dynamic BuildRequires and so on
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
Both approaches are valid, so feel free to continue using this one. I just
wanted to let you know in case you were writing a new package in a future.
> BuildRequires: python3-pyngus
This works for rawhide which is important. But just mentioning that it fails
for F39 because of
No matching package to install: 'python3-pyngus'
The fedora-review tool complains about the provided MD5sum:
- Sources used to build the package match the upstream source, as provided
in the spec URL.
Note: Upstream MD5sum check error, diff is in /tmp/fedora-
rawhide-x86_64/review-python-oslo-messaging/diff.txt
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/
The mentioned diff is here:
diff -U2 -r
/tmp/fedora-rawhide-x86_64/review-python-oslo-messaging/upstream-unpacked/Source102/0x2ef3fe0ec2b075ab7458b5f8b702b20b13df2318.txt
/tmp/fedora-rawhide-x86_64/review-python-oslo-messaging/srpm-unpacked/0x2ef3fe0ec2b075ab7458b5f8b702b20b13df2318.txt-extract/0x2ef3fe0ec2b075ab7458b5f8b702b20b13df2318.txt
---
/tmp/fedora-rawhide-x86_64/review-python-oslo-messaging/upstream-unpacked/Source102/0x2ef3fe0ec2b075ab7458b5f8b702b20b13df2318.txt
2024-04-30 13:34:18.038159010 +0200
+++
/tmp/fedora-rawhide-x86_64/review-python-oslo-messaging/srpm-unpacked/0x2ef3fe0ec2b075ab7458b5f8b702b20b13df2318.txt-extract/0x2ef3fe0ec2b075ab7458b5f8b702b20b13df2318.txt
2024-04-30 13:34:18.157158924 +0200
@@ -44,2 +44,3 @@
=7Dhm
-END PGP PUBLIC KEY BLOCK-
+
Overall the package looks good to me, basically only the license name and the
checksum error needs to be fixed.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2009155
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202009155%23c15
--
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2277710] Review Request: perl-Text-Lorem - Generate random Latin looking text
https://bugzilla.redhat.com/show_bug.cgi?id=2277710 Jitka Plesnikova changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||perl-Text-Lorem-0.34-1.fc41 Resolution|--- |RAWHIDE Last Closed||2024-04-30 11:48:23 --- Comment #4 from Jitka Plesnikova --- Thank you for the review. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2277710 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202277710%23c4 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2277730] Review Request: perl-Data-Fake - Declaratively generate fake structured data for testing
https://bugzilla.redhat.com/show_bug.cgi?id=2277730 Bug 2277730 depends on bug 2277710, which changed state. Bug 2277710 Summary: Review Request: perl-Text-Lorem - Generate random Latin looking text https://bugzilla.redhat.com/show_bug.cgi?id=2277710 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2277730 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2276780] Review Request: python-drain3 - Persistent & streaming log template miner
https://bugzilla.redhat.com/show_bug.cgi?id=2276780 --- Comment #2 from Jakub Kadlčík --- The fedora-review tool also complained about: Issues: === - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE.txt is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2276780 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202276780%23c2 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2276780] Review Request: python-drain3 - Persistent & streaming log template miner
https://bugzilla.redhat.com/show_bug.cgi?id=2276780
--- Comment #1 from Jakub Kadlčík ---
> %global commit 76d12defdeec14da3794d451875b781669f62acf
> Version:0.9.11
Should we point the package to a git tag instead of a commit, since it is
available? Also, this commit doesn't seem to be the one corresponding with the
0.9.11 release. I would expect 78d3cae4bcac329c4e4f275d416562e10c5c446e
> #%%autosetup -p1 -n drain3-%%{version}
> find
Probably some leftover from debugging
> # For official Fedora packages, including files with '*' +auto is not allowed
> # Replace it with a list of relevant Python modules/globs and list extra
> files in %%files
> %pyproject_save_files '*' +auto
Should probably be
%pyproject_save_files 'drain3'
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2276780
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202276780%23c1
--
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2276780] Review Request: python-drain3 - Persistent & streaming log template miner
https://bugzilla.redhat.com/show_bug.cgi?id=2276780 Jakub Kadlčík changed: What|Removed |Added Flags||fedora-review? Assignee|nob...@fedoraproject.org|jkadl...@redhat.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2276780 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2277966] Review Request: rust-lzma-rs - Codec for LZMA, LZMA2 and XZ written in pure Rust
https://bugzilla.redhat.com/show_bug.cgi?id=2277966 Ben Beasley changed: What|Removed |Added Blocks||2276230 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=2276230 [Bug 2276230] rust-zip-1.1.2 is available -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2277966 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2277966] New: Review Request: rust-lzma-rs - Codec for LZMA, LZMA2 and XZ written in pure Rust
https://bugzilla.redhat.com/show_bug.cgi?id=2277966 Bug ID: 2277966 Summary: Review Request: rust-lzma-rs - Codec for LZMA, LZMA2 and XZ written in pure Rust Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: c...@musicinmybrain.net QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://music.fedorapeople.org/rust-lzma-rs.spec SRPM URL: https://music.fedorapeople.org/rust-lzma-rs-0.3.0-1.fc39.src.rpm Description: A codec for LZMA, LZMA2 and XZ written in pure Rust. Fedora Account System Username: music This is needed to update rust-zip to 1.1.2 without hiding the lzma feature; rust-zip 1.1.2 is needed to package https://pypi.org/project/uv. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2277966 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202277966%23c0 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2274150] Review Request: ec2-instance-connect - This package contains the EC2 instance configuration and scripts necessary to enable AWS EC2 Instance Connect
https://bugzilla.redhat.com/show_bug.cgi?id=2274150 --- Comment #6 from Dominik Wombacher --- (In reply to Neal Gompa from comment #4) > > I don't think the conditionals are necessary since we're not aiming to add > this to EPEL 7... Indeed, dropped (In reply to Neal Gompa from comment #5) > Also, is it okay for the spec file to use the Fedora default license for > spec files (MIT)? If so, then could we drop the license header in the spec > file... Yes that's fine. I made a diff between the original spec and mine. I rewrote the whole thing from scratch at the end. Here is the latest version: Copr Build: https://copr.fedorainfracloud.org/coprs/wombelix/ec2-instance-connect/build/7393104/ Spec URL: https://download.copr.fedorainfracloud.org/results/wombelix/ec2-instance-connect/fedora-rawhide-x86_64/07393104-ec2-instance-connect/ec2-instance-connect.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/wombelix/ec2-instance-connect/fedora-rawhide-x86_64/07393104-ec2-instance-connect/ec2-instance-connect-1.1.17-1.fc41.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2274150 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202274150%23c6 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2277710] Review Request: perl-Text-Lorem - Generate random Latin looking text
https://bugzilla.redhat.com/show_bug.cgi?id=2277710 Fedora Admin user for bugzilla script actions changed: What|Removed |Added Status|ASSIGNED|POST --- Comment #3 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Text-Lorem -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2277710 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202277710%23c3 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 1816301] Review Request: openfoam - computational fluid dynamics
https://bugzilla.redhat.com/show_bug.cgi?id=1816301
--- Comment #49 from mark.ole...@esi-group.com ---
> a) In the spec file, can you change
> Prefix: /usr/lib/openfoam
> to
> Prefix: %{_libdir}/openfoam
OK to leave as is?
With the %{_libdir} macro it would expand to /usr/lib64 on openSUSE (for
example), since their site CONFIG_SITE has %{_lib} as lib64 for x86_64.
I'd prefer to have a fixed/known install location, and also reuse as much as of
the spec as possible for both targets.
> b) Please also change
> Release:240429%{?dist}
> to
> Release:1%{?dist}
>
> This is used to indicate changes in the spec file, for example due to
> rebuilds or changes
> to other options when the sources are not changed. It is independent of the
> actual release version of the sources.
Interesting. On previous copr builds it seems to ignore the auto increment
entirely (but my memory might be foggy), which is why I forced to have the
build date there too.
I can revert back without problem. Interesting, the openSUSE builds
prefer "0" instead of "1" for their Release, which is where they slap
in the special handling. Would "0%{?dist}" also work for Fedora, or
just "1%{?dist}" ?
With the "1%{?dist}" (or "0%{?dist}") I guess that the previously built
versions (with the date as release stamp) will mask out the revised one. I'll
need to see how to fix that I guess.
> c) In the files listing, please change
>
> %{prefix}/%{projectDir}/COPYING
> %{prefix}/%{projectDir}/README.md
> %{prefix}/%{projectDir}/ThirdParty/README
DONE
> d) Is there any way to get wmake to mostly use Fedora specific build flags?
We have provision for passing in extra stuff via the
FOAM_EXTRA_CFLAGS FOAM_EXTRA_CXXFLAGS FOAM_EXTRA_LDFLAGS
environment variables. Just not entirely sure should then be in there
for the spec file...
Something like this?
#-
%build
# Mimic set_build_flags macro, but with wmake names
%if 0%{?fedora}%{?rhel}
FOAM_EXTRA_CFLAGS="${FOAM_EXTRA_CFLAGS:-%{?build_cflags}}"
FOAM_EXTRA_CXXFLAGS="${FOAM_EXTRA_CXXFLAGS:-%{?build_cxxflags}}"
FOAM_EXTRA_LDFLAGS="${FOAM_EXTRA_LDFLAGS:-%{?build_ldflags}}"
export FOAM_EXTRA_CFLAGS FOAM_EXTRA_CXXFLAGS FOAM_EXTRA_LDFLAGS
%endif
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1816301
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%201816301%23c49
--
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2049400] Review Request: aws-c-cal - Aws Crypto Abstraction Layer: Cross-Platform, C99 wrapper for cryptography primitives.
https://bugzilla.redhat.com/show_bug.cgi?id=2049400 --- Comment #15 from Nikola Forró --- (In reply to Dominik Wombacher from comment #14) > True, so from a packaging Guideline perspective this falls then somehow > under > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_static_libraries > ? > Or is it bundled when it's linked against fedora external packages/sources > and static libraries if they exist as package in fedora? I'm not sure to be honest, but I think it still falls under bundling. > Yes it is, I guess that's why I was a bit confused about your comment that > packaging of aws-c-cal shouldn't proceed. Right, sorry, I didn't mean I have anything against packaging aws-c-cal separately, but I was under the impression that David initially intended to package aws-crt-python the "proper" way and this review request was the first step toward that, and when that idea was abandoned and aws-crt-python packaged the way it is, the review request no longer made sense. > So that means, there is no reason not to finalize the process and add > aws-c-cal to the already created repo? > And we should actually do the same with the rest of the libraries and if > possible use them during package building? I would say so. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2049400 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202049400%23c15 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2277710] Review Request: perl-Text-Lorem - Generate random Latin looking text
https://bugzilla.redhat.com/show_bug.cgi?id=2277710
Petr Pisar changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #2 from Petr Pisar ---
URL and Source0 addresses are Ok.
Source0 archive (SHA-512
c6d7f0e5dad59ce72bd86e84350a422f663289433508e125a592e6996a66578dfed50daa4904c7db76f6a90409673a2b2fcde9d660bb49e2e2efafeb887a0cfc)
is original. Ok.
Summary verified from lib/Text/Lorem.pm. Ok.
Description verified from lib/Text/Lorem.pm. Ok.
License verified from README, lib/Text/Lorem.pm, and Makefile.PL.
No XS code, noarch BuildArch is Ok.
All tests pass. Ok.
TODO: Consider running the tests in parallel by setting HARNESS_OPTIONS
variable.
$ rpmlint perl-Text-Lorem.spec ../SRPMS/perl-Text-Lorem-0.34-1.fc41.src.rpm
../RPMS/noarch/perl-Text-Lorem-0.34-1.fc41.noarch.rpm
rpmlint session starts
===
rpmlint: 2.5.0
configuration:
/usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3
=== 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 6 filtered, 0
badness; has taken 0.3 s ==
rpmlint is OK.
$ rpm -q -lv -p ../RPMS/noarch/perl-Text-Lorem-0.34-1.fc41.noarch.rpm
-rwxr-xr-x1 root root 1211 Apr 29 02:00
/usr/bin/lorem
drwxr-xr-x2 root root0 Apr 29 02:00
/usr/share/doc/perl-Text-Lorem
-rw-r--r--1 root root 595 Feb 25 2021
/usr/share/doc/perl-Text-Lorem/CHANGES
-rw-r--r--1 root root 1661 Feb 25 2021
/usr/share/doc/perl-Text-Lorem/README
-rw-r--r--1 root root 1073 Apr 29 02:00
/usr/share/man/man1/lorem.1.gz
-rw-r--r--1 root root 1592 Apr 29 02:00
/usr/share/man/man3/Text::Lorem.3pm.gz
-rw-r--r--1 root root 4796 Feb 25 2021
/usr/share/perl5/vendor_perl/Text/Lorem.pm
FIX: Package %{perl_vendorlib}/Text directory.
$ rpm -q --requires -p ../RPMS/noarch/perl-Text-Lorem-0.34-1.fc41.noarch.rpm |
sort -f | uniq -c
1 /usr/bin/perl
1 perl(Getopt::Std)
1 perl(strict)
1 perl(Text::Lorem)
1 perl(vars)
1 perl(warnings)
1 perl-libs
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary Requires are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-Text-Lorem-0.34-1.fc41.noarch.rpm |
sort -f | uniq -c
1 perl(Text::Lorem) = 0.34
1 perl-Text-Lorem = 0.34-1.fc41
Binary Provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-Text-Lorem-0.34-1.fc41.noarch.rpm
Binary dependencies are resolvable. Ok.
The package builds in Fedora 41
(https://koji.fedoraproject.org/koji/taskinfo?taskID=117068208). Ok.
Otherwise, the package is in line with Fedora and Perl packaging guidelines.
Please correct the FIX item and consider fixing the TODO item before building
this package.
Resolution: Package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2277710
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202277710%23c2
--
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2277910] Review Request: lean4 - Functional programming language and theorem prover
https://bugzilla.redhat.com/show_bug.cgi?id=2277910 --- Comment #3 from Jens Petersen --- Spec URL: https://petersen.fedorapeople.org/reviews/lean4/lean4.spec SRPM URL: https://petersen.fedorapeople.org/reviews/lean4/lean4-4.7.0-2.fc41.src.rpm strip bin and lib*.so files Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=117065121 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2277910 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202277910%23c3 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2277710] Review Request: perl-Text-Lorem - Generate random Latin looking text
https://bugzilla.redhat.com/show_bug.cgi?id=2277710 Petr Pisar changed: What|Removed |Added Flags||fedora-review? Assignee|nob...@fedoraproject.org|ppi...@redhat.com CC||ppi...@redhat.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2277710 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2257179] Review Request: qmplay2 - Qt based media player, streamer and downloader
https://bugzilla.redhat.com/show_bug.cgi?id=2257179 Dominik 'Rathann' Mierzejewski changed: What|Removed |Added Flags||needinfo?(yselkowi@redhat.c ||om) --- Comment #10 from Dominik 'Rathann' Mierzejewski --- Ping. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2257179 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202257179%23c10 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 1517451] Review Request: gtk-radio - Locate and listen to Free Internet Radio stations
https://bugzilla.redhat.com/show_bug.cgi?id=1517451 Dominik 'Rathann' Mierzejewski changed: What|Removed |Added Flags||needinfo?(o...@oka.no) --- Comment #46 from Dominik 'Rathann' Mierzejewski --- Ping. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1517451 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%201517451%23c46 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2258034] Review Request: python-fortranformat - reading and writing fortran style from python
https://bugzilla.redhat.com/show_bug.cgi?id=2258034 --- Comment #19 from david08...@gmail.com --- In case it is of any use to you, I have here a copr build with review enabled: https://copr.fedorainfracloud.org/coprs/davidsch/review/build/7392350/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2258034 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202258034%23c19 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
