[Bug 1003057] Review Request: irstlm - Statistical language model tool
https://bugzilla.redhat.com/show_bug.cgi?id=1003057 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|irstlm-5.80.03-2.fc19 |irstlm-5.80.03-2.fc20 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- irstlm-5.80.03-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003057] Review Request: irstlm - Statistical language model tool
https://bugzilla.redhat.com/show_bug.cgi?id=1003057 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||irstlm-5.80.03-2.fc19 Resolution|--- |ERRATA Last Closed||2013-11-07 23:39:11 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- irstlm-5.80.03-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003057] Review Request: irstlm - Statistical language model tool
https://bugzilla.redhat.com/show_bug.cgi?id=1003057 Jerry James loganje...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Jerry James loganje...@gmail.com --- No worries. Thanks for the review, Tim! New Package SCM Request === Package Name: irstlm Short Description: Statistical language model tool Owners: jjames Branches: f19 f20 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003057] Review Request: irstlm - Statistical language model tool
https://bugzilla.redhat.com/show_bug.cgi?id=1003057 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003057] Review Request: irstlm - Statistical language model tool
https://bugzilla.redhat.com/show_bug.cgi?id=1003057 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003057] Review Request: irstlm - Statistical language model tool
https://bugzilla.redhat.com/show_bug.cgi?id=1003057 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- irstlm-5.80.03-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/irstlm-5.80.03-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003057] Review Request: irstlm - Statistical language model tool
https://bugzilla.redhat.com/show_bug.cgi?id=1003057 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003057] Review Request: irstlm - Statistical language model tool
https://bugzilla.redhat.com/show_bug.cgi?id=1003057 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- irstlm-5.80.03-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/irstlm-5.80.03-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003057] Review Request: irstlm - Statistical language model tool
https://bugzilla.redhat.com/show_bug.cgi?id=1003057 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- irstlm-5.80.03-2.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003057] Review Request: irstlm - Statistical language model tool
https://bugzilla.redhat.com/show_bug.cgi?id=1003057 Tim Lauridsen t...@rasmil.dk changed: What|Removed |Added Status|NEW |ASSIGNED CC||t...@rasmil.dk Flags||fedora-review? --- Comment #1 from Tim Lauridsen t...@rasmil.dk --- I will review this one :) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003057] Review Request: irstlm - Statistical language model tool
https://bugzilla.redhat.com/show_bug.cgi?id=1003057
--- Comment #2 from Tim Lauridsen t...@rasmil.dk ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
LGPL (v2.1 or later), GPL (v2 or later), Unknown or generated. 12
files have unknown license. Detailed output of licensecheck in
/home/tim/udv/review/1003057-irstlm/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Perl:
[!]: Package contains the mandatory BuildRequires and Requires:.
Note: Requires: perl(:MODULE_COMPAT_%(eval `%{__perl} -V:version`; echo
$version)) missing?
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Scriptlets must be sane, if used.
[!]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile and build into
[Bug 1003057] Review Request: irstlm - Statistical language model tool
https://bugzilla.redhat.com/show_bug.cgi?id=1003057
--- Comment #3 from Tim Lauridsen t...@rasmil.dk ---
Issues:
Perl:
[!]: Package contains the mandatory BuildRequires and Requires:.
Note: Requires: perl(:MODULE_COMPAT_%(eval `%{__perl} -V:version`; echo
$version)) missing?
The tools package contains perls scripts, so it must require perl
Generic:
[!]: Package should not use obsolete m4 macros
Note: Some obsoleted macros found, see the attachment.
See: https://fedorahosted.org/FedoraReview/wiki/AutoTools
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003057] Review Request: irstlm - Statistical language model tool
https://bugzilla.redhat.com/show_bug.cgi?id=1003057
--- Comment #4 from Tim Lauridsen t...@rasmil.dk ---
$ cat *.pl | grep -i ^use | sort | uniq
use File::Basename;
use Getopt::Long GetOptions;
use strict;
I am no perl expert but i think you need
Requires: perl(:MODULE_COMPAT_%(eval `%{__perl} -V:version`; echo $version))
Requires: perl(File::Basename)
Requires: perlGetopt::Long)
Requires: perl(strict)
They are all provided by perl, but that can change in the future
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003057] Review Request: irstlm - Statistical language model tool
https://bugzilla.redhat.com/show_bug.cgi?id=1003057
--- Comment #5 from Jerry James loganje...@gmail.com ---
(In reply to Tim Lauridsen from comment #3)
Issues:
Perl:
[!]: Package contains the mandatory BuildRequires and Requires:.
Note: Requires: perl(:MODULE_COMPAT_%(eval `%{__perl} -V:version`;
echo
$version)) missing?
No, that is required for perl modules. This package does not contain any
modules, just scripts.
The tools package contains perls scripts, so it must require perl
The autogenerated Requires include /usr/bin/perl (see the Requires section at
the bottom of comment 2), which is sufficient.
Generic:
[!]: Package should not use obsolete m4 macros
Note: Some obsoleted macros found, see the attachment.
See: https://fedorahosted.org/FedoraReview/wiki/AutoTools
Fixed.
(In reply to Tim Lauridsen from comment #4)
$ cat *.pl | grep -i ^use | sort | uniq
use File::Basename;
use Getopt::Long GetOptions;
use strict;
I am no perl expert but i think you need
Requires: perl(:MODULE_COMPAT_%(eval `%{__perl} -V:version`; echo
$version))
Requires: perl(File::Basename)
Requires: perlGetopt::Long)
Requires: perl(strict)
They are all provided by perl, but that can change in the future
The autogenerated dependencies already include the last 3, and the first one
isn't needed since there is no perl module.
New URLs:
Spec URL: http://jjames.fedorapeople.org/irstlm/irstlm.spec
SRPM URL: http://jjames.fedorapeople.org/irstlm/irstlm-5.80.03-2.fc21.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003057] Review Request: irstlm - Statistical language model tool
https://bugzilla.redhat.com/show_bug.cgi?id=1003057 Tim Lauridsen t...@rasmil.dk changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Tim Lauridsen t...@rasmil.dk --- Missed the autogenerated deps :) APPROVED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
