[Bug 1003768] Review Request: lv2-x42-plugins - a collection of LV2 audio plugins

2013-09-13 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1003768

Brendan Jones  changed:

   What|Removed |Added

 CC|package-review@lists.fedora |
   |project.org |



--- Comment #2 from Brendan Jones  ---

OK, there is no tag to grab the source as outlined in [1] above, so I have used
a combination of it and pre-release syntax.


SRPM:
http://bsjones.fedorapeople.org/reviews/lv2-x42-plugins-0.1.1-0.1.20130615git7153e34.fc19.src.rpm
SPEC: http://bsjones.fedorapeople.org/reviews/lv2-x42-plugins.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=1K19B5Q0l6&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1003768] Review Request: lv2-x42-plugins - a collection of LV2 audio plugins

2013-09-12 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1003768



--- Comment #1 from Sandro Mani  ---
- The URL for the source is missing. Please see [1] for the guidelines on
github urls

- According to the ChangeLog, the version is 0.1.1

- For post-release snapshots, follow the guidelines here [2], i.e. append
.git%{shortcommit} to Release

- Detail: you could replace "make install DESTDIR=%{buildroot}" by
"%make_install" (see rpm -E '%make_install')

Rest looks good!



[1] http://fedoraproject.org/wiki/Packaging:SourceURL#Github
[2] http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=LIKvuRnzFU&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1003768] Review Request: lv2-x42-plugins - a collection of LV2 audio plugins

2013-09-12 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1003768

Sandro Mani  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||manisan...@gmail.com
   Assignee|nob...@fedoraproject.org|manisan...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=CIZk44DOdB&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review