[Bug 1004231] Review Request: lv2-sorcer - a wave-table synthesizer plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1004231 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||lv2-sorcer-1.1-1.1.20131104 ||git18e6891.fc20 Resolution|--- |ERRATA Last Closed||2013-11-10 02:52:40 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- lv2-sorcer-1.1-1.1.20131104git18e6891.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004231] Review Request: lv2-sorcer - a wave-table synthesizer plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1004231 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- Package lv2-sorcer-1.1-1.1.20131104git18e6891.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing lv2-sorcer-1.1-1.1.20131104git18e6891.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-20703/lv2-sorcer-1.1-1.1.20131104git18e6891.fc20 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004231] Review Request: lv2-sorcer - a wave-table synthesizer plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1004231 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004231] Review Request: lv2-sorcer - a wave-table synthesizer plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1004231 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004231] Review Request: lv2-sorcer - a wave-table synthesizer plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1004231 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004231] Review Request: lv2-sorcer - a wave-table synthesizer plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1004231 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- lv2-sorcer-0.0.1-1.0.20131104git18e6891.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/lv2-sorcer-0.0.1-1.0.20131104git18e6891.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004231] Review Request: lv2-sorcer - a wave-table synthesizer plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1004231 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Brendan Jones brendan.jones...@gmail.com --- Appreciate the review! Thanks New Package SCM Request === Package Name: lv2-sorcer Short Description: A wave-table LV2 synth plugin Owners: bsjones Branches: f18 f19 f20 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004231] Review Request: lv2-sorcer - a wave-table synthesizer plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1004231 --- Comment #9 from Brendan Jones brendan.jones...@gmail.com --- PS. I will correct the license file and raise the lv2- prefix on the packaging list. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004231] Review Request: lv2-sorcer - a wave-table synthesizer plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1004231 Nils Philippsen nphil...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Nils Philippsen nphil...@redhat.com --- Regarding the name, I concur having a common namespace for lv2 packages is a good idea. Would you please bring this up with the Packaging Committee to make this an official standard? -- https://fedoraproject.org/wiki/Packaging_Committee -- thanks. Diff to comment #4: ... [!]: License confusion in the README aside, the package should really package the correct version of the GPL (i.e. v3, not v2). ... [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. ... [x]: Final provides and requires are sane. ... -- Providing you include the correctly versioned license text, this package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004231] Review Request: lv2-sorcer - a wave-table synthesizer plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1004231 --- Comment #4 from Nils Philippsen nphil...@redhat.com --- One thing I didn't notice in my initial review is that the package name lv2-sorcer differs from the tarball name openAV-sorcer which would be more in line with the naming guidelines, cf.: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming Here's the diff to my initial review: ... [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [@]: License field in the package spec file seems to match the actual license, but frankly how it's documented is a mess: spec file: GPLv3+ (LICENSE text: GPLv2) README: This is released under GPLv3., but then you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. faust/main.dsp: GPLv3+ faust/main.cpp: LGPLv2+ gui/avtk: GPLv2+ -- at least the README file shouldn't contradict itself and the license file should be updated to GPLv3 IMO. ... [x]: Package must own all directories that it creates. -- Package requires lv2 now. [x]: %build honors applicable compiler flags or justifies otherwise. ... [!]: Package doesn't successfully compile and build into binary rpms on at least one supported primary architecture. -- I'll attach the build.log, it seems as if some build requirements are missing (headers, pkgconfig files not found) ... [@]: Final provides and requires are sane (see attachments). ... -- Why did you comment out the %global __provides_exclude_from line? ... -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004231] Review Request: lv2-sorcer - a wave-table synthesizer plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1004231 --- Comment #5 from Nils Philippsen nphil...@redhat.com --- Created attachment 817036 -- https://bugzilla.redhat.com/attachment.cgi?id=817036action=edit 0.0.1-0.2 build.log -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004231] Review Request: lv2-sorcer - a wave-table synthesizer plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1004231 --- Comment #6 from Brendan Jones brendan.jones...@gmail.com --- With regards to the name, there's an unofficial standard for lv2 plugins. They all are prefixed with lv2 . The install directory is sorcer.lv2, so I think lv2-sorcer is more appropriate ( openAv is just a software entity created by upstream) . I have added the missing build requires and uncommented the filters. Thanks SPEC: http://bsjones.fedorapeople.org/reviews/lv2-sorcer.spec SRPM: http://bsjones.fedorapeople.org/reviews/lv2-sorcer-0.0.1-0.3.20131013git4e35643.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004231] Review Request: lv2-sorcer - a wave-table synthesizer plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1004231 --- Comment #3 from Brendan Jones brendan.jones...@gmail.com --- Thanks Nils I have removed the presets in response to another review, and replaced with a link in the description. Open license ticket here. https://github.com/harryhaaren/openAV-Sorcer/issues/5 Assuming the license in the SPEC is correct, here's an update with the concerns above addressed. SPEC: http://bsjones.fedorapeople.org/reviews/lv2-sorcer.spec SRPM: http://bsjones.fedorapeople.org/reviews/lv2-sorcer-0.0.1-0.2.20131013git4e35643.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004231] Review Request: lv2-sorcer - a wave-table synthesizer plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1004231
Nils Philippsen nphil...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #2 from Nils Philippsen nphil...@redhat.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [@] = Needs to be looked at
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
BUT:
[@] The README mentions that the license is GPLv3, the source code files state
or any later version. Please check that with upstream.
[@] The source code files don't contain Copyright year ..., just mention
the author. Upstream should probably fix this as well.
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib64/lv2 -- other packages
simply depend on the lv2 package.
[!]: %build honors applicable compiler flags or justifies otherwise.
-- correct in most places, but I found this in the build log:
[3/3] cxxshlib: build/canvas.cxx.0.o build/sorcer_gui.cxx.0.o -
build/libsorcer_gui.so
17:22:32 runner ['/usr/lib64/ccache/g++', 'canvas.cxx.0.o',
'sorcer_gui.cxx.0.o', '-o',
'/builddir/build/BUILD/lv2-sorcer-0.0.1/gui/build/libsorcer_gui.so',
'-Wl,-Bstatic', '-Wl,-Bdynamic', '-lgtkmm-2.4', '-latkmm-1.6', '-lgtk-x11-2.0',
'-lgdkmm-2.4', '-lgiomm-2.4', '-lpangomm-1.4', '-lglibmm-2.4', '-lcairomm-1.0',
'-lsigc-2.0', '-lgdk-x11-2.0', '-lpangocairo-1.0', '-latk-1.0', '-lcairo',
'-lgdk_pixbuf-2.0', '-lgio-2.0', '-lpangoft2-1.0', '-lpango-1.0',
'-lgobject-2.0', '-lglib-2.0', '-lfontconfig', '-lfreetype', '-Wl,-z,nodelete',
'-shared', '-pthread']
Waf: Leaving directory `/builddir/build/BUILD/lv2-sorcer-0.0.1/gui/build'
'build' finished successfully (2.591s)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
-- maybe use wave table, synthesizer, dub step, bass lines
-- incoherent-version-in-changelog can be ignored (no need for dist tag
in changelog entry version-release)
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]:
[Bug 1004231] Review Request: lv2-sorcer - a wave-table synthesizer plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1004231 Nils Philippsen nphil...@redhat.com changed: What|Removed |Added CC||nphil...@redhat.com Assignee|nob...@fedoraproject.org|nphil...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004231] Review Request: lv2-sorcer - a wave-table synthesizer plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1004231 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added Blocks||805236 (FedoraAudio) --- Comment #1 from Brendan Jones brendan.jones...@gmail.com --- New upstream source, fix URL's and package release to standard. SPEC: http://bsjones.fedorapeople.org/reviews/lv2-sorcer.spec SRPM: http://bsjones.fedorapeople.org/reviews/lv2-sorcer-0.0.1-0.1.20130815git62d9577.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LxNSsQzreFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
