[Bug 1004913] Review Request: perl-Gtk2-SourceView2 - Perl bindings for the GtkSourceView 2.x widget
https://bugzilla.redhat.com/show_bug.cgi?id=1004913 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||perl-Gtk2-SourceView2-0.10- ||1.fc19 Resolution|--- |ERRATA Last Closed||2014-06-05 17:52:57 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- perl-Gtk2-SourceView2-0.10-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004913] Review Request: perl-Gtk2-SourceView2 - Perl bindings for the GtkSourceView 2.x widget
https://bugzilla.redhat.com/show_bug.cgi?id=1004913 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|perl-Gtk2-SourceView2-0.10- |perl-Gtk2-SourceView2-0.10- |1.fc19 |1.fc20 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- perl-Gtk2-SourceView2-0.10-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004913] Review Request: perl-Gtk2-SourceView2 - Perl bindings for the GtkSourceView 2.x widget
https://bugzilla.redhat.com/show_bug.cgi?id=1004913 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- perl-Gtk2-SourceView2-0.10-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004913] Review Request: perl-Gtk2-SourceView2 - Perl bindings for the GtkSourceView 2.x widget
https://bugzilla.redhat.com/show_bug.cgi?id=1004913 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004913] Review Request: perl-Gtk2-SourceView2 - Perl bindings for the GtkSourceView 2.x widget
https://bugzilla.redhat.com/show_bug.cgi?id=1004913 --- Comment #4 from Fedora Update System upda...@fedoraproject.org --- perl-Gtk2-SourceView2-0.10-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Gtk2-SourceView2-0.10-1.fc19 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004913] Review Request: perl-Gtk2-SourceView2 - Perl bindings for the GtkSourceView 2.x widget
https://bugzilla.redhat.com/show_bug.cgi?id=1004913 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- perl-Gtk2-SourceView2-0.10-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Gtk2-SourceView2-0.10-1.fc20 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004913] Review Request: perl-Gtk2-SourceView2 - Perl bindings for the GtkSourceView 2.x widget
https://bugzilla.redhat.com/show_bug.cgi?id=1004913
Björn besser82 Esser bjoern.es...@gmail.com changed:
What|Removed |Added
CC|package-review@lists.fedora |
|project.org |
Flags|fedora-review? |fedora-review+
--- Comment #1 from Björn besser82 Esser bjoern.es...@gmail.com ---
Package has some minor issues, but no blockers, so you can fixup during
SCM-import. :)
#
Package Review
==
Legend:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
= MUST items =
C/C++:
[-]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
--- false positive. this is supposed to be the case on c-compiled
perl-modules.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v2 or later) (with incorrect FSF address), GPL (v2 or later),
Unknown or generated. 3 files have unknown license. Detailed output of
licensecheck in /home/besser82/shared/fedora/review/1004913-perl-
Gtk2-SourceView2/licensecheck.txt
[-]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/lib64/perl5/vendor_perl/Gtk2(perl-Gtk2-Sexy, perl-Gtk2-ImageView,
perl-Gtk2-SourceView, perl-Gtk2-TrayIcon, perl-Gtk2-GladeXML, perl-
Gtk2-Unique, perl-Gtk2, perl-Gtk2-Notify),
/usr/lib64/perl5/vendor_perl/auto(perl-libs),
/usr/lib64/perl5/vendor_perl/auto/Gtk2(perl-Gtk2-Sexy, perl-Gtk2, perl-
Gtk2-TrayIcon, perl-Gtk2-GladeXML, perl-Gtk2-WebKit, perl-
Gtk2-SourceView, perl-Gtk2-Notify)
--- the mentioned dirs are not owned by any filesystem-pkg or such.
they seem to be specific to Gtk2-based perl-modules, so this
OK as is.
[!]: %build honors applicable compiler flags or justifies otherwise.
--- it seems system's LDFLAGS are not exported properly.
This can be fixed by adding %configure ||: atop of %build.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory names).
--- hardcoded name version in Source0. please fix.
use %global if needed.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install'
[Bug 1004913] Review Request: perl-Gtk2-SourceView2 - Perl bindings for the GtkSourceView 2.x widget
https://bugzilla.redhat.com/show_bug.cgi?id=1004913 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||bjoern.es...@gmail.com Assignee|nob...@fedoraproject.org|bjoern.es...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8eOBcbj47Fa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
