[Bug 1006197] Review Request: stockfish - Powerful open source chess engine
https://bugzilla.redhat.com/show_bug.cgi?id=1006197 Raphael Groner changed: What|Removed |Added Blocks|201449 (FE-DEADREVIEW), | |1196373 (stockfish) | Resolution|WONTFIX |DUPLICATE Flags|fedora-review? | --- Comment #14 from Raphael Groner --- *** This bug has been marked as a duplicate of bug 1196373 *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. https://bugzilla.redhat.com/show_bug.cgi?id=1196373 [Bug 1196373] Review Request: stockfish - Powerful open source chess engine -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1006197] Review Request: stockfish - Powerful open source chess engine
https://bugzilla.redhat.com/show_bug.cgi?id=1006197 Raphael Groner projects...@smart.ms changed: What|Removed |Added Blocks||1196373 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1196373 [Bug 1196373] Review Request: stockfish - Powerful open source chess engine -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006197] Review Request: stockfish - Powerful open source chess engine
https://bugzilla.redhat.com/show_bug.cgi?id=1006197 Raphael Groner projects...@smart.ms changed: What|Removed |Added Assignee|nob...@fedoraproject.org|projects...@smart.ms Flags||fedora-review? --- Comment #11 from Raphael Groner projects...@smart.ms --- Any progress here? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006197] Review Request: stockfish - Powerful open source chess engine
https://bugzilla.redhat.com/show_bug.cgi?id=1006197 --- Comment #12 from Dhiru Kholia dh...@openwall.com --- Hi, Feel free to take over (adopt) this package. I am currently short on free time. Dhiru -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006197] Review Request: stockfish - Powerful open source chess engine
https://bugzilla.redhat.com/show_bug.cgi?id=1006197 Raphael Groner projects...@smart.ms changed: What|Removed |Added Status|NEW |CLOSED Blocks||201449 (FE-DEADREVIEW) Resolution|--- |WONTFIX Last Closed||2014-12-10 07:12:58 --- Comment #13 from Raphael Groner projects...@smart.ms --- (In reply to Dhiru Kholia from comment #12) Feel free to take over (adopt) this package. I am currently short on free time. As you wish … closing. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006197] Review Request: stockfish - Powerful open source chess engine
https://bugzilla.redhat.com/show_bug.cgi?id=1006197
--- Comment #10 from Raphael Groner projects...@smart.ms ---
(In reply to Dhiru Kholia from comment #5)
…
Spec URL:
https://bitbucket.org/dhiru/packages/raw/master/stockfish/stockfish.spec
SRPM URL:
https://bitbucket.org/dhiru/packages/raw/master/stockfish/stockfish-4-2.fc19.
src.rpm
% rpmlint stockfish.spec stockfish-4-2.fc22.x86_64.rpm
stockfish-4-2.fc19.src.rpm
stockfish.spec: W: invalid-url Source1: stockfish-231-book.zip
Should be OK, since you're providing the file in your SRPM.
stockfish.x86_64: W: spelling-error %description -l en_US eboard - board,
aboard, e board
Maybe easily fixable.
stockfish.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/stockfish/Copying.txt
You may use the tool dos2unix to fix this.
stockfish.x86_64: W: no-manual-page-for-binary stockfish
Not needed if upstream does not provide.
stockfish.src: W: spelling-error %description -l en_US eboard - board, aboard,
e board
Ignored. False positive.
Remove ExclusiveArch cause those are now the default primary ones in rawhide.
You should use macros where possible:
- sed -i /Book File/s:book.bin:/usr/share/stockfish/Book.bin:
src/ucioption.cpp
+ sed -i /Book File/s:book.bin:%{_datadir}/%{name}/Book.bin:
src/ucioption.cpp
The folder /var/games is marked as deprecated in FHS. What is
/var/games/stockfish/polyglot.ini about, configuration? If so, consider to move
the file into folder /etc/stockfish/ instead and patch the source to find it
there.
--
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006197] Review Request: stockfish - Powerful open source chess engine
https://bugzilla.redhat.com/show_bug.cgi?id=1006197 matthew gatto mattga...@gmail.com changed: What|Removed |Added CC||mattga...@gmail.com --- Comment #7 from matthew gatto mattga...@gmail.com --- Is there a downloadable stockfish RPM build on koji.fedoraproject.org? I was linking to http://kojipkgs.fedoraproject.org//work/tasks/6926/5916926/stockfish-4-1.fc20.x86_64.rpm on the PyChess engines wiki at http://code.google.com/p/pychess/wiki/ChessEngines , but that link isn't working anymore. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006197] Review Request: stockfish - Powerful open source chess engine
https://bugzilla.redhat.com/show_bug.cgi?id=1006197 --- Comment #8 from Christopher Meng cicku...@gmail.com --- (In reply to matthew gatto from comment #7) Is there a downloadable stockfish RPM build on koji.fedoraproject.org? I was linking to http://kojipkgs.fedoraproject.org//work/tasks/6926/5916926/stockfish-4-1. fc20.x86_64.rpm on the PyChess engines wiki at http://code.google.com/p/pychess/wiki/ChessEngines , but that link isn't working anymore. That was a build only available in 7 days after it got built, now it's unavailable. You can use rpmbuild --rebuild to build the SRPM linked in comment 5, but I strongly recommend that you should wait for a while before this get approval of the review. The RPM is not good still. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006197] Review Request: stockfish - Powerful open source chess engine
https://bugzilla.redhat.com/show_bug.cgi?id=1006197 Ralf Corsepius rc040...@freenet.de changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | CC||rc040...@freenet.de --- Comment #6 from Ralf Corsepius rc040...@freenet.de --- (In reply to Dhiru Kholia from comment #5) I still need to think about using (or fixing) those upstream provided compiler flags. Well, you MUST use $RPM_OPT_FLAGS/%optflags to make sure the binaries are compatible to all current and futures architectures and features supported by Fedora and its build infrastructure. That said, * -g -O3 doesn't provide substantial advantages over -g -O2 * -msse is implied by Fedora's gcc's implicit default set of cflags on architectures it is applicatible. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZL4Ak9q0Wva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006197] Review Request: stockfish - Powerful open source chess engine
https://bugzilla.redhat.com/show_bug.cgi?id=1006197
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
CC||cicku...@gmail.com
--- Comment #1 from Christopher Meng cicku...@gmail.com ---
1. I've edited the common rpmlint error solutions page:
http://fedoraproject.org/wiki/Common_Rpmlint_issues#wrong-file-end-of-line-encoding
Please avoid using dos2unix if possible.
2. %{_var} should be %{_localstatedir}
3.
# polyglot file
install -m 644 Book.bin $RPM_BUILD_ROOT%{_var}/lib/games/%{name}
# the opening book
install -m 644 polyglot.ini $RPM_BUILD_ROOT%{_var}/lib/games/%{name}
missing -p option to preserve the timestamp.
4. Source1 should be:
Source1:
http://cl.ly/3x333m0G173F/download/%{name}-%{book_version}-book.zip
5. I've sent an email to website maintainer of stockfish, hope they can add a
sourcetarball download link on the website.
6. No %{optflags} during compiling?
I can see:
debug = no
optimize = yes (Research again contexts found:
# optimize = yes/no --- (-O3/-fast etc.) --- Enable/Disable optimizations
?O.0?)
7. Why not use make install?
8. If one want to use your package on ppc(Peter Lemenkev), I think the
installation way you've defined is not good. IMO upstream should use configure
script to do that but actually not.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=XYBqQxGfBNa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006197] Review Request: stockfish - Powerful open source chess engine
https://bugzilla.redhat.com/show_bug.cgi?id=1006197
--- Comment #2 from Michael Schwendt bugs.mich...@gmx.net ---
* Run rpmlint (or rpmlint -i for more helpful output) on the src.rpm and all
built rpms. Feel free to ignore obvious false positives in the report, but fix
anything else. Preferably add a comment here about whether/when you think what
rpmlint reports is correct or incorrect.
%setup -q -n %{upstream_name}-%{upstream_short_name}_%{version}
unzip %{SOURCE1}
%setup can unzip, too. You don't need a second line for that. Use:
%setup -q -a 1 -n %{upstream_name}-%{upstream_short_name}_%{version}
2. %{_var} should be %{_localstatedir}
Giving a rationale/explanation would be more helpful. We don't use macros just
for fun. Nothing during the build uses %{_localstatedir}. The %configure macro
isn't used either (it would pass --localstatedir=/var to the build framework).
So, using %{_var} is fine, but only provided that you use it consistently. The
sed substitution uses a hardcoded /var, so I would either use /var or %{_var}
everywhere, but not mix them.
%build
That section currenly only supports a few architectures and doesn't call make
for unknown archs. ExclusiveArch or ExcludeArch usage is missing:
https://fedoraproject.org/wiki/Packaging:Guidelines#Architecture_Support
install -m 644 Book.bin $RPM_BUILD_ROOT%{_var}/lib/games/%{name}
To be verified. Is that path correct?
The Polyglot .ini file contains a /usr/share/games/stockfish/Book.bin path.
Also consider contacting the Fedora Games SIG, since they tell that runtime
configuration files should go in /var/games/%{name} instead.
http://fedoraproject.org/wiki/SIGs/Games
- http://fedoraproject.org/wiki/SIGs/Games/Packaging
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=KetZj0EXIja=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006197] Review Request: stockfish - Powerful open source chess engine
https://bugzilla.redhat.com/show_bug.cgi?id=1006197
--- Comment #3 from Dhiru Kholia dkho...@redhat.com ---
(In reply to Christopher Meng from comment #1)
6. No %{optflags} during compiling?
Yes, we respect the upstream flags since this is a 100% CPU bound application
and they are experts when it comes to ricing ;)
I can see:
debug = no
optimize = yes (Research again contexts found:
These settings are fine and are desirable for good performance.
8. If one want to use your package on ppc(Peter Lemenkev), I think the
installation way you've defined is not good. IMO upstream should use
configure script to do that but actually not.
I don't have a good solution for this problem (is there one you know?).
Also, I don't think that the upstream will consider using configure stuff any
time soon.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=RNhnG7HkqDa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006197] Review Request: stockfish - Powerful open source chess engine
https://bugzilla.redhat.com/show_bug.cgi?id=1006197 --- Comment #4 from Michael Schwendt bugs.mich...@gmx.net --- That's a surprising response, given that the -debuginfo package is empty, and the guidelines have been ignored: https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=V91MBV3X4Xa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006197] Review Request: stockfish - Powerful open source chess engine
https://bugzilla.redhat.com/show_bug.cgi?id=1006197 --- Comment #5 from Dhiru Kholia dkho...@redhat.com --- Using debug = no was a mistake on my part, which is fixed now. Michael, thanks for pointing it out. The -debuginfo package is fine now. I still need to think about using (or fixing) those upstream provided compiler flags. Spec URL: https://bitbucket.org/dhiru/packages/raw/master/stockfish/stockfish.spec SRPM URL: https://bitbucket.org/dhiru/packages/raw/master/stockfish/stockfish-4-2.fc19.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=5920402 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IZ1iA784WRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
