[Bug 1007577] Review Request: arprec - Software package for performing arbitrary precision arithmetic
https://bugzilla.redhat.com/show_bug.cgi?id=1007577
Björn besser82 Esser bjoern.es...@gmail.com changed:
What|Removed |Added
CC|package-review@lists.fedora |
|project.org |
--- Comment #3 from Björn besser82 Esser bjoern.es...@gmail.com ---
(In reply to Ralf Corsepius from comment #2)
There are several details in the spec, I do not understand:
a) Why this:
...
# the testsuite is a good example for using this lib
cp -a tests examples
rm -rf examples/._*\
examples/Makefile*
...
To make these files available as examples, before building starts cluttering
the tests directory with intermediate files (*.o etc.)?
Yes, exactly. :) Added some more verbose comment in spec.
b) Why are you running autoreconf?
I do not see any reason why this spec needs to run autoreconf.
The tarball seem to contain broken timestamps, but these can be overcome in
less intrusive ways, which do not expose the sources to the risks of
autoreconf (Autoreconf is very dangerous, esp. in cases sources contain
fortran code).
purged
c) What are these ._* files to be found all over the place?
I think, all of them are not used and probably can be removed in %prep.
These files are purged during %prep now, too.
d) arprec-config contains arch-specific settings
= arprec-common-devel can not be noarched
My advise would be to implement a new arprec-config based on pkg-config
which is call-compatible to the original arprec-config.
merged common-devel with devel pkg.
e) IMO, the packaging is unnecessarily fine grained.
That said, I do not see much reasons for arprec-common-devel, arprec-doc,
arprec-tools-common and would advise against this kind of packaging.
as said above. renamed the tools-common to %{name}-data. But this pkg really
is noarch'ed data of ~ 72 MByte (noarch.rpm is ~30 MByte).
#
Update:
%changelog:
* Fri Sep 13 2013 Björn Esser bjoern.es...@gmail.com - 2.2.16-2
- renamed tools-common pkg to data
- merged common-devel pkg with devel, because it can't be noarch
- removed calling autoreconf during %%build
- some minor improvements in %%prep, mostly comments
- as suggested in rhbz# 1007577 c#2
* Thu Sep 12 2013 Björn Esser bjoern.es...@gmail.com - 2.2.16-1
- Initial rpm release (#1007577)
Koji Builds:
el5: no el5 build for this. autotools are too dated.
el6: https://koji.fedoraproject.org/koji/taskinfo?taskID=5930081
F18: https://koji.fedoraproject.org/koji/taskinfo?taskID=5930085
F19: https://koji.fedoraproject.org/koji/taskinfo?taskID=5930088
F20: https://koji.fedoraproject.org/koji/taskinfo?taskID=5930091
Frh: https://koji.fedoraproject.org/koji/taskinfo?taskID=5930095
Urls:
Spec URL: http://besser82.fedorapeople.org/review/arprec.spec
SRPM URL:
http://besser82.fedorapeople.org/review/arprec-2.2.16-2.fc21.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=pLaGBOrmxBa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1007577] Review Request: arprec - Software package for performing arbitrary precision arithmetic
https://bugzilla.redhat.com/show_bug.cgi?id=1007577 Matthias Runge mru...@redhat.com changed: What|Removed |Added CC||package-review@lists.fedora ||project.org -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9Q43K4n9oTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1007577] Review Request: arprec - Software package for performing arbitrary precision arithmetic
https://bugzilla.redhat.com/show_bug.cgi?id=1007577
--- Comment #4 from Ralf Corsepius rc040...@freenet.de ---
d) arprec-config contains arch-specific settings
This issue persists:
diff -Naur x86_64/usr/bin/arprec-config i386/usr/bin/arprec-config
--- x86_64/usr/bin/arprec-config2013-09-13 09:34:38.0 +0200
+++ i386/usr/bin/arprec-config 2013-09-13 09:45:30.0 +0200
@@ -3,7 +3,7 @@
prefix=/usr
exec_prefix=/usr
includedir=/usr/include
-libdir=/usr/lib64
+libdir=/usr/lib
bindir=/usr/bin
datadir=${prefix}/share
mandir=/usr/share/man
@@ -15,12 +15,12 @@
LIBS=-L$libdir -larprec
FC=f95
-FCLIBS=-L$libdir -larprecmod -larprec
-L/usr/lib/gcc/x86_64-redhat-linux/4.8.1 -L/usr/lib/
+FCLIBS=-L$libdir -larprecmod -larprec
-L/usr/lib/gcc/i686-redhat-linux/4.8.1 -L/usr/lib/gc
FCFLAGS=
MODINC=-I $includedir/arprec
FMAINLIB=-L$libdir -larprec_f_main
-configure_args= '--build=x86_64-redhat-linux-gnu'
'--host=x86_64-redhat-linux-gnu' '--progra
+configure_args= '--build=i686-redhat-linux-gnu'
'--host=i686-redhat-linux-gnu' '--program-pr
usage()
{
cat EOF
= My remark from comment#2 is still valid.
You'd see rpm installation conflicts when installing
*-devel.i386 and *-devel.x86_64 in parallel (This is a multilib problem!).
el5: no el5 build for this. autotools are too dated.
No idea, why you writing saying this. Right, it fails to build on epel5,
however not due to the autotools, but for rpm-incompatibilities:
...
error: Group field must be present in package: (main package)
...
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=lM2hLncMb5a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1007577] Review Request: arprec - Software package for performing arbitrary precision arithmetic
https://bugzilla.redhat.com/show_bug.cgi?id=1007577
Björn besser82 Esser bjoern.es...@gmail.com changed:
What|Removed |Added
CC|package-review@lists.fedora |
|project.org |
--- Comment #5 from Björn besser82 Esser bjoern.es...@gmail.com ---
(In reply to Ralf Corsepius from comment #4)
d) arprec-config contains arch-specific settings
This issue persists:
diff -Naur x86_64/usr/bin/arprec-config i386/usr/bin/arprec-config
--- x86_64/usr/bin/arprec-config2013-09-13 09:34:38.0 +0200
+++ i386/usr/bin/arprec-config 2013-09-13 09:45:30.0 +0200
@@ -3,7 +3,7 @@
prefix=/usr
exec_prefix=/usr
includedir=/usr/include
-libdir=/usr/lib64
+libdir=/usr/lib
bindir=/usr/bin
datadir=${prefix}/share
mandir=/usr/share/man
@@ -15,12 +15,12 @@
LIBS=-L$libdir -larprec
FC=f95
-FCLIBS=-L$libdir -larprecmod -larprec
-L/usr/lib/gcc/x86_64-redhat-linux/4.8.1 -L/usr/lib/
+FCLIBS=-L$libdir -larprecmod -larprec
-L/usr/lib/gcc/i686-redhat-linux/4.8.1 -L/usr/lib/gc
FCFLAGS=
MODINC=-I $includedir/arprec
FMAINLIB=-L$libdir -larprec_f_main
-configure_args= '--build=x86_64-redhat-linux-gnu'
'--host=x86_64-redhat-linux-gnu' '--progra
+configure_args= '--build=i686-redhat-linux-gnu'
'--host=i686-redhat-linux-gnu' '--program-pr
usage()
{
cat EOF
= My remark from comment#2 is still valid.
You'd see rpm installation conflicts when installing
*-devel.i386 and *-devel.x86_64 in parallel (This is a multilib problem!).
This should be fixed now by using modified arprec-config wrapper pkg-config.
el5: no el5 build for this. autotools are too dated.
No idea, why you writing saying this. Right, it fails to build on epel5,
however not due to the autotools, but for rpm-incompatibilities:
...
error: Group field must be present in package: (main package)
...
I've added the needed bits for el5, but during %build you can see %configure
throws warnings about too dated autotools' stuff. Testsuite seems to pass, so
I don't expect problems with el5 now.
#
Update:
%changelog:
* Fri Sep 13 2013 Björn Esser bjoern.es...@gmail.com - 2.2.16-3
- added needed bits for el5
- created an ascii-txt license from the license.doc provided by upstream
- nuked rpath from %%{_bindir}/%{name}-math*
- added .pc-file to solve the multiarch-problematic and aged %%{name}-config
- run `autoupdate` and `autoreconf -fiv` to fixup obsolete autotools-macros
for el6+
* Fri Sep 13 2013 Björn Esser bjoern.es...@gmail.com - 2.2.16-2
- renamed tools-common pkg to data
- merged common-devel pkg with devel, because it can't be noarch
- removed calling autoreconf during %%build
- some minor improvements in %%prep, mostly comments
- as suggested in rhbz# 1007577 c#2
* Thu Sep 12 2013 Björn Esser bjoern.es...@gmail.com - 2.2.16-1
- Initial rpm release (#1007577)
Koji Builds:
el5: https://koji.fedoraproject.org/koji/taskinfo?taskID=5930762
el6: https://koji.fedoraproject.org/koji/taskinfo?taskID=5930766
F18: https://koji.fedoraproject.org/koji/taskinfo?taskID=5930770
F19: https://koji.fedoraproject.org/koji/taskinfo?taskID=5930773
F20: https://koji.fedoraproject.org/koji/taskinfo?taskID=5930777
Frh: https://koji.fedoraproject.org/koji/taskinfo?taskID=5930782
Urls:
Spec URL: http://besser82.fedorapeople.org/review/arprec.spec
SRPM URL:
http://besser82.fedorapeople.org/review/arprec-2.2.16-3.fc21.src.rpm
#
This update should solve all issues found so far.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=6k5vuNLIkya=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1007577] Review Request: arprec - Software package for performing arbitrary precision arithmetic
https://bugzilla.redhat.com/show_bug.cgi?id=1007577 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||bjoern.es...@gmail.com, ||mru...@redhat.com Assignee|nob...@fedoraproject.org|mru...@redhat.com Alias||arprec Flags||fedora-review? --- Comment #1 from Björn besser82 Esser bjoern.es...@gmail.com --- Assigned to mrunge, as agreed for exchange with rhbz #1007374. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=x74jh7Fb57a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1007577] Review Request: arprec - Software package for performing arbitrary precision arithmetic
https://bugzilla.redhat.com/show_bug.cgi?id=1007577 Ralf Corsepius rc040...@freenet.de changed: What|Removed |Added CC||rc040...@freenet.de --- Comment #2 from Ralf Corsepius rc040...@freenet.de --- There are several details in the spec, I do not understand: a) Why this: ... # the testsuite is a good example for using this lib cp -a tests examples rm -rf examples/._*\ examples/Makefile* ... To make these files available as examples, before building starts cluttering the tests directory with intermediate files (*.o etc.)? b) Why are you running autoreconf? I do not see any reason why this spec needs to run autoreconf. The tarball seem to contain broken timestamps, but these can be overcome in less intrusive ways, which do not expose the sources to the risks of autoreconf (Autoreconf is very dangerous, esp. in cases sources contain fortran code). c) What are these ._* files to be found all over the place? I think, all of them are not used and probably can be removed in %prep. d) arprec-config contains arch-specific settings = arprec-common-devel can not be noarched My advise would be to implement a new arprec-config based on pkg-config which is call-compatible to the original arprec-config. e) IMO, the packaging is unnecessarily fine grained. That said, I do not see much reasons for arprec-common-devel, arprec-doc, arprec-tools-common and would advise against this kind of packaging. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=s8juXd7fFqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
