[Bug 1008473] Review Request: perl-Class-Tiny - Minimalist class construction
https://bugzilla.redhat.com/show_bug.cgi?id=1008473 Jitka Plesnikova jples...@redhat.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Flags||fedora-cvs? --- Comment #6 from Jitka Plesnikova jples...@redhat.com --- New Package SCM Request === Package Name: perl-Class-Tiny Short Description: Minimalist class construction Owners: jplesnik ppisar psabata Branches: f20 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PAizUCedLka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008473] Review Request: perl-Class-Tiny - Minimalist class construction
https://bugzilla.redhat.com/show_bug.cgi?id=1008473 Jitka Plesnikova jples...@redhat.com changed: What|Removed |Added Blocks||1008407 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qhqW8cvZyia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008473] Review Request: perl-Class-Tiny - Minimalist class construction
https://bugzilla.redhat.com/show_bug.cgi?id=1008473 Petr Šabata psab...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||psab...@redhat.com Assignee|nob...@fedoraproject.org|psab...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=90nx6hrka3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008473] Review Request: perl-Class-Tiny - Minimalist class construction
https://bugzilla.redhat.com/show_bug.cgi?id=1008473 Paul Howarth p...@city-fan.org changed: What|Removed |Added CC||p...@city-fan.org --- Comment #1 from Paul Howarth p...@city-fan.org --- Since you're not including the dependencies for old Perls, you should probably BR: perl = 5.14 rather than 5.8.1 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oUy0NhqDSSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008473] Review Request: perl-Class-Tiny - Minimalist class construction
https://bugzilla.redhat.com/show_bug.cgi?id=1008473 --- Comment #4 from Jitka Plesnikova jples...@redhat.com --- Updated files are on the same place. Spec URL: http://jplesnik.fedorapeople.org/perl-Class-Tiny/perl-Class-Tiny.spec SRPM URL: http://jplesnik.fedorapeople.org/perl-Class-Tiny/perl-Class-Tiny-0.008-1.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qypms9TDRia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008473] Review Request: perl-Class-Tiny - Minimalist class construction
https://bugzilla.redhat.com/show_bug.cgi?id=1008473 --- Comment #3 from Paul Howarth p...@city-fan.org --- My local build has this: %if %(perl -e 'print $] 5.014 ? 1 : 0;') BuildRequires: perl(Devel::GlobalDestruction) %else %global __requires_exclude ^perl\\(Devel::GlobalDestruction\\) %endif I have a similar condition for the Perl 5.10 support but Class-Tiny seems to have issues there (https://github.com/dagolden/Class-Tiny/issues/8) and a test build of Pod-Spell 1.07 on 5.8.8 failed for me with an error that suggested it was a Class::Tiny problem, whilst 5.10 passed OK. So I'd be inclined not to even try to support Perl 5.10 at the moment. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wrjRADdDJDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008473] Review Request: perl-Class-Tiny - Minimalist class construction
https://bugzilla.redhat.com/show_bug.cgi?id=1008473 --- Comment #2 from Petr Šabata psab...@redhat.com --- The package is fine except for the bit pointed out by Paul. I'd suggest wrapping the dependency (both BR and the filter) in a condition checking for the version of perl available. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4lFTQ2jaK7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008473] Review Request: perl-Class-Tiny - Minimalist class construction
https://bugzilla.redhat.com/show_bug.cgi?id=1008473 Petr Šabata psab...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Petr Šabata psab...@redhat.com --- Well, additional minimum perl depdency or Class::Tiny fixes could be added later if we hit the problems you're referring to. I don't think that's a review blocker. Approving. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Hgp6wjwI4la=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
