[Bug 1008787] Review Request: ghc-yaml - Support for parsing and rendering YAML documents
https://bugzilla.redhat.com/show_bug.cgi?id=1008787 Fedora Update System changed: What|Removed |Added Fixed In Version|ghc-yaml-0.8.5-3.fc19 |ghc-yaml-0.8.5-3.fc20 --- Comment #16 from Fedora Update System --- ghc-yaml-0.8.5-3.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008787] Review Request: ghc-yaml - Support for parsing and rendering YAML documents
https://bugzilla.redhat.com/show_bug.cgi?id=1008787 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||ghc-yaml-0.8.5-3.fc19 Resolution|--- |ERRATA Last Closed||2013-12-01 04:34:56 --- Comment #15 from Fedora Update System --- ghc-yaml-0.8.5-3.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008787] Review Request: ghc-yaml - Support for parsing and rendering YAML documents
https://bugzilla.redhat.com/show_bug.cgi?id=1008787 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System --- ghc-yaml-0.8.5-3.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008787] Review Request: ghc-yaml - Support for parsing and rendering YAML documents
https://bugzilla.redhat.com/show_bug.cgi?id=1008787 --- Comment #13 from Fedora Update System --- ghc-yaml-0.8.5-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/ghc-yaml-0.8.5-3.fc20 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008787] Review Request: ghc-yaml - Support for parsing and rendering YAML documents
https://bugzilla.redhat.com/show_bug.cgi?id=1008787 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008787] Review Request: ghc-yaml - Support for parsing and rendering YAML documents
https://bugzilla.redhat.com/show_bug.cgi?id=1008787 --- Comment #12 from Fedora Update System --- ghc-yaml-0.8.5-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/ghc-yaml-0.8.5-3.fc19 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008787] Review Request: ghc-yaml - Support for parsing and rendering YAML documents
https://bugzilla.redhat.com/show_bug.cgi?id=1008787 --- Comment #11 from Jens Petersen --- 0.7.0.4 would build on F18 (conduit-0.4). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008787] Review Request: ghc-yaml - Support for parsing and rendering YAML documents
https://bugzilla.redhat.com/show_bug.cgi?id=1008787 --- Comment #10 from Jens Petersen --- (In reply to Jens Petersen from comment #8) > BTW I just tested cblrpm in F20 and that does pull in chrpath > so I guess this issue is fixed in newer Cabal (>=1.16). > I should upgrade... ;) Doh, the chrpath was already there I was just running it on the wrong (non-existent) file, so it is a cblrpm bug/rfe... -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008787] Review Request: ghc-yaml - Support for parsing and rendering YAML documents
https://bugzilla.redhat.com/show_bug.cgi?id=1008787 --- Comment #9 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008787] Review Request: ghc-yaml - Support for parsing and rendering YAML documents
https://bugzilla.redhat.com/show_bug.cgi?id=1008787 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008787] Review Request: ghc-yaml - Support for parsing and rendering YAML documents
https://bugzilla.redhat.com/show_bug.cgi?id=1008787 --- Comment #8 from Jens Petersen --- > Thanks! Good catch - cblrpm is supposed to pick up that rpath > but it seems Cabal is not presenting it for some reason BTW I just tested cblrpm in F20 and that does pull in chrpath so I guess this issue is fixed in newer Cabal (>=1.16). I should upgrade... ;) -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008787] Review Request: ghc-yaml - Support for parsing and rendering YAML documents
https://bugzilla.redhat.com/show_bug.cgi?id=1008787 Jens Petersen changed: What|Removed |Added Status|NEW |ASSIGNED Whiteboard|Ready | Flags||fedora-cvs? --- Comment #7 from Jens Petersen --- (In reply to Ricky Elrod from comment #6) > APPROVED, but see rpmlint output and try to get rid of the rpath error. You > should be able to use chrpath for that, pretty easily (which is why I'm > approving now rather than having you wait for a new review :) ). Thanks! Good catch - cblrpm is supposed to pick up that rpath but it seems Cabal is not presenting it for some reason (it works in pandoc for example). Anyway sure, I will fix the yaml2json rpath when importing. New Package SCM Request === Package Name: ghc-yaml Short Description: Parsing and rendering of YAML documents Owners: petersen codeblock Branches: f20 f19 f18 el6 InitialCC: haskell-sig -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008787] Review Request: ghc-yaml - Support for parsing and rendering YAML documents
https://bugzilla.redhat.com/show_bug.cgi?id=1008787
Ricky Elrod changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #6 from Ricky Elrod ---
APPROVED, but see rpmlint output and try to get rid of the rpath error. You
should be able to use chrpath for that, pretty easily (which is why I'm
approving now rather than having you wait for a new review :) ).
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Static libraries in -static or -devel subpackage, providing -devel if
present.
Note: Package has .a files: ghc-yaml-devel. Does not provide -static: ghc-
yaml-devel.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries
(ok for haskell packages)
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be d
[Bug 1008787] Review Request: ghc-yaml - Support for parsing and rendering YAML documents
https://bugzilla.redhat.com/show_bug.cgi?id=1008787 Ricky Elrod changed: What|Removed |Added CC||rel...@redhat.com Assignee|nob...@fedoraproject.org|rel...@redhat.com Flags||fedora-review? --- Comment #5 from Ricky Elrod --- Taking. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008787] Review Request: ghc-yaml - Support for parsing and rendering YAML documents
https://bugzilla.redhat.com/show_bug.cgi?id=1008787 Jens Petersen changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Alias||ghc-yaml -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tpf1NXfbuU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008787] Review Request: ghc-yaml - Support for parsing and rendering YAML documents
https://bugzilla.redhat.com/show_bug.cgi?id=1008787 --- Comment #3 from Jens Petersen --- http://packdeps.haskellers.com/reverse/yaml -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=93ckcBPoMW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008787] Review Request: ghc-yaml - Support for parsing and rendering YAML documents
https://bugzilla.redhat.com/show_bug.cgi?id=1008787 Jens Petersen changed: What|Removed |Added CC||haskell-devel@lists.fedorap ||roject.org Blocks||630303 (yesod), 1008396 Whiteboard||Ready --- Comment #2 from Jens Petersen --- Needed for yesod and also pandoc-1.12. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=l8QNn16XyN&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008787] Review Request: ghc-yaml - Support for parsing and rendering YAML documents
https://bugzilla.redhat.com/show_bug.cgi?id=1008787 --- Comment #1 from Jens Petersen --- This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5943827 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xdI1qzZfCN&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
