[Bug 1009750] Review Request: python-falcon - High-performance cloud API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1009750 Jamie Lennox changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZKjzjddpHM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009750] Review Request: python-falcon - High-performance cloud API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1009750
Christopher Meng changed:
What|Removed |Added
CC||cicku...@gmail.com
--- Comment #1 from Christopher Meng ---
1. BuildRequires: python-setuptools-devel
-->
BuildRequires: python-setuptools
AND
BuildRequires: python-devel
-->
BuildRequires: python2-devel
2. rm -rf $RPM_BUILD_ROOT is not needed in modern system.
3. Good to see using %{__python2}, but you forgot it in %install
4. %{python_sitearch} --> %{python2_sitearch}
5. You forgot to use nose or tox to test as RPM %check.
https://github.com/racker/falcon/blob/master/README.md#test
6. No python3 support? Why?
7. You can add features listed on pypi as RPM %description:
Features
- Intuitive routing via URI templates and resource classes
- Easy access to headers and bodies through request and response classes
- Idiomatic HTTP error responses via a handy exception base class
- DRY request processing using global, resource, and method hooks
- Snappy unit testing through WSGI helpers and mocks
- 20% speed boost when Cython is available
- Python 2.6, Python 2.7, PyPy and Python 3.3 support
- Speed, speed, and more speed!
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=n36I0JyAnc&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009750] Review Request: python-falcon - High-performance cloud API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1009750 --- Comment #2 from Jamie Lennox --- Thanks for the review Christopher. I've updated the SPEC and SRPM. Same location as before. $ rpmlint SRPMS/python-falcon-0.1.7-1.fc19.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. f19: http://koji.fedoraproject.org/koji/taskinfo?taskID=5970098 rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=5970094 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=r0Sn3ppmcs&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009750] Review Request: python-falcon - High-performance cloud API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1009750 Rex Dieter changed: What|Removed |Added Status|NEW |ASSIGNED CC||rdie...@math.unl.edu Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu Flags||fedora-review? --- Comment #3 from Rex Dieter --- I can pick up the remainder of the review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=F72FUkMzA0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009750] Review Request: python-falcon - High-performance cloud API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1009750
Rex Dieter changed:
What|Removed |Added
Blocks|177841 (FE-NEEDSPONSOR) |
Flags|fedora-review? |fedora-review+
--- Comment #4 from Rex Dieter ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
Note: Using both %{buildroot} and $RPM_BUILD_ROOT
See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Apache (v2.0)", "Unknown or generated". 33 files have unknown license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[ ]: Macros in Summary, %description expandable at SRPM build time.
Note: Macros in: python-falcon (description), python3-falcon
(description)
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 61440 bytes in 10 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Package does not contain duplicates in %files.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[ ]: Python eggs must not download any dependencies during the build process.
[ ]: A package which is used by another package via an egg interface should
provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[ ]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[ ]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python3-falcon
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files
[Bug 1009750] Review Request: python-falcon - High-performance cloud API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1009750 --- Comment #5 from Jamie Lennox --- New Package SCM Request === Package Name: python-falcon Short Description: A supersonic micro-framework for building cloud APIs Owners: jamielennox Branches: f18 f19 f20 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MIY5SkKVwR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009750] Review Request: python-falcon - High-performance cloud API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1009750 Jamie Lennox changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vaCYJzCFQl&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009750] Review Request: python-falcon - High-performance cloud API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1009750 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wQi9aLionI&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009750] Review Request: python-falcon - High-performance cloud API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1009750 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1ZjbZbbg33&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009750] Review Request: python-falcon - High-performance cloud API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1009750 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009750] Review Request: python-falcon - High-performance cloud API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1009750 --- Comment #7 from Fedora Update System --- python-falcon-0.1.7-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-falcon-0.1.7-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009750] Review Request: python-falcon - High-performance cloud API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1009750 --- Comment #8 from Fedora Update System --- python-falcon-0.1.7-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-falcon-0.1.7-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009750] Review Request: python-falcon - High-performance cloud API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1009750 --- Comment #9 from Fedora Update System --- python-falcon-0.1.7-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-falcon-0.1.7-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009750] Review Request: python-falcon - High-performance cloud API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1009750 --- Comment #10 from Fedora Update System --- python-falcon-0.1.7-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009750] Review Request: python-falcon - High-performance cloud API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1009750 --- Comment #11 from Fedora Update System --- python-falcon-0.1.7-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009750] Review Request: python-falcon - High-performance cloud API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1009750 --- Comment #12 from Fedora Update System --- python-falcon-0.1.7-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009750] Review Request: python-falcon - High-performance cloud API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1009750 Christopher Meng changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2013-11-03 08:54:44 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
