[Bug 1010565] Review Request: tapkee - C++ template library for efficient dimension reduction
https://bugzilla.redhat.com/show_bug.cgi?id=1010565 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zrNtmMsNyma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010565] Review Request: tapkee - C++ template library for efficient dimension reduction
https://bugzilla.redhat.com/show_bug.cgi?id=1010565 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kNCWG8mfNza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010565] Review Request: tapkee - C++ template library for efficient dimension reduction
https://bugzilla.redhat.com/show_bug.cgi?id=1010565 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=N1Px6LOESsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010565] Review Request: tapkee - C++ template library for efficient dimension reduction
https://bugzilla.redhat.com/show_bug.cgi?id=1010565 --- Comment #4 from Fedora Update System upda...@fedoraproject.org --- tapkee-1.0-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/tapkee-1.0-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8WwK6ApJm8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010565] Review Request: tapkee - C++ template library for efficient dimension reduction
https://bugzilla.redhat.com/show_bug.cgi?id=1010565 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- tapkee-1.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/tapkee-1.0-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0I4yjLALOza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010565] Review Request: tapkee - C++ template library for efficient dimension reduction
https://bugzilla.redhat.com/show_bug.cgi?id=1010565 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- tapkee-1.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/tapkee-1.0-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9sNiBC4Lata=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010565] Review Request: tapkee - C++ template library for efficient dimension reduction
https://bugzilla.redhat.com/show_bug.cgi?id=1010565 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Flags|fedora-cvs+ |fedora-cvs? --- Comment #7 from Björn besser82 Esser bjoern.es...@gmail.com --- Package Change Request == Package Name: tapkee Owners: ml-sig besser82 Branches: el5 el6 f18 f19 f20 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gs4kFzi4zwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010565] Review Request: tapkee - C++ template library for efficient dimension reduction
https://bugzilla.redhat.com/show_bug.cgi?id=1010565 Bug 1010565 depends on bug 1010551, which changed state. Bug 1010551 Summary: needs rebuild work -- broken deps on RAWHIDE https://bugzilla.redhat.com/show_bug.cgi?id=1010551 What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=B5CISNp8kna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010565] Review Request: tapkee - C++ template library for efficient dimension reduction
https://bugzilla.redhat.com/show_bug.cgi?id=1010565 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added Depends On||1010551 Alias||tapkee -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rCaCTus81Ua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010565] Review Request: tapkee - C++ template library for efficient dimension reduction
https://bugzilla.redhat.com/show_bug.cgi?id=1010565 Wolfgang Ulbrich chat-to...@raveit.de changed: What|Removed |Added CC||chat-to...@raveit.de Assignee|nob...@fedoraproject.org|chat-to...@raveit.de Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XwS18w8hmha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010565] Review Request: tapkee - C++ template library for efficient dimension reduction
https://bugzilla.redhat.com/show_bug.cgi?id=1010565
Wolfgang Ulbrich chat-to...@raveit.de changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Wolfgang Ulbrich chat-to...@raveit.de ---
APPROVED !
Maybe you should try to fix some rpmlint warnings, minor.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Provides: bundled(gnulib) in place as required.
Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: BSD (3 clause), GPL (v3 or later),
Unknown or generated, BSD (4 clause). 80 files have unknown license.
Detailed output of licensecheck in
/home/rave/1010565-tapkee/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
Note: Especially check following dirs for bundled code:
/home/rave/1010565-tapkee/upstream-unpacked/Source99/gtest-1.6.0/include,
/home/rave/1010565-tapkee/upstream-unpacked/Source0/tapkee-1.0/include
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 61440 bytes in 8 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]:
[Bug 1010565] Review Request: tapkee - C++ template library for efficient dimension reduction
https://bugzilla.redhat.com/show_bug.cgi?id=1010565 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added Status|NEW |POST Flags||fedora-cvs? --- Comment #2 from Björn besser82 Esser bjoern.es...@gmail.com --- Thanks for the review, Wolfgang! :) You can ignore the rpmlint warnings about those *.pgm-files. They are images in some raw-format, but rpmlint isn't aware of that and treats them wrongly as plain/txt. # New Package SCM Request === Package Name: tapkee Short Description: C++ template library for efficient dimension reduction Owners: besser82 Branches: f18 f19 f20 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kL5QRo7Q18a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
