[Bug 1013807] Review Request: python-sendgrid - SendGrid library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1013807 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2014-10-09 15:29:35 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1013807] Review Request: python-sendgrid - SendGrid library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1013807 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #8 from Mario Blättermann mario.blaetterm...@gmail.com --- All packages have been built and are at least in the testing repo. I change the status to ON_QA. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1013807] Review Request: python-sendgrid - SendGrid library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1013807 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1013807] Review Request: python-sendgrid - SendGrid library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1013807 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1013807] Review Request: python-sendgrid - SendGrid library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1013807
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #5 from Mario Blättermann mario.blaetterm...@gmail.com ---
OK, here we go:
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
MIT
[.] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
7fa2b716721b0e95d608659df9e1e32d785ebd8754f650e8a34991212ed9d7c5
sendgrid-0.1.4.tar.gz
7fa2b716721b0e95d608659df9e1e32d785ebd8754f650e8a34991212ed9d7c5
sendgrid-0.1.4.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: Development files must be in a -devel package.
[.] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name}%{?_isa} =
%{version}-%{release}
[.] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must
[Bug 1013807] Review Request: python-sendgrid - SendGrid library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1013807 Daniel Bruno dbr...@fedoraproject.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Daniel Bruno dbr...@fedoraproject.org --- New Package SCM Request === Package Name: python-sendgrid Short Description: SendGrid library for Python Owners: dbruno Branches: f18 f19 f20 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1013807] Review Request: python-sendgrid - SendGrid library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1013807 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co ||m Flags||fedora-review? --- Comment #3 from Mario Blättermann mario.blaetterm...@gmail.com --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6017686 $ rpmlint -i -v * python-sendgrid.src: I: checking python-sendgrid.src: I: checking-url https://github.com/sendgrid/sendgrid-python/ (timeout 10 seconds) python-sendgrid.src: I: checking-url https://pypi.python.org/packages/source/s/sendgrid/sendgrid-0.1.4.tar.gz (timeout 10 seconds) python-sendgrid.noarch: I: checking python-sendgrid.noarch: I: checking-url https://github.com/sendgrid/sendgrid-python/ (timeout 10 seconds) python-sendgrid.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-sendgrid/README.md This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. python-sendgrid.spec: I: checking-url https://pypi.python.org/packages/source/s/sendgrid/sendgrid-0.1.4.tar.gz (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 1 warnings. Please fix the wrong line endings in README.md, and your package is ready for a full review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RfJbpxXpwoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1013807] Review Request: python-sendgrid - SendGrid library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1013807 --- Comment #4 from Daniel Bruno dbr...@fedoraproject.org --- The SRC and SPEC were fixed. Spec URL: http://dbruno.fedorapeople.org/python-sendgrid/python-sendgrid.spec SRPM URL: http://dbruno.fedorapeople.org/python-sendgrid/python-sendgrid-0.1.4-1.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gtpDMtepjva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1013807] Review Request: python-sendgrid - SendGrid library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1013807
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
CC||mario.blaetterm...@gmail.co
||m
--- Comment #1 from Mario Blättermann mario.blaetterm...@gmail.com ---
Please add README.md as %doc.
The tarball contains a prebuilt egg, please remove it in %prep before building
the package:
rm -fr %{tarball_name}.egg-info
See http://fedoraproject.org/wiki/Packaging:Python_Eggs#Upstream_Eggs for more
information.
The initial cleaning of %{buildroot} in %install is obsolete for ages and can
be safely dropped.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=a6SunBCjW1a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1013807] Review Request: python-sendgrid - SendGrid library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1013807 --- Comment #2 from Daniel Bruno dbr...@fedoraproject.org --- Follow the SRC and the SPEC fixed: Spec URL: http://dbruno.fedorapeople.org/python-sendgrid/python-sendgrid.spec SRPM URL: http://dbruno.fedorapeople.org/python-sendgrid/python-sendgrid-0.1.4-1.fc19.src.rpm Thanks -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OJz8nZIf4sa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
