[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #33 from Parag AN(पराग) panem...@gmail.com --- Ouch! you are right. I forgot to change it to serif as it was just copy paste from some other fontconfig file. a)amiri-fontconfig.conf ?xml version=1.0 encoding=UTF-8? !DOCTYPE fontconfig SYSTEM ../fonts.dtd fontconfig alias familyserif/family prefer familyAmiri/family /prefer /alias alias familyAmiri/family default familyserif/family /default /alias /fontconfig b) Khaled you suggest not to include any fontconfig file for Amiri Quran font? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #34 from Khaled Hosny khaledho...@eglug.org --- (In reply to Parag AN(पराग) from comment #33) b) Khaled you suggest not to include any fontconfig file for Amiri Quran font? I think it is better not to provide one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #35 from Mosaab Alzoubi moc...@hotmail.com --- Thank You for attention (and for invitation) Parag Thank You for your notes Khaled (maintainer of Amiri) - Fix Sourceforg link in Source0. - Decrease instructions to rebuild Amiri from the source. - Replace -docs by -common. - Change font priority to 67. - Improve font config. - The fonts in one family so it united into 1 main package instead of 2. - -common to be main package require. --- Spec : http://ojuba.org/oji/SPECS/amiri-fonts.spec SRPM : http://ojuba.org/oji/SRPMS/amiri-fonts-0.106-7.oji.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #36 from Parag AN(पराग) panem...@gmail.com --- 1) You need subpackage for Amiri Quran. Don't remove it. We add fonts (sub-)packages per family. Here, Amiri Quran is one family for amiri-quran.ttf and all other fonts under family name Amiri. so as said before, amiri-fonts installs amiri-boldslanted.ttf, amiri-bold.ttf, amiri-regular.ttf, amiri-slanted.ttf And amiri-quran-fonts installs amiri-quran.ttf and then -common is needed by amiri-quran-fonts subpackage also. 2) you can remove following %doc and instead make all docs files be owned/installed by -common subpackage %files common %doc documentation/* OFL.txt OFL-FAQ.txt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #37 from Mosaab Alzoubi moc...@hotmail.com --- Then, is amiri-quran-fontconfig.conf still needed? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added CC||nicolas.mail...@laposte.net --- Comment #38 from Parag AN(पराग) panem...@gmail.com --- generally we add fontconfig files per family per subpackage. I think if font is not supposed to be used as a desktop font but only for writing text then we can drop fontconfig file. Nicolas, If you are reading this package review emails then we need your input here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #39 from Nicolas Mailhot nicolas.mail...@laposte.net --- (In reply to Parag AN(पराग) from comment #38) generally we add fontconfig files per family per subpackage. I think if font is not supposed to be used as a desktop font but only for writing text then we can drop fontconfig file. Nicolas, If you are reading this package review emails then we need your input here. The guidelines intent is to treat all fonts the same and not assume users will only use them in a particular way. Packages have a long life and it's always worthwhile not to restrict hteir use beforehand. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #40 from Parag AN(पराग) panem...@gmail.com ---
Mosaab,
1)Add the fontconfig amiri-quran-fonts.conf file and submit new srpm for
further review. Note this is also serif font so add accordingly in fontconfig
file.
2) I saw your recent spec. You should write -common as
%package common
Summary:Common files for %{name}
Requires: fontpackages-filesystem
%description common
%common_desc
This package consists of files used by other %{name} packages.
3) your main package should drop
Requires: fontpackages-filesystem
as this is already added in -common
4) I tried to find some recent examples for font packages but could not find
spec as per updated guidelines but here are some that you should see.
http://pkgs.fedoraproject.org/cgit/ecolier-court-fonts.git/plain/ecolier-court-fonts.spec
http://pkgs.fedoraproject.org/cgit/sj-fonts.git/plain/sj-fonts.spec
http://pkgs.fedoraproject.org/cgit/linux-libertine-fonts.git/plain/linux-libertine-fonts.spec
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #41 from Mosaab Alzoubi moc...@hotmail.com --- - Re-split into main and Quran fonts. - Improve Amiri Quran font config. - Add license files to -common, dropped from others. - Drop fontpackages-filesystem requires from main package. -- Spec : http://ojuba.org/oji/SPECS/amiri-fonts.spec SRPM : http://ojuba.org/oji/SRPMS/amiri-fonts-0.106-8.oji.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #42 from Khaled Hosny khaledho...@eglug.org --- (In reply to Nicolas Mailhot from comment #39) (In reply to Parag AN(पराग) from comment #38) generally we add fontconfig files per family per subpackage. I think if font is not supposed to be used as a desktop font but only for writing text then we can drop fontconfig file. Nicolas, If you are reading this package review emails then we need your input here. The guidelines intent is to treat all fonts the same and not assume users will only use them in a particular way. Packages have a long life and it's always worthwhile not to restrict hteir use beforehand. I’m not sure I follow here, but Amiri Quran is just a modified version of Amiri with reduced character set and defaults suitable only for typesetting Quran. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #43 from Parag AN(पराग) panem...@gmail.com --- Though Amiri font is not yet in Fedora and Amiri Quran is modified version of Amiri font, Let's take reference of https://fedoraproject.org/wiki/Shipping_fonts_in_Fedora_%28FAQ%29#What_if_my_package_bundles_a_modified_version_of_an_existing_Fedora_font.3F Then the last submitted srpm is ready for final review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #31 from Parag AN(पराग) panem...@gmail.com ---
suggestions:
1) your source download link should be
http://downloads.sourceforge.net/project/amiri/%{fontname}-%{version}.tar.bz2
2) good to always truncate your long lines with 80 characters per line
# Sorts Mill tools (and others) which necessary to rebuild Amiri fonts isn't
# released in Fedora yet. Enable the disabled-lines when rebuilding of Amiri
# fonts possible.
but I will suggest you better clean the spec and let not include comments and
sorts mill tools information.
We have many font packages which are not built from source so not a hard
requirement. Just install binary files for now.
3) your fontconfig files should look neat as
a)amiri-fontconfig.conf
?xml version=1.0 encoding=UTF-8?
!DOCTYPE fontconfig SYSTEM ../fonts.dtd
fontconfig
alias
familysans-serif/family
prefer
familyAmiri/family
/prefer
/alias
alias
familyAmiri/family
default
familysans-serif/family
/default
/alias
/fontconfig
b)amiri-quran-fontconfig.conf
?xml version=1.0 encoding=UTF-8?
!DOCTYPE fontconfig SYSTEM ../fonts.dtd
fontconfig
alias
familysans-serif/family
prefer
familyAmiri Quran/family
/prefer
/alias
alias
familyAmiri Quran/family
default
familysans-serif/family
/default
/alias
/fontconfig
4) font package name should be
[foundryname-]projectname[-fontfamilyname]-fonts, in lowercase.
so you should install amiri-boldslanted.ttf, amiri-bold.ttf, amiri-regular.ttf,
amiri-slanted.ttf from main amiri-fonts package
and
amiri-quran.ttf font from amiri-quran-fonts package
5) I don't think we need this font to be default Arabic font in Fedora. I will
suggest to use 67 or 68 fontconfig priority like other fonts are using. Good to
keep 67 priority as we have one example as 67-paktype-naskh-basic.conf
6) you should add -common package and not -doc package. Also, all other
documentation files to -common package.
7) then, this -common be added to amiri-fonts and amiri-quran-fonts as
Requires: amiri-fonts-common
Feel free to ask me if you got any doubts in above.
Provide new srpm that fixes above issues.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #32 from Khaled Hosny khaledho...@eglug.org --- (In reply to Parag AN(पराग) from comment #31) 3) your fontconfig files should look neat as a)amiri-fontconfig.conf ?xml version=1.0 encoding=UTF-8? !DOCTYPE fontconfig SYSTEM ../fonts.dtd fontconfig alias familysans-serif/family prefer familyAmiri/family /prefer /alias alias familyAmiri/family default familysans-serif/family /default /alias /fontconfig Amiri is a serif, not a sans-serif font. b)amiri-quran-fontconfig.conf ?xml version=1.0 encoding=UTF-8? !DOCTYPE fontconfig SYSTEM ../fonts.dtd fontconfig alias familysans-serif/family prefer familyAmiri Quran/family /prefer /alias alias familyAmiri Quran/family default familysans-serif/family /default /alias /fontconfig Amiri Quran is a special font for typesetting Quran (it has a very high line hight, only support characters used in Quran, some typographic choices not generally suitable for regular text), so I don’t think such an alias is a good idea. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #30 from Parag AN(पराग) panem...@gmail.com --- Thanks. I will resume this review on Monday and will sponsor you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 Bug 1015701 depends on bug 1021164, which changed state. Bug 1021164 Summary: Review Request: general-purpose-preprocessor - Customizable language-agnostic preprocessor https://bugzilla.redhat.com/show_bug.cgi?id=1021164 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #29 from Mosaab Alzoubi moc...@hotmail.com --- Thank you Parag for your attention, Done: #1025601 #1025052 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|panem...@gmail.com Flags||fedora-review? --- Comment #28 from Parag AN(पराग) panem...@gmail.com --- I see that you have started reviewing other new packages. Please do 2 more full reviews and show that you understand packaging and can find issues in packages and can provide fixes to them. I am taking this for official review but will do so once I see your reviews done on other packages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #26 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
Informal review:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
OFL.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 2 files have unknown license. Detailed output of
licensecheck in /home/zbyszek/fedora/1015701-amiri-fonts/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 460800 bytes in 10 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in amiri-
fonts-docs , amiri-quran-fonts , amiri-naskh-fonts
Not needed.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed: What|Removed |Added Assignee|zbys...@in.waw.pl |nob...@fedoraproject.org --- Comment #27 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl --- In my opinion, package is good. Un-assigning, since I'm not a sponsor. Note, link to wiki: https://fedoraproject.org/wiki/Amiri_fonts -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #20 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl --- I learnt in another review that .woffs are not supposed to be packaged: http://fedoraproject.org/wiki/Packaging:Web_Assets#Fonts. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #21 from Parag AN(पराग) panem...@gmail.com --- That's right. Whichever format upstream is providing fonts, try to package ttf or otf only if available that format. For fonts packages its recommended to create a font package information on Fedora wiki page with In_progress category page which when font package review gets approved moved to packaged font category. See https://fedoraproject.org/wiki/Category:In-progress_fonts -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 Mosaab Alzoubi moc...@hotmail.com changed: What|Removed |Added CC||khaledho...@eglug.org --- Comment #22 from Mosaab Alzoubi moc...@hotmail.com --- * Well, I'll remove web fonts. * Font already now at the wiki. * CC Amiri Maintainer. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #23 from Mosaab Alzoubi moc...@hotmail.com --- - Dropped .woff fonts. - Update description by official one. - Make this package ready for building if it possible later. Spec : http://ojuba.org/oji/SPECS/amiri-fonts.spec SRPM : http://ojuba.org/oji/SRPMS/amiri-fonts-0.106-5.oji.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #24 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl --- Oh, one more issue: 1. change %define to %global -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #25 from Mosaab Alzoubi moc...@hotmail.com --- OK done: Spec : http://ojuba.org/oji/SPECS/amiri-fonts.spec SRPM : http://ojuba.org/oji/SRPMS/amiri-fonts-0.106-6.oji.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #19 from Mosaab Alzoubi moc...@hotmail.com --- First full-reviesion : bug 1023619 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #17 from Parag AN(पराग) panem...@gmail.com --- Mosaab, Do some full reviews of new packages not just one or two comments. I will be happy to sponsor then. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #18 from Mosaab Alzoubi moc...@hotmail.com --- Ok I'll search. These was latest 3 new review bugs !! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #14 from Parag AN(पराग) panem...@gmail.com --- Thanks for submitting 7 packages for review but you need to do package review of other people's submitted packages reviews. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #15 from Mosaab Alzoubi moc...@hotmail.com --- Ok . I read 4 package review new bugs and wrote my notes: #1021721 #1022407 #1021749 Thank You again Parag. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #16 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl --- (Strong suggestion:) Please install fedora-review, and use it on your *own* review requests. It will point out obvious things, letting the reviewers concentrate on subtler things and reduce the review time. Also, use it on *other* people's review requests, even pasting the whole review.txt with your own comments notes into comments on the tickets. This will show your sponsor that you can review other packages. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #13 from Mosaab Alzoubi moc...@hotmail.com --- Zbigniew :: This font couldn't built by FontForge, It built by fork of it found here: https://bitbucket.org/sortsmill/sortsmill-tools That what Khaled Hosny (maintainer of Amiri complex font) said. So I tried to build sortsmill, but it need gnulib to build. I surprised that gnulib isn't found in Fedora repo !! So I worked hard to package it #1022283 --- Parag :: Thank you for your attention, I did 7 package reveiw bugs :: https://bugzilla.redhat.com/buglist.cgi?component=Package%20Reviewemail1=moceap%40hotmail.comemailreporter1=1emailtype1=substringlist_id=1829241query_format=advanced GnuLib is the last one I did to package sortsmill to package Amiri fonts :) Really I want your sponsor to push these packages (and others) into Fedora. --- Kind Regards Mosaab -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #11 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl --- sfntly has been packaged: #912686, I think it is the same thing as sfnttool. gpp is in #1021164. fntsample, pdfoutline, latexmk are available. So I think it is viable to build from source. I'm not a sponsor, and I cannot sponsor you into the packager group. You'll have to find someone to do that. It would certainly be nice to polish this package so that it satisfies all guidelines, I'll by happy to help by doing further (informal) reviews of this package. It also *does* help if you do informal reviews of other packages, before you are sponsored. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #12 from Parag AN(पराग) panem...@gmail.com --- I can sponsor the reporter provided he will show package reviews done on other package review bugs where he can show he has helped in finding issues and providing fix for them. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #5 from Mosaab Alzoubi moc...@hotmail.com --- All Done, Rewritten almost from Zero :: Spec : http://ojuba.org/oji/SPECS/amiri-fonts.spec SRPM : http://ojuba.org/oji/SRPMS/amiri-fonts-0.106-3.oji.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #6 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl --- Some high-level problems: 1. Guidelines say that fonts must be built from sources, if those are provided. Here they are provided. 2. -web fonts are the same as in the main package with just some metainformation removed to save space. I don't think we normally package that. I think it is normal to just put .woff and other formats in the same -fonts package. 3. Some of your descriptions in Arabic are not the same as in English, afaict. This is supposed to be a translation, not a separate text. 4. -common just contains some documentation. It would be better to call it -docs. Also, -fonts packages should not depend on it. It is enough to include a copy of the license file in the -fonts packages. 5. License file is not packaged. 6. There's no need to remove the buildroot. 7. You can drop the empty %files sections and the two meta packages. What are they useful for? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #7 from Mosaab Alzoubi moc...@hotmail.com --- Thanx for reply. 1 - When I build it from source directly, nothing done because the destination of built fonts already busy, Also building of the font requirs gpp command I couldn't find it in Fedora repos. 2 - Did you mean to renaming files of -web? 3 - Arabic and English texts isn't matching 100% , but as whole they serve one idea. 4 - I taked (common) name from complex formal font spec, and I doesn't have problems to call it (docs), also the requires line. 5 - Ok ^_^ , (License alredy included in ttf files ^_^), I'll package it :) 6 - OK 7 - OK -- Thank you Zbigniew , this is longest spec I wrote ever, so I wrote it slowly. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #8 from Mosaab Alzoubi moc...@hotmail.com --- For point 7 , I think (amiri-fonts) meta package make download of the fonts as group more easy . I think this way must be formal in Fedora ^_^ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #9 from Mosaab Alzoubi moc...@hotmail.com --- All Fixed :: Spec : http://ojuba.org/oji/SPECS/amiri-fonts.spec SRPM : http://ojuba.org/oji/SRPMS/amiri-fonts-0.106-4.oji.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed: What|Removed |Added Depends On||1021164 Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl --- Comment #10 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl --- (In reply to Mosaab Alzoubi from comment #7) Thanx for reply. 1 - When I build it from source directly, nothing done because the destination of built fonts already busy, Also building of the font requirs gpp command I couldn't find it in Fedora repos. You can do 'make clean' to get rid of the generated files. gpp is now at #1021164. 2 - Did you mean to renaming files of -web? No, I meant to remove (not install) the files in -web. 3 - Arabic and English texts isn't matching 100% , but as whole they serve one idea. The Arabic should be a translation of the English one... 4 - I taked (common) name from complex formal font spec, and I doesn't have problems to call it (docs), also the requires line. The example from the wiki doesn't really fit here, so some adjustments must be made. 5 - Ok ^_^ , (License alredy included in ttf files ^_^), I'll package it :) 6 - OK 7 - OK -- Thank you Zbigniew , this is longest spec I wrote ever, so I wrote it slowly. Current spec looks nice. Let's see if is viable to build from source. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1021164 [Bug 1021164] Review Request: gpp - Customizable language-agnostic preprocessor -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 Mosaab Alzoubi moc...@hotmail.com changed: What|Removed |Added Alias||Amiri -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #4 from Mosaab Alzoubi moc...@hotmail.com --- Ok , rewiting in progress -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed: What|Removed |Added CC||zbys...@in.waw.pl --- Comment #3 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl --- This is pretty far from the guidelines... See https://fedoraproject.org/wiki/Packaging:FontsPolicy. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #2 from Mosaab Alzoubi moc...@hotmail.com --- Hosted at Ojuba server , Alot of fixes after many packages revision :) Spec : http://ojuba.org/oji/SPECS/amiri-fonts.spec SRPM : http://ojuba.org/oji/SRPMS/amiri-fonts-0.106-2.oji.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org
https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #1 from Mosaab Alzoubi moc...@hotmail.com --- Spec URL: http://helallinux.com/paste/show.php?id=1225mode=raw SRPM URL: http://downloads.sourceforge.net/projects/oji/srpms/amiri-fonts-0.106-1.fc19.src.rpm Description: مجموعة الخطوط الأميرية ذات المظهر الأنيق و التّراث العتيق . Amiri font is an open font revival of the Arabic Naskh typeface designed and first used by Bulaq Press in Cairo (Maṭbaʿtu Būlāq, also known as Āl-Maṭbaʿtu Āl-Āmīriīaʰ) in the early 2th century. Amiri's uniqueness comes from its superb balance between the beauty of Naskh calligraphy and the requirements of elegant typography. Amiri is most suitable for running text and book printing. Fedora Account System Username: moceap -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
