[Bug 1016370] Review Request: rubygem-capillary - Generate a JSON payload from Git log output

2013-11-09 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1016370

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|rubygem-capillary-1.0.3-3.f |rubygem-capillary-1.0.3-3.f
   |c19 |c20



--- Comment #15 from Fedora Update System upda...@fedoraproject.org ---
rubygem-capillary-1.0.3-3.fc20 has been pushed to the Fedora 20 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1016370] Review Request: rubygem-capillary - Generate a JSON payload from Git log output

2013-11-02 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1016370

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||rubygem-capillary-1.0.3-3.f
   ||c19
 Resolution|--- |ERRATA
Last Closed||2013-11-03 00:31:47



--- Comment #14 from Fedora Update System upda...@fedoraproject.org ---
rubygem-capillary-1.0.3-3.fc19 has been pushed to the Fedora 19 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1016370] Review Request: rubygem-capillary - Generate a JSON payload from Git log output

2013-10-11 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1016370

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System upda...@fedoraproject.org ---
rubygem-capillary-1.0.3-3.fc20 has been pushed to the Fedora 20 testing
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1016370] Review Request: rubygem-capillary - Generate a JSON payload from Git log output

2013-10-10 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1016370



--- Comment #5 from Ken Dreyer ktdre...@ktdreyer.com ---
You're quite right. I didn't realize that the gemspec doesn't use double
quotation marks once we regenerate it. Thanks.

I've adjusted the first sed regex, and removed the second sed operation (now
that the first works properly.)

Release 3:

Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-capillary.spec
SRPM URL:
http://ktdreyer.fedorapeople.org/reviews/rubygem-capillary-1.0.3-3.fc21.src.rpm

Specific changes:
http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-capillary.git/commit/?id=09764a7a6f3b97dc9a75337d9363dea2c398a7db

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1016370] Review Request: rubygem-capillary - Generate a JSON payload from Git log output

2013-10-10 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1016370

Mamoru TASAKA mtas...@fedoraproject.org changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Mamoru TASAKA mtas...@fedoraproject.org ---
Approving.

-
   This package (rubygem-capillary) is APPROVED
   by mtasaka
-

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1016370] Review Request: rubygem-capillary - Generate a JSON payload from Git log output

2013-10-10 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1016370

Ken Dreyer ktdre...@ktdreyer.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #7 from Ken Dreyer ktdre...@ktdreyer.com ---
Thanks mtasaka!

New Package SCM Request
===
Package Name: rubygem-capillary
Short Description: Generate a JSON payload from Git log output
Owners: ktdreyer
Branches: f19 f20
InitialCC: ruby-sig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1016370] Review Request: rubygem-capillary - Generate a JSON payload from Git log output

2013-10-10 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1016370



--- Comment #8 from Jon Ciesla limburg...@gmail.com ---
ruby-sig is not a valid FAS account.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1016370] Review Request: rubygem-capillary - Generate a JSON payload from Git log output

2013-10-10 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1016370

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1016370] Review Request: rubygem-capillary - Generate a JSON payload from Git log output

2013-10-10 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1016370

Ken Dreyer ktdre...@ktdreyer.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #9 from Ken Dreyer ktdre...@ktdreyer.com ---
Sorry about that. I got confused with Perl.

New Package SCM Request
===
Package Name: rubygem-capillary
Short Description: Generate a JSON payload from Git log output
Owners: ktdreyer
Branches: f19 f20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1016370] Review Request: rubygem-capillary - Generate a JSON payload from Git log output

2013-10-10 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1016370

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1016370] Review Request: rubygem-capillary - Generate a JSON payload from Git log output

2013-10-10 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1016370



--- Comment #10 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1016370] Review Request: rubygem-capillary - Generate a JSON payload from Git log output

2013-10-10 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1016370

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1016370] Review Request: rubygem-capillary - Generate a JSON payload from Git log output

2013-10-10 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1016370



--- Comment #11 from Fedora Update System upda...@fedoraproject.org ---
rubygem-capillary-1.0.3-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/rubygem-capillary-1.0.3-3.fc19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1016370] Review Request: rubygem-capillary - Generate a JSON payload from Git log output

2013-10-10 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1016370



--- Comment #12 from Fedora Update System upda...@fedoraproject.org ---
rubygem-capillary-1.0.3-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/rubygem-capillary-1.0.3-3.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1016370] Review Request: rubygem-capillary - Generate a JSON payload from Git log output

2013-10-09 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1016370



--- Comment #4 from Mamoru TASAKA mtas...@fedoraproject.org ---
For -2:

* About excluding /usr/bin/ruby dependency
  - Well, I don't oppose to this (i.e. not a blocker), 
however I don't think
adding this line makes so much sense...
We don't explicitly exclude shebang dependency on
other packages even if they don't contain the explicit
dependency which provides such interpreter (such as
bash).

* Removing mini_shoulda dependency
  - Well, actually the following line is added:
--
66  # We must remove mini_shoulda in the installed gemspec, too.
67  sed -e '\|mini_shoulda|d' -i .%{gem_spec}
--
However, instead it is better that you fix the
following line:
--
55  sed -e '\|mini_shoulda|d' -i %{gem_name}.gemspec
--
Note:
- Check the actually generated %{gem_name}.gemspec,
  which does not match 'mini_shoulda' (note that
  one unknown double quotation mark is included in
  the regex)

Otherwise okay.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1016370] Review Request: rubygem-capillary - Generate a JSON payload from Git log output

2013-10-08 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1016370

Mamoru TASAKA mtas...@fedoraproject.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|mtas...@fedoraproject.org
  Flags||fedora-review?



--- Comment #1 from Mamoru TASAKA mtas...@fedoraproject.org ---
Some notes:

* mini_shoulda dependency
  - Installed %gem_spec still contains mini_shoulda
dependency.
Currently it is for development_dependency so
no runtime dependency is added, but anyway I think
this is against your intention.

* Executing tests
  - Actually no tests are executed. Please check
%check section.
---
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.IQdVQm
+ umask 022
+ cd /builddir/build/BUILD
+ cd capillary-1.0.3
+ pushd ./usr/share/gems/gems/capillary-1.0.3
~/build/BUILD/capillary-1.0.3/usr/share/gems/gems/capillary-1.0.3
~/build/BUILD/capillary-1.0.3
+ testrb -Ilib test/capillary/commit_test.rb test/capillary/log_parser_test.rb
test/capillary/ref_collection_test.rb
test/capillary/commit_test.rb: cannot load such file -- test_helper
test/capillary/log_parser_test.rb: cannot load such file -- test_helper
test/capillary/ref_collection_test.rb: cannot load such file -- test_helper
Run options: -Ilib
# Running tests:
Finished tests in 0.002931s, 0. tests/s, 0. assertions/s.
0 tests, 0 assertions, 0 failures, 0 errors, 0 skips

ruby -v: ruby 2.0.0p247 (2013-06-27 revision 41674) [i386-linux]
~/build/BUILD/capillary-1.0.3
+ popd
+ exit 0
---

* Documentation
  - I recommend README to be put in main package, because
the file README is actually the upstream want user to
read it.

  - Please consider if Gemfile{,.lock} Rakefile really
needs to be included in binary rpm.
- Especially Rakefile is like makefiles in autotool-
  generated tarballs, which we usually don't include in
  binary rpm.

  - tests scripts are usually not needed in binary rpm:
   
https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites
See Do not ship tests

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1016370] Review Request: rubygem-capillary - Generate a JSON payload from Git log output

2013-10-08 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1016370



--- Comment #2 from Mamoru TASAKA mtas...@fedoraproject.org ---
By the way I would appreciate it if you would review one of my review requests
(e.g. bug 904640 )

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1016370] Review Request: rubygem-capillary - Generate a JSON payload from Git log output

2013-10-08 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1016370



--- Comment #3 from Ken Dreyer ktdre...@ktdreyer.com ---
Thanks very much for the review. I've incorporated all your recommended changes
in Release 2.

Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-capillary.spec
SRPM URL:
http://ktdreyer.fedorapeople.org/reviews/rubygem-capillary-1.0.3-2.fc21.src.rpm

Specific changes:
http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-capillary.git/commit/?id=08af24babcb120133b90d716320a289b2c930e72

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review