[Bug 1019770] Review Request: lua-term - lua module for manipulating terminal
https://bugzilla.redhat.com/show_bug.cgi?id=1019770 Jiri Machala changed: What|Removed |Added Flags|needinfo?(george.machala+rh | |bugzi...@gmail.com) | --- Comment #8 from Jiri Machala --- I'm sorry for not responding, I lost interest in this long time ago due to circumstances and also lost track of this (I stumbled now upon reminding email). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1019770] Review Request: lua-term - lua module for manipulating terminal
https://bugzilla.redhat.com/show_bug.cgi?id=1019770 Orion Poplawski changed: What|Removed |Added Status|NEW |CLOSED Blocks|177841 (FE-NEEDSPONSOR),| |1089409 | Resolution|--- |DUPLICATE Last Closed||2014-05-01 18:52:26 --- Comment #7 from Orion Poplawski --- *** This bug has been marked as a duplicate of bug 1093503 *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=1089409 [Bug 1089409] Review Request: Lmod - Environmental Modules System in Lua -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1019770] Review Request: lua-term - lua module for manipulating terminal
https://bugzilla.redhat.com/show_bug.cgi?id=1019770 Orion Poplawski changed: What|Removed |Added Blocks||1089409 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1089409 [Bug 1089409] Review Request: Lmod - Environmental Modules System in Lua -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1019770] Review Request: lua-term - lua module for manipulating terminal
https://bugzilla.redhat.com/show_bug.cgi?id=1019770 Orion Poplawski changed: What|Removed |Added CC||george.machala+rhbugzilla@g ||mail.com Flags||needinfo?(george.machala+rh ||bugzi...@gmail.com) --- Comment #6 from Orion Poplawski --- Jiri - Are you still interested in this? I need this ASAP for Lmod, and will submit my own review soon if I don't here back from you. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1019770] Review Request: lua-term - lua module for manipulating terminal
https://bugzilla.redhat.com/show_bug.cgi?id=1019770 --- Comment #5 from Orion Poplawski --- Upstream has now released 0.3 that fixes this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1019770] Review Request: lua-term - lua module for manipulating terminal
https://bugzilla.redhat.com/show_bug.cgi?id=1019770 --- Comment #4 from Orion Poplawski --- Package doesn't work on Fedora 20: # lua Lua 5.2.2 Copyright (C) 1994-2013 Lua.org, PUC-Rio > local term = require 'term' error loading module 'term.cursor' from file '/usr/share/lua/5.2/term/cursor.lua': /usr/share/lua/5.2/term/cursor.lua:24: unexpected symbol near 'goto' stack traceback: [C]: in ? [C]: in function 'require' /usr/share/lua/5.2/term/init.lua:43: in main chunk [C]: in function 'require' stdin:1: in main chunk [C]: in ? I've filed https://github.com/hoelzro/lua-term/issues/7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1019770] Review Request: lua-term - lua module for manipulating terminal
https://bugzilla.redhat.com/show_bug.cgi?id=1019770 Orion Poplawski changed: What|Removed |Added CC||or...@cora.nwra.com --- Comment #3 from Orion Poplawski --- Jiri - Are you still interested in packaging this? I can sponsor you if so, but you should address the above concerns fist. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1019770] Review Request: lua-term - lua module for manipulating terminal
https://bugzilla.redhat.com/show_bug.cgi?id=1019770
--- Comment #2 from Michael Schwendt ---
Right.
[...]
The file at "Spec URL" and the spec file in the src.rpm are not the same. The
diff is:
-%{lualibdir}/term/core.so
+%attr(644, -, -) %{lualibdir}/term/core.so
The %changelog ought to have mentioned that. ;)
So far, we keep shared libs executable, since that's a requirement for the
automatic -debuginfo generation and stripping done by rpmbuild. We must not
turn them -x in %install. Setting them to -x via %attr works _currently_,
because apparently it sets the file attribute at a sufficiently later point.
Though, it's widely accepted practise to restrict usage of %attr to setting
really special/unusual permissions (e.g. setuid, setgid, g-rx) and owner/group
changes, so special attributes set with %attr really stick out (especially when
using syntax highlighting).
There's nothing in the packaging guidelines about it yet. Better not get used
to
using %attr for ordinary permissions that could be set in %install. In packages
with many more files, if you needed to "fix" permissions, overusing %attr would
reduce readability of the spec file a lot.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1019770] Review Request: lua-term - lua module for manipulating terminal
https://bugzilla.redhat.com/show_bug.cgi?id=1019770 Johan Swensson changed: What|Removed |Added CC||k...@kupo.se --- Comment #1 from Johan Swensson --- A few comments. drop %clean You have duplicate file listings. https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#DuplicateFiles -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1019770] Review Request: lua-term - lua module for manipulating terminal
https://bugzilla.redhat.com/show_bug.cgi?id=1019770 Jiri Machala changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
