[Bug 1020468] Review Request: ucpp - Embeddable, quick, light and fully compliant ISO C99 preprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=1020468 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||ucpp-1.3.4-3.fc20 Resolution|--- |ERRATA Last Closed||2014-03-07 01:33:44 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- ucpp-1.3.4-3.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020468] Review Request: ucpp - Embeddable, quick, light and fully compliant ISO C99 preprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=1020468 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|ucpp-1.3.4-3.fc20 |ucpp-1.3.4-3.fc19 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- ucpp-1.3.4-3.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020468] Review Request: ucpp - Embeddable, quick, light and fully compliant ISO C99 preprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=1020468 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- Package ucpp-1.3.4-3.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing ucpp-1.3.4-3.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-3086/ucpp-1.3.4-3.fc20 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020468] Review Request: ucpp - Embeddable, quick, light and fully compliant ISO C99 preprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=1020468 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020468] Review Request: ucpp - Embeddable, quick, light and fully compliant ISO C99 preprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=1020468 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- ucpp-1.3.4-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/ucpp-1.3.4-3.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020468] Review Request: ucpp - Embeddable, quick, light and fully compliant ISO C99 preprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=1020468 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- ucpp-1.3.4-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/ucpp-1.3.4-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020468] Review Request: ucpp - Embeddable, quick, light and fully compliant ISO C99 preprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=1020468 Dominik 'Rathann' Mierzejewski domi...@greysector.net changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from Dominik 'Rathann' Mierzejewski domi...@greysector.net --- New Package SCM Request === Package Name: ucpp Short Description: Embeddable, quick, light and fully compliant ISO C99 preprocessor Owners: rathann Branches: f19 f20 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020468] Review Request: ucpp - Embeddable, quick, light and fully compliant ISO C99 preprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=1020468 --- Comment #11 from Dominik 'Rathann' Mierzejewski domi...@greysector.net --- Thanks for the review, Chris. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020468] Review Request: ucpp - Embeddable, quick, light and fully compliant ISO C99 preprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=1020468 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020468] Review Request: ucpp - Embeddable, quick, light and fully compliant ISO C99 preprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=1020468 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020468] Review Request: ucpp - Embeddable, quick, light and fully compliant ISO C99 preprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=1020468
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #9 from Christopher Meng cicku...@gmail.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v2 or later), Unknown or generated. 19 files have unknown
license. Detailed output of licensecheck:
GPL (v2 or later)
-
ucpp-1.3.4/ltmain.sh
Unknown or generated
ucpp-1.3.4/src/arith.c
ucpp-1.3.4/src/arith.h
ucpp-1.3.4/src/assert.c
ucpp-1.3.4/src/atest.c
ucpp-1.3.4/src/cpp.c
ucpp-1.3.4/src/cpp.h
ucpp-1.3.4/src/eval.c
ucpp-1.3.4/src/hash.c
ucpp-1.3.4/src/hash.h
ucpp-1.3.4/src/lexer.c
ucpp-1.3.4/src/macro.c
ucpp-1.3.4/src/mem.c
ucpp-1.3.4/src/mem.h
ucpp-1.3.4/src/nhash.c
ucpp-1.3.4/src/nhash.h
ucpp-1.3.4/src/sample.c
ucpp-1.3.4/src/tune.h
ucpp-1.3.4/src/ucpp-config.h
ucpp-1.3.4/src/ucppi.h
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 61440 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires
[Bug 1020468] Review Request: ucpp - Embeddable, quick, light and fully compliant ISO C99 preprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=1020468 --- Comment #8 from Dominik 'Rathann' Mierzejewski domi...@greysector.net --- Added ?_isa to dependencies. What's wrong with the descriptions? Can you suggest improvements? Spec URL: http://rathann.fedorapeople.org/review/ucpp/ucpp.spec SRPM URL: http://rathann.fedorapeople.org/review/ucpp/ucpp-1.3.4-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020468] Review Request: ucpp - Embeddable, quick, light and fully compliant ISO C99 preprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=1020468
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|cicku...@gmail.com
Flags||fedora-review?
--- Comment #6 from Christopher Meng cicku...@gmail.com ---
1. Please modify with ?_isa appended:
Requires: %{name}-libs{?_isa} = %{version}-%{release}
2. Please improve devel and libs' %package and %description, both not good IMO.
An example:
%packagedevel
Summary:Development files for %{name}
Requires: %{name}-libs%{?_isa} = %{version}-%{release}
%descriptiondevel
This package contains libraries and header files for
developing applications that use %{name}.
---
%packagelibs
Summary:Shared libraries for %{name}
Requires: %{name}-libs%{?_isa} = %{version}-%{release}
%descriptiondevel
This package contains shared libraries for %{name}.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020468] Review Request: ucpp - Embeddable, quick, light and fully compliant ISO C99 preprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=1020468
--- Comment #7 from Christopher Meng cicku...@gmail.com ---
Oops, ignore the copy-paste wrong
Requires: %{name}-libs%{?_isa} = %{version}-%{release}
in the -libs. ;)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020468] Review Request: ucpp - Embeddable, quick, light and fully compliant ISO C99 preprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=1020468 --- Comment #5 from Dominik 'Rathann' Mierzejewski domi...@greysector.net --- Fixed all issues: Spec URL: http://rathann.fedorapeople.org/review/ucpp/ucpp.spec SRPM URL: http://rathann.fedorapeople.org/review/ucpp/ucpp-1.3.4-2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020468] Review Request: ucpp - Embeddable, quick, light and fully compliant ISO C99 preprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=1020468 Ralf Corsepius rc040...@freenet.de changed: What|Removed |Added CC||rc040...@freenet.de --- Comment #4 from Ralf Corsepius rc040...@freenet.de --- Make is silent - It's impossible to check whether this package is compiled correctly from build.logs = Please append --disable-silent-rules to %configure rpmlint complains: ... ucpp-libs.x86_64: W: file-not-utf8 /usr/share/doc/ucpp-libs/README ucpp-libs.x86_64: E: library-without-ldconfig-postin /usr/lib64/libucpp.so.13.0.4 ucpp-libs.x86_64: E: library-without-ldconfig-postun /usr/lib64/libucpp.so.13.0.4 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020468] Review Request: ucpp - Embeddable, quick, light and fully compliant ISO C99 preprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=1020468 --- Comment #3 from Dominik 'Rathann' Mierzejewski domi...@greysector.net --- Updated package: Spec URL: http://rathann.fedorapeople.org/review/ucpp/ucpp.spec SRPM URL: http://rathann.fedorapeople.org/review/ucpp/ucpp-1.3.4-1.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020468] Review Request: ucpp - Embeddable, quick, light and fully compliant ISO C99 preprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=1020468 --- Comment #2 from Dominik 'Rathann' Mierzejewski domi...@greysector.net --- Looks like a fork based on upstream 1.3.2 version. However, there have been no new releases from original upstream, so we might just as well consider the fork as the new upstream: https://github.com/scarabeusiv/ucpp I'll prepare an updated package based on that, once I verify that the application for which ucpp is a dependency still builds and works. Thanks for pointing it out. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020468] Review Request: ucpp - Embeddable, quick, light and fully compliant ISO C99 preprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=1020468 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||cicku...@gmail.com --- Comment #1 from Christopher Meng cicku...@gmail.com --- gentoo ebuild shows that 1.3.4 is the latest version: http://dev.gentooexperimental.org/~scarabeus/ucpp-1.3.4.tar.xz Can you verify it? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
