[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export
https://bugzilla.redhat.com/show_bug.cgi?id=1021261 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|kipi-plugins-elegant-theme- |kipi-plugins-elegant-theme- |1.4.0-2.fc20|1.4.0-2.fc19 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- kipi-plugins-elegant-theme-1.4.0-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export
https://bugzilla.redhat.com/show_bug.cgi?id=1021261 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||kipi-plugins-elegant-theme- ||1.4.0-2.fc20 Resolution|--- |ERRATA Last Closed||2013-11-10 02:04:22 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- kipi-plugins-elegant-theme-1.4.0-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export
https://bugzilla.redhat.com/show_bug.cgi?id=1021261 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export
https://bugzilla.redhat.com/show_bug.cgi?id=1021261 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export
https://bugzilla.redhat.com/show_bug.cgi?id=1021261 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- kipi-plugins-elegant-theme-1.4.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/kipi-plugins-elegant-theme-1.4.0-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export
https://bugzilla.redhat.com/show_bug.cgi?id=1021261 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export
https://bugzilla.redhat.com/show_bug.cgi?id=1021261 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- kipi-plugins-elegant-theme-1.4.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/kipi-plugins-elegant-theme-1.4.0-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export
https://bugzilla.redhat.com/show_bug.cgi?id=1021261 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- kipi-plugins-elegant-theme-1.4.0-2.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export
https://bugzilla.redhat.com/show_bug.cgi?id=1021261
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||mario.blaetterm...@gmail.co
||m
Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
||m
Flags||fedora-review+
--- Comment #9 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6122293
$ rpmlint -i -v *kipi-plugins-elegant-theme.noarch: I: checking
kipi-plugins-elegant-theme.noarch: I: checking-url
http://kde-look.org/content/show.php/Elegant+theme+for+DigiKam%2BKipi+HTML+Expo?content=61904
(timeout 10 seconds)
kipi-plugins-elegant-theme.noarch: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
kipi-plugins-elegant-theme.src: I: checking
kipi-plugins-elegant-theme.src: I: checking-url
http://kde-look.org/content/show.php/Elegant+theme+for+DigiKam%2BKipi+HTML+Expo?content=61904
(timeout 10 seconds)
kipi-plugins-elegant-theme.src: I: checking-url
http://graphics.ucsd.edu/~wjarosz/kde-look/elegant-1.4.0.tar.gz (timeout 10
seconds)
kipi-plugins-elegant-theme.spec: I: checking-url
http://graphics.ucsd.edu/~wjarosz/kde-look/elegant-1.4.0.tar.gz (timeout 10
seconds)
2 packages and 1 specfiles checked; 0 errors, 1 warnings.
The warning is ignorabele, because the tarball doesn't contain any docs.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
CC-BY
[.] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
e20bcf359c0a2d337920410229a1a96e521d77260834c511bfe04e1f3e80810e
elegant-1.4.0.tar.gz
e20bcf359c0a2d337920410229a1a96e521d77260834c511bfe04e1f3e80810e
elegant-1.4.0.tar.gz.packaged
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files
[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export
https://bugzilla.redhat.com/show_bug.cgi?id=1021261 --- Comment #10 from Sebastian Dyroff fed...@dyroff.org --- Thanks for the review Mario! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export
https://bugzilla.redhat.com/show_bug.cgi?id=1021261 Sebastian Dyroff fed...@dyroff.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from Sebastian Dyroff fed...@dyroff.org --- New Package SCM Request === Package Name: kipi-plugins-elegant-theme Short Description: Theme for Kipi HTML export Owners: sdyroff Branches: f19 f20 InitialCC: sdyroff -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export
https://bugzilla.redhat.com/show_bug.cgi?id=1021261 Johan Swensson k...@kupo.se changed: What|Removed |Added CC||k...@kupo.se --- Comment #2 from Johan Swensson k...@kupo.se --- kipi-plugins-elegant-theme.noarch: W: spelling-error %description -l en_US slideshow - sideshow, slide show, slide-show kipi-plugins-elegant-theme.noarch: W: incoherent-version-in-changelog 1.4.1-1 ['1.4.0-1.fc19', '1.4.0-1'] kipi-plugins-elegant-theme.noarch: W: no-documentation kipi-plugins-elegant-theme.src: W: spelling-error %description -l en_US slideshow - sideshow, slide show, slide-show kipi-plugins-elegant-theme.src: E: specfile-error warning: bogus date in %changelog: Tue Oct 20 2013 Sebastian Dyroff sdyr...@fedoraproject.org 1.4.1-1 You are not using desktop-file-install or desktop-file-validate when you're installing the .desktop file. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export
https://bugzilla.redhat.com/show_bug.cgi?id=1021261 --- Comment #3 from Rex Dieter rdie...@math.unl.edu --- Per https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Desktop_files If a package contains a GUI application..., this isn't a GUI application, so that section is not relevant. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export
https://bugzilla.redhat.com/show_bug.cgi?id=1021261 --- Comment #4 from Johan Swensson k...@kupo.se --- (In reply to Rex Dieter from comment #3) Per https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ Guidelines#Desktop_files If a package contains a GUI application..., this isn't a GUI application, so that section is not relevant. Ah, yes of course. My bad. :) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export
https://bugzilla.redhat.com/show_bug.cgi?id=1021261 --- Comment #5 from Sebastian Dyroff fed...@dyroff.org --- Wow, thanks for the fast review. Updated the spec file: http://git.dyroff.org/?p=sdyroff-rpms.git;a=blob_plain;f=SPECS/kipi-plugins-elegant-theme.spec;hb=3a18a07641bf673c4863436c2c76e2fea07dfcd7 - fixed the bogus changelog entry - fixed the spelling error -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export
https://bugzilla.redhat.com/show_bug.cgi?id=1021261 --- Comment #6 from Sebastian Dyroff fed...@dyroff.org --- The spelling seems not so clear, wikipedia says When referring to the video or computer-based visual equivalent, in which the slides are not individual physical objects, the term is often written as one word, slideshow. I am not a native speaker so I cannot really judge on this one. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export
https://bugzilla.redhat.com/show_bug.cgi?id=1021261 --- Comment #7 from Johan Swensson k...@kupo.se --- There are still a inconsistency between the changelog and version tag. Version:1.4.0 %changelog * Mon Oct 21 2013 Sebastian Dyroff sdyr...@fedoraproject.org - 1.4.1-2 - Fixed spelling error in description (bz 1021261) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export
https://bugzilla.redhat.com/show_bug.cgi?id=1021261 --- Comment #8 from Sebastian Dyroff fed...@dyroff.org --- Sorry, missed that completely, new spec (without version bump): http://git.dyroff.org/?p=sdyroff-rpms.git;a=blob_plain;f=SPECS/kipi-plugins-elegant-theme.spec;hb=c59f866d018314d478a602bd322a4d0847d52158 SRPM: http://kojipkgs.fedoraproject.org//work/tasks/5174/6085174/kipi-plugins-elegant-theme-1.4.0-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export
https://bugzilla.redhat.com/show_bug.cgi?id=1021261 --- Comment #1 from Sebastian Dyroff fed...@dyroff.org --- koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6081769 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export
https://bugzilla.redhat.com/show_bug.cgi?id=1021261 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC||rdie...@math.unl.edu Blocks||656997 (kde-reviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
