[Bug 1022827] Review Request: rubygem-http-cookie - Ruby library to handle HTTP Cookies based on RFC 6265
https://bugzilla.redhat.com/show_bug.cgi?id=1022827 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2013-11-12 03:35:59 --- Comment #8 from Mamoru TASAKA mtas...@fedoraproject.org --- Rebuilt on all branches, push requested on F-20 and F-19, closing. Thank you for review and git procedure. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1022827] Review Request: rubygem-http-cookie - Ruby library to handle HTTP Cookies based on RFC 6265
https://bugzilla.redhat.com/show_bug.cgi?id=1022827 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1022827] Review Request: rubygem-http-cookie - Ruby library to handle HTTP Cookies based on RFC 6265
https://bugzilla.redhat.com/show_bug.cgi?id=1022827 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1022827] Review Request: rubygem-http-cookie - Ruby library to handle HTTP Cookies based on RFC 6265
https://bugzilla.redhat.com/show_bug.cgi?id=1022827 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Mamoru TASAKA mtas...@fedoraproject.org --- Thank you! I will incorpolate your suggestion when importing into Fedora git. New Package SCM Request === Package Name: rubygem-http-cookie Short Description: Ruby library to handle HTTP Cookies based on RFC 6265 Owners: mtasaka Branches: f20 f19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1022827] Review Request: rubygem-http-cookie - Ruby library to handle HTTP Cookies based on RFC 6265
https://bugzilla.redhat.com/show_bug.cgi?id=1022827 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Flags|fedora-review? | |needinfo?(bjoern.esser@gmai | |l.com) | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1022827] Review Request: rubygem-http-cookie - Ruby library to handle HTTP Cookies based on RFC 6265
https://bugzilla.redhat.com/show_bug.cgi?id=1022827 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|bjoern.es...@gmail.com |nob...@fedoraproject.org --- Comment #3 from Mamoru TASAKA mtas...@fedoraproject.org --- Another one week has passed. Björn, sorry, however as I want to try importing this package before F-20 lands (due to other dependency), once revoking assignment. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1022827] Review Request: rubygem-http-cookie - Ruby library to handle HTTP Cookies based on RFC 6265
https://bugzilla.redhat.com/show_bug.cgi?id=1022827 --- Comment #4 from Mamoru TASAKA mtas...@fedoraproject.org --- Thank you for trying to take this package anyway. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1022827] Review Request: rubygem-http-cookie - Ruby library to handle HTTP Cookies based on RFC 6265
https://bugzilla.redhat.com/show_bug.cgi?id=1022827
Ken Dreyer ktdre...@ktdreyer.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||ktdre...@ktdreyer.com
Assignee|nob...@fedoraproject.org|ktdre...@ktdreyer.com
Flags||fedora-review+
--- Comment #5 from Ken Dreyer ktdre...@ktdreyer.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Please remove the whitespace after Requires:ruby(rubygems) .
- The test/test_http_cookie_jar.rb test optionally loads sqlite3, and it's
currently printing a warning sqlite3 missing? because this gem is missing
during the test run. You may want to BR: rubygem(sqlite3) in order to expand
the test coverage during %check.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Ruby:
[x]: Platform dependent files must all go under %{gem_extdir_mri}, platform
independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage.
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).
[x]: Package contains Requires: ruby(release).
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec
[Bug 1022827] Review Request: rubygem-http-cookie - Ruby library to handle HTTP Cookies based on RFC 6265
https://bugzilla.redhat.com/show_bug.cgi?id=1022827 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Flags||needinfo?(bjoern.esser@gmai ||l.com) --- Comment #2 from Mamoru TASAKA mtas...@fedoraproject.org --- ping? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1022827] Review Request: rubygem-http-cookie - Ruby library to handle HTTP Cookies based on RFC 6265
https://bugzilla.redhat.com/show_bug.cgi?id=1022827 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||bjoern.es...@gmail.com Assignee|nob...@fedoraproject.org|bjoern.es...@gmail.com Flags||fedora-review? --- Comment #1 from Björn besser82 Esser bjoern.es...@gmail.com --- taken ;) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
