[Bug 1023474] Review Request: efivar - utility and library for manipulating efi variables
https://bugzilla.redhat.com/show_bug.cgi?id=1023474 Adam Jackson changed: What|Removed |Added Assignee|nob...@fedoraproject.org|a...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1023474] Review Request: efivar - utility and library for manipulating efi variables
https://bugzilla.redhat.com/show_bug.cgi?id=1023474 --- Comment #1 from Adam Jackson --- Missing BuildRequires: git Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.mem0T9 + umask 022 + cd /builddir/build/BUILD + cd /builddir/build/BUILD + rm -rf efivar-0.7 + /usr/bin/gzip -dc /builddir/build/SOURCES/0.7.tar.gz + /usr/bin/tar -xf - + STATUS=0 + '[' 0 -ne 0 ']' + cd efivar-0.7 + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w . + git init /var/tmp/rpm-tmp.mem0T9: line 39: git: command not found error: Bad exit status from /var/tmp/rpm-tmp.mem0T9 (%prep) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.mem0T9 (%prep) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1023474] Review Request: efivar - utility and library for manipulating efi variables
https://bugzilla.redhat.com/show_bug.cgi?id=1023474
--- Comment #2 from Adam Jackson ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
%doc COPYING
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"LGPL", "Unknown or generated". 4 files have unknown license. Detailed
output of licensecheck in
/home/ajax/efivar/efivar-0.7-1.fc20.src/efivar/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.
[!]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in efivar-libs
, efivar-devel
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
translations for supported
[Bug 1023474] Review Request: efivar - utility and library for manipulating efi variables
https://bugzilla.redhat.com/show_bug.cgi?id=1023474 --- Comment #3 from Peter Jones --- Okay, I've fixed those things. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1023474] Review Request: efivar - utility and library for manipulating efi variables
https://bugzilla.redhat.com/show_bug.cgi?id=1023474 Adam Jackson changed: What|Removed |Added Flags||fedora-review+ --- Comment #4 from Adam Jackson --- Well your spec file still doesn't say BuildRequires: git, but you'll need to fix that quite soon anyway. r+ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1023474] Review Request: efivar - utility and library for manipulating efi variables
https://bugzilla.redhat.com/show_bug.cgi?id=1023474 --- Comment #5 from Peter Jones --- Sorry, didn't scp the new .spec . Done now. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1023474] Review Request: efivar - utility and library for manipulating efi variables
https://bugzilla.redhat.com/show_bug.cgi?id=1023474 --- Comment #6 from Peter Jones --- New Package SCM Request === Package Name: efivar Short Description: efivar provides a utility and library to manipulate efi variables Owners: pjones Branches: f20 f21 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1023474] Review Request: efivar - utility and library for manipulating efi variables
https://bugzilla.redhat.com/show_bug.cgi?id=1023474 Peter Jones changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1023474] Review Request: efivar - utility and library for manipulating efi variables
https://bugzilla.redhat.com/show_bug.cgi?id=1023474 --- Comment #7 from Jon Ciesla --- Git done (by process-git-requests). f21 not yet branched, devel is automatic. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1023474] Review Request: efivar - utility and library for manipulating efi variables
https://bugzilla.redhat.com/show_bug.cgi?id=1023474 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1023474] Review Request: efivar - utility and library for manipulating efi variables
https://bugzilla.redhat.com/show_bug.cgi?id=1023474 Ralf Corsepius changed: What|Removed |Added CC||rc040...@freenet.de --- Comment #8 from Ralf Corsepius --- According to the bugzilla time stamps: Submission: 2013-10-25 09:47:19 EDT Git done: 2013-10-25 10:48:51 EDT => 61 minutes from submission to "git done" Mails delivered at my place Submission Fri, 25 Oct 2013 16:27:01 Git done: Fri, 25 Oct 2013 16:49:07 => 22 minutes from submission to review. Sorry, folks but ... this is Redhat Review Ping Pong. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1023474] Review Request: efivar - utility and library for manipulating efi variables
https://bugzilla.redhat.com/show_bug.cgi?id=1023474 Christopher Meng changed: What|Removed |Added Status|NEW |ASSIGNED CC||cicku...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1023474] Review Request: efivar - utility and library for manipulating efi variables
https://bugzilla.redhat.com/show_bug.cgi?id=1023474 --- Comment #9 from Christopher Meng --- A month passed, I still can't see any changes in SCM. PING. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1023474] Review Request: efivar - utility and library for manipulating efi variables
https://bugzilla.redhat.com/show_bug.cgi?id=1023474 Christopher Meng changed: What|Removed |Added CC||pjo...@redhat.com Flags||needinfo?(pjo...@redhat.com ||) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1023474] Review Request: efivar - utility and library for manipulating efi variables
https://bugzilla.redhat.com/show_bug.cgi?id=1023474 Frank Ansari changed: What|Removed |Added CC||m...@frank-ansari.de --- Comment #10 from Frank Ansari --- I have downloaded the 0.7 sources and make a test on my Feodra 20 system. The tool gives this error: efivar: poprReadDefaultConfig failed: No such file or directory (I guess it should be "poptReadDefaultConfig"?) I found it starts working as soon as I create an empty file in /etc/popt.d: touch /etc/popt.d/popt When I now run "efivar -l" I get the paramter list but printing any parameter fails. Example: [root@bat ~]# efivar -p -n 8be4df61-93ca-11d2-aa0d-00e098032b8c-Boot efivar: invalid name "8be4df61-93ca-11d2-aa0d-00e098032b8c-Boot" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1023474] Review Request: efivar - utility and library for manipulating efi variables
https://bugzilla.redhat.com/show_bug.cgi?id=1023474 Adam Jackson changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2015-07-27 12:50:35 --- Comment #13 from Adam Jackson --- dmt:~% koji -q latest-pkg f19-updates efivar efivar-0.13-1.fc19f19-updates pjones -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1023474] Review Request: efivar - utility and library for manipulating efi variables
https://bugzilla.redhat.com/show_bug.cgi?id=1023474 Peter Jones changed: What|Removed |Added Flags|needinfo?(pjo...@redhat.com |fedora-cvs? |) fedora-cvs+ | --- Comment #11 from Peter Jones --- Package Change Request == Package Name: efivar New Branches: f19 Owners: pjones This is needed to backport newer versions of efibootmgr for bugfixes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1023474] Review Request: efivar - utility and library for manipulating efi variables
https://bugzilla.redhat.com/show_bug.cgi?id=1023474 Kevin Fenzi changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1023474] Review Request: efivar - utility and library for manipulating efi variables
https://bugzilla.redhat.com/show_bug.cgi?id=1023474 --- Comment #12 from Kevin Fenzi --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
