[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-openstackclient-0.3. ||0-1.fc20 Resolution|--- |ERRATA Last Closed||2014-03-21 05:38:35 --- Comment #27 from Fedora Update System upda...@fedoraproject.org --- python-openstackclient-0.3.0-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 --- Comment #26 from Fedora Update System upda...@fedoraproject.org --- python-openstackclient-0.3.0-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-openstackclient-0.3.0-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #25 from Fedora Update System upda...@fedoraproject.org --- python-openstackclient-0.2.2-2.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 --- Comment #24 from Fedora Update System upda...@fedoraproject.org --- python-openstackclient-0.2.2-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-openstackclient-0.2.2-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 Kashyap Chamarthy kcham...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #21 from Kashyap Chamarthy kcham...@redhat.com --- New changes look good to me, approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 Jakub Ruzicka jruzi...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #22 from Jakub Ruzicka jruzi...@redhat.com --- New Package SCM Request === Package Name: python-openstackclient Short Description: OpenStack Command-line Client Owners: jruzicka Branches: f20 el6 InitialCC: pbrady apevec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 --- Comment #23 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 --- Comment #20 from Jakub Ruzicka jruzi...@redhat.com --- Thanks for the review, I fixed the flaws you found. Spec URL: http://jruzicka.fedorapeople.org/pkgs/python-openstackclient/python-openstackclient.spec SRPM URL: http://jruzicka.fedorapeople.org/pkgs/python-openstackclient/python-openstackclient-0.2.2-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885
Kashyap Chamarthy kcham...@redhat.com changed:
What|Removed |Added
Flags|needinfo? |
--- Comment #19 from Kashyap Chamarthy kcham...@redhat.com ---
TL;DR:
(NOTE: with 1 2 below addressed, package approved.)
1. In -doc package Requires: %{name} = %{version}-%{release} is missing.
This would allow the -docs package without having the license file installed,
which violates License file installed when any subpackage combination is
installed.
2. In %install section,
%{__python} setup.py install -O1 --skip-build --root %{buildroot}
should be
%{__python2} setup.py install -O1 --skip-build --root %{buildroot}
Reference: http://fedoraproject.org/wiki/Packaging:Python#Macros -- The
unversioned macro, %{__python} is deprecated. You should use %{__python2} to
explicitly reference the python2 interpreter instead. This is future proofing
for the time when things will be switched over to python3 by default instead of
python2.
3. For the question in Comment #17, licensecheck tool provides some false
positives. Licenses in this case are just fine.
4. About %check, we agreed to proceed w/o having it for now, as
test-requirements not being in Fedora. Conv. from IRC:
===
Nov 14 12:11:54 jruzicka I think I spent reasonable amount of time getting
it work and it doesnt. I think it's simply a matter of it
(python-openstackclient) using bleeding edge packages that are not available in
Fedora. Once they are, it's likely to already using newer version.
Nov 14 12:12:08 jruzicka mrunge, so I see that as additional burden in
future - package not building because of a new unavailable test req.
Nov 14 12:12:18 jruzicka even though it's working just fine
Nov 14 12:12:23 mrungejruzicka, ok, agreed on that
===
Thanks mrunge for clarifications, please note here if I missed anything else.
Manual review:
~~
= MUST items =
Generic:
[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
- ASL 2.0
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Apache (v2.0), Unknown or generated, *No copyright* Apache (v2.0).
4 files have unknown license. Detailed output of licensecheck in
/home/kashyap/rpmbuild/SRPMS/1024885-python-
openstackclient/licensecheck.txt
- licensecheck just generates some false positives, linceses in this case
are okay.
[!]: License file installed when any subpackage combination is installed.
- Requires: %{name} = %{version}-%{release} is needed for -doc
package.
===
$ file
./rpms-unpacked/python-openstackclient-0.2.2-1.fc20.noarch.rpm/usr/share/doc/python-openstackclient-0.2.2/LICENSE
./rpms-unpacked/python-openstackclient-0.2.2-1.fc20.noarch.rpm/usr/share/doc/python-openstackclient-0.2.2/LICENSE:
ASCII text
===
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x ]: A package which is used by another package via an egg interface should
provide egg info.
egg-info for the package:
===
$ tree
./rpms-unpacked/python-openstackclient-0.2.2-1.fc20.noarch.rpm/usr/lib/python2.7/site-packages/python_openstackclient-0.2.2-py2.7.egg-info/
./rpms-unpacked/python-openstackclient-0.2.2-1.fc20.noarch.rpm/usr/lib/python2.7/site-packages/python_openstackclient-0.2.2-py2.7.egg-info/
├── dependency_links.txt
├── entry_points.txt
├── not-zip-safe
├── PKG-INFO
├── SOURCES.txt
└── top_level.txt
===
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 Kashyap Chamarthy kcham...@redhat.com changed: What|Removed |Added Flags||needinfo?(kchamart@redhat.c ||om) --- Comment #16 from Kashyap Chamarthy kcham...@redhat.com --- Manual review in progress, meanwhile a quick comment: For the below MUST item, looking inside setup.py file License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: Apache (v2.0), Unknown or generated, *No copyright* Apache (v2.0). 4 files have unknown license. Detailed output of licensecheck in /home/kashyap/rpmbuild/SRPMS/1024885-python- openstackclient/licensecheck.txt Unknown or generated /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/python-openstackclient-0.2.2/doc/source/conf.py - [ This is generated by sphinx-quickstart] /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/python-openstackclient-0.2.2/run_tests.sh /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/python-openstackclient-0.2.2/setup.py /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/python-openstackclient-0.2.2/tools/with_venv.sh But. . . looking inside setup.py file, it /does/ have ASL 2.0 lincense: === $ head -10 /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/python-openstackclient-0.2.2/setup.py #!/usr/bin/env python # Copyright (c) 2013 Hewlett-Packard Development Company, L.P. # # Licensed under the Apache License, Version 2.0 (the License); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # #http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software === Why would the review tool flag this as /not/ having an unknown license? Is this a legal question? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 Kashyap Chamarthy kcham...@redhat.com changed: What|Removed |Added Flags|needinfo?(kchamart@redhat.c |needinfo? |om) | --- Comment #17 from Kashyap Chamarthy kcham...@redhat.com --- Duh, incorrectly assigned the needinfo on self. Meant to be for anyone. Also, in the previous line, read: /not/ having an unknown license? = having an unknown license -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 --- Comment #18 from Jakub Ruzicka jruzi...@redhat.com --- Not sure why the tool doesn't recognize it, but it looks like ASL 2.0 to me. I think it's OK. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 Jakub Ruzicka jruzi...@redhat.com changed: What|Removed |Added Flags||needinfo?(mru...@redhat.com ||) --- Comment #14 from Jakub Ruzicka jruzi...@redhat.com --- Bump. I wasn't able to get %check working, so can we have openstackclient without it? something nothing -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 Jakub Ruzicka jruzi...@redhat.com changed: What|Removed |Added Flags|needinfo?(mru...@redhat.com | |) | --- Comment #15 from Jakub Ruzicka jruzi...@redhat.com --- Spec URL: http://jruzicka.fedorapeople.org/pkgs/python-openstackclient/python-openstackclient.spec SRPM URL: http://jruzicka.fedorapeople.org/pkgs/python-openstackclient/python-openstackclient-0.2.2-1.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885
--- Comment #13 from Jakub Ruzicka jruzi...@redhat.com ---
It doesn't work without pbr out of the box.
pbr stands for Python Build Reasonableness. Aside from not being resonable, it
includes the versioning functionality which is used runtime. I believe this was
to be moved to oslo.version but it haven't yet so I patch all the clients to
provide version from .spec file to prevent runtime dep on pbr.
The dependency handling functionality is also unwanted because deps are (and
should be) handled by package manager. That's why I remove
{test,}requirements.txt and setup_requires=['pbr'] from setup.py as well.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 --- Comment #11 from Jakub Ruzicka jruzi...@redhat.com --- Indeed, I didn't update the patches here, but I removed 0002 as well to get the above behavior. However, no degree of pbr nuking (including none) led me to working %check. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 --- Comment #12 from Matthias Runge mru...@redhat.com --- Does the client work without pbr installed at runtime? I thought, pbr is just for building the release, right? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 Kashyap Chamarthy kcham...@redhat.com changed: What|Removed |Added QA Contact|kcham...@redhat.com |extras...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 --- Comment #8 from Matthias Runge mru...@redhat.com --- Actually, it is available: http://koji.fedoraproject.org/koji/packageinfo?packageID=14887 (for fedora 21 aka rawhide). Stable policy forbids to upgrade the version for f20 and older. Since it's required the package builds on rawhide, you can add the check and skip it for later versions ;-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 --- Comment #9 from Jakub Ruzicka jruzi...@redhat.com --- Created attachment 819183 -- https://bugzilla.redhat.com/attachment.cgi?id=819183action=edit WIP %check With rawhide tox 1.6.1 I get only a little further: + ./run_tests.sh py27 create: /builddir/build/BUILD/python-openstackclient-0.2.2/.tox/py27 py27 installdeps: -r/builddir/build/BUILD/python-openstackclient-0.2.2/requirements.txt, -r/builddir/build/BUILD/python-openstackclient-0.2.2/test-requirements.txt py27 develop-inst: /builddir/build/BUILD/python-openstackclient-0.2.2 py27 runtests: commands[0] | python setup.py testr --testr-args= /usr/lib64/python2.7/distutils/dist.py:267: UserWarning: Unknown distribution option: 'pbr' warnings.warn(msg) usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...] or: setup.py --help [cmd1 cmd2 ...] or: setup.py --help-commands or: setup.py cmd --help error: invalid command 'testr' ERROR: InvocationError: '/builddir/build/BUILD/python-openstackclient-0.2.2/.tox/py27/bin/python setup.py testr --testr-args=' ___ summary ERROR: py27: commands failed chyba: Špatný návratový kód z /var/tmp/rpm-tm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 --- Comment #10 from Matthias Runge mru...@redhat.com --- I think, your patch 0002 is somehow not doing, what's intended. Just skipping that, brings me (somehow) further. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 --- Comment #7 from Jakub Ruzicka jruzi...@redhat.com --- I tried to add %check but I didn't get past tox version conflict. 1.4.1 is available in Fedora but 1.6 is required. Also, some requires from test-requirements.txt aren't available but the seem to not be used anywhere. I can add %check when required tox version is available. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 Kashyap Chamarthy kcham...@redhat.com changed: What|Removed |Added CC||kcham...@redhat.com --- Comment #1 from Kashyap Chamarthy kcham...@redhat.com --- [Manual review upcoming, fedora-review tool status here] Review tool: $ fedora-review -m fedora-rawhide-x86_64 \ --rpm-spec -n python-openstackclient-0.2.2-1.fc19.src.rpm INFO: Processing local files: python-openstackclient-0.2.2-1.fc19.src.rpm INFO: Getting .spec and .srpm Urls from : Local files in /home/kashyap/rpmbuild/SRPMS INFO: -- SRPM url: file:///home/kashyap/rpmbuild/SRPMS/python-openstackclient-0.2.2-1.fc19.src.rpm INFO: Using review directory: /home/kashyap/rpmbuild/SRPMS/python-openstackclient INFO: Downloading (Source0): http://pypi.python.org/packages/source/p/python-openstackclient/python-openstackclient-0.2.2.tar.gz INFO: Running checks and generating report ERROR: Exception(/home/kashyap/rpmbuild/SRPMS/python-openstackclient-0.2.2-1.fc19.src.rpm) Config(fedora-rawhide-x86_64) 0 minutes 11 seconds INFO: Results and/or logs in: /home/kashyap/rpmbuild/SRPMS/python-openstackclient/results ERROR: Command failed. See logs for output. ERROR: 'mock build failed, see /home/kashyap/rpmbuild/SRPMS/python-openstackclient/results/build.log' And, this is what build.log says: - $ less /home/kashyap/rpmbuild/SRPMS/python-openstackclient/results/build.log [...] running install_scripts + rm -fr /builddir/build/BUILDROOT/python-openstackclient-0.2.2-1.fc20.x86_64/usr/lib/python2.7/site-packages/openstackclient/tests ++ pwd + export PYTHONPATH=/builddir/build/BUILD/python-openstackclient-0.2.2: + PYTHONPATH=/builddir/build/BUILD/python-openstackclient-0.2.2: + sphinx-build -b html doc/source html Making output directory... Running Sphinx v1.1.3 Exception occurred: File /usr/lib/python2.7/site-packages/pbr/packaging.py, line 524, in get_version raise Exception(Versioning for this project requires either an sdist Exception: Versioning for this project requires either an sdist tarball, or access to an upstream git repository. The full traceback has been saved in /tmp/sphinx-err-Em5lEB.log, if you want to report the issue to the developers. Please also report this if it was a user error, so that a better error message can be provided next time. Either send bugs to the mailing list at http://groups.google.com/group/sphinx-dev/, or report them in the tracker at http://bitbucket.org/birkenfeld/sphinx/issues/. Thanks! error: Bad exit status from /var/tmp/rpm-tmp.6WTgXu (%install) Bad exit status from /var/tmp/rpm-tmp.6WTgXu (%install) RPM build errors: Child return code was: 1 EXCEPTION: Command failed. See logs for output. # ['bash', '--login', '-c', 'rpmbuild -bb --target x86_64 --nodeps builddir/build/SPECS/python-openstackclient.spec'] Traceback (most recent call last): File /usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py, line 70, in trace result = func(*args, **kw) File /usr/lib/python2.7/site-packages/mockbuild/util.py, line 361, in do raise mockbuild.exception.Error, (Command failed. See logs for output.\n # %s % (command,), child.returncode) Error: Command failed. See logs for output. # ['bash', '--login', '-c', 'rpmbuild -bb --target x86_64 --nodeps builddir/build/SPECS/python-openstackclient.spec'] LEAVE do -- EXCEPTION RAISED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 --- Comment #2 from Kashyap Chamarthy kcham...@redhat.com --- Successful koji scratch build result: - $ koji build --scratch rawhide python-openstackclient-0.2.2-1.fc19.src.rpm Uploading srpm: python-openstackclient-0.2.2-1.fc19.src.rpm [] 100% 00:00:06 138.70 KiB 20.33 KiB/sec Created task: 6118963 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=6118963 Watching tasks (this may be safely interrupted)... 6118963 build (rawhide, python-openstackclient-0.2.2-1.fc19.src.rpm): open (buildvm-13.phx2.fedoraproject.org) 6118966 buildArch (python-openstackclient-0.2.2-1.fc19.src.rpm, noarch): open (arm02-builder08.arm.fedoraproject.org) 6118966 buildArch (python-openstackclient-0.2.2-1.fc19.src.rpm, noarch): open (arm02-builder08.arm.fedoraproject.org) - closed 0 free 1 open 1 done 0 failed 6118963 build (rawhide, python-openstackclient-0.2.2-1.fc19.src.rpm): open (buildvm-13.phx2.fedoraproject.org) - closed 0 free 0 open 2 done 0 failed 6118963 build (rawhide, python-openstackclient-0.2.2-1.fc19.src.rpm) completed successfully -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 Jakub Ruzicka jruzi...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #3 from Jakub Ruzicka jruzi...@redhat.com --- I have no problem with fedora-review -m fedora-rawhide-x86_64 -b 1024885 And I can also manually build using mock with fedora-19, fedora-20 and fedora-rawhide roots. Any ideas what might be wrong? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885
--- Comment #4 from Kashyap Chamarthy kcham...@redhat.com ---
Right, I can only reproduce the above problem on my laptop. I re-ran the
fedora-review tool on a different machine (F20), it goes through fine:
For now, posting the automated review below. Will do the manual review on the
v2 you're about to post with %check (and any other updates you may have).
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Apache (v2.0), Unknown or generated, *No copyright* Apache (v2.0).
4 files have unknown license. Detailed output of licensecheck in
/home/kashyap/rpmbuild/SRPMS/1024885-python-
openstackclient/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[ ]: Python eggs must not download any dependencies during the build process.
[ ]: A package which is used by another package via an egg interface should
provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[ ]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python-
openstackclient-doc
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[ ]: Description and summary sections in the package spec file contains
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 Matthias Runge mru...@redhat.com changed: What|Removed |Added CC||mru...@redhat.com --- Comment #5 from Matthias Runge mru...@redhat.com --- Kashyap, you're supposed to complete the form on your own for all the empty spaces [ ]. But I agree, you should defer that, until Jakub included %check as well. If you're doing a review, please assign this ticket to you and also set the fedora-review-flag to ? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 Kashyap Chamarthy kcham...@redhat.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|kcham...@redhat.com QA Contact|extras...@fedoraproject.org |kcham...@redhat.com Flags||fedora-review? --- Comment #6 from Kashyap Chamarthy kcham...@redhat.com --- Sure Matthias - I just waited to the assign/flip review flags as I didn't how soon Jakub wanted it (and Monday/Tuesday are a holiday for me). Anyhow, I just did it, as I'll finish this review completely. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client
https://bugzilla.redhat.com/show_bug.cgi?id=1024885 Jakub Ruzicka jruzi...@redhat.com changed: What|Removed |Added Blocks||1022720 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1022720 [Bug 1022720] python-openstackclient should probably be added to the repos -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
