[Bug 1025103] Review Request: rubygem-bourne - Adds test spies to mocha

2013-11-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025103

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||rubygem-bourne-1.5.0-2.fc20
 Resolution|--- |ERRATA
Last Closed||2013-11-10 02:40:43



--- Comment #6 from Fedora Update System upda...@fedoraproject.org ---
rubygem-bourne-1.5.0-2.fc20 has been pushed to the Fedora 20 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025103] Review Request: rubygem-bourne - Adds test spies to mocha

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025103

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System upda...@fedoraproject.org ---
rubygem-bourne-1.5.0-2.fc20 has been pushed to the Fedora 20 testing
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025103] Review Request: rubygem-bourne - Adds test spies to mocha

2013-11-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025103

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025103] Review Request: rubygem-bourne - Adds test spies to mocha

2013-11-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025103



--- Comment #4 from Fedora Update System upda...@fedoraproject.org ---
rubygem-bourne-1.5.0-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/rubygem-bourne-1.5.0-2.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025103] Review Request: rubygem-bourne - Adds test spies to mocha

2013-11-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025103

Mario Blättermann mario.blaetterm...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mario.blaetterm...@gmail.co
   ||m
   Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
   ||m
  Flags||fedora-review+



--- Comment #1 from Mario Blättermann mario.blaetterm...@gmail.com ---
$ rpmlint -i -v *rubygem-bourne.noarch: I: checking
rubygem-bourne.noarch: W: spelling-error %description -l en_US rspec - spec, r
spec
The value of this tag appears to be misspelled. Please double-check.

rubygem-bourne.noarch: W: spelling-error %description -l en_US matcher -
marcher, matches, catcher
The value of this tag appears to be misspelled. Please double-check.

rubygem-bourne.noarch: W: spelling-error %description -l en_US jferris -
Ferris
The value of this tag appears to be misspelled. Please double-check.

rubygem-bourne.noarch: I: checking-url http://github.com/thoughtbot/bourne
(timeout 10 seconds)
rubygem-bourne.src: I: checking
rubygem-bourne.src: W: spelling-error %description -l en_US rspec - spec, r
spec
The value of this tag appears to be misspelled. Please double-check.

rubygem-bourne.src: W: spelling-error %description -l en_US matcher - marcher,
matches, catcher
The value of this tag appears to be misspelled. Please double-check.

rubygem-bourne.src: W: spelling-error %description -l en_US jferris - Ferris
The value of this tag appears to be misspelled. Please double-check.

rubygem-bourne.src: I: checking-url http://github.com/thoughtbot/bourne
(timeout 10 seconds)
rubygem-bourne.src: I: checking-url https://rubygems.org/gems/bourne-1.5.0.gem
(timeout 10 seconds)
rubygem-bourne-doc.noarch: I: checking
rubygem-bourne-doc.noarch: I: checking-url http://github.com/thoughtbot/bourne
(timeout 10 seconds)
rubygem-bourne.spec: I: checking-url https://rubygems.org/gems/bourne-1.5.0.gem
(timeout 10 seconds)
3 packages and 1 specfiles checked; 0 errors, 6 warnings.

Ignorable spelling errors only.


-
key:

[+] OK
[.] OK, not applicable
[X] needs work
-

[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
MIT
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
b96492d4805ca581173bc9e97b7a31f3986d749f94d42abc7bfef20d6ab7a8a1 
bourne-1.5.0.gem
b96492d4805ca581173bc9e97b7a31f3986d749f94d42abc7bfef20d6ab7a8a1 
bourne-1.5.0.gem.orig

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: 

[Bug 1025103] Review Request: rubygem-bourne - Adds test spies to mocha

2013-11-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025103

Ken Dreyer ktdre...@ktdreyer.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #2 from Ken Dreyer ktdre...@ktdreyer.com ---
Thanks very much for the review!

New Package SCM Request
===
Package Name: rubygem-bourne
Short Description: Adds test spies to mocha
Owners: ktdreyer
Branches: f19 f20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025103] Review Request: rubygem-bourne - Adds test spies to mocha

2013-11-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025103



--- Comment #3 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025103] Review Request: rubygem-bourne - Adds test spies to mocha

2013-11-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025103

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review