[Bug 1025601] Review Request: python-pypump - Python Pump.io library
https://bugzilla.redhat.com/show_bug.cgi?id=1025601 --- Comment #13 from Fedora Update System --- python-pypump-0.4-3.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1025601] Review Request: python-pypump - Python Pump.io library
https://bugzilla.redhat.com/show_bug.cgi?id=1025601 --- Comment #12 from Fedora Update System --- python-pypump-0.4-3.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1025601] Review Request: python-pypump - Python Pump.io library
https://bugzilla.redhat.com/show_bug.cgi?id=1025601 Ralph Bean changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2014-01-27 13:55:20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1025601] Review Request: python-pypump - Python Pump.io library
https://bugzilla.redhat.com/show_bug.cgi?id=1025601 --- Comment #11 from Fedora Update System --- python-pypump-0.4-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-pypump-0.4-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1025601] Review Request: python-pypump - Python Pump.io library
https://bugzilla.redhat.com/show_bug.cgi?id=1025601 --- Comment #10 from Fedora Update System --- python-pypump-0.4-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-pypump-0.4-3.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1025601] Review Request: python-pypump - Python Pump.io library
https://bugzilla.redhat.com/show_bug.cgi?id=1025601 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1025601] Review Request: python-pypump - Python Pump.io library
https://bugzilla.redhat.com/show_bug.cgi?id=1025601 --- Comment #9 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1025601] Review Request: python-pypump - Python Pump.io library
https://bugzilla.redhat.com/show_bug.cgi?id=1025601 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1025601] Review Request: python-pypump - Python Pump.io library
https://bugzilla.redhat.com/show_bug.cgi?id=1025601 Ralph Bean changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Ralph Bean --- New Package SCM Request === Package Name: python-pypump Short Description: Python Pump.io library Owners: ralph Branches: f20 f19 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1025601] Review Request: python-pypump - Python Pump.io library
https://bugzilla.redhat.com/show_bug.cgi?id=1025601
Mario Blättermann changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #7 from Mario Blättermann ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6451561
$ rpmlint -i -v *
python3-pypump.noarch: I: checking
python3-pypump.noarch: E: explicit-lib-dependency python3-oauthlib
You must let rpm find the library dependencies by itself. Do not put unneeded
explicit Requires: tags.
python3-pypump.noarch: W: spelling-error Summary(en_US) io -> oi, Io, ii
The value of this tag appears to be misspelled. Please double-check.
python3-pypump.noarch: W: spelling-error %description -l en_US io -> oi, Io, ii
The value of this tag appears to be misspelled. Please double-check.
python3-pypump.noarch: W: spelling-error %description -l en_US pythonic ->
Python, python
The value of this tag appears to be misspelled. Please double-check.
python3-pypump.noarch: I: checking-url http://pypi.python.org/pypi/PyPump
(timeout 10 seconds)
python-pypump.src: I: checking
python-pypump.src: W: spelling-error Summary(en_US) io -> oi, Io, ii
The value of this tag appears to be misspelled. Please double-check.
python-pypump.src: W: spelling-error %description -l en_US io -> oi, Io, ii
The value of this tag appears to be misspelled. Please double-check.
python-pypump.src: W: spelling-error %description -l en_US pythonic -> Python,
python
The value of this tag appears to be misspelled. Please double-check.
python-pypump.src: I: checking-url http://pypi.python.org/pypi/PyPump (timeout
10 seconds)
python-pypump.src: I: checking-url
http://pypi.python.org/packages/source/P/PyPump/PyPump-0.4.tar.gz (timeout 10
seconds)
python-pypump.noarch: I: checking
python-pypump.noarch: E: explicit-lib-dependency python-oauthlib
You must let rpm find the library dependencies by itself. Do not put unneeded
explicit Requires: tags.
python-pypump.noarch: W: spelling-error Summary(en_US) io -> oi, Io, ii
The value of this tag appears to be misspelled. Please double-check.
python-pypump.noarch: W: spelling-error %description -l en_US io -> oi, Io, ii
The value of this tag appears to be misspelled. Please double-check.
python-pypump.noarch: W: spelling-error %description -l en_US pythonic ->
Python, python
The value of this tag appears to be misspelled. Please double-check.
python-pypump.noarch: I: checking-url http://pypi.python.org/pypi/PyPump
(timeout 10 seconds)
python-pypump.spec: I: checking-url
http://pypi.python.org/packages/source/P/PyPump/PyPump-0.4.tar.gz (timeout 10
seconds)
3 packages and 1 specfiles checked; 2 errors, 9 warnings.
Already discussed issues, no new ones so far.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
MIT
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
1e64f66888e57724adc834ffe9619acd2fbc5a44b5ec7cf615e2b03dbc6f0a81
PyPump-0.4.tar.gz
1e64f66888e57724adc834ffe9619acd2fbc5a44b5ec7cf615e2b03dbc6f0a81
PyPump-0.4.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any
[Bug 1025601] Review Request: python-pypump - Python Pump.io library
https://bugzilla.redhat.com/show_bug.cgi?id=1025601 Bug 1025601 depends on bug 1025367, which changed state. Bug 1025367 Summary: Review Request: python-requests-oauthlib - OAuthlib authentication support for Requests. https://bugzilla.redhat.com/show_bug.cgi?id=1025367 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1025601] Review Request: python-pypump - Python Pump.io library
https://bugzilla.redhat.com/show_bug.cgi?id=1025601 Bug 1025601 depends on bug 1025367, which changed state. Bug 1025367 Summary: Review Request: python-requests-oauthlib - OAuthlib authentication support for Requests. https://bugzilla.redhat.com/show_bug.cgi?id=1025367 What|Removed |Added Status|CLOSED |MODIFIED Resolution|ERRATA |--- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1025601] Review Request: python-pypump - Python Pump.io library
https://bugzilla.redhat.com/show_bug.cgi?id=1025601 --- Comment #6 from Ralph Bean --- Thanks Mario. This release should take care of all those issues. Spec Url: http://threebean.org/rpm/python-pypump.spec SRPM Url: http://threebean.org/rpm/python-pypump-0.4-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1025601] Review Request: python-pypump - Python Pump.io library
https://bugzilla.redhat.com/show_bug.cgi?id=1025601 --- Comment #5 from Mario Blättermann --- Just found another issue: $ rpm -qpR python3-pypump-0.4-2.fc21.noarch.rpm /usr/bin/env python(abi) = 3.3 python-dateutil python-oauthlib python-requests rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 The "Requires" listing is outside of the python3 condition. You have to include the runtime requirements there, applying the special needs for Python 3, otherwise I'm afraid the Python 3 version won't work. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1025601] Review Request: python-pypump - Python Pump.io library
https://bugzilla.redhat.com/show_bug.cgi?id=1025601 Mario Blättermann changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co ||m Flags||fedora-review? --- Comment #4 from Mario Blättermann --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6378378 $ rpmlint -i -v * python3-pypump.noarch: I: checking python3-pypump.noarch: E: explicit-lib-dependency python-oauthlib You must let rpm find the library dependencies by itself. Do not put unneeded explicit Requires: tags. python3-pypump.noarch: W: spelling-error Summary(en_US) io -> oi, Io, ii The value of this tag appears to be misspelled. Please double-check. python3-pypump.noarch: W: spelling-error %description -l en_US io -> oi, Io, ii The value of this tag appears to be misspelled. Please double-check. python3-pypump.noarch: W: spelling-error %description -l en_US pythonic -> Python, python The value of this tag appears to be misspelled. Please double-check. python3-pypump.noarch: I: checking-url http://pypi.python.org/pypi/PyPump (timeout 10 seconds) python3-pypump.noarch: W: hidden-file-or-dir /usr/share/doc/python3-pypump/docs-html/.doctrees The file or directory is hidden. You should see if this is normal, and delete it from the package if not. python3-pypump.noarch: W: hidden-file-or-dir /usr/share/doc/python3-pypump/docs-html/.doctrees The file or directory is hidden. You should see if this is normal, and delete it from the package if not. python3-pypump.noarch: W: hidden-file-or-dir /usr/share/doc/python3-pypump/docs-html/.buildinfo The file or directory is hidden. You should see if this is normal, and delete it from the package if not. python3-pypump.noarch: W: doc-file-dependency /usr/share/doc/python3-pypump/docs/examples/pypump-post-note.py /usr/bin/env An included file marked as %doc creates a possible additional dependency in the package. Usually, this is not wanted and may be caused by eg. example scripts with executable bits set included in the package's documentation. python-pypump.src: I: checking python-pypump.src: W: spelling-error Summary(en_US) io -> oi, Io, ii The value of this tag appears to be misspelled. Please double-check. python-pypump.src: W: spelling-error %description -l en_US io -> oi, Io, ii The value of this tag appears to be misspelled. Please double-check. python-pypump.src: W: spelling-error %description -l en_US pythonic -> Python, python The value of this tag appears to be misspelled. Please double-check. python-pypump.src: I: checking-url http://pypi.python.org/pypi/PyPump (timeout 10 seconds) python-pypump.src: I: checking-url http://pypi.python.org/packages/source/P/PyPump/PyPump-0.4.tar.gz (timeout 10 seconds) python-pypump.noarch: I: checking python-pypump.noarch: E: explicit-lib-dependency python-oauthlib You must let rpm find the library dependencies by itself. Do not put unneeded explicit Requires: tags. python-pypump.noarch: W: spelling-error Summary(en_US) io -> oi, Io, ii The value of this tag appears to be misspelled. Please double-check. python-pypump.noarch: W: spelling-error %description -l en_US io -> oi, Io, ii The value of this tag appears to be misspelled. Please double-check. python-pypump.noarch: W: spelling-error %description -l en_US pythonic -> Python, python The value of this tag appears to be misspelled. Please double-check. python-pypump.noarch: I: checking-url http://pypi.python.org/pypi/PyPump (timeout 10 seconds) python-pypump.noarch: W: hidden-file-or-dir /usr/share/doc/python-pypump/docs-html/.doctrees The file or directory is hidden. You should see if this is normal, and delete it from the package if not. python-pypump.noarch: W: hidden-file-or-dir /usr/share/doc/python-pypump/docs-html/.doctrees The file or directory is hidden. You should see if this is normal, and delete it from the package if not. python-pypump.noarch: W: hidden-file-or-dir /usr/share/doc/python-pypump/docs-html/.buildinfo The file or directory is hidden. You should see if this is normal, and delete it from the package if not. python-pypump.noarch: W: doc-file-dependency /usr/share/doc/python-pypump/docs/examples/pypump-post-note.py /usr/bin/env An included file marked as %doc creates a possible additional dependency in the package. Usually, this is not wanted and may be caused by eg. example scripts with executable bits set included in the package's documentation. python-pypump.spec: I: checking-url http://pypi.python.org/packages/source/P/PyPump/PyPump-0.4.tar.gz (timeout 10 seconds) 3 packages and 1 specfiles checked; 2 errors, 17 warnings. The explicit-library-dependency warning are false positive, python-oauthlib is noarch and that's why not a library in commo
[Bug 1025601] Review Request: python-pypump - Python Pump.io library
https://bugzilla.redhat.com/show_bug.cgi?id=1025601 --- Comment #3 from Ralph Bean --- Mosaab, Mario, sorry for not responding sooner. It was rude of me. Here's an updated version of the spec and srpm based on your feedback. I built the HTML docs, and used the appropriate python2 macro. Spec Url: http://threebean.org/rpm/python-pypump.spec SRPM Url: http://threebean.org/rpm/python-pypump-0.4-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1025601] Review Request: python-pypump - Python Pump.io library
https://bugzilla.redhat.com/show_bug.cgi?id=1025601 Bug 1025601 depends on bug 1025367, which changed state. Bug 1025367 Summary: Review Request: python-requests-oauthlib - OAuthlib authentication support for Requests. https://bugzilla.redhat.com/show_bug.cgi?id=1025367 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1025601] Review Request: python-pypump - Python Pump.io library
https://bugzilla.redhat.com/show_bug.cgi?id=1025601 Mario Blättermann changed: What|Removed |Added CC||mario.blaetterm...@gmail.co ||m --- Comment #2 from Mario Blättermann --- (In reply to Mosaab Alzoubi from comment #1) > * License GPLv3 Have a look at this: $ licensecheck -r * docs/conf.py: GENERATED FILE docs/examples/pypump-post-note.py: *No copyright* UNKNOWN pypump/exception/PumpException.py: *No copyright* UNKNOWN pypump/exception/DoesNotExist.py: *No copyright* UNKNOWN pypump/exception/ImmutableException.py: *No copyright* UNKNOWN pypump/exception/__init__.py: *No copyright* UNKNOWN pypump/exception/ServerError.py: *No copyright* UNKNOWN pypump/pypump.py: GPL (v3 or later) pypump/__init__.py: *No copyright* UNKNOWN pypump/models/comment.py: GPL (v3 or later) pypump/models/image.py: GPL (v3 or later) pypump/models/activity.py: GPL (v3 or later) pypump/models/person.py: GPL (v3 or later) pypump/models/feed.py: GPL (v3 or later) pypump/models/__init__.py: GPL (v3 or later) pypump/models/location.py: GPL (v3 or later) pypump/models/collection.py: GPL (v3 or later) pypump/models/note.py: GPL (v3 or later) pypump/openid.py: GPL (v3 or later) pypump/compatability.py: GPL (v3 or later) setup.py: *No copyright* UNKNOWN Don't refer to the license file only. In doubt, have a look at the file headers to see if the "later versions" clause has to be applied. > * Using docs/ folder as documents in both python-pypump and python3-pypump > without making them ! Indeed, the docs contain the "docs" folder as it is. If you want to add those contents to the package, proceed the Makefile to get real content. > * Must use %__python2 macro instead of %__python. See also https://bugzilla.redhat.com/show_bug.cgi?id=1025368#c1. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1025601] Review Request: python-pypump - Python Pump.io library
https://bugzilla.redhat.com/show_bug.cgi?id=1025601 Mosaab Alzoubi changed: What|Removed |Added CC||moc...@hotmail.com --- Comment #1 from Mosaab Alzoubi --- I'm not a packager yet, but these information may help. - Package PRE-Review : * License GPLv3 * Using docs/ folder as documents in both python-pypump and python3-pypump without making them ! There are alot of choises : html to make standalone HTML files dirhtmlto make HTML files named index.html in directories singlehtml to make a single large HTML file pickle to make pickle files json to make JSON files htmlhelp to make HTML files and a HTML help project qthelp to make HTML files and a qthelp project devhelpto make HTML files and a Devhelp project epub to make an epub latex to make LaTeX files, you can set PAPER=a4 or PAPER=letter latexpdf to make LaTeX files and run them through pdflatex text to make text files manto make manual pages texinfoto make Texinfo files info to make Texinfo files and run them through makeinfo gettextto make PO message catalogs changesto make an overview of all changed/added/deprecated items linkcheck to check all external links for integrity doctestto run all doctests embedded in the documentation (if enabled) That will be nice if some of them (html,man..) maked. * Must use %__python2 macro instead of %__python. * Source in SRPM match upstream one. 197a6bbb604edda02390f23bb7cc817a. * Spec and contents is clean. * Rpmlint almost clean : rpmlint -i /run/media/moceap/MULTIBOOT/1025601-python-pypump/srpm/python-pypump-0.4-1.fc19.src.rpm python-pypump.src: W: spelling-error Summary(en_US) io -> oi, Io, ii The value of this tag appears to be misspelled. Please double-check. python-pypump.src: W: spelling-error %description -l en_US io -> oi, Io, ii The value of this tag appears to be misspelled. Please double-check. python-pypump.src: W: spelling-error %description -l en_US pythonic -> Python, python The value of this tag appears to be misspelled. Please double-check. python-pypump.src: W: invalid-url URL: http://pypi.python.org/pypi/PyPump timed out The value should be a valid, public HTTP, HTTPS, or FTP URL. 1 packages and 0 specfiles checked; 0 errors, 4 warnings. * To solve URL warning use HTTPS instead HTTP. * Builds succeed in Fedora 19 i686 (using updates-testing repo). * No bundels. == -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1025601] Review Request: python-pypump - Python Pump.io library
https://bugzilla.redhat.com/show_bug.cgi?id=1025601 Ralph Bean changed: What|Removed |Added Depends On||1025367 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1025367 [Bug 1025367] Review Request: python-requests-oauthlib - OAuthlib authentication support for Requests. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
