[Bug 1026052] Review Request: rubygem-github-markdown - rubygem to process github markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1026052

Otto Urpelainen  changed:

   What|Removed |Added

 CC||otu...@iki.fi
  Flags||needinfo?(af...@affix.me)



--- Comment #14 from Otto Urpelainen  ---
This review request is really old. Do you still intend to complete it? If so, I
can review. If not, please close this issue and make it block FE-DEADREVIEW, or
do nothing, in which case automation will close the request in one month.

Since there is no public upstream repository and the gem itself is now "not
maintained and not supported", I think this package should not be added to
Fedora. But it is your call if you want to do that, of course.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 1026052] Review Request: rubygem-github-markdown - rubygem to process github markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1026052



--- Comment #11 from Upstream Release Monitoring 
 ---
pbrobinson's scratch build of
rubygem-ruby-libvirt?#7d89f84f497486cae74535bbce9acee2b56b2a40 for
epel7-archbootstrap and
git://pkgs.fedoraproject.org/rubygem-ruby-libvirt?#7d89f84f497486cae74535bbce9acee2b56b2a40
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12039225

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026052] Review Request: rubygem-github-markdown - rubygem to process github markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1026052



--- Comment #10 from Ken Dreyer ktdre...@ktdreyer.com ---
Hi Keiran, we haven't heard from you in a while. Are you still interested in
getting this package into Fedora? Achilleas and I will need this gem for GitLab
and Gitorious.


We'll want to ship the latest upstream release(0.6.5) in Fedora, update the
package for the latest Fedora 21 and Ruby 2.1 guidelines, etc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026052] Review Request: rubygem-github-markdown - rubygem to process github markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1026052

Ken Dreyer ktdre...@ktdreyer.com changed:

   What|Removed |Added

 CC||fed...@affix.me
  Flags||needinfo?(fed...@affix.me)



--- Comment #9 from Ken Dreyer ktdre...@ktdreyer.com ---
Hi Keiran, just checking in again to see if you're still interested in
maintaining this package?

I was looking at the packaging some more, and one other thing I noticed is that
since this is a C extension, it should Require: ruby, not Require:
ruby(release).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026052] Review Request: rubygem-github-markdown - rubygem to process github markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1026052



--- Comment #8 from Ken Dreyer ktdre...@ktdreyer.com ---
Upon closer inspection of the license text in the source code, I think the
license is actually ISC versus MIT. That will need to be reflected in the
spec file.

https://github.com/Affix/RPMs/pull/1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026052] Review Request: rubygem-github-markdown - rubygem to process github markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1026052



--- Comment #7 from Ken Dreyer ktdre...@ktdreyer.com ---
Hi Keiran, I'm checking again to see if you're still interested in maintaining
this package?

You probably saw the email from the developer at GitHub. It seems that while
github-markdown is technically available from rubygems.org under the MIT
license, GitHub didn't intend it to be an open-source project. The Git
repository and issue tracker are not public, and GitHub doesn't recommend that
Linux distributions package the software due to expectations of instability.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026052] Review Request: rubygem-github-markdown - rubygem to process github markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1026052



--- Comment #6 from Ken Dreyer ktdre...@ktdreyer.com ---
Hi Keiran, are you still interested in maintaining this package?

I've emailed GitHub support today about the missing Git repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026052] Review Request: rubygem-github-markdown - rubygem to process github markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1026052

Axilleas Pipinellis axill...@archlinux.gr changed:

   What|Removed |Added

 CC||axill...@archlinux.gr



--- Comment #5 from Axilleas Pipinellis axill...@archlinux.gr ---
Hey Keiran, you can check how I've done it for Fedora 19+ here [0]. And guys,
remember that the LICENSE is not shipped with this gem. I haven't found the
source code on github so as to open an issue. Also, the current version is
0.6.3.


[0]
https://github.com/axilleas/fedora/blob/master/packages/SPECS/rubygem-github-markdown.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026052] Review Request: rubygem-github-markdown - rubygem to process github markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1026052



--- Comment #1 from Keiran Smith fed...@affix.me ---
*** Bug 1026051 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026052] Review Request: rubygem-github-markdown - rubygem to process github markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1026052



--- Comment #2 from Keiran Smith fed...@affix.me ---
Mock Build.log

Mock Version: 1.1.33
ENTER do(['bash', '--login', '-c', 'rpmbuild -bs --target x86_64 --nodeps
builddir/build/SPECS/rubygem-github-markdown.spec'], False,
'/var/lib/mock/fedora-19-x86_64/root/', None, 0, True, False, 1000, 135, None,
False, {'LANG': 'en_GB.UTF-8', 'TERM': 'vt100', 'SHELL': '/bin/bash',
'CCACHE_DIR': '/tmp/ccache', 'HOSTNAME': 'mock', 'PROMPT_COMMAND': 'echo -n
mock-chroot', 'HOME': '/builddir', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin',
'CCACHE_UMASK': '002'}, logger=mockbuild.trace_decorator.getLog object at
0x213e3d0)
Executing command: ['bash', '--login', '-c', 'rpmbuild -bs --target x86_64
--nodeps builddir/build/SPECS/rubygem-github-markdown.spec'] with env {'LANG':
'en_GB.UTF-8', 'TERM': 'vt100', 'SHELL': '/bin/bash', 'CCACHE_DIR':
'/tmp/ccache', 'HOSTNAME': 'mock', 'PROMPT_COMMAND': 'echo -n mock-chroot',
'HOME': '/builddir', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin', 'CCACHE_UMASK':
'002'}
warning: Could not canonicalize hostname: fedora19.affix
Building target platforms: x86_64
Building for target x86_64
Wrote: /builddir/build/SRPMS/rubygem-github-markdown-0.6.1-1.fc19.src.rpm
Child return code was: 0
LEAVE do -- 

ENTER do(['bash', '--login', '-c', 'rpmbuild -bb --target x86_64 --nodeps
builddir/build/SPECS/rubygem-github-markdown.spec'], False,
'/var/lib/mock/fedora-19-x86_64/root/', None, 0, True, False, 1000, 135, None,
False, {'LANG': 'en_GB.UTF-8', 'TERM': 'vt100', 'SHELL': '/bin/bash',
'CCACHE_DIR': '/tmp/ccache', 'HOSTNAME': 'mock', 'PROMPT_COMMAND': 'echo -n
mock-chroot', 'HOME': '/builddir', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin',
'CCACHE_UMASK': '002'}, logger=mockbuild.trace_decorator.getLog object at
0x213e3d0)
Executing command: ['bash', '--login', '-c', 'rpmbuild -bb --target x86_64
--nodeps builddir/build/SPECS/rubygem-github-markdown.spec'] with env {'LANG':
'en_GB.UTF-8', 'TERM': 'vt100', 'SHELL': '/bin/bash', 'CCACHE_DIR':
'/tmp/ccache', 'HOSTNAME': 'mock', 'PROMPT_COMMAND': 'echo -n mock-chroot',
'HOME': '/builddir', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin', 'CCACHE_UMASK':
'002'}
Building target platforms: x86_64
Building for target x86_64
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.cZbYj4
+ umask 022
+ cd /builddir/build/BUILD
+ cd /builddir/build/BUILD
+ rm -rf rubygem-github-markdown-0.6.1
+ /usr/bin/mkdir -p rubygem-github-markdown-0.6.1
+ cd rubygem-github-markdown-0.6.1
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
++ pwd
+ TOPDIR=/builddir/build/BUILD/rubygem-github-markdown-0.6.1
+ mkdir tmpunpackdir
+ pushd tmpunpackdir
~/build/BUILD/rubygem-github-markdown-0.6.1/tmpunpackdir
~/build/BUILD/rubygem-github-markdown-0.6.1
+ gem unpack /builddir/build/SOURCES/github-markdown-0.6.1.gem
Unpacked gem:
'/builddir/build/BUILD/rubygem-github-markdown-0.6.1/tmpunpackdir/github-markdown-0.6.1'
+ cd github-markdown-0.6.1
+ gem specification -l --ruby /builddir/build/SOURCES/github-markdown-0.6.1.gem
+ gem build github-markdown.gemspec
WARNING:  licenses is empty
  Successfully built RubyGem
  Name: github-markdown
  Version: 0.6.1
  File: github-markdown-0.6.1.gem
+ mv github-markdown-0.6.1.gem
/builddir/build/BUILD/rubygem-github-markdown-0.6.1
+ popd
~/build/BUILD/rubygem-github-markdown-0.6.1
+ rm -rf tmpunpackdir
+ exit 0
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.T9B0Wh
+ umask 022
+ cd /builddir/build/BUILD
+ cd rubygem-github-markdown-0.6.1
+ mkdir -p ./usr/share/gems
+ CONFIGURE_ARGS='--with-cflags='\''-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector --param=ssp-buffer-size=4 -grecord-gcc-switches 
-m64 -mtune=generic'\'' '
+ gem install -V --local --install-dir ./usr/share/gems --bindir ./usr/bin
--force --document=ri,rdoc --backtrace github-markdown-0.6.1.gem
Installing gem github-markdown-0.6.1
/builddir/build/BUILD/rubygem-github-markdown-0.6.1/usr/share/gems/gems/github-markdown-0.6.1/Rakefile
/builddir/build/BUILD/rubygem-github-markdown-0.6.1/usr/share/gems/gems/github-markdown-0.6.1/bin/gfm
/builddir/build/BUILD/rubygem-github-markdown-0.6.1/usr/share/gems/gems/github-markdown-0.6.1/ext/markdown/autolink.c
/builddir/build/BUILD/rubygem-github-markdown-0.6.1/usr/share/gems/gems/github-markdown-0.6.1/ext/markdown/autolink.h
/builddir/build/BUILD/rubygem-github-markdown-0.6.1/usr/share/gems/gems/github-markdown-0.6.1/ext/markdown/buffer.c
/builddir/build/BUILD/rubygem-github-markdown-0.6.1/usr/share/gems/gems/github-markdown-0.6.1/ext/markdown/buffer.h
/builddir/build/BUILD/rubygem-github-markdown-0.6.1/usr/share/gems/gems/github-markdown-0.6.1/ext/markdown/extconf.rb
/builddir/build/BUILD/rubygem-github-markdown-0.6.1/usr/share/gems/gems/github-markdown-0.6.1/ext/markdown/gh-markdown.c
/builddir/build/BUILD/rubygem-github-markdown-0.6.1/usr/share/gems/gems/github-markdown-0.6.1/ext/markdown/houdini.h

[Bug 1026052] Review Request: rubygem-github-markdown - rubygem to process github markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1026052

Ken Dreyer ktdre...@ktdreyer.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ktdre...@ktdreyer.com
   Assignee|nob...@fedoraproject.org|ktdre...@ktdreyer.com
  Flags||fedora-review?



--- Comment #3 from Ken Dreyer ktdre...@ktdreyer.com ---
I'll need this for rubygem-github-markup, so I can take this review.

Most importantly: Can you please add the test suite in %check?

Please use HTTPS for the URL and Source0.

Do you need to have the version number comparison (= 1.3.6) for rubygems and
rubygems-devel? If not, I recommend leaving it out.

Does this package need rubygem(rubyforge) and rubygem(rake)? I'm thinking these
can be removed from the Requires/BuildRequires.

Is this chmod line necessary?
  chmod 0644 %{buildroot}%{gemdir}/cache/*gem

Are you planning on building for EL5? If not, please remove the %defattr(-,
root, root, -) lines under %files.

You're using the old-style EL6 macros, like gemdir or geminstdir. Can you
switch this to use the newer styles available in F19? The gem2rpm tool that's
available in Fedora 19 should help you. If you're still interested in packaging
this for EL6, you can just use backwards-compatible macros.

My suggestion would be to re-run gem2rpm on Fedora 19 for this gem.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026052] Review Request: rubygem-github-markdown - rubygem to process github markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1026052

Mamoru TASAKA mtas...@fedoraproject.org changed:

   What|Removed |Added

 CC||mtas...@fedoraproject.org



--- Comment #4 from Mamoru TASAKA mtas...@fedoraproject.org ---
And another important thing:
* Please check how ext/ directory should be treated.
  Arch dependent .so file must not be under /usr/share , so this file
  must be moved somewhere (usually %{gem_extdir_mri}/lib )

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review