[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 Petr Vobornik pvobo...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #20 from Petr Vobornik pvobo...@redhat.com --- Package Change Request == Package Name: fontawesome-fonts New Branches: epel7 Owners: pvoborni because of: https://bugzilla.redhat.com/show_bug.cgi?id=1138536 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 --- Comment #21 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||fontawesome-fonts-4.0.3-1.f ||c19 Resolution|--- |ERRATA Last Closed||2014-01-18 23:00:46 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- fontawesome-fonts-4.0.3-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|fontawesome-fonts-4.0.3-1.f |fontawesome-fonts-4.0.3-1.f |c19 |c20 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- fontawesome-fonts-4.0.3-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- fontawesome-fonts-4.0.3-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/fontawesome-fonts-4.0.3-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- fontawesome-fonts-4.0.3-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/fontawesome-fonts-4.0.3-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- fontawesome-fonts-4.0.3-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 Petr Vobornik pvobo...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #13 from Petr Vobornik pvobo...@redhat.com --- New Package SCM Request === Package Name: fontawesome-fonts Short Description: Iconic font set Owners: pvoborni Branches: f19 f20 InitialCC:fonts-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 --- Comment #14 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 Ankur Sinha (FranciscoD) sanjay.an...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #12 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- Hi Petr, Package looks OK now: [asinha@ankur-laptop SRPMS]$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm ../SPECS/fontawesome-fonts.spec ./fontawesome-fonts-4.0.3-1.fc20.src.rpm fontawesome-fonts.noarch: W: spelling-error %description -l en_US scalable - salable, callable, calculable fontawesome-fonts.noarch: W: invalid-url URL: http://fontawesome.io/ HTTP Error 302: The HTTP server returned a redirect error that would lead to an infinite loop. The last 30x error message was: Found fontawesome-fonts.src: W: spelling-error %description -l en_US scalable - salable, callable, calculable fontawesome-fonts-web.noarch: W: no-documentation fontawesome-fonts.src: W: spelling-error %description -l en_US scalable - salable, callable, calculable 4 packages and 1 specfiles checked; 0 errors, 5 warnings. [asinha@ankur-laptop SRPMS]$ Nothing serious here. [asinha@ankur-laptop result]$ review-req-check == fontawesome-fonts-4.0.3-1.fc21.noarch.rpm == Provides: config(fontawesome-fonts) = 4.0.3-1.fc21 font(fontawesome) fontawesome-fonts = 4.0.3-1.fc21 Requires: /bin/sh /bin/sh config(fontawesome-fonts) = 4.0.3-1.fc21 fontpackages-filesystem == fontawesome-fonts-4.0.3-1.fc21.src.rpm == Provides: Requires: fontpackages-devel ttembed == fontawesome-fonts-web-4.0.3-1.fc21.noarch.rpm == Provides: fontawesome-fonts-web = 4.0.3-1.fc21 Requires: fontawesome-fonts = 4.0.3-1.fc21 [asinha@ankur-laptop result]$ [asinha@ankur-laptop result]$ for i in *.rpm ; do echo ** $i ** ; rpmls $i; done ** fontawesome-fonts-4.0.3-1.fc21.noarch.rpm ** lrwxrwxrwx /etc/fonts/conf.d/60-fontawesome.conf drwxr-xr-x /usr/share/doc/fontawesome-fonts -rw-r--r-- /usr/share/doc/fontawesome-fonts/README-Trademarks.txt -rw-r--r-- /usr/share/fontconfig/conf.avail/60-fontawesome.conf drwxr-xr-x /usr/share/fonts/fontawesome -rw-r--r-- /usr/share/fonts/fontawesome/FontAwesome.otf -rw-r--r-- /usr/share/fonts/fontawesome/fontawesome-webfont.ttf ** fontawesome-fonts-4.0.3-1.fc21.src.rpm ** -rw-rw-r-- README-Trademarks.txt -rw-rw-r-- font-awesome-4.0.3.zip -rw-rw-r-- fontawesome-fonts-fontconfig.conf -rw-rw-r-- fontawesome-fonts.spec ** fontawesome-fonts-web-4.0.3-1.fc21.noarch.rpm ** drwxr-xr-x /usr/share/font-awesome-4.0.3 drwxr-xr-x /usr/share/font-awesome-4.0.3/css -rw-r--r-- /usr/share/font-awesome-4.0.3/css/font-awesome.css -rw-r--r-- /usr/share/font-awesome-4.0.3/css/font-awesome.min.css drwxr-xr-x /usr/share/font-awesome-4.0.3/less -rw-r--r-- /usr/share/font-awesome-4.0.3/less/bordered-pulled.less -rw-r--r-- /usr/share/font-awesome-4.0.3/less/core.less -rw-r--r-- /usr/share/font-awesome-4.0.3/less/fixed-width.less -rw-r--r-- /usr/share/font-awesome-4.0.3/less/font-awesome.less -rw-r--r-- /usr/share/font-awesome-4.0.3/less/icons.less -rw-r--r-- /usr/share/font-awesome-4.0.3/less/larger.less -rw-r--r-- /usr/share/font-awesome-4.0.3/less/list.less -rw-r--r-- /usr/share/font-awesome-4.0.3/less/mixins.less -rw-r--r-- /usr/share/font-awesome-4.0.3/less/path.less -rw-r--r-- /usr/share/font-awesome-4.0.3/less/rotated-flipped.less -rw-r--r-- /usr/share/font-awesome-4.0.3/less/spinning.less -rw-r--r-- /usr/share/font-awesome-4.0.3/less/stacked.less -rw-r--r-- /usr/share/font-awesome-4.0.3/less/variables.less drwxr-xr-x /usr/share/font-awesome-4.0.3/scss -rw-r--r-- /usr/share/font-awesome-4.0.3/scss/_bordered-pulled.scss -rw-r--r-- /usr/share/font-awesome-4.0.3/scss/_core.scss -rw-r--r-- /usr/share/font-awesome-4.0.3/scss/_fixed-width.scss -rw-r--r-- /usr/share/font-awesome-4.0.3/scss/_icons.scss -rw-r--r-- /usr/share/font-awesome-4.0.3/scss/_larger.scss -rw-r--r-- /usr/share/font-awesome-4.0.3/scss/_list.scss -rw-r--r-- /usr/share/font-awesome-4.0.3/scss/_mixins.scss -rw-r--r-- /usr/share/font-awesome-4.0.3/scss/_path.scss -rw-r--r-- /usr/share/font-awesome-4.0.3/scss/_rotated-flipped.scss -rw-r--r-- /usr/share/font-awesome-4.0.3/scss/_spinning.scss -rw-r--r-- /usr/share/font-awesome-4.0.3/scss/_stacked.scss -rw-r--r-- /usr/share/font-awesome-4.0.3/scss/_variables.scss -rw-r--r-- /usr/share/font-awesome-4.0.3/scss/font-awesome.scss [asinha@ankur-laptop result]$ XXX APPROVED XXX -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 --- Comment #11 from Petr Vobornik pvobo...@redhat.com --- I can take over. New version: - embeddable flag set to installable by ttembed - web package license updated to MIT (according to http://fontawesome.io/license/) - README-Trademarks.txt added - url changed to http://fontawesome.io/ Spec URL: http://pvoborni.fedorapeople.org/fontawesome/fontawesome-fonts.spec SRPM URL: http://pvoborni.fedorapeople.org/fontawesome/fontawesome-fonts-4.0.3-1.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 --- Comment #10 from Ryan Lerch rle...@redhat.com --- I originally submitted this package review, as this was a dep for corebird. However, corebird no longer requires fontawesome, so I am no going to pursue packaging this anymore. If anyone wants to take it over, feel free. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 --- Comment #9 from Petr Vobornik pvobo...@redhat.com --- Hi, thank you for packaging this font. We would like to use it as well in FreeIPA. There is an issue though. Current otf and ttf versions of this font contains a bug: embeddable permissions are set to printable(fstype=0004) instead of installable(fstype=). This causes a bug when the font is served to Internet Explorer 9+: CSS3114: @font-face failed OpenType embedding permission check. Permission must be Installable. fontawesome-webfont.ttf Can you please set the flag to 0 during rpm build until upstream fixes it? There is a discussion on fedora devel about it: https://lists.fedoraproject.org/pipermail/devel/2013-November/192518.html I'm packaging Open Sans fonts - bug 1035897 where it's fixed by ttembed tool which is being packages as well - bug 1036754. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 Ankur Sinha (FranciscoD) sanjay.an...@gmail.com changed: What|Removed |Added Blocks|1026380 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1026380 [Bug 1026380] Review Request: corebird - Native GTK Twitter client -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 Thomas Spura toms...@fedoraproject.org changed: What|Removed |Added CC||toms...@fedoraproject.org Blocks||1006575 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1006575 [Bug 1006575] ipython: please package new upstream version (1.1) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 --- Comment #7 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- (In reply to Tom spot Callaway from comment #6) I think given that A) the logos in this font are the ones with specific permissions granted by their owners and B) it is highly likely in the context of this font that such logos will only be used in compliance with those permissions, they are acceptable in Fedora. That said, please add a README-Trademarks.txt file which notes these marks, their owners, and provides links to their respective trademark use policies. Thanks for the clarification Spot. Ryan, I see upstream has a branch called no-font where he's completely removed fontawesome-fonts (or is trying to). Do you want to wait for him to complete that and then package up corebird, if you're only looking to package fontawesome-fonts because they're needed by corebird? If you'd like to maintain the fonts even if corebird doesn't use them, I'll continue the review. https://github.com/baedert/corebird/tree/no-font Thanks, Warm regards, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 --- Comment #8 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- From https://bugzilla.redhat.com/show_bug.cgi?id=1026380#c12 FYI: With todays commit #9fea73447ebb86d82242e104d7804d78e221dbe8 corebird no longer uses fontawesome: https://github.com/baedert/corebird/commit/9fea73447ebb86d82242e104d7804d78e221dbe8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added CC||tcall...@redhat.com --- Comment #6 from Tom spot Callaway tcall...@redhat.com --- I think given that A) the logos in this font are the ones with specific permissions granted by their owners and B) it is highly likely in the context of this font that such logos will only be used in compliance with those permissions, they are acceptable in Fedora. That said, please add a README-Trademarks.txt file which notes these marks, their owners, and provides links to their respective trademark use policies. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 --- Comment #4 from Ryan Lerch rle...@redhat.com --- Thanks for the feedback! I have updated it to 4.0.3, and fixed the source links. Also i have removed the %doc macro. http://ryanlerch.fedorapeople.org/packaging/fontawesome/2/fontawesome-fonts-4.0.3-0.fc20.src.rpm http://ryanlerch.fedorapeople.org/packaging/fontawesome/2/fontawesome-fonts.spec I checked the trademarked logos, but should i just send an email to legal@ anyway? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 --- Comment #5 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- (In reply to Ryan Lerch from comment #4) Thanks for the feedback! I have updated it to 4.0.3, and fixed the source links. Also i have removed the %doc macro. http://ryanlerch.fedorapeople.org/packaging/fontawesome/2/fontawesome-fonts- 4.0.3-0.fc20.src.rpm http://ryanlerch.fedorapeople.org/packaging/fontawesome/2/fontawesome-fonts. spec I checked the trademarked logos, but should i just send an email to legal@ anyway? I think it's safer to mail Legal and get them to look at it, just in case. It'll delay the review by a few days at the most, but we'll be sure once they've had a look. I'll look at the updated spec/srpm today and update the review. Thanks, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Blocks||1026380 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1026380 [Bug 1026380] Review Request: corebird - Native GTK Twitter client -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 Ankur Sinha (FranciscoD) sanjay.an...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||sanjay.an...@gmail.com Assignee|nob...@fedoraproject.org|sanjay.an...@gmail.com Flags||fedora-review? --- Comment #1 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- Hi, I'll review both the fonts and corebird. Thanks, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 --- Comment #2 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- Reviewing the spec. It appears a new version: 4.0.2 is out. Can you please update the spec for this version? rpmlint can't find the 4.0.0 sources since they aren't around anymore http://fortawesome.github.io/Font-Awesome/assets/font-awesome-4.0.2.zip I'll put up the complete review later today. Thanks, Warm regards, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 --- Comment #3 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- [+] OK [-] NA [?] Issue ** Mandatory review guidelines: ** [+] rpmlint output: [asinha@ankur-laptop SRPMS]$ rpmlint ../SPECS/fontawesome-fonts.spec ./fontawesome-fonts-4.0.0-1.fc20.src.rpm /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm ../SPECS/fontawesome-fonts.spec: W: invalid-url Source0: http://fortawesome.github.io/Font-Awesome/assets/font-awesome-4.0.0.zip HTTP Error 404: Not Found fontawesome-fonts.src: W: spelling-error %description -l en_US scalable - salable, callable, calculable fontawesome-fonts.src: W: invalid-url Source0: http://fortawesome.github.io/Font-Awesome/assets/font-awesome-4.0.0.zip HTTP Error 404: Not Found fontawesome-fonts.noarch: W: spelling-error %description -l en_US scalable - salable, callable, calculable fontawesome-fonts.noarch: W: no-documentation fontawesome-fonts.src: W: spelling-error %description -l en_US scalable - salable, callable, calculable fontawesome-fonts.src: W: invalid-url Source0: http://fortawesome.github.io/Font-Awesome/assets/font-awesome-4.0.0.zip HTTP Error 404: Not Found fontawesome-fonts-web.noarch: W: no-documentation 4 packages and 1 specfiles checked; 0 errors, 8 warnings. [asinha@ankur-laptop SRPMS]$ ^^ - A new version is out which should correct the 404 errors. - No documentation in src tarball. Please consider asking upstream to include a license if possible. Otherwise please remove the %doc macro since it's unneeded. [+] License is acceptable (...) [+] License field in spec is correct ^ License is included in the font metadata itself: SIL Open Font License 1.1 [?] License files included in package %docs if included in source package [?] License files installed when any subpackage combination is installed ^ Please consider requesting upstream to include a license file. This isn't necessary though, since the font clearly declares what license it's under. [+] Spec written in American English [+] Spec is legible [?] Sources match upstream unless altered to fix permissibility issues Upstream SHA256: ... Your SHA256: ... ^ Cannot check md5 since the spec is using an older version which isn't available. To be checked once spec is updated to pack new version. [+] Build succeeds on at least one primary arch [+] Build succeeds on all primary arches or has ExcludeArch + bugs filed [+] BuildRequires correct, justified where necessary [-] Locales handled with %find_lang, not %_datadir/locale/* [-] %post, %postun call ldconfig if package contains shared .so files [+] No bundled libs [-] Relocatability is justified [+] Package owns all directories it creates [+] Package requires others for directories it uses but does not own [+] No duplication in %files unless necessary for license files [+] File permissions are sane [+] Package contains permissible code or content [-] Large docs go in -doc subpackage [-] %doc files not required at runtime [-] Static libs go in -static package/virtual Provides [-] Development files go in -devel package [-] -devel packages Require base with fully-versioned dependency, %_isa [-] No .la files [-] GUI app uses .desktop file, installs it with desktop-file-install [+] File list does not conflict with other packages' without justification [+] File names are valid UTF-8 ** Optional review guidelines: ** [?] Query upstream about including license files TODO [-] Translations of description, summary [-] Builds in mock [-] Builds on all arches [?] Functions as described (e.g. no crashes) Not yet checked. Please do this. [+] Scriptlets are sane [+] Subpackages require base with fully-versioned dependency if sensible [-] .pc file subpackage placement is sensible [+] No file deps outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin [-] Include man pages if available Naming guidelines: [+] Package names use only a-zA-Z0-9-._+ subject to restrictions on -._+ [+] Package names are sane [+] No naming conflicts [+] Spec file name matches base package name [+] Version is sane [+] Version does not contain ~ [+] Release is sane [+] %dist tag [-] Case used only when necessary [-] Renaming handled correctly Packaging guidelines: [+] Useful without external bits [-] No kmods [-] Pre-built binaries, libs removed in %prep [+] Sources contain only redistributable code or content [+] Spec format is sane [+] Package obeys FHS, except libexecdir, /run, /usr/target [+] No files in /bin, /sbin, /lib* on = F17 [-] Programs run before FS mounting use /run instead of /var/run [-] Binaries in /bin, /sbin do not depend on files in /usr on F17 [+] No files under /srv, /opt, /usr/local [+] Changelog in prescribed format [+] No Packager, Vendor, Copyright, PreReq tags [+] Summary does not end in a period [-] Correct BuildRoot tag on EL6 [-] Correct %clean section on EL6 [+] Requires correct, justified where necessary [+] Summary, description
