[Bug 1027407] Review Request: rubygem-thinking-sphinx - A smart wrapper over Sphinx for ActiveRecord
https://bugzilla.redhat.com/show_bug.cgi?id=1027407 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|rubygem-thinking-sphinx-3.0 |rubygem-thinking-sphinx-3.0 |.6-2.fc19 |.6-2.fc20 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- rubygem-thinking-sphinx-3.0.6-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1027407] Review Request: rubygem-thinking-sphinx - A smart wrapper over Sphinx for ActiveRecord
https://bugzilla.redhat.com/show_bug.cgi?id=1027407 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||rubygem-thinking-sphinx-3.0 ||.6-2.fc19 Resolution|--- |ERRATA Last Closed||2013-12-02 04:35:28 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- rubygem-thinking-sphinx-3.0.6-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1027407] Review Request: rubygem-thinking-sphinx - A smart wrapper over Sphinx for ActiveRecord
https://bugzilla.redhat.com/show_bug.cgi?id=1027407 Bug 1027407 depends on bug 1028642, which changed state. Bug 1028642 Summary: Review Request: rubygem-middleware - Generalized implementation of the middleware abstraction for Ruby https://bugzilla.redhat.com/show_bug.cgi?id=1028642 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1027407] Review Request: rubygem-thinking-sphinx - A smart wrapper over Sphinx for ActiveRecord
https://bugzilla.redhat.com/show_bug.cgi?id=1027407 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Mario Blättermann mario.blaetterm...@gmail.com --- rubuygem-middleware is ON_QA, so this ticket gets the same state. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1027407] Review Request: rubygem-thinking-sphinx - A smart wrapper over Sphinx for ActiveRecord
https://bugzilla.redhat.com/show_bug.cgi?id=1027407
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||mario.blaetterm...@gmail.co
||m
Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
||m
Flags||fedora-review+
--- Comment #2 from Mario Blättermann mario.blaetterm...@gmail.com ---
$ rpmlint -i -v *rubygem-thinking-sphinx.noarch: I: checking
rubygem-thinking-sphinx.noarch: I: checking-url
http://pat.github.io/thinking-sphinx/ (timeout 10 seconds)
rubygem-thinking-sphinx.src: I: checking
rubygem-thinking-sphinx.src: I: checking-url
http://pat.github.io/thinking-sphinx/ (timeout 10 seconds)
rubygem-thinking-sphinx.src:94: W: macro-in-comment %{SOURCE1}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
rubygem-thinking-sphinx.src: I: checking-url
https://rubygems.org/gems/thinking-sphinx-3.0.6.gem (timeout 10 seconds)
rubygem-thinking-sphinx-doc.noarch: I: checking
rubygem-thinking-sphinx-doc.noarch: I: checking-url
http://pat.github.io/thinking-sphinx/ (timeout 10 seconds)
rubygem-thinking-sphinx.spec:94: W: macro-in-comment %{SOURCE1}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
rubygem-thinking-sphinx.spec: I: checking-url
https://rubygems.org/gems/thinking-sphinx-3.0.6.gem (timeout 10 seconds)
3 packages and 1 specfiles checked; 0 errors, 2 warnings.
The macro-in-comment warning should be taken serious. It can cause some
unexpected behavior. Please escape the % in line 94 with a second one. Can be
done later.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
MIT
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
1b3ebead66c711802c91c8c70195207ae13e896344e3ae1c850f4df37c846224
thinking-sphinx-3.0.6.gem
1b3ebead66c711802c91c8c70195207ae13e896344e3ae1c850f4df37c846224
thinking-sphinx-3.0.6.gem.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in
[Bug 1027407] Review Request: rubygem-thinking-sphinx - A smart wrapper over Sphinx for ActiveRecord
https://bugzilla.redhat.com/show_bug.cgi?id=1027407 Ken Dreyer ktdre...@ktdreyer.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Ken Dreyer ktdre...@ktdreyer.com --- Thank you very much for the review! I've escaped the macro in the comments per your suggestion. http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-thinking-sphinx.git/commit/?id=f795480c533ac124747ab55136c09cfd3bfdda57 New Package SCM Request === Package Name: rubygem-thinking-sphinx Short Description: A smart wrapper over Sphinx for ActiveRecord Owners: ktdreyer Branches: f19 f20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1027407] Review Request: rubygem-thinking-sphinx - A smart wrapper over Sphinx for ActiveRecord
https://bugzilla.redhat.com/show_bug.cgi?id=1027407 --- Comment #4 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1027407] Review Request: rubygem-thinking-sphinx - A smart wrapper over Sphinx for ActiveRecord
https://bugzilla.redhat.com/show_bug.cgi?id=1027407 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1027407] Review Request: rubygem-thinking-sphinx - A smart wrapper over Sphinx for ActiveRecord
https://bugzilla.redhat.com/show_bug.cgi?id=1027407 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1027407] Review Request: rubygem-thinking-sphinx - A smart wrapper over Sphinx for ActiveRecord
https://bugzilla.redhat.com/show_bug.cgi?id=1027407 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- rubygem-thinking-sphinx-3.0.6-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/rubygem-thinking-sphinx-3.0.6-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1027407] Review Request: rubygem-thinking-sphinx - A smart wrapper over Sphinx for ActiveRecord
https://bugzilla.redhat.com/show_bug.cgi?id=1027407 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- rubygem-thinking-sphinx-3.0.6-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rubygem-thinking-sphinx-3.0.6-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1027407] Review Request: rubygem-thinking-sphinx - A smart wrapper over Sphinx for ActiveRecord
https://bugzilla.redhat.com/show_bug.cgi?id=1027407 Ken Dreyer ktdre...@ktdreyer.com changed: What|Removed |Added Depends On||1028642 --- Comment #7 from Ken Dreyer ktdre...@ktdreyer.com --- I just realized that this package requires rubygem-middleware, which is not yet in Fedora. Review request at bug 1028642. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1028642 [Bug 1028642] Review Request: rubygem-middleware - Generalized implementation of the middleware abstraction for Ruby -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1027407] Review Request: rubygem-thinking-sphinx - A smart wrapper over Sphinx for ActiveRecord
https://bugzilla.redhat.com/show_bug.cgi?id=1027407 --- Comment #1 from Ken Dreyer ktdre...@ktdreyer.com --- (Please note that rubygem-riddle is a dependency and is in updates-testing for F20 and F19. So the package will only build on F21 until rubygem-riddle gets pushed to stable.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
