[Bug 1028168] Review Request: rubygem-expression_parser - A math parser
https://bugzilla.redhat.com/show_bug.cgi?id=1028168 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|rubygem-expression_parser-0 |rubygem-expression_parser-0 |.9.0-4.fc19 |.9.0-4.fc20 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- rubygem-expression_parser-0.9.0-4.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028168] Review Request: rubygem-expression_parser - A math parser
https://bugzilla.redhat.com/show_bug.cgi?id=1028168 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||rubygem-expression_parser-0 ||.9.0-4.fc19 Resolution|--- |ERRATA Last Closed||2013-12-02 04:33:48 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- rubygem-expression_parser-0.9.0-4.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028168] Review Request: rubygem-expression_parser - A math parser
https://bugzilla.redhat.com/show_bug.cgi?id=1028168 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- rubygem-expression_parser-0.9.0-4.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028168] Review Request: rubygem-expression_parser - A math parser
https://bugzilla.redhat.com/show_bug.cgi?id=1028168 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028168] Review Request: rubygem-expression_parser - A math parser
https://bugzilla.redhat.com/show_bug.cgi?id=1028168 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028168] Review Request: rubygem-expression_parser - A math parser
https://bugzilla.redhat.com/show_bug.cgi?id=1028168 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028168] Review Request: rubygem-expression_parser - A math parser
https://bugzilla.redhat.com/show_bug.cgi?id=1028168 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- rubygem-expression_parser-0.9.0-4.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/rubygem-expression_parser-0.9.0-4.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028168] Review Request: rubygem-expression_parser - A math parser
https://bugzilla.redhat.com/show_bug.cgi?id=1028168 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- rubygem-expression_parser-0.9.0-4.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rubygem-expression_parser-0.9.0-4.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028168] Review Request: rubygem-expression_parser - A math parser
https://bugzilla.redhat.com/show_bug.cgi?id=1028168
Mamoru TASAKA mtas...@fedoraproject.org changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #8 from Mamoru TASAKA mtas...@fedoraproject.org ---
One more issue:
* install command
---
install -p %{SOURCE1} %{buildroot}%{gem_instdir}/MIT-LICENSE
---
- This causes the following rpmlint:
---
rubygem-expression_parser.noarch: E: script-without-shebang
/usr/share/gems/gems/expression_parser-0.9.0/MIT-LICENSE
---
Please fix this when importing this package into git (by specifying
mode like install -p -m 0644)
--
This package (rubygem-expression_parser) is
APPROVE by mtasaka
--
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028168] Review Request: rubygem-expression_parser - A math parser
https://bugzilla.redhat.com/show_bug.cgi?id=1028168 Ken Dreyer ktdre...@ktdreyer.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Ken Dreyer ktdre...@ktdreyer.com --- Whoops, thanks for pointing out the missing permissions on install. I'll fix this before importing. Thanks mtasaka for the review! New Package SCM Request === Package Name: rubygem-expression_parser Short Description: A math parser Owners: ktdreyer Branches: f19 f20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028168] Review Request: rubygem-expression_parser - A math parser
https://bugzilla.redhat.com/show_bug.cgi?id=1028168 --- Comment #6 from Mamoru TASAKA mtas...@fedoraproject.org --- (In reply to Ken Dreyer from comment #5) (In reply to Mamoru TASAKA from comment #4) * License text - Please include the mail confirmation text to the binary rpms (note that the emails will be anyway visible into public when you include them into srpm and it is necessary) For this one, I think I'd rather include the MIT-LICENSE from Git upstream. What do you think? I am okay with that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028168] Review Request: rubygem-expression_parser - A math parser
https://bugzilla.redhat.com/show_bug.cgi?id=1028168 --- Comment #7 from Ken Dreyer ktdre...@ktdreyer.com --- Ok, thanks. * Tue Nov 19 2013 Ken Dreyer ktdre...@ktdreyer.com - 0.9.0-3 - Remove macro in comment - Remove email transcripts - Add MIT-LICENSE file from upstream Exact changes in Git: http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-expression_parser.git/commit/?id=5561856da0d02fc2302fa43d6510ad975281bfae Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-expression_parser.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-expression_parser-0.9.0-3.fc21.src.rpm F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6204514 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028168] Review Request: rubygem-expression_parser - A math parser
https://bugzilla.redhat.com/show_bug.cgi?id=1028168 --- Comment #2 from Mamoru TASAKA mtas...@fedoraproject.org --- Well, before review this, I cannot find out any text files or so which suggests the license of this gem. Would you tell me how you knew this is under MIT? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028168] Review Request: rubygem-expression_parser - A math parser
https://bugzilla.redhat.com/show_bug.cgi?id=1028168 --- Comment #3 from Ken Dreyer ktdre...@ktdreyer.com --- Sure. I saw that there was an MIT-LICENSE file in upstream's Git repo. Also, I emailed both of the authors of the code to be doubly sure of the license. For completeness, I'm including copies of their emails in 0.9.0-2. * Mon Nov 18 2013 Ken Dreyer ktdre...@ktdreyer.com - 0.9.0-2 - Include email transcripts describing MIT license. Exact change in Git: http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-expression_parser.git/commit/?id=92161c45495293a0e4690f315768f1481cf964b6 Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-expression_parser.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-expression_parser-0.9.0-2.fc21.src.rpm F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6196395 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028168] Review Request: rubygem-expression_parser - A math parser
https://bugzilla.redhat.com/show_bug.cgi?id=1028168
--- Comment #4 from Mamoru TASAKA mtas...@fedoraproject.org ---
Okay, now for -2:
* License text
- Please include the mail confirmation text to the binary rpms
(note that the emails will be anyway visible into public when
you include them into srpm and it is necessary)
* rpmlint cleanup
- Please cleanup the following rpmlint (just replace macro in comments
with %%)
---
rubygem-expression_parser.src:53: W: macro-in-comment %{gem_instdir}
rubygem-expression_parser.src:53: W: macro-in-comment %{gem_name}
---
Then I can approve this package.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028168] Review Request: rubygem-expression_parser - A math parser
https://bugzilla.redhat.com/show_bug.cgi?id=1028168 --- Comment #5 from Ken Dreyer ktdre...@ktdreyer.com --- (In reply to Mamoru TASAKA from comment #4) * License text - Please include the mail confirmation text to the binary rpms (note that the emails will be anyway visible into public when you include them into srpm and it is necessary) For this one, I think I'd rather include the MIT-LICENSE from Git upstream. What do you think? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028168] Review Request: rubygem-expression_parser - A math parser
https://bugzilla.redhat.com/show_bug.cgi?id=1028168 --- Comment #1 from Mamoru TASAKA mtas...@fedoraproject.org --- Taking. I would appreciate it if you would review one of my review requests (e.g. bug 1031315 ) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028168] Review Request: rubygem-expression_parser - A math parser
https://bugzilla.redhat.com/show_bug.cgi?id=1028168 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mtas...@fedoraproject.org Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
