[Bug 1028818] Review Request: python-pyplete - Dynamic autocompletion for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1028818 Elliott Sales de Andrade changed: What|Removed |Added Status|NEW |CLOSED CC||quantum.anal...@gmail.com Blocks||201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Flags|fedora-review? | Last Closed||2017-09-17 23:44:30 --- Comment #7 from Elliott Sales de Andrade --- Seems not. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1028818] Review Request: python-pyplete - Dynamic autocompletion for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1028818 William Moreno changed: What|Removed |Added Assignee|williamjmore...@gmail.com |nob...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028818] Review Request: python-pyplete - Dynamic autocompletion for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1028818 William Moreno changed: What|Removed |Added CC||tchollingswo...@gmail.com Flags||needinfo?(tchollingsworth@g ||mail.com) --- Comment #6 from William Moreno --- Hi, do want to continue with this review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028818] Review Request: python-pyplete - Dynamic autocompletion for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1028818 William Moreno changed: What|Removed |Added Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028818] Review Request: python-pyplete - Dynamic autocompletion for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1028818 José Matos changed: What|Removed |Added CC||jama...@fc.up.pt --- Comment #5 from José Matos --- (In reply to William Moreno from comment #3) > Any update here? > > Can I take the review? Please do. :-) I was searching for open reviews to process and this is already taken, so please assign this report to yourself. BTW in my humble opinion the spell checker warnings are bogus. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028818] Review Request: python-pyplete - Dynamic autocompletion for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1028818
--- Comment #4 from William Moreno ---
Package Review
==
Need Work:
1- Request upstream to add a License file and include it in tarball.
2- Update macros in %%build and %%install from %{__python} to %{__python2}.
3- In %%files update %{python_sitelib} to %{python2_sitelib}.
4- In %%prep you must remove *egg.info.
5- There many spelling-error warning in rpmlint than can be fixed.
Fedora is moving to Python 3 so ask upstream about support it.
= MUST items =
Generic:
[OK]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[OK]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[OK]: Package contains no bundled libraries without FPC exception.
[OK]: Changelog in prescribed format.
[OK]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[OK]: Package uses nothing in %doc for runtime.
[OK]: Package consistently uses macros (instead of hard-coded directory
names).
[OK]: Package is named according to the Package Naming Guidelines.
[OK]: Package does not generate any conflict.
[OK]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[OK]: Requires correct, justified where necessary.
[OK]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage.
[OK]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[OK]: Package installs properly.
[OK]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[OK]: Package requires other packages for directories it uses.
[OK]: Package must own all directories that it creates.
[OK]: Package does not own files or directories owned by other packages.
[OK]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[OK]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[OK]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[OK]: Macros in Summary, %description expandable at SRPM build time.
[OK]: Dist tag is present.
[OK]: Package does not contain duplicates in %files.
[OK]: Permissions on files are set properly.
[OK]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[OK]: Package is named using only allowed ASCII characters.
[OK]: Package does not use a name that already exists.
[OK]: Package is not relocatable.
[OK]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[OK]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[OK]: File names are valid UTF-8.
[OK]: Packages must not store files under /srv, /opt or /usr/local
Python:
[OK]: Python eggs must not download any dependencies during the build
process.
[OK]: A package which is used by another package via an egg interface should
provide egg info.
[OK]: Package contains BR: python2-devel or python3-devel
= SHOULD items =
Generic:
[NW]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[OK]: Final provides and requires are sane (see attachments).
[OK]: Package functions as described.
[OK]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[OK]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[OK]: Packages should try to preserve timestamps of original installed
files.
[OK]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[OK]: Sources can be downloaded from URI in Source: tag
[OK]: Reviewer should test that the package builds in mock.
[OK]: Buildroot is not present
[OK]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[OK]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[OK]: SourceX is a working URL.
[OK]: Spec use %globa
[Bug 1028818] Review Request: python-pyplete - Dynamic autocompletion for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1028818 William Moreno changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028818] Review Request: python-pyplete - Dynamic autocompletion for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1028818 William Moreno changed: What|Removed |Added CC||williamjmore...@gmail.com --- Comment #3 from William Moreno --- Any update here? Can I take the review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028818] Review Request: python-pyplete - Dynamic autocompletion for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1028818 --- Comment #2 from Raphael Groner --- Are you interested in a review swap? Maybe bug #1225231 is for you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028818] Review Request: python-pyplete - Dynamic autocompletion for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1028818 Cole Robinson changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|crobi...@redhat.com |nob...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028818] Review Request: python-pyplete - Dynamic autocompletion for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1028818
Cole Robinson changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||crobi...@redhat.com
Assignee|nob...@fedoraproject.org|crobi...@redhat.com
--- Comment #1 from Cole Robinson ---
Similar to as mentioned in the pysmell review over here:
https://bugzilla.redhat.com/show_bug.cgi?id=1028817#c1
drop the egg-info from the tarball, let the RPM build generate it
%{__python}-->%{__python2}
%{python_sitelib}-->%{python2_sitelib}
https://fedoraproject.org/wiki/Packaging:Python_Eggs#Providing_Eggs_using_Setuptools
: suggests simply doing %{python2_sitelib}/* in %files to catch the module and
egg-info directory
First 3 description lines have trailing whitespace
As does line 33 above %files
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028818] Review Request: python-pyplete - Dynamic autocompletion for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1028818 Bug 1028818 depends on bug 1028817, which changed state. Bug 1028817 Summary: Review Request: python-pysmell - An autocompletion library for Python https://bugzilla.redhat.com/show_bug.cgi?id=1028817 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028818] Review Request: python-pyplete - Dynamic autocompletion for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1028818 Rex Dieter changed: What|Removed |Added CC||rdie...@math.unl.edu Alias||python-pyplete -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028818] Review Request: python-pyplete - Dynamic autocompletion for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1028818 T.C. Hollingsworth changed: What|Removed |Added Blocks||1028819 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1028819 [Bug 1028819] missing python-foo requires for pate plugins -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028818] Review Request: python-pyplete - Dynamic autocompletion for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1028818 T.C. Hollingsworth changed: What|Removed |Added Depends On||1028817 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1028817 [Bug 1028817] Review Request: python-pysmell - An autocompletion library for Python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
