[Bug 1031531] Review Request: ghc-scotty - Haskell web framework inspired by Ruby's Sinatra, using WAI and Warp
https://bugzilla.redhat.com/show_bug.cgi?id=1031531 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||ghc-scotty-0.5.0-2.fc20 Resolution|--- |ERRATA Last Closed||2013-12-31 14:01:51 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- ghc-scotty-0.5.0-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031531] Review Request: ghc-scotty - Haskell web framework inspired by Ruby's Sinatra, using WAI and Warp
https://bugzilla.redhat.com/show_bug.cgi?id=1031531 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- ghc-scotty-0.5.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/ghc-scotty-0.5.0-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031531] Review Request: ghc-scotty - Haskell web framework inspired by Ruby's Sinatra, using WAI and Warp
https://bugzilla.redhat.com/show_bug.cgi?id=1031531 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031531] Review Request: ghc-scotty - Haskell web framework inspired by Ruby's Sinatra, using WAI and Warp
https://bugzilla.redhat.com/show_bug.cgi?id=1031531 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- ghc-scotty-0.5.0-2.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031531] Review Request: ghc-scotty - Haskell web framework inspired by Ruby's Sinatra, using WAI and Warp
https://bugzilla.redhat.com/show_bug.cgi?id=1031531 Jens Petersen peter...@redhat.com changed: What|Removed |Added Status|ASSIGNED|POST -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031531] Review Request: ghc-scotty - Haskell web framework inspired by Ruby's Sinatra, using WAI and Warp
https://bugzilla.redhat.com/show_bug.cgi?id=1031531 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031531] Review Request: ghc-scotty - Haskell web framework inspired by Ruby's Sinatra, using WAI and Warp
https://bugzilla.redhat.com/show_bug.cgi?id=1031531 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031531] Review Request: ghc-scotty - Haskell web framework inspired by Ruby's Sinatra, using WAI and Warp
https://bugzilla.redhat.com/show_bug.cgi?id=1031531 Ricky Elrod rel...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Ricky Elrod rel...@redhat.com --- New Package SCM Request === Package Name: ghc-scotty Short Description: Haskell web framework inspired by Ruby's Sinatra, using WAI and Warp Owners: codeblock petersen Branches: f20 f19 el6 InitialCC: haskell-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031531] Review Request: ghc-scotty - Haskell web framework inspired by Ruby's Sinatra, using WAI and Warp
https://bugzilla.redhat.com/show_bug.cgi?id=1031531 Jens Petersen peter...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|peter...@redhat.com --- Comment #1 from Jens Petersen peter...@redhat.com --- Basically looks fine so far - only comment is the summary and description are both a little bit long. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031531] Review Request: ghc-scotty - Haskell web framework inspired by Ruby's Sinatra, using WAI and Warp
https://bugzilla.redhat.com/show_bug.cgi?id=1031531 --- Comment #2 from Jens Petersen peter...@redhat.com --- I note for the record that the examples include a copy of jquery.js. Though it is not used directly by scotty itself so maybe it is okay. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031531] Review Request: ghc-scotty - Haskell web framework inspired by Ruby's Sinatra, using WAI and Warp
https://bugzilla.redhat.com/show_bug.cgi?id=1031531 --- Comment #3 from Jens Petersen peter...@redhat.com --- Created attachment 826439 -- https://bugzilla.redhat.com/attachment.cgi?id=826439action=edit ghc-scotty.spec-1.patch This is just a suggestion for how the summary/description could be made more concise: doesn't block the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031531] Review Request: ghc-scotty - Haskell web framework inspired by Ruby's Sinatra, using WAI and Warp
https://bugzilla.redhat.com/show_bug.cgi?id=1031531
Jens Petersen peter...@redhat.com changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #4 from Jens Petersen peter...@redhat.com ---
Package APPROVED.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
jquery is not part of the scotty library, so I believe this is ok.
One of the examples include in devel/doc does use jquery though.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 593920 bytes in 36 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[Bug 1031531] Review Request: ghc-scotty - Haskell web framework inspired by Ruby's Sinatra, using WAI and Warp
https://bugzilla.redhat.com/show_bug.cgi?id=1031531 Jens Petersen peter...@redhat.com changed: What|Removed |Added Whiteboard|Ready | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031531] Review Request: ghc-scotty - Haskell web framework inspired by Ruby's Sinatra, using WAI and Warp
https://bugzilla.redhat.com/show_bug.cgi?id=1031531 Ricky Elrod rel...@redhat.com changed: What|Removed |Added Whiteboard||Ready -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
