[Bug 1032204] Review Request: jamon-processor - Jamon Template Processor
https://bugzilla.redhat.com/show_bug.cgi?id=1032204 Robert Rati changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2013-12-03 09:38:00 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1032204] Review Request: jamon-processor - Jamon Template Processor
https://bugzilla.redhat.com/show_bug.cgi?id=1032204 Bug 1032204 depends on bug 1032205, which changed state. Bug 1032205 Summary: Review Request: jamon-runtime - Jamon runtime support classes https://bugzilla.redhat.com/show_bug.cgi?id=1032205 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1032204] Review Request: jamon-processor - Jamon Template Processor
https://bugzilla.redhat.com/show_bug.cgi?id=1032204 Bug 1032204 depends on bug 1032202, which changed state. Bug 1032202 Summary: Review Request: jamon-nodegen-plugin - Jamon Nodegen Maven Plugin https://bugzilla.redhat.com/show_bug.cgi?id=1032202 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1032204] Review Request: jamon-processor - Jamon Template Processor
https://bugzilla.redhat.com/show_bug.cgi?id=1032204 --- Comment #3 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1032204] Review Request: jamon-processor - Jamon Template Processor
https://bugzilla.redhat.com/show_bug.cgi?id=1032204 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1032204] Review Request: jamon-processor - Jamon Template Processor
https://bugzilla.redhat.com/show_bug.cgi?id=1032204 Robert Rati changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Robert Rati --- New Package SCM Request === Package Name: jamon-processor Short Description: Jamon Template Processor Owners: rrati Branches: InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1032204] Review Request: jamon-processor - Jamon Template Processor
https://bugzilla.redhat.com/show_bug.cgi?id=1032204 gil cattaneo changed: What|Removed |Added Depends On||1032196, 1032202, 1032205, ||1032197 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1032196 [Bug 1032196] Review Request: jamon-api - Jamon processor API https://bugzilla.redhat.com/show_bug.cgi?id=1032197 [Bug 1032197] Review Request: jamon-java-parent - Jamon Java Parent https://bugzilla.redhat.com/show_bug.cgi?id=1032202 [Bug 1032202] Review Request: jamon-nodegen-plugin - Jamon Nodegen Maven Plugin https://bugzilla.redhat.com/show_bug.cgi?id=1032205 [Bug 1032205] Review Request: jamon-runtime - Jamon runtime support classes -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1032204] Review Request: jamon-processor - Jamon Template Processor
https://bugzilla.redhat.com/show_bug.cgi?id=1032204 gil cattaneo changed: What|Removed |Added Blocks||1032200 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1032200 [Bug 1032200] Review Request: jamon-maven-plugin - Jamon Maven plugin -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1032204] Review Request: jamon-processor - Jamon Template Processor
https://bugzilla.redhat.com/show_bug.cgi?id=1032204
gil cattaneo changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flags|fedora-review? |fedora-review+
--- Comment #1 from gil cattaneo ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"MPL (v1.1)", "Unknown or generated". 43 files have unknown license.
Detailed output of licensecheck in /home/gil/1032204-jamon-
processor/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It is
pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
[x]: Bundled jar/class files should be removed before build
Maven:
[x]: If package contains pom.xml files install it (including depmaps) even
when building with ant
[x]: Pom files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the
[Bug 1032204] Review Request: jamon-processor - Jamon Template Processor
https://bugzilla.redhat.com/show_bug.cgi?id=1032204 gil cattaneo changed: What|Removed |Added CC||punto...@libero.it Assignee|nob...@fedoraproject.org|punto...@libero.it Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1032204] Review Request: jamon-processor - Jamon Template Processor
https://bugzilla.redhat.com/show_bug.cgi?id=1032204 Robert Rati changed: What|Removed |Added Blocks||1010003 (bigdata-review) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1010003 [Bug 1010003] bigdata-sig review-tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
