[Bug 1033433] Review Request: budgie - Simple and distraction free GTK+3 media player
https://bugzilla.redhat.com/show_bug.cgi?id=1033433 Sergio Pascual changed: What|Removed |Added CC||sergio.pa...@gmail.com Assignee|nob...@fedoraproject.org|sergio.pa...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1033433] Review Request: budgie - Simple and distraction free GTK+3 media player
https://bugzilla.redhat.com/show_bug.cgi?id=1033433 --- Comment #1 from Sergio Pascual --- The output of rpmlint: Rpmlint --- Checking: budgie-2-1.fc21.x86_64.rpm budgie-2-1.fc21.src.rpm budgie.x86_64: E: zero-length /usr/share/doc/budgie/NEWS budgie.x86_64: W: no-manual-page-for-binary budgie budgie.src: W: invalid-url Source0: https://github.com/ikeydoherty/budgie/releases/download/v2/budgie-2.tar.xz HTTP Error 403: Forbidden 2 packages and 0 specfiles checked; 1 errors, 2 warnings. Rpmlint (installed packages) # rpmlint budgie budgie.x86_64: E: zero-length /usr/share/doc/budgie/NEWS budgie.x86_64: W: no-manual-page-for-binary budgie 1 packages and 0 specfiles checked; 1 errors, 1 warnings. The invalid-url Source0 is bogus, I can download the source with the url and fedora-review downloads just OK also. You have to remove the empty NEWS file, -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1033433] Review Request: budgie - Simple and distraction free GTK+3 media player
https://bugzilla.redhat.com/show_bug.cgi?id=1033433
--- Comment #2 from Sergio Pascual ---
Here goes the full review
= MUST items =
C/C++:
[X]: Package does not contain kernel modules.
[X]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[X]: License field in the package spec file matches the actual license (is
GPLv2+).
[X]: Package requires other packages for directories it uses.
[X]: Package must own all directories that it creates.
[X]: %build honors applicable compiler flags or justifies otherwise.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[X]: Package uses nothing in %doc for runtime.
[X]: glib-compile-schemas is run in %postun and %posttrans if package has
*.gschema.xml files.
[X]: Package consistently uses macros (instead of hard-coded directory names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[X]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[X]: Package contains systemd file(s) if in need.
[X]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
[X]: Useful -debuginfo package or justification otherwise.
[X]: Package is not known to require an ExcludeArch tag.
[X]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[X]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[X]: Final provides and requires are sane.
[X]: Package functions as described.
[X]: Latest version is packaged.
[X]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[X]: Package should compile and build into binary rpms on all supported
architectures.
http://koji.fedoraproject.org/koji/taskinfo?taskID=6311547
[X]: %check is present and all tests pass.
[X]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
Generic:
[X]: If the source package does not include license text(s) as a separate file
from upstream, the pack
[Bug 1033433] Review Request: budgie - Simple and distraction free GTK+3 media player
https://bugzilla.redhat.com/show_bug.cgi?id=1033433 Christopher Meng changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #3 from Christopher Meng --- Can you approve it? I can do this minor fix before SCM import. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1033433] Review Request: budgie - Simple and distraction free GTK+3 media player
https://bugzilla.redhat.com/show_bug.cgi?id=1033433 Sergio Pascual changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Sergio Pascual --- OK then. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1033433] Review Request: budgie - Simple and distraction free GTK+3 media player
https://bugzilla.redhat.com/show_bug.cgi?id=1033433 Christopher Meng changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Christopher Meng --- New Package SCM Request === Package Name: budgie Short Description: Simple and distraction free GTK+3 media player Owners: cicku Branches: f19 f20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1033433] Review Request: budgie - Simple and distraction free GTK+3 media player
https://bugzilla.redhat.com/show_bug.cgi?id=1033433 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1033433] Review Request: budgie - Simple and distraction free GTK+3 media player
https://bugzilla.redhat.com/show_bug.cgi?id=1033433 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1033433] Review Request: budgie - Simple and distraction free GTK+3 media player
https://bugzilla.redhat.com/show_bug.cgi?id=1033433 Sergio Pascual changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2014-01-15 05:46:18 --- Comment #7 from Sergio Pascual --- As the package as been built in Rawhide and f20, I close the bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1033433] Review Request: budgie - Simple and distraction free GTK+3 media player
https://bugzilla.redhat.com/show_bug.cgi?id=1033433 --- Comment #8 from Christopher Meng --- (In reply to Sergio Pascual from comment #7) > As the package as been built in Rawhide and f20, I close the bug Ah Ah Ah Please don't do that next time! I forgot to send the update to bodhi because I can't find it in my bugs because you'd closed it! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1033433] Review Request: budgie - Simple and distraction free GTK+3 media player
https://bugzilla.redhat.com/show_bug.cgi?id=1033433 --- Comment #9 from Fedora Update System --- budgie-2-1.fc20.1 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/budgie-2-1.fc20.1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1033433] Review Request: budgie - Simple and distraction free GTK+3 media player
https://bugzilla.redhat.com/show_bug.cgi?id=1033433 Fedora Update System changed: What|Removed |Added Fixed In Version||budgie-2-1.fc20.1 Resolution|NEXTRELEASE |ERRATA --- Comment #10 from Fedora Update System --- budgie-2-1.fc20.1 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1033433] Review Request: budgie - Simple and distraction free GTK+3 media player
https://bugzilla.redhat.com/show_bug.cgi?id=1033433 Christopher Meng changed: What|Removed |Added Flags||needinfo?(sergio.pasra@gmai ||l.com) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1033433] Review Request: budgie - Simple and distraction free GTK+3 media player
https://bugzilla.redhat.com/show_bug.cgi?id=1033433 Sergio Pascual changed: What|Removed |Added Flags|needinfo?(sergio.pasra@gmai | |l.com) | --- Comment #11 from Sergio Pascual --- Sorry about that, Christopher! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
