[Bug 1034413] Review Request: SDL2_ttf - TrueType font rendering library for SDL2
https://bugzilla.redhat.com/show_bug.cgi?id=1034413 Sébastien Willmann changed: What|Removed |Added CC||cas...@casperlefantom.net --- Comment #18 from Sébastien Willmann --- *** Bug 1089556 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034413] Review Request: SDL2_ttf - TrueType font rendering library for SDL2
https://bugzilla.redhat.com/show_bug.cgi?id=1034413 Fedora Update System changed: What|Removed |Added Fixed In Version|SDL2_ttf-2.0.12-2.fc20 |SDL2_ttf-2.0.12-2.fc19 --- Comment #17 from Fedora Update System --- SDL2_ttf-2.0.12-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034413] Review Request: SDL2_ttf - TrueType font rendering library for SDL2
https://bugzilla.redhat.com/show_bug.cgi?id=1034413 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||SDL2_ttf-2.0.12-2.fc20 Resolution|--- |ERRATA Last Closed||2014-05-01 02:58:54 --- Comment #16 from Fedora Update System --- SDL2_ttf-2.0.12-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034413] Review Request: SDL2_ttf - TrueType font rendering library for SDL2
https://bugzilla.redhat.com/show_bug.cgi?id=1034413 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System --- SDL2_ttf-2.0.12-2.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034413] Review Request: SDL2_ttf - TrueType font rendering library for SDL2
https://bugzilla.redhat.com/show_bug.cgi?id=1034413 --- Comment #14 from Fedora Update System --- SDL2_ttf-2.0.12-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/SDL2_ttf-2.0.12-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034413] Review Request: SDL2_ttf - TrueType font rendering library for SDL2
https://bugzilla.redhat.com/show_bug.cgi?id=1034413 --- Comment #13 from Fedora Update System --- SDL2_ttf-2.0.12-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/SDL2_ttf-2.0.12-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034413] Review Request: SDL2_ttf - TrueType font rendering library for SDL2
https://bugzilla.redhat.com/show_bug.cgi?id=1034413 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034413] Review Request: SDL2_ttf - TrueType font rendering library for SDL2
https://bugzilla.redhat.com/show_bug.cgi?id=1034413 --- Comment #12 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034413] Review Request: SDL2_ttf - TrueType font rendering library for SDL2
https://bugzilla.redhat.com/show_bug.cgi?id=1034413 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034413] Review Request: SDL2_ttf - TrueType font rendering library for SDL2
https://bugzilla.redhat.com/show_bug.cgi?id=1034413 Tom "spot" Callaway changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from Tom "spot" Callaway --- New Package SCM Request === Package Name: SDL2_ttf Short Description: TrueType font rendering library for SDL2 Owners: spot ignatenkobrain Branches: f19 f20 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034413] Review Request: SDL2_ttf - TrueType font rendering library for SDL2
https://bugzilla.redhat.com/show_bug.cgi?id=1034413 --- Comment #10 from Paulo Andrade --- For the record, I also want SDL2_net in Fedora :-) Since I am a Fedora packager/contributor I may try to package it (SDL2_net) at some point, but would prefer to not interfere with the work you are already doing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034413] Review Request: SDL2_ttf - TrueType font rendering library for SDL2
https://bugzilla.redhat.com/show_bug.cgi?id=1034413 --- Comment #9 from Yuki Izumi --- (In reply to Paulo Andrade from comment #8) > I am making some experimental SDL bindings, and did choose > SDL2, so for now using the srpm from the review for SDL2_ttf. I found this while looking for SDL2_ttf-devel. I'm a Fedora newb, so this comment tipped me in the right direction; thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034413] Review Request: SDL2_ttf - TrueType font rendering library for SDL2
https://bugzilla.redhat.com/show_bug.cgi?id=1034413 Paulo Andrade changed: What|Removed |Added CC||paulo.cesar.pereira.de.andr ||a...@gmail.com --- Comment #8 from Paulo Andrade --- I think you forgot to ask for the repository and build it :-) I am making some experimental SDL bindings, and did choose SDL2, so for now using the srpm from the review for SDL2_ttf. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034413] Review Request: SDL2_ttf - TrueType font rendering library for SDL2
https://bugzilla.redhat.com/show_bug.cgi?id=1034413 Igor Gnatenko changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Igor Gnatenko --- okay. sounds good. APPROVED. Tom, add me as co-maintainer of this package. thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034413] Review Request: SDL2_ttf - TrueType font rendering library for SDL2
https://bugzilla.redhat.com/show_bug.cgi?id=1034413 --- Comment #6 from Tom "spot" Callaway --- With regards to your request that I use %make_install, I respectfully decline. Since they are identical, and I've had that pattern hammered into me for years now, I'll just keep using it. COPYING.txt is the zlib license, so it is sufficient. New SRPM: http://spot.fedorapeople.org/SDL2_ttf-2.0.12-2.fc20.src.rpm New SPEC: http://spot.fedorapeople.org/SDL2_ttf.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034413] Review Request: SDL2_ttf - TrueType font rendering library for SDL2
https://bugzilla.redhat.com/show_bug.cgi?id=1034413 --- Comment #5 from Michael Dudek --- Hey guys, so what's the status of this bug? When can we expect a resolution? :P -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034413] Review Request: SDL2_ttf - TrueType font rendering library for SDL2
https://bugzilla.redhat.com/show_bug.cgi?id=1034413 --- Comment #4 from Igor Gnatenko --- About license, I don't know is COPYING.txt license or we need to put zlib license separate ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034413] Review Request: SDL2_ttf - TrueType font rendering library for SDL2
https://bugzilla.redhat.com/show_bug.cgi?id=1034413
--- Comment #3 from Igor Gnatenko ---
Fix some issues and go ;)
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Use %make_install instead of make DESTDIR=%{buildroot} install
- Add to %prep "rm -rf external" for 100% dropping bundles
- Do not own /usr/include/SDL2/
- Fix unused shlib dependency
See:
https://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-dependency
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"MIT/X11 (BSD like)", "BSD (3 clause)", "GPL (v2 or later)", "Unknown or
generated", "zlib/libpng". 652 files have unknown license. Detailed
output of licensecheck in /home/brain/1034413-SDL2_ttf/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/include/SDL2(SDL2-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[!]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[ ]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spe
[Bug 1034413] Review Request: SDL2_ttf - TrueType font rendering library for SDL2
https://bugzilla.redhat.com/show_bug.cgi?id=1034413 Igor Gnatenko changed: What|Removed |Added Flags||fedora-review? --- Comment #2 from Igor Gnatenko --- Oh. I'm sorry. I'm stupid ;) Doing the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034413] Review Request: SDL2_ttf - TrueType font rendering library for SDL2
https://bugzilla.redhat.com/show_bug.cgi?id=1034413 Igor Gnatenko changed: What|Removed |Added Status|NEW |ASSIGNED CC||i.gnatenko.br...@gmail.com Assignee|nob...@fedoraproject.org|i.gnatenko.br...@gmail.com --- Comment #1 from Igor Gnatenko --- actually SDL_ttf contains 2.0.11 of SDL2_ttf. Please fix this w/ Jon Ciesla. If he will downgrade SDL_ttf to 1.2.x tree, I will review this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
